http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-10-10T17:12:28ZTYPO3 ForgeTYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3886632018-10-10T17:12:28ZJonas Eberlejonas.eberle@aero.de
<ul></ul><p>Could you add your TypoScript language config, so all relating to config.*lang*?</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3886662018-10-10T17:58:43ZMartin Weymayeroffice@weymayer.at
<ul><li><strong>File</strong> <a href="/attachments/33826">Unbenannt-1.jpg</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/33826/Unbenannt-1.jpg">Unbenannt-1.jpg</a> added</li></ul><p>I use site configuration and have following setup added<br /><pre><code class="javascript syntaxhl" data-language="javascript">
<span class="p">[</span><span class="nf">siteLanguage</span><span class="p">(</span><span class="dl">"</span><span class="s2">languageId</span><span class="dl">"</span><span class="p">)</span> <span class="o">==</span> <span class="mi">1</span><span class="p">]</span>
<span class="nx">page</span><span class="p">.</span><span class="nx">config</span><span class="p">.</span><span class="nx">htmlTag_langKey</span> <span class="o">=</span> <span class="nx">en</span>
<span class="nx">config</span> <span class="p">{</span>
<span class="nx">sys_language_uid</span> <span class="o">=</span> <span class="mi">1</span>
<span class="nx">language</span> <span class="o">=</span> <span class="nx">en</span>
<span class="nx">locale_all</span> <span class="o">=</span> <span class="nx">en_EN</span>
<span class="nx">htmlTag_langKey</span> <span class="o">=</span> <span class="nx">en</span><span class="o">-</span><span class="nx">EN</span>
<span class="p">}</span>
<span class="p">[</span><span class="nb">global</span><span class="p">]</span>
</code></pre></p>
<p>!!</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3886672018-10-10T18:41:17ZJonas Eberlejonas.eberle@aero.de
<ul></ul><p>Sorry, I am out then. Didn't grasp site configurations yet.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887182018-10-11T10:18:23ZTymoteusz Motylewskit.motylewski@gmail.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/388718/diff?detail_id=326110">diff</a>)</li></ul> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887702018-10-12T10:17:10ZSusanne Moogsusanne.moog@typo3.org
<ul></ul><p>Not really related to the bug, but a side note:<br />you should not need to set the typoscript settings anymore if you have a site configuration with configured languages.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887882018-10-12T14:02:26ZMartin Weymayeroffice@weymayer.at
<ul></ul><p>Thanks, I know - I added ts because site configuration did not work and hoped ts is helping to solve bug :-)</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887892018-10-12T14:15:52ZAlex Bigott
<ul></ul><p>This is connected to the 'Important 82363' in the upgrade docs for 9.5</p>
<p>In every new install of 9.5 language handling changed.</p>
<p>As I found out this means in this special case that the findAll() method in the repository returns localized values (serving the 'list' view), whereas the findByUid() does not anymore (serving the 'detail' view).<br />I have the same problem in my extension and to be honest I am not sure if i think this is a good idea.</p>
<p>If you want your old behaviour back and the extension working, you can set the following TypoScript switch:<br /><code>config.tx_extbase.features.consistentTranslationOverlayHandling = 0</code></p>
<p>Cheers</p>
<p>Alex</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887902018-10-12T14:18:39ZMartin Weymayeroffice@weymayer.at
<ul></ul><p>Thanks! But does the switch-back effect "new" translation handling? If yes, I do not think it is good idea to mix old an new ...</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887912018-10-12T14:32:08ZAlex Bigott
<ul></ul><p>Exactely my thoughs. This makes me shrug as well.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887972018-10-12T16:38:56ZTymoteusz Motylewskit.motylewski@gmail.com
<ul><li><strong>Category</strong> set to <i>Extbase + l10n</i></li></ul><p>I confirm the issue, will take a look what can we do to lower the hassle for integrators/developers.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3887982018-10-12T16:42:40ZMartin Weymayeroffice@weymayer.at
<ul></ul><p>Thanks!</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888042018-10-13T10:28:12ZAlex Bigott
<ul></ul><p>The longer I look into this issue, the more I think there is something seriously broken here.</p>
<p>For me this feels like a huge step back in the way extension developers are working, since from now on fundamentals of how to work in extbase are broken, not to mention that the current status will result in almost every extension there is not working in a fresh 9.5 install when it comes to multilingual projects.</p>
<p>Let's get back to the very core of this topic here: list views and details views (list and show).</p>
On the very core:
<ul>
<li>in your list action you get all the records and give the result to a view:<br /><pre><code class="php syntaxhl" data-language="php"><span class="k">public</span> <span class="k">function</span> <span class="n">listAction</span><span class="p">()</span>
<span class="p">{</span>
<span class="nv">$langtests</span> <span class="o">=</span> <span class="nv">$this</span><span class="o">-></span><span class="n">langtestRepository</span><span class="o">-></span><span class="nf">findAll</span><span class="p">();</span>
<span class="nv">$this</span><span class="o">-></span><span class="n">view</span><span class="o">-></span><span class="nf">assign</span><span class="p">(</span><span class="s1">'langtests'</span><span class="p">,</span> <span class="nv">$langtests</span><span class="p">);</span>
<span class="p">}</span>
</code></pre></li>
</ul>
<ul>
<li>next in your view you have a for loop over the results and create links<br /><pre><code class="html syntaxhl" data-language="html"><span class="nt"><f:for</span> <span class="na">each=</span><span class="s">"{langtests}"</span> <span class="na">as=</span><span class="s">"langtest"</span><span class="nt">></span>
<span class="nt"><f:link.action</span> <span class="na">action=</span><span class="s">"show"</span> <span class="na">arguments=</span><span class="s">"{langtest : langtest}"</span><span class="nt">></span> {langtest.title}<span class="nt"></f:link.action></span>
<span class="nt"></f:for></span>
</code></pre></li>
<li>in the show action you continue the easiest way<br /><pre><code class="php syntaxhl" data-language="php"><span class="k">public</span> <span class="k">function</span> <span class="n">showAction</span><span class="p">(</span><span class="nc">\Alex\Langtest\Domain\Model\Langtest</span> <span class="nv">$langtest</span><span class="p">)</span>
<span class="p">{</span>
<span class="nv">$this</span><span class="o">-></span><span class="n">view</span><span class="o">-></span><span class="nf">assign</span><span class="p">(</span><span class="s1">'langtest'</span><span class="p">,</span> <span class="nv">$langtest</span><span class="p">);</span>
<span class="p">}</span>
</code></pre></li>
<li>and finally the show view displays all<br /><pre><code class="html syntaxhl" data-language="html"> {langtest.title}
</code></pre></li>
</ul>
<p>And guess what: this does not work anymore!</p>
<p>In the details/show view you will always get the default language and not a translation. This is not just an inconvenience for the developer in my eyes. This is wrong to me.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888492018-10-15T12:38:51ZTymoteusz Motylewskit.motylewski@gmail.com
<ul></ul><p>Hi<br />Here is a work in progress solution:<br /><a class="external" href="https://review.typo3.org/#/c/58635/">https://review.typo3.org/#/c/58635/</a></p>
<p>It fixes the issue if you have overlay mode set to "true" or "hideNonTrnaslated" for the website (in the global context).</p>
<p>I'm checking whether /how we should also fix the case when overlay mode is set to 0/false.<br />And other consequences.</p>
<p>This also shows that we desperately need tests for propertyMapper (object converter) which would cover cases when translated record is expected.<br />If any of you can/want to help in writing these tests, I would be very grateful.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888502018-10-15T12:58:21ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888572018-10-15T17:09:26ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888582018-10-15T17:41:01ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3888882018-10-16T10:08:16ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890032018-10-19T23:16:02ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890042018-10-19T23:18:03ZGerrit Code Review
<ul></ul><p>Patch set 7 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890052018-10-19T23:23:45ZGerrit Code Review
<ul></ul><p>Patch set 8 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890062018-10-19T23:25:17ZGerrit Code Review
<ul></ul><p>Patch set 9 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890092018-10-20T00:16:47ZGerrit Code Review
<ul></ul><p>Patch set 10 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890102018-10-20T00:31:40ZGerrit Code Review
<ul></ul><p>Patch set 11 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/58635">https://review.typo3.org/58635</a></p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890112018-10-20T00:34:53ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>We kindly ask all involved persons in this issue to test the latest version of the patch.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890122018-10-20T11:00:04ZTymoteusz Motylewskit.motylewski@gmail.com
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Bring back findByUid behavior for L>0 findByUid as well as getObjectByIdentifier will a..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5e0305969800cb1cd61c098e2c09cab773c54717">5e0305969800cb1cd61c098e2c09cab773c54717</a>.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=3890202018-10-20T18:49:59ZMartin Weymayeroffice@weymayer.at
<ul></ul><p>thanks! tested and working correct now.</p> TYPO3 Core - Bug #86619: Extbase translation handling for detail page not workinghttp://forge.typo3.org/issues/86619?journal_id=4000752019-05-07T12:14:56ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>