http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-12-07T23:22:51ZTYPO3 ForgeTYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3918212018-12-07T23:22:51ZJosef Glatzjosef.glatz@typo3.org
<ul><li><strong>Is Regression</strong> set to <i>Yes</i></li></ul> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3918632018-12-09T12:13:48ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3918862018-12-09T20:58:47ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3921202018-12-13T07:21:40ZBenni Mackbenni@typo3.org
<ul></ul><p>Loading order is an important here, and can likely break.</p>
<p>TBH, looking at Code in TYPO3 v7.6 it is exactly at the same place as in v9. AFTER AdditionalConfiguration and BEFORE ext_localconf inclusion. This means _ if _ we change something here (like "initializing Locales AFTER ext_localconf.php) this is a breaking change. because ANY extension could depend on Locales being already initialized.</p>
<p>In docs I did not find any place where ext_localconf.php is mentioned to add user-defined locales - in our projects we always place it in AdditionalConfiguration.php or LocalConfiguration.php, as it is project-specific.</p>
<p>So there are two ways to solve this:<br />- Re-initialize Locales after ext_localconf.php (but keep it before as well to maintain backwards compatibility) with a note to remove the first initialize() call in v10.0 (= breaking) - this has a little bit of performance drawbacks (because it is instantiated at every call).<br />- Call Locales::initialize() in your extensions' ext_localconf.php after adding the user-defined locales</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3921812018-12-13T22:30:03ZSebastian Mazzasebastian@mazza.at
<ul></ul><p>When the order of <code>AdditionalConfiguration</code> and <code>ext_localconf.php</code> inclusion in TYPO3 v7.6 was the same as in v9.5. How was it possible to use xlf files for e.g. "en" by adding <code>$GLOBALS['TYPO3_CONF_VARS']['SYS']['localization']['locales']['user']['en'] = 'English';</code> to the <code>ext_localconf.php</code> of an extension?</p>
<p>I think the answer is: In TYPO3 v7.6 the <code>Locales::initialize</code> method is called a second time from the <code>TypoScriptFrontendController</code>.</p>
<p>Call stack of the first execution:<br /><pre>
Classes/Localization/Locales.php.TYPO3\CMS\Core\Localization\Locales::initialize:143
Classes/Core/Bootstrap.php.TYPO3\CMS\Core\Core\Bootstrap->initializeL10nLocales:649
Classes/Core/Bootstrap.php.TYPO3\CMS\Core\Core\Bootstrap->loadConfigurationAndInitialize:405
Classes/Core/Bootstrap.php.TYPO3\CMS\Core\Core\Bootstrap->configure:171
Classes/Http/Application.php.TYPO3\CMS\Frontend\Http\Application->__construct:67
www/index.php.{closure:XXXXX/typo3_src-7.6.30/index.php:31-34}:33
www/index.php.{main}:34
</pre></p>
<p>Call stack of the second execution:<br /><pre>
Classes/Localization/Locales.php.TYPO3\CMS\Core\Localization\Locales::initialize:143
Classes/Controller/TypoScriptFrontendController.php.TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->initLLvars:4612
Classes/Controller/TypoScriptFrontendController.php.TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController->settingLanguage:2694
Classes/Http/RequestHandler.php.TYPO3\CMS\Frontend\Http\RequestHandler->handleRequest:187
Classes/Core/Bootstrap.php.TYPO3\CMS\Core\Core\Bootstrap->handleRequest:308
Classes/Http/Application.php.TYPO3\CMS\Frontend\Http\Application->run:78
www/index.php.{closure:XXXXX/typo3_src-7.6.30/index.php:31-34}:33
www/index.php.{main}:34
</pre></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3921842018-12-13T22:49:12ZSebastian Mazzasebastian@mazza.at
<ul></ul><p>In TYPO3 v9.5 the <code>Locales::initialize()</code> method is only called once.</p>
<p>Call Stack:<br /><pre>
Classes/Localization/Locales.php.TYPO3\CMS\Core\Localization\Locales::initialize:139
Classes/Core/Bootstrap.php.TYPO3\CMS\Core\Core\Bootstrap::init:123
index.php.{closure:XXXX/TYPO3.CMS/index.php:21-25}:24
index.php.{main}:25
</pre></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3923172018-12-15T15:21:19ZGuido Schmechel
<ul></ul><p>I think that makes sense to implement that again at the TypoScriptFrontendController. Presumably this is there, because in TypoScript also languages can be overwritten?</p>
<p>Benni: What do you say to that?</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3923452018-12-17T08:57:48ZBenni Mackbenni@typo3.org
<ul></ul><p>Guido Schmechel wrote:</p>
<blockquote>
<p>I think that makes sense to implement that again at the TypoScriptFrontendController. Presumably this is there, because in TypoScript also languages can be overwritten?</p>
<p>Benni: What do you say to that?</p>
</blockquote>
<p>Thanks for further information!</p>
<p>Just rechecked, seems like v8 worked the same way as v7. In order to fix this, we should add this again into v9/master at the same place, with a note why this is done.</p>
<p>However, we should then create a followup patch to add this AFTER ext_localconf.php in the bootstrap for master later on as a breaking change.</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3924122018-12-18T09:00:52ZSebastian Mazzasebastian@mazza.at
<ul></ul><p>Benni Mack wrote:</p>
<blockquote>
<p>Just rechecked, seems like v8 worked the same way as v7. In order to fix this, we should add this again into v9/master at the same place, with a note why this is done.</p>
<p>However, we should then create a followup patch to add this AFTER ext_localconf.php in the bootstrap for master later on as a breaking change.</p>
</blockquote>
<p>I think this is a good approach.</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3924232018-12-18T11:08:23ZGuido Schmechel
<ul></ul><p>I will edit the current patch und build then a follow-up patch. Thanks for your feedback!</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3924572018-12-18T21:59:13ZGerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3926092018-12-20T08:27:34ZGerrit Code Review
<ul></ul><p>Patch set 4 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3926232018-12-20T11:49:04ZGerrit Code Review
<ul></ul><p>Patch set 5 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3926282018-12-20T11:58:15ZGerrit Code Review
<ul></ul><p>Patch set 6 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59068">https://review.typo3.org/59068</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3926452018-12-20T13:56:30ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>9.5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/59240">https://review.typo3.org/59240</a></p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=3926482018-12-20T14:00:06ZGuido Schmechel
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Reimplement custom BE languages Because of a regression the backend does not load custo..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/5668d61aca9fad0a6d23705c12bf41ae671d0abf">5668d61aca9fad0a6d23705c12bf41ae671d0abf</a>.</p> TYPO3 Core - Bug #87101: in TYPO3 v9.5 user defined locales can not be added by an extension any morehttp://forge.typo3.org/issues/87101?journal_id=4002222019-05-07T12:15:31ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>