http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692018-12-11T15:29:22ZTYPO3 ForgeTYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920262018-12-11T15:29:22ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>File</strong> <a href="/attachments/34001">update dialog.jpg</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/34001/update%20dialog.jpg">update dialog.jpg</a> added</li></ul> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920272018-12-11T15:54:34ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>File</strong> <a href="/attachments/34002">add media.jpg</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/34002/add%20media.jpg">add media.jpg</a> added</li><li><strong>Subject</strong> changed from <i>Extension Update dialog broken</i> to <i>Multiple modal dialogs show HTML</i></li></ul> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920302018-12-11T16:00:46ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>All usages of Modals in v7, v8 and v9 need to be checked, whether HTML code display is necessary and is passed as <code>string</code> to the modal method.</p>
<p>Broken calls are:</p>
<pre>
Modal.show(title, '<div>broken html</div>', ...);
Modal.confirm(title, '<div>broken html</div>', ...);
Modal.advanced({content: '<div>broken html</div>', ... });
</pre>
<p>Those need to be refactored to use jQuery objects like</p>
<pre>
let $content = $('<div>').text('working stuff');
Modal.show(title, $content, ...);
</pre> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920312018-12-11T16:01:40ZJosef Glatzjosef.glatz@typo3.org
<ul><li><strong>File</strong> <a href="/attachments/34004">forge87124-dev-master-before.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/34004/forge87124-dev-master-before.png">forge87124-dev-master-before.png</a> added</li><li><strong>File</strong> <a href="/attachments/34005">forge87124-dev-master-after.png</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/34005/forge87124-dev-master-after.png">forge87124-dev-master-after.png</a> added</li></ul><a name="also-affected-95-dev-master"></a>
<h2 >also affected 9.5 / dev-master<a href="#also-affected-95-dev-master" class="wiki-anchor">¶</a></h2>
<a name="Before"></a>
<h3 >Before<a href="#Before" class="wiki-anchor">¶</a></h3>
<p><img src="http://forge.typo3.org/attachments/download/34004/forge87124-dev-master-before.png" loading="lazy" style="max-width:90%;" alt="" /></p>
<a name="After"></a>
<h3 >After<a href="#After" class="wiki-anchor">¶</a></h3>
<p><img src="http://forge.typo3.org/attachments/download/34005/forge87124-dev-master-after.png" loading="lazy" style="max-width:90%;" alt="" /></p> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920322018-12-11T16:01:59ZJosef Glatzjosef.glatz@typo3.org
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/392032/diff?detail_id=328583">diff</a>)</li></ul> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920332018-12-11T16:25:23ZMarkus Kleinmarkus.klein@typo3.org
<ul><li><strong>Assignee</strong> set to <i>Markus Klein</i></li></ul> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3920592018-12-11T23:59:09ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>List of affected code places</p>
<p>v9:</p>
<p>- typo3/sysext/backend/Resources/Private/TypeScript/OnlineMedia.ts:93<br />- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js:267+302+567+152<br />- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+389+429</p>
<p>v8:</p>
<p>- typo3/sysext/backend/Resources/Public/JavaScript/OnlineMedia.js:89<br />- typo3/sysext/extensionmanager/Resources/Public/JavaScript/Main.js:260+462+502</p> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3921252018-12-13T09:00:26ZPixelant Developerdev-test@pixelant.se
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-3 priority-lowest closed child" href="/issues/87144">Bug #87144</a>: "Add media by URL" shows encoded html</i> added</li></ul> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3921272018-12-13T09:12:43ZRene Tobias
<ul></ul><p>Markus Klein wrote:</p>
<blockquote>
<p>Updating extensions is not possible anymore as the content of the modal shows the HTML.</p>
<p>Affected versions: 8.7.21, 9.5.2</p>
</blockquote>
<p>Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok</p> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3921302018-12-13T09:15:34ZWittkiel Gruppe
<ul></ul><p>Rene Tobias Tobias wrote:</p>
<blockquote>
<p>Hey, is this also affecting FE? In some site we have empty <p> tags, for empty spaces, but in 8.7.21 there are no empty spaces...if i revert back to 8.7.19 is ok</p>
</blockquote>
<p>This should be issue <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: Since 8.7.20 (#83795) all <p>&nbsp;</p> are converted to <p></p> (Closed)" href="http://forge.typo3.org/issues/86819">#86819</a></p> TYPO3 Core - Bug #87124: Multiple modal dialogs show HTMLhttp://forge.typo3.org/issues/87124?journal_id=3923212018-12-15T21:41:57ZRiccardo De Contardierredeco@gmail.com
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Closed</i></li><li><strong>Assignee</strong> deleted (<del><i>Markus Klein</i></del>)</li><li><strong>Target version</strong> deleted (<del><i>next-patchlevel</i></del>)</li></ul><p>All subtasks are closed, therefore I close this one for now.</p>
<p>Let me know if this is the wrong decision and I'll reopen it. Thank you.</p>