Task #8724

remove not needed argument from renderPartial

Added by Felix Oertel almost 12 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
Core
Target version:
-
Start date:
2010-07-07
Due date:
% Done:

0%

Estimated time:
Has patch:

Description

hey,

in Classes/View/TemplateView.php renderPartial() the second argument $sectionToRender is required (no default value) but it is not used in the method ...

it clearly will be a breaking change if we remove that, but propably it's not too late right now ;)

or is this variable intended to be used later?

regards, foertel

ps: while checkin v5 i see that the TemaplateView looks different there. Is this intended or just un-backported refactoring?

#1

Updated by Sebastian Kurfuerst almost 12 years ago

That's not-yet-backported refactoring.
However, renderPartial is no public API, so I think it's no problem if we change this.

Greets,
Sebastian

#2

Updated by Bastian Waidelich almost 12 years ago

  • Status changed from New to Resolved

In the meantime this feature has been backported. The renderPartial() method has been moved to the AbstractTemplateView.

Also available in: Atom PDF