TYPO3 Core

This isn't a real fix, just a short workaround

typo3/sysext/scheduler/Classes/Task/ExecuteSchedulableCommandTask.php Line 89

        $definition = $schedulableCommand->getDefinition();
        if ($definition->hasArgument('command') && !array_key_exists('command', $this->getArguments())) {
            $this->arguments = array_merge($this->getArguments(), ['command' => $schedulableCommand->getName()]);
        }

Unfortunaly i don't know why the command info is lost in a loop scenario.

Hi. I also can reproduce this issue.
You just need to create a scheduler task for a Symfony command.
Then create a second task, using the same command (with e.g. different arguments).

When you run both separately, it works.

When you run both together, the first running one works, but the second one get an additional argument:

  ["command"]=>
  object(Symfony\Component\Console\Input\InputArgument)#775 (4) {
    ["name":"Symfony\Component\Console\Input\InputArgument":private]=>
    string(7) "command" 
    ["mode":"Symfony\Component\Console\Input\InputArgument":private]=>
    int(1)
    ["default":"Symfony\Component\Console\Input\InputArgument":private]=>
    NULL
    ["description":"Symfony\Component\Console\Input\InputArgument":private]=>
    string(22) "The command to execute" 
  }

I think the reason is the \Symfony\Component\Console\Command\Command::mergeApplicationDefinition method, which get called in ->run() method.

In CommandRegistry a new instance of the Command is created, but (apparently) not for its definition.

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964

Is there an easy way to reproduce with just default commands and the scheduler?

Armin Vieweg wrote:

I think the reason is the \Symfony\Component\Console\Command\Command::mergeApplicationDefinition method, which get called in ->run() method.

Sorry, I don't understand this conclusion. The command object is run calling the run method, but there isn't an Application object set in the command, which will cause mergeApplicationDefinition to exit early.

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964

The issue is mitigated on master branch, when all commanda are registered via DI.
The mitigation works, because \TYPO3\CMS\Core\Console\CommandRegistry implements \Symfony\Component\Console\CommandLoader\CommandLoaderInterface in master and
commands that are registered via DI are lazily instantiated. Lazy means, only when the command itself is called, or the list command is called.

Commands registered via Configuration/Commands.php are always instantiated whether they are executed or not. This means, when the scheduler:run command is executed all other commands
are prepared as well and part of this preparation is adding the Application object to each command object.
If the Application object is present though, the first execution of the run method, merges the Application's definition with the one from the command.
This isn't an issue, because the run method itself takes care to set the command argument properly.

However our code that is executed before calling this method, prepares the Input and passes the Command's Definition in this preparation, which in turn
leads to a validation of the Imput. This validation however fails, when the command object already has the command argument merged from the Application.

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63964

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64143