http://forge.typo3.org/
http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?1705866169
2020-03-25T00:13:35Z
TYPO3 Forge
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420458
2020-03-25T00:13:35Z
Georg Ringer
<ul><li><strong>Status</strong> changed from <i>Accepted</i> to <i>Needs Feedback</i></li></ul><p>can you pls recheck if still valid in 10, imo fixed</p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420460
2020-03-25T00:14:56Z
Georg Ringer
<ul><li><strong>Related to</strong> <i><a class="issue tracker-1 status-5 priority-4 priority-default closed" href="/issues/88883">Bug #88883</a>: Wrong sorting in documentation changelog</i> added</li></ul>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420477
2020-03-25T07:07:24Z
Josef Glatz
josef.glatz@typo3.org
<ul><li><strong>Subject</strong> changed from <i>View Upgrade Documentation: ordering mixed</i> to <i>View Upgrade Documentation: ordering mixed (wrong sorting)</i></li></ul><a name="Nope-not-fixed-in-95-or-master-as-of-today"></a>
<h3 >Nope, not fixed in 9.5 or master as of today<a href="#Nope-not-fixed-in-95-or-master-as-of-today" class="wiki-anchor">¶</a></h3>
<p><strong>Affected TYPO3 versions: 9.5 and master (10)</strong></p>
<p>until TYPO3 8.7 the rST's itself where sorted by "severity". Beginning with <code>Breaking</code>, ... and so on</p>
<a name="By-looking-into-the-code-I-think-the-right-position-is-in-TYPO3CMSInstallUpgradeAnalysisDocumentationFilegetDocumentationFilesForVersion"></a>
<h4 >By looking into the code I think the right position is in <code>\TYPO3\CMS\Install\UpgradeAnalysis\DocumentationFile::getDocumentationFilesForVersion</code><a href="#By-looking-into-the-code-I-think-the-right-position-is-in-TYPO3CMSInstallUpgradeAnalysisDocumentationFilegetDocumentationFilesForVersion" class="wiki-anchor">¶</a></h4>
<pre><code class="php syntaxhl" data-language="php"> <span class="cd">/**
* Handle a single directory
*
* @param string $docDirectory
* @return array
*/</span>
<span class="k">protected</span> <span class="k">function</span> <span class="n">getDocumentationFilesForVersion</span><span class="p">(</span><span class="kt">string</span> <span class="nv">$docDirectory</span><span class="p">):</span> <span class="kt">array</span>
<span class="p">{</span>
<span class="nv">$documentationFiles</span> <span class="o">=</span> <span class="p">[[]];</span>
<span class="nv">$absolutePath</span> <span class="o">=</span> <span class="nb">str_replace</span><span class="p">(</span><span class="s1">'\\'</span><span class="p">,</span> <span class="s1">'/'</span><span class="p">,</span> <span class="nv">$docDirectory</span><span class="p">);</span>
<span class="nv">$finder</span> <span class="o">=</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getDocumentFinder</span><span class="p">()</span><span class="o">-></span><span class="nf">in</span><span class="p">(</span><span class="nv">$absolutePath</span><span class="p">);</span>
<span class="k">foreach</span> <span class="p">(</span><span class="nv">$finder</span><span class="o">-></span><span class="nf">files</span><span class="p">()</span> <span class="k">as</span> <span class="nv">$file</span><span class="p">)</span> <span class="p">{</span>
<span class="cd">/** @var SplFileInfo $file */</span>
<span class="nv">$documentationFiles</span><span class="p">[]</span> <span class="o">=</span> <span class="nv">$this</span><span class="o">-></span><span class="nf">getListEntry</span><span class="p">(</span><span class="nv">$file</span><span class="o">-></span><span class="nf">getPathname</span><span class="p">());</span>
<span class="p">}</span>
<span class="k">return</span> <span class="nb">array_merge</span><span class="p">(</span><span class="mf">...</span><span class="nv">$documentationFiles</span><span class="p">);</span>
<span class="p">}</span>
</code></pre>
<p>Maybe it's the right area to sort by <code>class</code> subarray value. The "<code>class</code>" subarray value holds values like <code>feature</code>.</p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420480
2020-03-25T08:00:09Z
Gerrit Code Review
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913</a></p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420483
2020-03-25T08:27:29Z
Gerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913</a></p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420495
2020-03-25T09:24:52Z
Gerrit Code Review
<ul></ul><p>Patch set 3 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913</a></p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420500
2020-03-25T09:58:23Z
Gerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>9.5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/63894">https://review.typo3.org/c/Packages/TYPO3.CMS/+/63894</a></p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=420502
2020-03-25T10:00:05Z
Anonymous
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Sort upgrade documentation by filename Restore sorting of documentation files based on ..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/ed216f78bf6a13b81f7dab81b720df5423b68a08">ed216f78bf6a13b81f7dab81b720df5423b68a08</a>.</p>
TYPO3 Core - Bug #87390: View Upgrade Documentation: ordering mixed (wrong sorting)
http://forge.typo3.org/issues/87390?journal_id=421393
2020-04-01T21:14:34Z
Benni Mack
benni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>