Project

General

Profile

Actions
Copy link

Task #87394

closed

composer gerrit:setup should be available for all platforms

Added by Sybille Peters over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Josef Glatz
Category:
-
Target version:
-
Start date:
2019-01-11
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

I am currently updating the Contribution Guide. I would like to simplify the setup.

composer gerrit:setup sets up both commit hooks: commit-msg and pre-commit. The pre-commit hook currently may not run on Windows.

For this reason, you can't just write: just run composer gerrit:setup to setup commit hooks. You have to write: for windows do ..., for Linux / Mac do ...

So, it might be useful to do one of the following:

  1. make the pre-commit hook portable
  2. only copy the commit-msg hook with gerrit:setup
  3. or check before copying if it will run on current system in InstallerScripts:enablePreCommitHook
Actions
Copy link
 #1

Updated by Josef Glatz over 5 years ago

  • Assignee set to Josef Glatz
Actions
Copy link
 #2

Updated by Susanne Moog about 4 years ago

  • Status changed from New to Closed

As this is a technical task and nothing happened for a long time due to lack of time, I'm going to close the ticket for now. If you have time to work on it again, please reopen once you start work.

Actions
Copy link

Also available in: Atom PDF