Bug #879

setValidator et al. are misleading method names

Added by Robert Lemke over 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Could have
Category:
MVC
Target version:
-
Start date:
2008-06-26
Due date:
% Done:

0%

Estimated time:
0.00 h
PHP Version:
Has patch:
Complexity:

Description

Method names such "setValidator" imply that the expected argument actually is a validator object. However in F3_FLOW3_MVC_Controller_Argument the expected argument is a class name.

Either rename the method to setNewValidator or change the method signature.

There are also a lot of tests missing for new methods introduced to F3_FLOW3_MVC_Controller_Argument.

History

#1 Updated by Karsten Dambekalns over 10 years ago

  • Status changed from New to Closed

Has been obsoleted by recent changes.

Also available in: Atom PDF