http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692019-04-13T06:39:43ZTYPO3 ForgeTYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3981052019-04-13T06:39:43ZBenni Mackbenni@typo3.org
<ul></ul><p>Thanks for opening this ticket.</p>
<p>However, I found out that the RouterInterface uses the same logic, so we'd need the interface to change as well.</p>
<p>The original idea was to use the same Interface for SiteMatcher as well, however, I never went through with this.</p>
<p>So we have two options:<br />a) Make the change and also the interface, making it kind of breaking.<br />b) catch the null issue in PageRouter to make an early return, make the Interface Change in v10 only</p>
<p>What do you think?</p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3981712019-04-14T17:57:01ZDmitry Dulepov
<ul></ul><p>Option "b" would be sufficient solution and also no brainer.</p>
<p>However I do not think that interface should change because I think I saw a place where another router is called without a second argument. I can be mistaken about this but I think there was something like this in the code.</p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3982082019-04-15T06:53:41ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Under Review</i></li></ul><p>Patch set 1 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474">https://review.typo3.org/c/Packages/TYPO3.CMS/+/60474</a></p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3982882019-04-17T11:09:14ZGerrit Code Review
<ul></ul><p>Patch set 1 for branch <strong>9.5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489">https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489</a></p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3982902019-04-17T11:17:00ZGerrit Code Review
<ul></ul><p>Patch set 2 for branch <strong>9.5</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489">https://review.typo3.org/c/Packages/TYPO3.CMS/+/60489</a></p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3982922019-04-17T11:30:04ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="[BUGFIX] Ensure PageRouter only operates with previous result If no previous result given, an ex..." href="http://forge.typo3.org/projects/typo3cms-core/repository/1749/revisions/0480e3849bcbef7e463dd8115cfab4b6357f14f4">0480e3849bcbef7e463dd8115cfab4b6357f14f4</a>.</p> TYPO3 Core - Task #88133: Required code change in PageRouterhttp://forge.typo3.org/issues/88133?journal_id=3998292019-05-07T12:10:42ZBenni Mackbenni@typo3.org
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Closed</i></li></ul>