http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692019-11-25T12:51:46ZTYPO3 ForgeTYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4104022019-11-25T12:51:46ZGerrit Code Review
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Under Review</i></li></ul><p>Patch set 2 for branch <strong>master</strong> of project <strong>Packages/TYPO3.CMS</strong> has been pushed to the review server.<br />It is available at <a class="external" href="https://review.typo3.org/c/Packages/TYPO3.CMS/+/62426">https://review.typo3.org/c/Packages/TYPO3.CMS/+/62426</a></p> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4104302019-11-25T22:58:54ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>I think that these issues are related or even the same:</p>
<p><a class="issue tracker-1 status-5 priority-7 priority-highest closed" title="Bug: Unable to set preconfigured values in CKEditor for title and target (Closed)" href="http://forge.typo3.org/issues/83754">#83754</a>, <a class="issue tracker-1 status-5 priority-3 priority-lowest closed" title="Bug: ClassesAnchor target not set (ckeeditor) (Closed)" href="http://forge.typo3.org/issues/84743">#84743</a>, <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: rte_ckeditor link browser classes and their titleText and target (Closed)" href="http://forge.typo3.org/issues/88710">#88710</a></p> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4104312019-11-25T23:49:59ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p>I am unsure about how to reproduce this issue. May I ask a step-by-step guide? Including the CKeditor yaml configuration that should be used? Thank you!</p> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4104372019-11-26T08:30:28ZAndreas Kienast
<ul></ul><p>@Riccardo</p>
<p>I've tested this with Bootstrap Package, reproducing it's pretty simple:</p>
<ol>
<li>Edit any content element that has a ckeditor</li>
<li>Mark some text and put a link on it. In the Link Browser, select a CSS class from the selector and finally set the link</li>
<li>Edit the link again, the previously selected class is not selected anymore</li>
</ol> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4104692019-11-26T21:14:23ZRiccardo De Contardierredeco@gmail.com
<ul></ul><p><a class="user active user-mention" href="http://forge.typo3.org/users/351">@Andreas Otto †</a></p>
<p>I tried with the yaml configuration taken from Bootstap package:</p>
<pre>
classesAnchor:
page:
class: 'link-page'
type: 'page'
folder:
class: 'link-folder'
type: 'folder'
file:
class: 'link-file'
type: 'file'
external:
class: 'link-external'
type: 'url'
mail:
class: 'link-mail'
type: 'mail'
buttons:
link:
properties:
class:
allowedClasses: 'link-arrow, link-page, link-folder, link-file, link-external, link-mail'
</pre>
<p>And actually, the behavior is the one you described. But I think that it is due to the <code>link-arrow</code> class that has no <strong>"type"</strong> defined. Actually, if you remove it, then the selected class will stay.</p>
<p>That's the same behavior I experienced with my first attempt:</p>
<pre>
classesAnchor:
internalLink:
class: 'internal-link'
type: 'page'
internalLink2:
class: 'internal-link-2'
type: 'page'
buttons:
link:
properties:
class:
allowedClasses: 'internal-link,internal-link-2'
</pre> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4132252020-01-12T13:44:41ZMarkus Kleinmarkus.klein@typo3.org
<ul></ul><p>I agree with Riccardo here, configuration error.</p> TYPO3 Core - Bug #89770: Editing a link in ckeditor removes a set CSS classhttp://forge.typo3.org/issues/89770?journal_id=4133022020-01-13T08:41:21ZAndreas Kienast
<ul><li><strong>Status</strong> changed from <i>Under Review</i> to <i>Rejected</i></li></ul>