Bug #90335

Login Failure Warning email doesn’t show IP addresses

Added by RVVN no-lastname-given 19 days ago. Updated 8 days ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2020-02-06
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.2
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Since TYPO3 9.5 the login failure warning email doesn’t contains IP addresses anymore. Instead there is a marker ###IP###.

This is a dump of the failures:

05-02-20 17:52:  Login-attempt from ###IP###, username 'johndoe' not found!!
05-02-20 18:01:  Login-attempt from ###IP###, username 'janedoe', password not accepted!
05-02-20 18:01:  Login-attempt from ###IP###, username 'janedoe', password not accepted!
05-02-20 18:02:  Login-attempt from ###IP###, username 'johndoe' not found!!

Is it some kind of anonymization ?

I checked the function BackendUserAuthentication::checkLogFailures() and it uses the raw log_data from sys_log without replacing this marker.

Associated revisions

Revision 7561ec95 (diff)
Added by Georg Ringer 8 days ago

[BUGFIX] Replace IP address in login error log mails

After reworking the IP usage in logs with #85316 the IP address hasn't
been substituted anymore in the login error log mails.

Replace the IP address which can be found in the field 'IP'.

Resolves: #90335
Releases: master, 9.5
Change-Id: I2472bd8902915bf964a167c389c2048242b29207
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63249
Reviewed-by: Markus Klein <>
Reviewed-by: Guido Schmechel <>
Reviewed-by: Benni Mack <>
Tested-by: TYPO3com <>
Tested-by: Guido Schmechel <>
Tested-by: Benni Mack <>

Revision 3beda3e1 (diff)
Added by Georg Ringer 8 days ago

[BUGFIX] Replace IP address in login error log mails

After reworking the IP usage in logs with #85316 the IP address hasn't
been substituted anymore in the login error log mails.

Replace the IP address which can be found in the field 'IP'.

Resolves: #90335
Releases: master, 9.5
Change-Id: I2472bd8902915bf964a167c389c2048242b29207
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63229
Tested-by: TYPO3com <>
Tested-by: Georg Ringer <>
Reviewed-by: Georg Ringer <>

History

#1 Updated by Georg Ringer 10 days ago

  • Status changed from New to Accepted

#2 Updated by Gerrit Code Review 10 days ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63249

#3 Updated by Gerrit Code Review 9 days ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63249

#4 Updated by Gerrit Code Review 8 days ago

Patch set 1 for branch 9.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/63229

#5 Updated by Georg Ringer 8 days ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF