Task #91084

Pass targetElement explicitly for RegularEvent.delegateTo

Added by Oliver Hader 3 months ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2020-04-17
Due date:
% Done:

100%

TYPO3 Version:
10
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

new RegularEvent('click', (evt) => {
  console.log(this, this instanceof HTMLElement);
}).delegateTo(document, 'a[data-action="toggle"]');

this won't contain the expected HTMLElement (as assigned a thisArg when invoking the callback)

Associated revisions

Revision 1d39973f (diff)
Added by Oliver Hader 3 months ago

[TASK] Pass targetElement explicitly for RegularEvent.delegateTo

Arrow functions keep using their own `thisArg` on invocation. To
be able to avoid unscoped `function()` call and still retrieving
`targetElement` it is passed explicitly as 2nd callback argument.

Resolves: #91084
Releases: master
Change-Id: I3f1087713827605ac8b59f18eb4a59becd67e460
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64209
Tested-by: Andreas Fernandez <>
Tested-by: TYPO3com <>
Tested-by: Oliver Hader <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Oliver Hader <>

History

#1 Updated by Oliver Hader 3 months ago

  • Description updated (diff)

#2 Updated by Oliver Hader 3 months ago

  • Description updated (diff)

#3 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/64209

#4 Updated by Oliver Hader 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF