http://forge.typo3.org/http://forge.typo3.org/themes/typo3_forge/favicon/favicon.png?17058661692020-05-14T15:00:03ZTYPO3 ForgeTYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4253292020-05-14T15:00:03ZAndreas Kienast
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Needs Feedback</i></li></ul><p>Hello,</p>
<p>Can you please try to upgrade EXT:vhs to version 6.0, where the offending code isn't available anymore?</p> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4253492020-05-14T16:27:11ZAndreas Kiesslingandreas.kiessling@web.de
<ul></ul><p>That's what i'm testing right now..<br />Something seems to be off on that staging server with the error reporting / handling, since i did not get these errors in my local setup. (Or the local setup is screwed up)<br />Nevertheless that change probably should not have gotten merged in the late stage of 8.7.<br />I'm wondering who will run 8.7 with Fluid 3 :/</p> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4254782020-05-16T13:42:48ZOliver Haderoliver.hader@typo3.org
<ul><li><strong>Related to</strong> <i><a class="issue tracker-4 status-5 priority-4 priority-default closed" href="/issues/90289">Task #90289</a>: AbstractViewHelper class of TYPO3 8.7 can be compatible with Fluid 3.0 with minor changes</i> added</li></ul> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4264672020-06-03T18:59:56ZAndreas Kiesslingandreas.kiessling@web.de
<ul></ul><p>The vhs upgrade worked, imho we can close the issue.</p> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4265682020-06-04T15:26:44ZBjörn Jacobbjoern.jacob@tritum.de
<ul><li><strong>Status</strong> changed from <i>Needs Feedback</i> to <i>Closed</i></li></ul><p>Closing as requested by the author. Thanks for your response mate!</p> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4273122020-07-02T16:38:14ZFelix Buenemannfelix.buenemann@gmail.com
<ul></ul><p>I think this issue should be re-opened.</p>
<p>It broke multiple of our sites when upgrading from TYPO3 8.7.31 to 8.7.32.</p>
<p>Minor updates should only have non-breaking changes, so I think this is a bug, even if it can be fixed by upgrading the VHS ext.</p> TYPO3 Core - Bug #91401: Fluid AbstractViewHelper::getArguments incompatibilitieshttp://forge.typo3.org/issues/91401?journal_id=4273142020-07-02T17:26:17ZFelix Buenemannfelix.buenemann@gmail.com
<ul></ul><p>As noted by me in <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Task: AbstractViewHelper class of TYPO3 8.7 can be compatible with Fluid 3.0 with minor changes (Closed)" href="http://forge.typo3.org/issues/90289">#90289</a> the change of the return type of the <code>TYPO3\CMS\Fluid\Core\ViewHelper::getArguments()</code> from <code>array</code> (as stated in the doc comments), to <code>ArgumentCollection</code> will break any downstream classes that implement their own <code>getArguments()</code>, so while upgrading VHS might work in some projects I don't think it can be seen as the solution to the problem.</p>
<p>Instead it should be investigated wether the Fluid 3 support can be adapted to not break backwards compatibility.</p>