Project

General

Profile

Actions

Task #94283

closed

Avoid assigning unexpected node types in GeneratorClassesResolver

Added by Oliver Hader almost 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Code Cleanup
Target version:
-
Start date:
2021-06-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
11
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

GeneratorClassesResolver used for the extension scanner preprocesses GeneralUtility::makeInstance calls, transforms class-string values to their corresponding class-constants and provides an alternative low-level class instantiation using new.

When modifying PHP parser nodes, only expected types shall be used - which is ClassConstFetch instead of FullyQualified.

Actions #1

Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/69403

Actions #2

Updated by Oliver Hader almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF