Task #96163

Replace currentworkingdir in phpstan.neon?

Added by Sybille Peters 6 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Should have
Category:
Tests
Target version:
-
Start date:
2021-11-30
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
12
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

There are two predefined parameters usable to expand in config parameters that represent paths:

rootDir - root directory where PHPStan resides (i.e. vendor/phpstan/phpstan in Composer installation)
currentWorkingDirectory - current working directory where PHPStan was executed
These are no longer very useful as all relative paths in config parameters are resolved based on the directory of the config file is in, resulting in a short and concise notation.

Thus, you don't need currentworkingdir. You can write the path relative to the path the .neon file is in, it does not matter where phpstan is executed.

https://phpstan.org/config-reference#expanding-paths


Related issues

Related to TYPO3 Core - Task #93966: Use %currentWorkingDirectory% in phpstan config filesClosed2021-04-22

Actions
#1

Updated by Sybille Peters 6 months ago

  • Related to Task #93966: Use %currentWorkingDirectory% in phpstan config files added
#2

Updated by Benni Mack 6 months ago

  • Status changed from New to Needs Feedback

Can you provide a patch?

#3

Updated by Sybille Peters 6 months ago

  • Assignee set to Sybille Peters
#4

Updated by Sybille Peters 5 months ago

  • Status changed from Needs Feedback to New
#5

Updated by Gerrit Code Review 5 months ago

  • Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/72709

#6

Updated by Sybille Peters 5 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF