Activity

From 2009-06-09 to 2009-07-08

2009-07-08

14:19 Revision 6b063274: [-API] FLOW3 (Package): Removed the getPackagePAth() and getPackageClassesPath() from the Package Manager because they were redundant. Please use $package->getPackagePath() and $package->getClassesPath() respectively.
[~API] FLOW3 (Package): In the class Package renamed getPackageMetaDataPath() and getPackageDocumentationPath() to ge... Robert Lemke
09:06 Feature #3846 (Resolved): Enforce validation before persisting model objects
If there are validation rules defined for a (domain model) object, they should be enforced before actually persisting... Robert Lemke

2009-07-07

12:51 Revision f8110b65: [~TASK] FLOW3 (Documentation): Some changes to the section on commit message rules.
Karsten Dambekalns
11:57 Revision 2ed8e5fa: [~TASK] FLOW3 (Persistence): isDirty() now considers properties on new objects as dirty.
Karsten Dambekalns
10:14 Bug #3837 (Resolved): Objects added to a repository are not found if repository doesn't follow naming conventions
We have a model called \F3\TYPO3\Domain\Model\Structure\Site and a repository called \F3\TYPO3\Domain\Repository\Site... Robert Lemke

2009-07-06

18:35 Bug #3534: File permission issues
Robert Lemke wrote:
> * Depending on how we decide about the general concept of having a GUI or CLI for the main adm...
Tim Eilers
14:58 Bug #3534: File permission issues
Random additional notes:
* The Public/* directories must be owned by the webserver's user because "touch" seems on...
Robert Lemke

2009-07-05

23:50 Bug #3699 (Needs Feedback): Misleading error message when calling inactive package
Please have a look at the attached patch.
It brings some extensive changes to the way the controller is resolved and...
Bastian Waidelich

2009-07-03

18:59 Bug #3699: Misleading error message when calling inactive package
I'll upload a patch with a suggested solution tomorrow. Bastian Waidelich
12:24 Revision e87a6e19: [TASK] FLOW3 (Documentation): Updated the documentation to contain the commit message rules, updated the code documentation and did some shuffling around.
Karsten Dambekalns

2009-07-02

19:00 Bug #3823 (Resolved): FileMonitor does not fix "windows" paths
Several FileMonitorTests fail on Windows due to backslashes in pathes.
Attached patch fixes the issue for me.
Bastian Waidelich
15:45 Revision 5ba91bc3: [TASK] FLOW3 (Tests): Removed a bunch of tests checking the object handling rather than the test target
[TASK] TYPO3CR (Tests): Removed a bunch of tests checking the object handling rather than the test target Karsten Dambekalns
15:16 Revision d277992e: [TASK] FLOW3 (Tests): Fixed some issues found while trying PHPUnit 3.4
[TASK] Fluid (Tests): Fixed some issues found while trying PHPUnit 3.4
[TASK] TYPO3CR (Tests): Fixed some issues foun...
Karsten Dambekalns

2009-07-01

21:51 Bug #3815 (Closed): F3\FLOW3\Monitor\FileMonitorTest fails on Windows with alpha2
Failure in detectChangesEmitsDirectoryChangedSignalAndMemorizesDirectoryIfDirectoryHasNotBeenMonitoredPreviously
Det...
David Bruehlmeier
16:24 Bug #3029: Routing is not working correctly on all platforms
I can reproduce this on two machines:
Debian Etch
Apache/2.2.3 with mod_fcgid
PHP 5.3.0 as CGI/FastCGI
cgi.fix_...
Markus Wagner
14:12 Revision 0839b356: [TASK] FLOW3 (Documentation): Adjusted the documentation slightly in light of the final PHP 5.3 release.
Karsten Dambekalns
11:21 Revision 03fd15aa: Set next version number of package FLOW3 to 1.0.0-alpha3
Robert Lemke
09:09 Bug #3569 (Resolved): setfilepermissions.sh: with non-writable Temporary folder caches end up elsewhere (CLI mode)
Resolved in r2684 (FLOW3 distribution) Robert Lemke
00:00 Bug #3806 (Resolved): Persistence fails when objects and/or lazy loading are involved...
Applied in changeset r2691. Karsten Dambekalns
00:00 Revision f8e072d4: [FIX] FLOW3 (Persistence): dirty checking and activation of lazy loading work as intended now, fixes #3806
Karsten Dambekalns

2009-06-30

18:00 Task #3559 (Resolved): Get rid of state in Package.xml files
Applied in changeset r2685. Robert Lemke
17:48 Revision 64e93c11: * [TASK] FLOW3 (Package): Removed the "state" tag from the Package.xml files and the related code. Resolves #3559
Robert Lemke
15:47 Revision 5628a163: * [TASK] FLOW3 (Core): Improved implementation of the fix for #3568 "PHP version check comes too late on non-namespaced PHP versions"
Robert Lemke
15:25 Bug #3806 (Resolved): Persistence fails when objects and/or lazy loading are involved...
The fix for #3451 in r2591 has some side effects - even after adding something to a proxied SplObjectStorage it is no... Karsten Dambekalns
15:21 Revision b92c05a0: [TASK] FLOW3 (Documentation): Install PHP 5.3 appendix (Windows) changed to use the stable download page
Irene Höppner
14:00 Bug #3795 (Resolved): Arguments in AbstractController are not cleared after forward
Applied in changeset r2675. Karsten Dambekalns
12:58 Bug #3795 (Accepted): Arguments in AbstractController are not cleared after forward
The fix in r2659 breaks REST controllers, maybe more. I'll check. Karsten Dambekalns
14:00 Feature #3650 (Resolved): AOP proxies support classes implementing an interface declaring a __construct() signature
Applied in changeset r2673. Karsten Dambekalns
12:51 Feature #3650 (Accepted): AOP proxies support classes implementing an interface declaring a __construct() signature
Almost, but the original constructor is never called, unless it is advised with anything calling proceed() it seems. ... Karsten Dambekalns
13:54 Revision c9092ca7: [FIX] FLOW3 (MVC): Different fix for #3795, now arguments are cleared only on forward(), fixes #3795
Karsten Dambekalns
13:40 Revision 5a462704: [TASK] FLOW3 (Documentation): Changed the Context-documentation (from index_dev.php to environment variable), update of PHP-editors that can handle namespaces
Irene Höppner
13:18 Revision 8f871cc5: [FIX] FLOW3 (AOP): Fixed changes introduced with r2640, fixes #3650
[FIX] FLOW3 (Object): Fixed changes introduced with r2640, fixes #3650
[TASK] TYPO3CR (Tests): Adjusted tests and fix...
Karsten Dambekalns
09:58 Revision 6152a60f: [TASK] FLOW3 (Validation): Refactored ValidatorResolver to have less code duplication.
Karsten Dambekalns
01:00 Bug #3568 (Resolved): PHP version check comes too late on non-namespaced PHP versions
Applied in changeset r2668. Karsten Dambekalns
00:16 Revision db7e81f3: [FIX] FLOW3: PHP versions below 5.3 now die with a meaningful error message, fixes #3568
Karsten Dambekalns

2009-06-29

23:37 Revision 028f0bf7: [FIX] FLOW3 (MVC): Fixed test for error action that used Arguments object for forward, refs #3790
Christopher Hlubek
23:37 Revision 08aacc08: [FIX] FLOW3 (MVC): forward() in AbstractController now has (correct) array type hint and documentation for $arguments again
Karsten Dambekalns
23:17 Revision 260ebe75: * [FIX] FLOW3 (MVC): Introduced type hint for arguments in forward
Christopher Hlubek
22:53 Revision 3a09787a: * [FIX] FLOW3 (MVC): Reintroduced array type hint on redirect that was removed in last commit
Christopher Hlubek
22:00 Feature #3790 (Resolved): Generic error action and validation errors for current request
Applied in changeset r2659. Christopher Hlubek
22:00 Bug #3795 (Resolved): Arguments in AbstractController are not cleared after forward
Applied in changeset r2659. Christopher Hlubek
00:17 Bug #3795 (Resolved): Arguments in AbstractController are not cleared after forward
The arguments object is created in the constructor of the @AbstractController@ class. After a forward the existing co... Christopher Hlubek
21:31 Revision 46e8f7c6: * [FIX] FLOW3 (MVC): Arguments are reset on each call to processRequest, fixes #3795
* [FIX] FLOW3 (MVC): Fixed wrong type hints in AbstractController and added the param for redirect arguments
* [+FEAT...
Christopher Hlubek
20:00 Bug #3801 (Resolved): ValidatorResolver doesn't accept custom validator classes as validator name
Applied in changeset r2658. Christopher Hlubek
19:28 Bug #3801 (Resolved): ValidatorResolver doesn't accept custom validator classes as validator name
When trying to implement a new Validator for URLs I stumbled upon a problem in the ValidatorResolver: it is currently... Christopher Hlubek
19:56 Revision 35e43ea0: [FIX] FLOW3 (Validation): ValidatorResolver now accepts namespaced class names in validator annotations. This enables custom validator classes and fixes #3801
Christopher Hlubek
16:00 Bug #3275 (Resolved): ValidatorResolver can't parse validator arguments containing round brackets
Applied in changeset r2657. Karsten Dambekalns
15:10 Revision abc7990d: [FIX] FLOW3 (Validation): ValidatorResolver can now parse validator arguments containing round brackets, commas, equal signs, fixes #3275. The option values must be quoted for this to work (either single or double quotes will do).
Karsten Dambekalns
11:09 Revision d9ec88b4: [TASK] FLOW3: Fixed a file header to standard format.
Karsten Dambekalns
10:59 Bug #3569 (Accepted): setfilepermissions.sh: with non-writable Temporary folder caches end up elsewhere (CLI mode)
While the fix was mentioned in the commit message, it seems it was not committed... Karsten Dambekalns
10:00 Bug #3569 (Resolved): setfilepermissions.sh: with non-writable Temporary folder caches end up elsewhere (CLI mode)
Applied in changeset r2655. Robert Lemke
10:57 Bug #3568 (Accepted): PHP version check comes too late on non-namespaced PHP versions
The parsing is done before the execution... See:
kmac:Public karsten$ /usr/bin/php -v
PHP 5.2.8 (cli) (built: Feb...
Karsten Dambekalns
10:00 Bug #3568 (Resolved): PHP version check comes too late on non-namespaced PHP versions
Applied in changeset r2655. Robert Lemke
09:59 Revision 4346a929: * [FIX] FLOW3 (Core): FLOW3's index.php now checks if the PHP version supports namespaces before including the FLOW3 bootstrap. For PHP versions below 5.3.0RC2 an error message will be displayed. Resolves #3568
* [TASK] FLOW3 (Package): String change in the UnknownPackage exception thrown in the Package Manager.
* [FIX] FLOW3 ...
Robert Lemke

2009-06-28

18:31 Feature #3790 (Resolved): Generic error action and validation errors for current request
The user shouldn't have to write a custom error action (altough it should still be possible) for handling argument ma... Christopher Hlubek

2009-06-25

12:39 Revision 537a53b4: * [TASK] Welcome: Adjusted the first steps text in the welcome screen.
Robert Lemke
09:49 Revision ec354256: [-API] FLOW3 (MVC): Removed setDataType() from Controller\Argument
Karsten Dambekalns
09:36 Task #3755 (New): Concurrency stress testing and cache mechanism
After the first experiences and results from #3582 we need to do some more thorough stress testing to identify race c... Robert Lemke
09:33 Task #3582 (Closed): Concurrency stress test
Did some first stress testing with concurrent requests with siege and the front page of the Blog Example.
If cache...
Robert Lemke

2009-06-24

23:21 Revision f4754854: [TAKS] FLOW3 (MVC): Moved mapping of UUIDs to objects from ArgumentsValidator to Argument, refs #3726
Karsten Dambekalns
23:00 Bug #3733 (Resolved): Site should be unlocked by Exception Handler
Applied in changeset r2648. Robert Lemke
22:25 Revision f6cb74b5: * [+FIX] FLOW3 (Error): FLOW3's exception handler now unlocks the site if it previously has been locked by the same request. Resolves #3733
Robert Lemke
19:15 Revision f7541765: * [FIX] FLOW3 (Core): Fixed a regression introduced in the last commit which resulted in the FLOW3 revision not being cached.
* [TASK] FLOW3 (Monitor): Improved the File Monitor's signals. Now a collective signal is sent containing a list of a... Robert Lemke
18:01 Revision 040ffa0c: * [TASK] FLOW3 (Core): Further improved the automatic cache flushing mechanism. Instead of only the revision of the Bootstrap class additionally FLOW3's package version number is taken into account. Addresses #3649
Robert Lemke
18:00 Feature #3649 (Resolved): Caches should be flushed on package version number changes
Applied in changeset r2645. Robert Lemke
18:00 Bug #3240 (Resolved): AOP cache is not emptied if class file is deleted
Applied in changeset r2645. Robert Lemke
17:34 Bug #3240: AOP cache is not emptied if class file is deleted
The problem lies in the Monitoring mechanism, not in the AOP framework. Robert Lemke
17:18 Bug #3240 (Accepted): AOP cache is not emptied if class file is deleted
Karsten Dambekalns
18:00 Feature #3736 (Resolved): Implement support for Directory status monitoring
Applied in changeset r2645. Robert Lemke
18:00 Bug #3726 (Resolved): Links with arguments don't work without routes
Applied in changeset r2644. Karsten Dambekalns
13:29 Bug #3726: Links with arguments don't work without routes
The property mapper adds the returned errors to it's local MappingResults instance only if they are Validation\Proper... Karsten Dambekalns
13:22 Bug #3726 (Accepted): Links with arguments don't work without routes
Karsten Dambekalns
12:58 Bug #3726: Links with arguments don't work without routes
The change in "isPropertyValid()":http://forge.typo3.org/repositories/diff/package-flow3/trunk/Classes/MVC/Controller... Karsten Dambekalns
17:37 Revision 44ad6e9b: * [+FEAT] FLOW3 (Utility): The Files::readDirectoryRecursively() function now supports an optional $suffix parameter which allows for filtering the list of files by a given extension.
* [+FEAT] FLOW3 (Monitor): The File Monitor now supports monitoring of directories. Once a directory is monitored, an... Robert Lemke
17:30 Feature #1947 (Accepted): Implement session scope for object manager
Andreas Förthner
17:23 Task #3624 (Accepted): Write documentation for the security framework
Karsten Dambekalns
17:19 Bug #3275 (Accepted): ValidatorResolver can't parse validator arguments containing round brackets
Karsten Dambekalns
17:12 Revision 45408ced: [FIX] FLOW3 (MVC): Moved mapping of UUIDs to objects into ArgumentsValidator, fixes #3726
[TASK] FLOW3 (MVC): Removed Argument\setNewFilterChain() and related tests, as Filter\Chain does no longer exist
[TAS...
Karsten Dambekalns
13:00 Bug #3537 (Resolved): Subroute placeholders appear in URL if no replaced
Applied in changeset r2643. Karsten Dambekalns
12:09 Bug #3537 (Accepted): Subroute placeholders appear in URL if no replaced
Thanks for the patch, it solves the issue.
Injecting a logger into the configuration manager is impossible, as the...
Karsten Dambekalns
12:39 Revision 535b8666: [FIX] FLOW3 (Configuration): Subroute placeholders are now ignored if the package they refer to is not active, fixes #3537
Karsten Dambekalns
11:36 Revision 26e15de5: [TASK] FLOW3 (Object): cleaned up some docblocks, made one method protected
[TASK] FLOW3 Distribution: removed test.php that should not have been there Karsten Dambekalns
11:30 Bug #3742 (Resolved): getObjectConfigurations() returns original objects
getObjectConfigurations() currently returns the original configuration objects, which allows to alter those circumven... Karsten Dambekalns
10:51 Task #3583 (Closed): Profiling of persistence framework / CR
I worked on this using XHProf (http://mirror.facebook.net/facebook/xhprof/) as Xdebug is awefully slow (albeit it's t... Karsten Dambekalns
10:37 Feature #3740 (Resolved): Implement a Static Object Container
As work on #3583 showed, object creation takes a lot more time than desired. Especially autowiring is a good target f... Karsten Dambekalns

2009-06-23

21:53 Bug #3726: Links with arguments don't work without routes
revision r2620 works, revision r2621 doesn't. Irene Höppner
18:00 Feature #3650 (Resolved): AOP proxies support classes implementing an interface declaring a __construct() signature
Applied in changeset r2640. Andreas Förthner
11:17 Feature #3650 (Accepted): AOP proxies support classes implementing an interface declaring a __construct() signature
Karsten Dambekalns
17:03 Revision bf4790b5: * [+FEAT]: FLOW3 (AOP): AOP proxies now support classes implementing an interface declaring a __construct() signature. Resolves #3650
* [+FEAT]: FLOW3 (Object): The object manager handles the new AOP proxies.
* [TASK]: FLOW3 (Persistence): Changed som...
Andreas Förthner
17:00 Bug #3735 (Resolved): randomizeArrayOrder() does not randomize...
Applied in changeset r2639. Karsten Dambekalns
16:12 Bug #3735 (Resolved): randomizeArrayOrder() does not randomize...
randomizeArrayOrder() (added with r114) uses array_rand(), which does not randomize if as many "random" keys are requ... Karsten Dambekalns
16:19 Feature #3736 (Resolved): Implement support for Directory status monitoring
Currently the File Monitor and the ModificationTimeStrategy only support file monitoring. Implement support for whole... Robert Lemke
16:18 Revision ce251246: [-API] FLOW3 (Utility): removed randomizeArrayOrder(), use native shuffle() function instead, fixes #3735
[FIX] Testing: Tests are run in random order again, fixes #3734 Karsten Dambekalns
15:43 Bug #3733 (Resolved): Site should be unlocked by Exception Handler
If the site was locked and during that run FLOW3 crashes with some exception, the lock is not removed which results i... Robert Lemke
12:00 Bug #3730 (Resolved): Signal Slot Dispatcher does not check if slot class is a registered object
Applied in changeset r2637. Robert Lemke
11:51 Bug #3730 (Resolved): Signal Slot Dispatcher does not check if slot class is a registered object
If a slot class is not registered as an object at the Object Manager, the Object Manager throws a not very meaningful... Robert Lemke
12:00 Feature #3581 (Resolved): Site lock / code cache flushing mechanism
Applied in changeset r2637. Robert Lemke
11:58 Revision 3990fb87: * [TASK] FLOW3 (Monitor): Renamed F3\FLOW3\Monitor\ChangeDetectionStrategy\ModificationTime to F3\FLOW3\Monitor\ChangeDetectionStrategy\ModificationTimeStrategy
* [TASK] FLOW3 (Core): Move the F3\FLOW3\FLOW3 class into its own sub package "Core". The class is now called "Bootst... Robert Lemke
08:12 Feature #3728 (New): Support arrays of objects as controller arguments
Sometimes, you need to receive a variable number of objects of a given type as argument in the controller.
It woul...
Sebastian Kurfuerst

2009-06-22

22:38 Bug #3726 (Resolved): Links with arguments don't work without routes
If you set an action link with fluid that uses arguments, it generates a URL like this:
http://blog.flow3.local:81/b...
Irene Höppner
13:14 Feature #3581 (Accepted): Site lock / code cache flushing mechanism
Robert Lemke

2009-06-19

15:23 Revision 1914b667: * [~CONF]: FLOW(Security): Cleaned up the authentication provider configuration syntax
* [TASK]: FLOW(Security): Fixed a doc comment in the RSAWalletService
* [FIX]: FLOW(Security): The encrypted password...
Andreas Förthner
14:06 Feature #3649 (Accepted): Caches should be flushed on package version number changes
Robert Lemke

2009-06-18

14:25 Bug #3699 (Resolved): Misleading error message when calling inactive package
When trying to use an inactive package you currently get a "404 Not Found - No controller could be resolved which wou... Karsten Dambekalns

2009-06-16

23:38 Revision 05fb6eab: [+FEAT] FLOW3 (MVC): Arguments validator behaves like the generic object validator and creates an ArgumentError with information about the erroneous argument
Christopher Hlubek
11:36 Feature #3616: Implement Accounts/UserManagement
Added two charts, describing the two main authentication scenarios:
* Delegated (LDAP)
* integrated (e.g. compar...
Andreas Förthner

2009-06-15

20:43 Revision 63a930e5: * [FIX] FLOW3 (Tests): Replaced PHP_EOL by chr(10) in YAMLSourceTests to avoid failures on Windows
* [TASK] FLOW3 (Tests): Renamed class names PHPTest -> PHPSourceTest, YAMLTest -> YAMLSourceTest Bastian Waidelich
00:03 Bug #3633 (Closed): Local packages path is guessed wrong
I could not reproduce the issue again and the code seems actually to be right. So I'll close this for now as everythi... Christopher Hlubek

2009-06-12

12:26 Feature #3650 (Resolved): AOP proxies support classes implementing an interface declaring a __construct() signature
Currently AOP proxy classes add a few parameters to the constructor in order to inject the Object Manager and the Obj... Robert Lemke
11:32 Task #3559 (New): Get rid of state in Package.xml files
Robert Lemke
11:30 Feature #3649 (Resolved): Caches should be flushed on package version number changes
Usually when upgrading from one FLOW3 version to another the user will experience a PHP fatal error because some inte... Robert Lemke
10:34 Revision e351db2e: * [TASK] FLOW3 (Configuration): Added an array type hint to the WritableSourceInterface::save() method and the YAML implementation.
* [TASK] FLOW3 (MVC): Whitespace fixes in the AbstractRoutePart.
* [TASK] FLOW3 (Utility): Text changes in the Enviro...
Robert Lemke

2009-06-11

22:49 Revision 84716604: [FEAT+] FLOW3 (Package): the ManagerController now can list available and active packages
[TASK] FLOW3 Distribution: the flow3 script now allows to list available and active packages
[TASK] TYPO3v5 Distribut...
Karsten Dambekalns

2009-06-10

11:00 Feature #3639 (Resolved): Active packages should be saved in a configuration file
Applied in changeset r2596. Christopher Hlubek
10:12 Feature #3639 (Resolved): Active packages should be saved in a configuration file
To activate and deactivate packages, a list of active packages must be saved.
This should be done by providing wri...
Christopher Hlubek
10:21 Revision b3640f4d: [!!!] FLOW3: Packages.yaml configuration renamed to Package.yaml, configuration in single package is no longer indexed with package key
[FEAT] FLOW3 (Configuration): Package state configuration will be handled by a special writable configuration source,... Christopher Hlubek

2009-06-09

22:00 Bug #3451 (Resolved): LazyLoadingProxy must mark property as clean after activation
Applied in changeset r2591. Karsten Dambekalns
21:38 Revision ed18ef97: [FIX] FLOW3: fixed method signature for memorizeCleanState() in tests
[FIX] Fluid: fixed method signature for memorizeCleanState() in tests
[FIX] TYPO3CR: fixed method signature for memor...
Karsten Dambekalns
21:23 Revision bcb52e9c: [FIX] FLOW3 (AOP): getMethodArgument() on JoinPoint no longer throws an exception if a NULL value is found in the requested property
[API+] FLOW3 (Persistence): FLOW3_Persistence_memorizeCleanState() now takes an optional $propertyName argument, refs... Karsten Dambekalns
18:51 Bug #3633 (Closed): Local packages path is guessed wrong
A wrong path for local packages ("Packages/Local") will be used by the package manager if the Global diretcory is lin... Christopher Hlubek
00:33 Revision 2c4db078: * [+API] FLOW3 (Configuration): Added new interface for a writable configuration source
* [+FEAT] FLOW3 (Configuration): YAML configuration source can be written back and the YAMLSource implements the Writ... Christopher Hlubek
 

Also available in: Atom