Activity

From 2011-04-07 to 2011-05-06

2011-05-06

22:48 Feature #26688 (Closed): Magic Object Routes
I'm dreaming of having a more intuitive way of defining default object-controller routes like this:... Martin Brüggemann
22:32 Bug #26687 (Resolved): UTF-8 support is broken
I just saved some FLOW3 objects with german umlauts and it seems that there's a "SET NAMES UTF-8" or some Doctrine2 U... Martin Brüggemann
16:50 Revision 11b7b8a6: [+FEATURE] MVC: Get root request from sub request
If sub requests are nested over more than one level,
it must be possible to retrieve the top most parent
request. Thi...
Lienhart Woitok
11:43 Feature #26669 (Resolved): Routing should support multidimensional arguments
In order to create URIs for plugins and other sub requests (e.g. widgets) the routing needs to support default values... Bastian Waidelich
11:36 Task #26662: Fix and cleanup UriBuilder
Matrix for expected behavior: https://spreadsheets.google.com/ccc?key=0AlDROZpGJKkIdHpvMkhocjhQVXZfYmxoekxERU9Da0E&hl... Bastian Waidelich
10:58 Task #26662 (Resolved): Fix and cleanup UriBuilder
Currently the UriBuilder does not reliably support SubRequests and it has some flaws, that should be fixed.
Some fac...
Bastian Waidelich
09:27 Bug #12365 (Rejected): mapAndValidate() and map() behave differently
Not relevant anymore because of new Property Mapper Sebastian Kurfuerst
00:35 Revision c460fd6b: Merge "[+BUGFIX] Fix AOP Proxy Building"
Sebastian Kurfuerst

2011-05-05

17:35 Bug #25906 (Resolved): Injection with settings use breaks
Applied in changeset commit:4fc6b9e401f07939a2cf00da5e2021a3b564acb6. Christopher Hlubek
11:50 Bug #25906: Injection with settings use breaks
Patch set 1 of change Ie6310c9b1a01c879408c512c6808e8b9485cf744 has been pushed to the review server.
It is available...
Mr. Hudson
11:49 Bug #25906 (Under Review): Injection with settings use breaks
I have to reopen this issue since constructor injection of settings wasn't fixed. I pushed a new change with addition... Christopher Hlubek
17:29 Revision c00c5708: Merge "[FEATURE] Property: Include array to object converter"
Christopher Hlubek
17:29 Revision 04ea1707: Merge "[BUGFIX] Fix constructor setting injection for singletons"
Christopher Hlubek
15:59 Revision de1a1ba2: Merge "[+BUGFIX] Cache manager should flush classes in Tests"
Christopher Hlubek
15:58 Revision 0bf0aa2d: [+BUGFIX] Fix AOP Proxy Building
This fixes a regression introduced by I1987e582a195e8913b7c80fa26ceeb3bbd0319f6
but the code was also wrong before th...
Sebastian Kurfuerst
15:53 Revision f7693d11: Merge "[BUGFIX] Fix several generic persistence problems"
Karsten Dambekalns
13:00 Bug #26107 (Resolved): Proxy class builder rebuild classes without AOP on every change
Applied in changeset commit:50eff49b74ea33b3236781dfbb5269ca9263642d. Christopher Hlubek
12:47 Revision a39ced8e: [BUGFIX] Fix several generic persistence problems
This change fixes several small generic persistence problems:
* NULL array collection should be flattened to an emp...
Christopher Hlubek
12:39 Revision b66b8dc5: Merge "[BUGFIX] Caching of unproxied classes in ProxyClassBuilder"
Christopher Hlubek
12:29 Revision d25ade8c: [FEATURE] Property: Include array to object converter
Besides the persistent object mapping it is useful being able
to convert arrays to simple objects.
Some code could b...
Christopher Hlubek
11:47 Revision 4fc6b9e4: [BUGFIX] Fix constructor setting injection for singletons
Change I15f86cc651935dbe756f5b02a155b5ff14c5e668 missed one spot for
setting injection in the ProxyClassBuilder.
Thi...
Christopher Hlubek
11:36 Task #11683: symlink() is not working on Windows XP
Yes, filesystem based you can use symlinks on XP - at least after installing some tool. But the php-function symlink(... Irene Höppner
10:22 Revision b38edb68: Merge "[BUGFIX] Security: Fix runtime evaluations with global objects"
Christopher Hlubek
06:55 Revision 6f020a32: Merge "[TASK] Adjust AOP ProxyBuilder unit tests to recent change"
Sebastian Kurfuerst

2011-05-04

22:30 Bug #26493 (Resolved): Repository::countAll() does not return integers
Applied in changeset commit:2aa7624ff8c0db195d9df63ec507217278f33e3f. Karsten Dambekalns
22:14 Revision 516def4c: Merge "[BUGFIX] Make sure countAll() returns integers"
Karsten Dambekalns
22:05 Revision 70ff746a: [BUGFIX] Doctrine: Allow nesting of AND and OR conditions in queries
There is no reason to not support nesting of AND and OR conditions.
This change enables Doctrine to allow this nestin...
Andreas Förthner
21:36 Revision 68954d8a: [TASK] Adjust AOP ProxyBuilder unit tests to recent change
In I1987e582a195e8913b7c80fa26ceeb3bbd0319f6 some changes were done but
their (desired) changes to the result of prox...
Karsten Dambekalns
21:09 Bug #26107: Proxy class builder rebuild classes without AOP on every change
Patch set 2 of change I5f75b00bccc4ef22a5214d4e4c227aa1c76e3f72 has been pushed to the review server.
It is available...
Mr. Hudson
21:09 Revision 50eff49b: [BUGFIX] Caching of unproxied classes in ProxyClassBuilder
Classes that don't get a proxy class will be stored in the object
configuration cache as separate cache entries with ...
Christopher Hlubek
17:30 Bug #26565 (Resolved): Wrong doc comment in proxy class breaks ReflectionService->getMethodTagsValues
Applied in changeset commit:ddb790730939d3f592f8e962fd7e3c25febea106. Christopher Hlubek
16:51 Bug #26565: Wrong doc comment in proxy class breaks ReflectionService->getMethodTagsValues
Patch set 3 of change I1987e582a195e8913b7c80fa26ceeb3bbd0319f6 has been pushed to the review server.
It is available...
Mr. Hudson
13:33 Bug #26565 (Under Review): Wrong doc comment in proxy class breaks ReflectionService->getMethodTagsValues
Christopher Hlubek
13:32 Bug #26565: Wrong doc comment in proxy class breaks ReflectionService->getMethodTagsValues
Patch set 2 of change I1987e582a195e8913b7c80fa26ceeb3bbd0319f6 has been pushed to the review server.
It is available...
Mr. Hudson
17:00 Bug #26482 (Resolved): Must specify table name with unique constraints and indexes with Doctrine 2
Applied in changeset commit:364c6d41c499f3e3d1f6d81012651bbfa568819f. Karsten Dambekalns
16:51 Revision ddb79073: [BUGFIX] Several AOP bugfixes
This change fixes several small but blocking issues:
- AOP runtime evaluations with Doctrine collections not support...
Christopher Hlubek
16:34 Revision dc5ab419: Merge "[BUGFIX] Testing: Fix var annotations in FunctionalTestCase"
Karsten Dambekalns
16:31 Revision 584c0188: Merge "[BUGFIX] Make table name in @Table annotation optional"
Karsten Dambekalns
14:26 Revision 4da1f9a5: [FEATURE] Support DateTime in JsonView
The JsonView did not handle DateTime values correctly. A string
should be returned in a JavaScript parseable date for...
Christopher Hlubek
13:39 Bug #26128: Doctrine persistence manager compilation should be configurable
The problem inside the package is gone. Now I face the problem, that the Doctrine compilation is always executed in n... Christopher Hlubek
10:00 Bug #26159 (Resolved): PersistenceMagicAspect doesn't set unique identifier for value objects
Applied in changeset commit:0cd6cb2f9499b10b87dc666dfbce0ed5252855a3. Karsten Dambekalns
09:59 Revision 7b49ac62: Merge "[BUGFIX] Fix calculation of identifier for value objects"
Christopher Hlubek

2011-05-03

17:49 Bug #26107 (Under Review): Proxy class builder rebuild classes without AOP on every change
Christopher Hlubek
16:58 Bug #26107: Proxy class builder rebuild classes without AOP on every change
Patch set 1 of change I5f75b00bccc4ef22a5214d4e4c227aa1c76e3f72 has been pushed to the review server.
It is available...
Mr. Hudson
12:36 Bug #26107 (Accepted): Proxy class builder rebuild classes without AOP on every change
I found a solution that seems to work. Inside the ProxyClassBuilder each target class that doesn't get a proxy is mar... Christopher Hlubek
17:30 Bug #25906 (Resolved): Injection with settings use breaks
Applied in changeset commit:888b03da80bfbd437909496a9b243fce6a902506. Karsten Dambekalns
17:14 Bug #25906: Injection with settings use breaks
Patch set 4 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available...
Mr. Hudson
14:47 Bug #25906: Injection with settings use breaks
Patch set 3 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available...
Mr. Hudson
17:30 Feature #25882 (Resolved): Dedicated query log
Applied in changeset commit:fd7eb8b176ceb6296df864902c2e596aec90a2e8. Karsten Dambekalns
17:14 Feature #25882: Dedicated query log
Patch set 5 of change I4b9927092bb07209cbf9510a1c578858bfaeeb5d has been pushed to the review server.
It is available...
Mr. Hudson
14:47 Feature #25882: Dedicated query log
Patch set 4 of change I4b9927092bb07209cbf9510a1c578858bfaeeb5d has been pushed to the review server.
It is available...
Mr. Hudson
17:21 Revision 4f82ecef: [BUGFIX] Testing: Fix var annotations in FunctionalTestCase
Some var annotations were not renamed correctly.
Change-Id: I29b129e4914b71a85b58217d15eb24b2f8ff1a00
Christopher Hlubek
17:19 Revision 5dcb9178: [BUGFIX] Security: Fix runtime evaluations with global objects
The runtime evaluations closure code need a "closure" reference
to the object manager. This was removed in a recent c...
Christopher Hlubek
17:13 Revision 888b03da: [BUGFIX] Injection with factory settings is usable again
If configuring injection in Objects.yaml and making use of settings for
a factory there, the generated proxy is broke...
Karsten Dambekalns
17:13 Revision fd7eb8b1: [FEATURE] Use dedicated log for SQL queries
Now a dedicated log is used for SQL queries, it is by default named
Query_<context>.log and configurable through sett...
Karsten Dambekalns
17:07 Revision 55e792e9: [+BUGFIX] Cache manager should flush classes in Tests
The cache flushing mechanism in the cache manager does not
generate the correct tag for a class inside the Tests dire...
Christopher Hlubek
17:00 Bug #25908 (Resolved): ProxyClassBuilder produces invalid code for prototype arguments
Applied in changeset commit:feff686a2e3095188794baedd72bb17a493f45be. Bastian Waidelich
16:47 Bug #25908: ProxyClassBuilder produces invalid code for prototype arguments
Patch set 2 of change I5650866cc2aa117dc580d16867a5e9a686d0c1f2 has been pushed to the review server.
It is available...
Mr. Hudson
16:47 Revision feff686a: [BUGFIX] ProxyClassBuilder produces valid code for prototype arguments
Currently FLOW3 does not support the injection of prototype objects
that require constructor arguments. Instead the P...
Bastian Waidelich
13:39 Bug #26582: Repository remove() throws error even if __identity is furnished
And here's the query preliminary to the faulty remove()... Regine Rosewich
13:24 Bug #26582 (Rejected): Repository remove() throws error even if __identity is furnished
The attempt to remove an object from the repository throws an error even if the __identity (flow3_persistence_identif... Regine Rosewich

2011-05-02

21:00 Bug #25902 (Resolved): It's not possible to add an entity as link/redirect argument
Applied in changeset commit:c7f66e0867f6de610706e1a53d64554852157e40. Karsten Dambekalns
20:58 Revision 7a7f5201: Merge "[BUGFIX] Make sure entities can be used in links/redirect"
Robert Lemke
20:49 Feature #25882: Dedicated query log
Patch set 3 of change I4b9927092bb07209cbf9510a1c578858bfaeeb5d has been pushed to the review server.
It is available...
Mr. Hudson
20:49 Bug #25906: Injection with settings use breaks
Patch set 2 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available...
Mr. Hudson
18:22 Bug #25908: ProxyClassBuilder produces invalid code for prototype arguments
Patch set 1 of change I5650866cc2aa117dc580d16867a5e9a686d0c1f2 has been pushed to the review server.
It is available...
Mr. Hudson
17:55 Bug #26565 (Resolved): Wrong doc comment in proxy class breaks ReflectionService->getMethodTagsValues
The method ReflectionService->getMethodTagsValues does a MethodReflection on the given class. But the new proxy mecha... Christopher Hlubek
17:24 Feature #26560: Use reverse index for AOP matching
One example of a slow filter: @PointcutMethodTaggedWithFilter@:
It uses the very slow operation @getMethodTagsValu...
Christopher Hlubek
16:51 Feature #26560 (Resolved): Use reverse index for AOP matching
The AOP matching done inside the ProxyClassBuilder is very slow. It doesn't scales well, because the complexity is ti... Christopher Hlubek
10:50 Bug #26542 (Accepted): Autoincrement unique identifiers not working anymore
Most probably caused the the todo at http://bit.ly/iIPPbR Karsten Dambekalns
10:43 Task #11683: symlink() is not working on Windows XP
IIRC symlinks should work on Windows XP too - at least on a NTFS based file system Bastian Waidelich
10:38 Task #11683: symlink() is not working on Windows XP
Getting rid of XP is definitly a +1 :-) (http://support.microsoft.com/lifecycle/?p1=3223).
Another thing, that hur...
Irene Höppner

2011-05-01

23:15 Bug #26542 (Resolved): Autoincrement unique identifiers not working anymore
I used the @Id and @GeneratedValue properties as seen in the blog example package to have short urls with integer ide... Martin Brüggemann

2011-04-29

22:42 Feature #26411 (Needs Feedback): More meaningful exception on DB errors
Ok, catching DB errors is rather hard. Obvious things that break setting up the connection completely (e.g. wrong PDO... Karsten Dambekalns
22:13 Feature #9534: RAND as order posibility
Please close..
with Doctrine no problem, this issue is from time before doctrine
Julian Kleinhans
21:51 Feature #9534: RAND as order posibility
Implementation hint at http://www.petefreitag.com/item/466.cfm Karsten Dambekalns
21:57 Revision a2da4e48: [TASK] Update requirements in installation chapter
Bumo required PHP version to 5.3.2 and note Windows systems and support
for symlinks.
Change-Id: I9dd08b9ab125c6ef85...
Karsten Dambekalns
21:43 Task #4931 (Closed): Check correct behaviour of object replacement in persistence
Karsten Dambekalns
21:41 Task #11683 (Needs Feedback): symlink() is not working on Windows XP
Should we just make symlink support for Windows a requirement, get rid of XP and drop the mirrorMode configuration op... Karsten Dambekalns
15:03 Bug #26482 (Under Review): Must specify table name with unique constraints and indexes with Doctrine 2
Karsten Dambekalns
15:03 Bug #26482: Must specify table name with unique constraints and indexes with Doctrine 2
Patch set 1 of change I3515ad0247f5495254f19dfcdf11b3aa27cdf704 has been pushed to the review server.
It is available...
Mr. Hudson
12:03 Bug #26482 (Accepted): Must specify table name with unique constraints and indexes with Doctrine 2
Karsten Dambekalns
09:40 Bug #26482 (Resolved): Must specify table name with unique constraints and indexes with Doctrine 2
If a unique-constraint or an additional index is needed for a table/object, the Doctrine 2 ORM has the possiblity to ... Regine Rosewich
15:02 Revision 364c6d41: [BUGFIX] Make table name in @Table annotation optional
When using the @Table Doctrine annotation to specify unique constraints
or indexes one had to specify the table name,...
Karsten Dambekalns
14:40 Bug #26493 (Under Review): Repository::countAll() does not return integers
Karsten Dambekalns
14:40 Bug #26493: Repository::countAll() does not return integers
Patch set 1 of change I4d7afd65e819d0fda0dbedf541d0766aa81138e6 has been pushed to the review server.
It is available...
Mr. Hudson
14:01 Bug #26493 (Accepted): Repository::countAll() does not return integers
Karsten Dambekalns
12:53 Bug #26493 (Resolved): Repository::countAll() does not return integers
RepositoryInterface::countAll() should return integers. But apparently the doctrine integration does not cast the ret... Bastian Waidelich
14:40 Revision 2aa7624f: [BUGFIX] Make sure countAll() returns integers
With Doctrine persistence countAll() would not return integers (in all
cases), thus strict comparison did not work.
...
Karsten Dambekalns

2011-04-28

15:32 Feature #26411 (Closed): More meaningful exception on DB errors
In case of a wrong Database Connection specification (wrong host, wrong socket, credentials, database not existing, .... Karsten Dambekalns
12:08 Bug #25902 (Under Review): It's not possible to add an entity as link/redirect argument
Karsten Dambekalns
12:02 Bug #25902: It's not possible to add an entity as link/redirect argument
Patch set 1 of change I8a5547ab34732c4c6db5369da14337cb3b7a3047 has been pushed to the review server.
It is available...
Mr. Hudson
12:02 Revision c7f66e08: [BUGFIX] Make sure entities can be used in links/redirect
Now the Doctrine\PersistenceManager also checks for the FLOW3 identifier
introduced by AOP in getIdentifierByObject()...
Karsten Dambekalns
11:13 Bug #25790 (Closed): newest Index of FLOW3 throws error
Regine Rosewich wrote:
> the mentioned error message is thrown whenever there is something wrong with an object or a...
Karsten Dambekalns
10:56 Bug #26159 (Under Review): PersistenceMagicAspect doesn't set unique identifier for value objects
Karsten Dambekalns
10:55 Bug #26159: PersistenceMagicAspect doesn't set unique identifier for value objects
Patch set 1 of change I8c113edd47fe2441f928ce19d7a0066356af3e12 has been pushed to the review server.
It is available...
Mr. Hudson
10:55 Revision 0cd6cb2f: [BUGFIX] Fix calculation of identifier for value objects
The generateValueHash advice is a before advice, thus it needs to use
the arguments given to __construct() for calcul...
Karsten Dambekalns
10:26 Feature #25882: Dedicated query log
Patch set 2 of change I4b9927092bb07209cbf9510a1c578858bfaeeb5d has been pushed to the review server.
It is available...
Mr. Hudson
10:14 Bug #26196 (Closed): Doctrine2: Object of class F3\FLOW3\Resource\Resource could not be converted to string
Karsten Dambekalns

2011-04-27

21:55 Bug #26365 (Resolved): Importing resources causes integrity constraint violation: 1062 Duplicate entry
Example... Julian Kleinhans
21:50 Bug #26196: Doctrine2: Object of class F3\FLOW3\Resource\Resource could not be converted to string
Dont no why, but it works now.. close and thx Julian Kleinhans
13:51 Bug #26196 (Needs Feedback): Doctrine2: Object of class F3\FLOW3\Resource\Resource could not be converted to string
Show me your Language domain model code... Karsten Dambekalns
19:16 Revision 9fb09c59: [FEATURE] Enable CSRF protection for ExtDirect requests
The CSRF token has to be transfered to each of the resulting
web requests an ExtDirect request initiates.
Change-Id:...
Andreas Förthner
15:57 Bug #25790: newest Index of FLOW3 throws error
Hi Karsten,
I simply forgot to delete this bug-report. In the meantime I found out that the mentioned error messag...
Regine Rosewich
15:42 Bug #25790 (Needs Feedback): newest Index of FLOW3 throws error
Could you provide some detail about your setup? Path names, symlinks, Apache configuration regarding document root, ... Karsten Dambekalns
15:23 Feature #25882 (Under Review): Dedicated query log
Karsten Dambekalns
15:22 Feature #25882: Dedicated query log
Patch set 1 of change I4b9927092bb07209cbf9510a1c578858bfaeeb5d has been pushed to the review server.
It is available...
Mr. Hudson
15:23 Bug #25906 (Under Review): Injection with settings use breaks
Karsten Dambekalns
15:22 Bug #25906: Injection with settings use breaks
Patch set 1 of change I15f86cc651935dbe756f5b02a155b5ff14c5e668 has been pushed to the review server.
It is available...
Mr. Hudson
15:05 Feature #26358 (Resolved): Initialize sessions only when necessary
As soon as a session is initialized, a cookie is sent to the browser and therefore making client- or proxy-side cachi... Robert Lemke
15:00 Bug #25801 (Resolved): Request arguments should never contain objects
Applied in changeset commit:4f8708ed15e7fca71921f58a9d1fb38dd6f28f13. Bastian Waidelich
14:33 Bug #25801: Request arguments should never contain objects
Patch set 4 of change Ia7b2c9972003c3f91170dc63db43ef2b3c15fc4e has been pushed to the review server.
It is available...
Mr. Hudson
14:06 Bug #25801: Request arguments should never contain objects
Patch set 3 of change Ia7b2c9972003c3f91170dc63db43ef2b3c15fc4e has been pushed to the review server.
It is available...
Mr. Hudson
14:33 Revision 4f8708ed: [+BUGFIX] Request arguments should never contain objects
Request arguments are serialized in Fluid forms in order to generate the
hidden referrer fields that are required to ...
Bastian Waidelich
13:51 Bug #25966 (Accepted): ResourcePointer breaks if you upload the same file twice
Karsten Dambekalns
13:49 Task #25605 (Needs Feedback): In the FLOW3 Bootstrap in handleCommandLineSlaveRequest() persistAll() should be triggered by a signal slot
When we discussed this, we did agree on dispatching a signal after every dispatched request and wire that to a persis... Karsten Dambekalns
13:48 Bug #26159 (Accepted): PersistenceMagicAspect doesn't set unique identifier for value objects
Karsten Dambekalns
13:48 Bug #26128 (Accepted): Doctrine persistence manager compilation should be configurable
Karsten Dambekalns
13:47 Bug #25902: It's not possible to add an entity as link/redirect argument
Partly solved, as new entities now have an identifier for their whole lifetime (generated through AOP).
Leaves the...
Karsten Dambekalns
13:30 Revision 397a28da: Merge changes I3f278762,I809b8f8a
* changes:
[TASK] Run Doctrine setup as CLI sub request
[TASK] Make Doctrine\PersistenceManager::compile() "test-...
Robert Lemke
13:13 Revision 35cafff1: Merge "[TASK] Don't use automatic proxy compilation in Doctrine"
Robert Lemke
13:11 Revision e089a7f7: Merge "[BUGFIX] Fix potentially uninitialized variable"
Robert Lemke
12:34 Revision b2fcfa91: [TASK] Run Doctrine setup as CLI sub request
When FLOW3 needs to set up Doctrine, the proxy classes for entities need
to be used, because without them no AOP-intr...
Karsten Dambekalns
12:34 Revision 3f9bb811: [TASK] Make Doctrine\PersistenceManager::compile() "test-only"
The compile method is no longer used to set up the DB and proxies in
development and production contexts, but is now ...
Karsten Dambekalns
12:34 Revision 01fcf9b2: [TASK] Don't use automatic proxy compilation in Doctrine
We do proxy compilation in our bootstrap phase if needed, thus we can
switch this always off (no need for configurati...
Karsten Dambekalns
12:12 Revision 8c69cb7b: [TASK] Rename service variable to doctrineService
Change-Id: Iad6452aa6e7455bb5898fe67c6dcbd7fbcf68fc1 Karsten Dambekalns
12:09 Revision b3769e0f: [BUGFIX] Fix potentially uninitialized variable
If the compileCommand was called with $force set to TRUE, the object
configuration cache would not have been defined,...
Karsten Dambekalns
00:37 Revision a6b474f3: Merge "[BUGFIX] Remove obsolete variable definition from ApcBackend"
Robert Lemke
00:36 Revision f4936054: [BUGFIX] Remove obsolete variable definition from ApcBackend
$cacheIdentifier is already defined in AbstractBackend.
Change-Id: Id1d3c9b10fb21c422b717da4199fbfa06c19a08e
Christian Kuhn
00:35 Revision 8699944a: [BUGFIX] Remove unused variable in Cache PdoBackend tests
Change-Id: Id997cd485934beb27c64b03d8f660c8b4cb58c4d Christian Kuhn
00:35 Revision f763feaa: [BUGFIX] Fatal error in redis backend cache tests
injectSystemLogger() was removed from internal API.
Change-Id: Ifd65904ad29f27a75708a23f4d62b1ca51a40ba9
Christian Kuhn
00:31 Revision ca43e2a7: [BUGFIX] Fix cache file backend collectGarbage()
collectGarbage() of cache file backend broke after latest refactoring.
Fix it and add a unit test for this case.
Cha...
Christian Kuhn
00:30 Task #13973 (Resolved): Possible table name clash with Doctrine
Applied in changeset commit:767e33563fab315de25172634e7161e52978bfea. Karsten Dambekalns

2011-04-26

23:58 Task #13973: Possible table name clash with Doctrine
Patch set 4 of change I10316deddb045e0d0f1d078d44d3aca5df0bc68a has been pushed to the review server.
It is available...
Mr. Hudson
22:54 Task #13973: Possible table name clash with Doctrine
Patch set 3 of change I10316deddb045e0d0f1d078d44d3aca5df0bc68a has been pushed to the review server.
It is available...
Mr. Hudson
13:05 Task #13973: Possible table name clash with Doctrine
Patch set 2 of change I10316deddb045e0d0f1d078d44d3aca5df0bc68a has been pushed to the review server.
It is available...
Mr. Hudson
12:59 Task #13973 (Under Review): Possible table name clash with Doctrine
https://review.typo3.org/#change,1690 Karsten Dambekalns
23:58 Revision 767e3356: [!!!][TASK] Change generated table structure for Doctrine
This makes all column names lowercase and creates table names with a
lower risk of name clashes.
Resolves: #13973
Ch...
Karsten Dambekalns
23:58 Revision 9a545306: [TASK] Enhance the DoctrineCommandController
Add a create command and make update use the safe mode. To get rid of
unused stuff, use updateAndClean now.
Move act...
Karsten Dambekalns
23:58 Revision 394be57a: [FEATURE] Add Doctrine Migrations support
This adds support for Doctrine Migrations to FLOW3 via new commands in
the Doctrine command controller (flow3:doctrin...
Karsten Dambekalns
23:43 Revision d2eb68d1: Merge "[BUGFIX] Clean up cache file backend unit tests"
Robert Lemke
23:42 Revision e00c2993: Merge "[TASK] Prepare for better table name inference from class names"
Robert Lemke
23:25 Revision 2ce53b7f: Merge changes If03bbf35,I6b7e1780
* changes:
[~BUGFIX] Save policy cache before doctrine compilation is triggerd
[TASK] Use native serialize for se...
Karsten Dambekalns
22:54 Revision 65b0258b: [TASK] Prepare for better table name inference from class names
Change-Id: Iafa52b7e276a90219e92c7d7a83d57d81f46e9a5 Karsten Dambekalns
22:20 Revision 59e69402: Merge "[TASK] Remove outdated unit test"
Andreas Förthner
22:14 Revision 23b59b7b: [~BUGFIX] Save policy cache before doctrine compilation is triggerd
As the doctrine compilation might throw a missing ID exception,
this change makes sure to execute the policy saving b...
Andreas Förthner
22:14 Revision 8a6dee58: [TASK] Use native serialize for session scope objects
With the new proxy class mechanism it becomes possible to use serialize
directly, without the need of the ObjectSeria...
Andreas Förthner
22:14 Revision 84953ce3: [FEATURE] Enable autogenerated @Id properties for Doctrine
With this change Doctrine will use the FLOW3-generated UUID as instance
identifier. You no longer need to define arti...
Karsten Dambekalns
22:14 Revision ea7efe9f: [TASK] Remove @Id annotations to use FLOW3 auto-identifiers
Change-Id: I623e0d3ff189cc9e606542ff08ff8447b2d2669b Karsten Dambekalns
22:14 Revision 793ca816: [BUGFIX] Make sure to never proxy internal classes
Internal classes (e.g. DateTime) cannot be proxied (mostly because it is
not possible to rename them to _Original). M...
Karsten Dambekalns
22:14 Revision fcbc62da: [BUGFIX] Allow advice on __construct and __clone even if not in class
Even when __construct() and __clone() are not explicitly coded in a
class advice on those methods will take effect.
...
Karsten Dambekalns
22:14 Revision b54cefe3: [TASK] Optimize and fix persistence magic aspect & interface
The @afterreturning advice was too late, needs to be @before so
identifiers are assigned before initializeObject() is...
Karsten Dambekalns
22:14 Revision ff0f1880: [FEATURE] Allow AOP to work on abstract classes
Change-Id: I5d507975a6d78de2e80aa0770bf8f343c3eb7f69 Karsten Dambekalns

2011-04-24

20:02 Revision d7e15356: [BUGFIX] Clean up cache file backend unit tests
Class variables $backend and $environment are unused after latest refactoring
and can be removed.
Change-Id: I45e57a...
Christian Kuhn

2011-04-23

15:51 Bug #26196: Doctrine2: Object of class F3\FLOW3\Resource\Resource could not be converted to string
hum i think the way i go is not correct.. will check it later again Julian Kleinhans
11:48 Bug #26196 (Closed): Doctrine2: Object of class F3\FLOW3\Resource\Resource could not be converted to string
Since Doctrine2 integration i had the following error if i will store a Resource... Julian Kleinhans

2011-04-21

13:20 Revision 6f9ac244: [TASK] Remove outdated unit test
With I0274e5aafef29be4494383029d015be5cfb2d60e this test should have
been removed already...
Change-Id: I83be341572f...
Karsten Dambekalns
12:38 Revision 83859166: [TASK] Remove isClone() introduction from persistence magic
Change-Id: I617634420ff46baa85f488921744f6577ba74ff4 Karsten Dambekalns

2011-04-20

20:07 Bug #26159 (Resolved): PersistenceMagicAspect doesn't set unique identifier for value objects
In change _Ia8a607386d69b00183f4b20acd2823296a7cfdff_ the pointcut for the value hash generation was changed to @befo... Christopher Hlubek
17:32 Revision bd9e869d: Merge "[TASK] Remove unused FLOW3_AOP_Proxy_construct() method"
Robert Lemke
17:23 Revision 5a0c202a: [TASK] Ignore invalid backend options in generic backend
Since the Doctrine backend introduced so many new options we should
just ignore the unknown options here. Otherwise t...
Christopher Hlubek
16:34 Revision 46547954: [BUGFIX] Fix generic persistence
This change fixes the scope of the generic persistence manager and the
query result for the generic query object (Que...
Christopher Hlubek
16:00 Task #26078 (Resolved): Enforce RouteParts to only return simple types
Applied in changeset commit:c3e79ace3b3498aa4060e5c7cecefdfaeef752e4. Bastian Waidelich
15:56 Task #26078: Enforce RouteParts to only return simple types
Patch set 2 of change I7cb6874314e00505cb5d5272a48b2c11d0a95c6e has been pushed to the review server.
It is available...
Mr. Hudson
15:55 Revision c3e79ace: [+TASK] Enforce RouteParts to only return simple types
Requests should never contain objects (see #25801 for details).
Consequently the Router should not deal with objects ...
Bastian Waidelich

2011-04-19

21:53 Revision c5fa1987: [TASK] Remove unused FLOW3_AOP_Proxy_construct() method
Change-Id: Ia098826d50710018b1a85be0412af9dc5ac64ab0 Karsten Dambekalns
21:50 Revision 7890bd88: [TASK] Rename $data to $propertyMetaData for clarity
Change-Id: I1c950ae1c90ea818ef07db2831de700f5a74b55e Karsten Dambekalns
21:48 Revision dd09b9f8: [TASK] No longer ignore exceptions in validate command
Change-Id: I06e8359fce369f680a5bb6d06ff6dc38bf22bf4b Karsten Dambekalns
21:31 Revision b70f4591: [TASK] Correct use of getClassTag()
Replaces two dynamic calls by the static variant on the CacheManager.
Change-Id: Id36e26e6ee081cb0c4308309c1a357d0b7...
Karsten Dambekalns
21:24 Revision 7cc0c839: [TASK] Remove FLOW3_AOP_Proxy_getProperty() method
Change-Id: I05be60cb111442f687369e1a497b32f435ee2ee7 Karsten Dambekalns
21:24 Revision 69cf955b: [TASK] Remove FLOW3_AOP_Proxy_getProxyTargetClassName() method
Change-Id: I4286fb6bf43ae7d5c34b97790b77e45662304453 Karsten Dambekalns
21:24 Revision 927febd7: [TASK] Remove FLOW3_AOP_Proxy_hasProperty() method
Change-Id: I5d160f3ee64a962d79009f39fa75d1acef2c4063 Karsten Dambekalns
21:24 Revision fc31a5a7: [FEATURE] Allow property introduction through AOP
With this change it is possible to mark properties in an aspect with
@introduce and the property will be added to the...
Karsten Dambekalns
21:24 Revision aafa75ba: [TASK] Forced ObjectAccess works with undeclared properties
When using $forceDirectAccess of getProperty() and setProperty() on
properties not declared in a class, using reflect...
Karsten Dambekalns
21:24 Revision f7b1050e: [TASK] Unify FLOW3 persistence identifier property
The former distinction between UUID and SHA1 for entities and value
objects is removed.
In addition the used propert...
Karsten Dambekalns
21:24 Revision f7e81a01: [TASK] Move PersistenceMagicAspect out of Generic folder
Change-Id: I69fe75b291ebdd708355b481f92551e8f70cda35 Karsten Dambekalns
21:24 Revision 927fd4d6: [TASK] Remove FLOW3_AOP_Proxy_setProperty() method
Change-Id: I02a860f664139bfe50ea087009c06fdf20d19f6b Karsten Dambekalns
21:24 Revision 2cb75fe9: [!!!][TASK] Move interface introductions to class level
When introducing an interface this is no longer done by annotating a
property, but with an @introduce annotation in t...
Karsten Dambekalns
18:30 Bug #25609 (Resolved): Router should skip routes if the target controller does not exist
Applied in changeset commit:894d3b264e0f9ad97ab02d8dfd9d3b5e3e9b489c. Bastian Waidelich
12:39 Bug #25609: Router should skip routes if the target controller does not exist
Patch set 7 of change I3bdff3dcd4384af088f3859d5640ad07d33a732d has been pushed to the review server.
It is available...
Mr. Hudson
18:26 Revision 1562ec88: Merge "[+BUGFIX] delay in redirects is ignored"
Robert Lemke
18:08 Revision 627a5856: Merge "[BUGFIX] Router skips routes if the target controller does not exist"
Robert Lemke
17:53 Feature #26132 (Closed): FloatToFloatConverter missing in F3\Property\TypeConverter
When trying to updat a table row with float values using the ExtDirect Interface FLOW3 throws an error:... Regine Rosewich
16:20 Bug #26128: Doctrine persistence manager compilation should be configurable
The mere existence of the PersistenceManager is a problem if no driver is configured:... Christopher Hlubek
16:11 Bug #26128 (Resolved): Doctrine persistence manager compilation should be configurable
The compile method of the Doctrine persistence manager is currently hard-coded inside the FLOW3 Metapackage:... Christopher Hlubek
16:17 Task #26129: Establish simple conventions for qualified and unqualified class names
See also Revision 541350ed and make sure to update the code generated by the kickstarter. Robert Lemke
16:15 Task #26129 (Closed): Establish simple conventions for qualified and unqualified class names
Refactor code and update documentation so that fully qualified class names with a leading backslash are allowed (and ... Robert Lemke
13:22 Revision f0725918: Merge "[TASK] Improve error message in base repository"
Robert Lemke
12:37 Revision 894d3b26: [BUGFIX] Router skips routes if the target controller does not exist
The Router now checks if the target controller exists. If not, the route
is skipped when resolving route values.
Fur...
Bastian Waidelich
12:12 Revision 821839a1: [+BUGFIX] delay in redirects is ignored
When calling redirect() or redirectToUri(), delays > 0 are ignored
because location header doesn't support it.
This i...
Bastian Waidelich
11:32 Bug #25965: AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
The change handling is still not optimal, see #26107. Christopher Hlubek
11:30 Bug #25965 (Resolved): AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
Applied in changeset commit:b021a963cdcfc3b4e8cfbb07627a1a8cc64bf8ae. Karsten Dambekalns
11:30 Bug #26107 (Resolved): Proxy class builder rebuild classes without AOP on every change
Since classes that don't get a proxy class (if they don't use DI or AOP) are not put inside the cache, the build meth... Christopher Hlubek
11:16 Revision aa1fe32c: Merge "[+BUGFIX] (Functional Tests): Make sendWebRequest more realistic"
Sebastian Kurfuerst
11:04 Revision 95368669: Merge "[BUGFIX] Fix aspect change detection in AOP ProxyClassBuilder"
Christopher Hlubek
10:38 Revision 62878088: [TASK] Improve error message in base repository
This makes an error message in Repository::update() more meaningful and
removes some obsolete code from the construct...
Robert Lemke
10:37 Revision 56322b06: [+BUGFIX] (Functional Tests): Make sendWebRequest more realistic
This includes:
- make Routing available
- getArgument/hasArgument implementation in Request
- more realistic base URI...
Sebastian Kurfuerst

2011-04-18

16:24 Task #26078: Enforce RouteParts to only return simple types
Patch set 1 of change I7cb6874314e00505cb5d5272a48b2c11d0a95c6e has been pushed to the review server.
It is available...
Mr. Hudson
10:31 Task #26078 (Resolved): Enforce RouteParts to only return simple types
After calling @Route::matches()@, @Route::getMatchResults()@ must not contain objects. See #25801 for reasoning.
Add...
Bastian Waidelich
12:28 Revision ec7f4a12: Merge "[BUGFIX] Only write Reflection Data if it changed"
Sebastian Kurfuerst

2011-04-15

21:58 Bug #4407 (Resolved): flow3 script cannot flush caches
With the new command controller flushing caches works. Karsten Dambekalns
15:52 Revision 1660cd5a: [BUGFIX] Make links/redirects work in SubRequests
Web\SubRequest::getBaseUri() is never set and it makes no sense to have
a custom base URI in a sub request anyways.
...
Bastian Waidelich
15:15 Bug #25988 (New): Useless proxies are built for some classes
Consider the proxies for the Package classes, they contain no code except for some checks on constructor arguments. I... Karsten Dambekalns
12:33 Bug #25965 (Under Review): AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
Karsten Dambekalns
12:32 Bug #25965: AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
Patch set 1 of change I4182a91bdf02e6ffd93804d2df76095f12bb4508 has been pushed to the review server.
It is available...
Mr. Hudson
12:32 Revision b021a963: [BUGFIX] Fix aspect change detection in AOP ProxyClassBuilder
If there is an aspect A, which does not need dependency injection, and
another class C is modified, the ProxyClassBui...
Karsten Dambekalns

2011-04-14

18:55 Revision 90e140f6: [BUGFIX] AOP: Fix multiple runtime conditions per method
The AOP proxy class builder had a problem with multiple aspects per
method that have runtime evaluations defined. The...
Christopher Hlubek
17:58 Bug #25965 (Accepted): AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
Karsten Dambekalns
16:44 Bug #25965: AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
!!! When fixing this issue, make sure to revert http://review.typo3.org/1614 again! Sebastian Kurfuerst
16:39 Bug #25965 (Resolved): AOP ProxyClassBuilder always detects an aspect as "changed" if no Dependency Injection is used in this aspect (f.e. in LazyLoadingObjectAspect)
h2. Problem
If there is an aspect A, which does not need dependency injection, and *another* class C is modified, ...
Sebastian Kurfuerst
17:55 Revision 55844bf7: Merge "[+BUGFIX] Fix log messages in AOP proxy creation"
Karsten Dambekalns
17:39 Revision 5b307661: [BUGFIX] Only write Reflection Data if it changed
While profiling file system writes, I discovered that the Reflection
Data is written on every request, although nothi...
Sebastian Kurfuerst
17:30 Bug #25859 (Resolved): CSRF protection does not work for methods that contain upper case characters
Applied in changeset commit:797fcc64b3a491861b7bdc0b732788a66229cd55. Bastian Waidelich
16:31 Bug #25859: CSRF protection does not work for methods that contain upper case characters
Patch set 3 of change Ibae8ad81a7839c983b64bad86a8631c0176c59b1 has been pushed to the review server.
It is available...
Mr. Hudson
16:22 Bug #25859: CSRF protection does not work for methods that contain upper case characters
Patch set 2 of change Ibae8ad81a7839c983b64bad86a8631c0176c59b1 has been pushed to the review server.
It is available...
Mr. Hudson
17:09 Revision 5992e7d2: Merge "[+BUGFIX] Fix CSRF protection for camelCased actions"
Bastian Waidelich
17:08 Bug #25966 (Resolved): ResourcePointer breaks if you upload the same file twice
As ResourcePointer is no valueobject (for doctrine) anymore, the resource manager creates a second one for the same f... Andreas Förthner
16:54 Bug #25609: Router should skip routes if the target controller does not exist
Patch set 6 of change I3bdff3dcd4384af088f3859d5640ad07d33a732d has been pushed to the review server.
It is available...
Mr. Hudson
16:23 Bug #25609: Router should skip routes if the target controller does not exist
Patch set 5 of change I3bdff3dcd4384af088f3859d5640ad07d33a732d has been pushed to the review server.
It is available...
Mr. Hudson
10:10 Bug #25609: Router should skip routes if the target controller does not exist
Patch set 4 of change I3bdff3dcd4384af088f3859d5640ad07d33a732d has been pushed to the review server.
It is available...
Mr. Hudson
16:40 Revision de34da58: Merge "[TASK] Improve testable security support for functional tests"
Robert Lemke
16:31 Revision 797fcc64: [+BUGFIX] Fix CSRF protection for camelCased actions
The FLOW3-CSRF-TOKEN is not attached to links pointing to
actions that contain upper case letters.
The solution is to...
Bastian Waidelich
16:31 Revision bbde1a23: [+BUGFIX] Fix log messages in AOP proxy creation
Some core classes are marked as @proxy disable, but are still
shown in the log that AOP proxies have been created for...
Sebastian Kurfuerst
15:00 Revision 0d949d96: Merge "[+BUGFIX] replace uniqid() calls in Unit Tests"
Robert Lemke
15:00 Bug #25874 (Resolved): Security Randomizer produces a Warning on Windows if openssl_* is not available
Applied in changeset commit:c8e21cdf742af924b21105eab5d0675e25e1cb5b. Bastian Waidelich
13:16 Bug #25874: Security Randomizer produces a Warning on Windows if openssl_* is not available
Patch set 1 of change I7bc25437000c982083003926eaeb4d1f71f4e007 has been pushed to the review server.
It is available...
Mr. Hudson
14:58 Revision c67d5f25: Merge "[+FEATURE] Reflection: Allow access to description in reflections"
Christopher Hlubek
14:57 Revision b16829ff: [+FEATURE] Reflection: Allow access to description in reflections
Change-Id: I834f2880c748b4d080c9309d73163ea53b42606d Christopher Hlubek
14:10 Bug #25801: Request arguments should never contain objects
Patch set 2 of change Ia7b2c9972003c3f91170dc63db43ef2b3c15fc4e has been pushed to the review server.
It is available...
Mr. Hudson
12:31 Bug #25801: Request arguments should never contain objects
Patch set 1 of change Ia7b2c9972003c3f91170dc63db43ef2b3c15fc4e has been pushed to the review server.
It is available...
Mr. Hudson
12:24 Bug #25801 (Accepted): Request arguments should never contain objects
Bastian Waidelich
13:58 Revision 4a6dc776: [+BUGFIX] replace uniqid() calls in Unit Tests
Currently we're using uniqid() in order to create random (class) names
in the FLOW3 unit tests. Unfortunately uniqid(...
Bastian Waidelich
13:47 Bug #25961 (Resolved): HTML should be escaped in the pre output of DebugExceptionHandler
I noticed this today when doing some debugging. Seems the html outputted in the pre tags isn't escaped..... Aske Ertmann
13:15 Revision c8e21cdf: [+BUGFIX] Security Randomizer produces a Warning on Windows
If openssl is not available, the 3rd party script we're using to
generate random bytes executes
$fp = @fopen('/dev/ur...
Bastian Waidelich
11:28 Revision f79d8e2a: Merge "[TASK] Replace use of mkdir() in PhpSession"
Karsten Dambekalns
08:21 Revision d6760a92: [TASK] Improve testable security support for functional tests
With this change authenticateRoles() will return the newly created
account so that functional tests have a chance to ...
Robert Lemke

2011-04-13

16:26 Revision ae32f23f: Merge "[TASK] Fix unit test for PolicyExpressionParser"
Karsten Dambekalns
15:19 Revision 4f6029a9: Merge "[TASK] Trivial optimization in readDirectoryRecursively()"
Sebastian Kurfuerst
11:32 Bug #25902 (Accepted): It's not possible to add an entity as link/redirect argument
Karsten Dambekalns
09:55 Bug #25902: It's not possible to add an entity as link/redirect argument
Additional notes:
Calling...
Bastian Waidelich
11:00 Bug #25776 (Resolved): Doctrine proxy class files can't be overwritten by other SAPI type
Applied in changeset commit:30151e02cd9cc893af94dcf4852ace3ee17f8e0b. Karsten Dambekalns
10:56 Revision a9384f24: Merge "[TASK] Use temporary file and rename for proxy class creation"
Karsten Dambekalns

2011-04-12

18:31 Revision 5d10897b: [TASK] Replace use of mkdir() in PhpSession
Rather use createDirectoryRecursively() instead.
Change-Id: I2a0a2b178578fe7645fe609f390b2bdf6746637c
Karsten Dambekalns
17:31 Task #25923 (Resolved): Clean up session files in compile run
During the compile run, certain / most caches are rebuilt. If an account is currently logged in, it won't be able to ... Robert Lemke
17:00 Bug #25922 (Closed): Proxy classes have to be regenerated when the Objects.yaml has changed
Otherwise we might end up in proxies that don't reflect the dependencies configured in the Objects.yaml. Andreas Förthner
16:56 Revision dcffaa8b: [BUGFIX] Fix wrong quotes in ProxyMethod class
One has to use double quotes to output a newline, otherwise
a \n will end up as characters in the proxy classes
causi...
Andreas Förthner
16:08 Revision d7bfbecd: [TASK] Fix unit test for PolicyExpressionParser
In the wake of I3dce79164168e7213f323ef7b2829d98954c011e this test broke
and now it's fixed again.
Change-Id: I5ed36...
Karsten Dambekalns
16:05 Revision 42f365b7: Merge "[BUGFIX] Property Mapper does not support interface as conversion target"
Sebastian Kurfuerst
16:00 Revision ce69a00b: [TASK] Trivial optimization in readDirectoryRecursively()
A tiny followup to I0d4c1ed601a7d55fc36c136b3f8fa3c246d0de7d.
Change-Id: I938db555e46673dec68713cf02f56dfeb65659bd
Karsten Dambekalns
15:31 Revision f4d64538: Merge "[+BUGFIX] Directory Iteration should skip hidden directories"
Robert Lemke
15:30 Bug #25853 (Resolved): Functional tests for persistence are broken
Applied in changeset commit:b8422bb442b9ae9fad69a83552e4759b9382492c. Karsten Dambekalns
15:12 Bug #25853: Functional tests for persistence are broken
Patch set 3 of change Ic714fe64af3fa25872a05b9f8e609ce2645c9c9f has been pushed to the review server.
It is available...
Mr. Hudson
15:12 Revision b8422bb4: [!!!][BUGFIX] Make FunctionalTestCase usable for persistence tests
This change makes persistence tests usable with Doctrine (again).
It changes some important things:
* enableTestabl...
Karsten Dambekalns
15:12 Revision d69ef1af: [TASK] Cleaned up compile code for Doctrine schema/proxies
Also adds a tearDown() method for use in functional tests.
Change-Id: I246749c7efd9dad7f351f21c7281ba0bcee4c6cf
Karsten Dambekalns
15:11 Revision 72d4a373: [BUGFIX] (Doctrine) Teach SqlitePlatform it's own type
When asking for schema one would get "double precision" back as a type,
but that could not be understood by SqlitePla...
Karsten Dambekalns
15:11 Revision 474cf0ac: [TASK] Small improvement to class loading
The ClassLoader returns TRUE if a class already exists and in
Bootstrap an explicit loadClass() call has been removed...
Karsten Dambekalns
14:41 Bug #25776: Doctrine proxy class files can't be overwritten by other SAPI type
Karsten Dambekalns wrote:
> All files, also the cache files FLOW3 creates, are not writeable by the group, thus the ...
Karsten Dambekalns
14:39 Bug #25776 (Under Review): Doctrine proxy class files can't be overwritten by other SAPI type
Karsten Dambekalns
14:39 Bug #25776: Doctrine proxy class files can't be overwritten by other SAPI type
Patch set 1 of change Icec4e1a7ecebf96cf07a9be09f3c9510b0679f63 has been pushed to the review server.
It is available...
Mr. Hudson
14:39 Revision 30151e02: [TASK] Use temporary file and rename for proxy class creation
Instead of a simple file_put_contents() the proxy class code is written
to a temporary file and renamed to the final ...
Karsten Dambekalns
12:34 Bug #25908 (New): ProxyClassBuilder produces invalid code for prototype arguments
Karsten Dambekalns wrote:
> Duplicate with nicer description provided by Bastian :)
sorry for the duplicate, bu...
Bastian Waidelich
12:17 Bug #25908 (Closed): ProxyClassBuilder produces invalid code for prototype arguments
Duplicate with nicer description provided by Bastian :) Karsten Dambekalns
12:13 Bug #25908 (Resolved): ProxyClassBuilder produces invalid code for prototype arguments
When using SwiftMailer the ProxyClassBuilder creates following code in @F3_SwiftMailer_Message.php@:... Bastian Waidelich
12:30 Bug #25880 (Resolved): Increase minimum PHP version
Applied in changeset commit:318044a7450d57880c5f1a14ea1a013168322534. Bastian Waidelich
12:08 Bug #25880: Increase minimum PHP version
Patch set 3 of change If935afa648afbf00d214a7948d7bc8d083d204f9 has been pushed to the review server.
It is available...
Mr. Hudson
12:17 Revision e2e53f6a: [+BUGFIX] Directory Iteration should skip hidden directories
The problem manifests if one uses SVN, which adds .svn
directories into places which are monitored by file monitoring...
Sebastian Kurfuerst
12:17 Bug #25448 (Closed): Use of undefined constant 'X' during prototype injection
Duplicate with nicer description provided by Bastian :) Karsten Dambekalns
12:08 Revision 318044a7: [+BUGFIX] Increase minimum PHP version to 5.3.2
Currently the MINIMUM_PHP_VERSION is set to '5.3.0RC2-dev' in
the Bootstrap.
But we're calling \ReflectionMethod::set...
Bastian Waidelich
12:00 Task #25907 (New): Referrer should only contain the URI of the previous request
Currently we store all the referrer parts (package, subpackage, controller, action & arguments) of the original reque... Bastian Waidelich
11:54 Bug #25801: Request arguments should never contain objects
Note: We currently also add objects to the Request in ActionController::forward(). To make sure, we only have simple ... Bastian Waidelich
11:30 Bug #25881 (Resolved): Inherited methods cannot be adviced
Applied in changeset commit:db1043531960d4269f258c6913907ca9f2ec6a17. Robert Lemke
11:28 Bug #25906 (Resolved): Injection with settings use breaks
If configuring injection in @Objects.yaml@ and making use of settings for a factory there the generated proxy is brok... Karsten Dambekalns
11:16 Revision d1e4cef2: [BUGFIX] Provide SystemLogger to PointcutMethodNameFilter
Change I7683716c3fa06667867cabafb5efa2b350d6cd19 added logging of
missing argument names when matching. This change m...
Karsten Dambekalns
11:11 Revision 0ffb0ddc: Merge "[BUGFIX] Inherited methods cannot be adviced"
Robert Lemke
11:05 Revision 2487fa24: Merge "[BUGFIX] Broken error message in generic Request class"
Karsten Dambekalns
10:20 Revision a0bf3bb8: [BUGFIX] Property Mapper does not support interface as conversion target
This fixes a check in a function of the Property Mapper which failed if
the given target type was an interface.
Chan...
Robert Lemke
10:03 Bug #25902 (Resolved): It's not possible to add an entity as link/redirect argument
It's very common to redirect to a details view after creating an entity:... Bastian Waidelich

2011-04-11

18:30 Bug #25851 (Resolved): Methods whose name contain "protected" can't be adviced
Applied in changeset commit:036fd8b3a8a5a53c0295ceb9fbc785b1458dece1. Robert Lemke
18:08 Bug #25851: Methods whose name contain "protected" can't be adviced
Patch set 2 of change I11c5cdbeed4caa97682907a0cf39d689e79c3d4a has been pushed to the review server.
It is available...
Mr. Hudson
18:28 Revision dbcad96b: Merge "[FEATURE] Add Doctrine commands for CLI"
Robert Lemke
18:20 Bug #25881: Inherited methods cannot be adviced
Patch set 1 of change I86277ef2b80e68135d069b842fba48b337c05014 has been pushed to the review server.
It is available...
Mr. Hudson
12:04 Bug #25881 (Resolved): Inherited methods cannot be adviced
Due to a bug in the AOP Proxy Class Builder methods of the target class which have been inherited from a parent class... Robert Lemke
18:20 Revision db104353: [BUGFIX] Inherited methods cannot be adviced
This solves a bug in the AOP Proxy Class Builder which resulted in
methods which have been inherited by a parent clas...
Robert Lemke
18:16 Revision 4c73f60a: [BUGFIX] Broken error message in generic Request class
This fixes an error message for specifying a not existing controller
object name.
Change-Id: I7001b4aa9bf15a7bdd3e20...
Robert Lemke
18:06 Revision 036fd8b3: [+BUGFIX] Methods whose name contain "protected" can't be adviced
This fixes a bug in the PointcutExpressionParser which was confused by
"protected" or "public" appearing as part of t...
Robert Lemke
18:06 Bug #25776: Doctrine proxy class files can't be overwritten by other SAPI type
No, it's a more general problem. All files, also the cache files FLOW3 creates, are not writeable by the group, thus ... Karsten Dambekalns
16:12 Bug #25880: Increase minimum PHP version
Patch set 2 of change If935afa648afbf00d214a7948d7bc8d083d204f9 has been pushed to the review server.
It is available...
Mr. Hudson
12:09 Bug #25880: Increase minimum PHP version
Patch set 1 of change If935afa648afbf00d214a7948d7bc8d083d204f9 has been pushed to the review server.
It is available...
Mr. Hudson
12:04 Bug #25880 (Resolved): Increase minimum PHP version
Currently the @MINIMUM_PHP_VERSION@ is set to '5.3.0RC2-dev' in the Bootstrap.
But we're calling @\ReflectionMethod:...
Bastian Waidelich
13:36 Task #25886 (Resolved): Clean up Request hierarchy and fix type hints
Currently we a hierarchy around RequestInterface like this:... Karsten Dambekalns
12:25 Feature #25882 (Accepted): Dedicated query log
Will do... Karsten Dambekalns
12:11 Feature #25882 (Resolved): Dedicated query log
For debugging purposes it would be helpful to log queries executed by Doctrine into a dedicated log ("Query_Developme... Robert Lemke
12:00 Bug #13979 (Resolved): Problem with deleting package
Applied in changeset commit:ee876fdaf524e55cf0fce90283f02271985cfc15. Karsten Dambekalns
12:00 Bug #25858 (Resolved): General global settings override local context settings
Applied in changeset commit:f5c57f1d353aabcd192553c9855a53b79c95d01c. Karsten Dambekalns
11:58 Revision 7247e05c: Merge "[BUGFIX] Fix order in which settings are merged"
Robert Lemke
11:32 Revision 12364ae8: Merge changes I44553020,Ie8bae6d7
* changes:
[BUGFIX] (Package) Clear message when package dir cannot be deleted
[TASK] (Utility) Exception when un...
Karsten Dambekalns
10:27 Bug #25874 (Resolved): Security Randomizer produces a Warning on Windows if openssl_* is not available
In line 166ff of the Security_Randomizer script we're currently using to create the CSRF tokens a random string is ge... Bastian Waidelich
10:19 Bug #25859: CSRF protection does not work for methods that contain upper case characters
Patch set 1 of change Ibae8ad81a7839c983b64bad86a8631c0176c59b1 has been pushed to the review server.
It is available...
Mr. Hudson

2011-04-08

17:44 Bug #25859: CSRF protection does not work for methods that contain upper case characters
solution: all methods and classes should be stored and checked in lowercase in the security context... Andreas Förthner
17:37 Bug #25859 (Resolved): CSRF protection does not work for methods that contain upper case characters
I'm trying to protect all methods of certain controllers with following policy rule:... Bastian Waidelich
17:31 Bug #25853: Functional tests for persistence are broken
Patch set 2 of change Ic714fe64af3fa25872a05b9f8e609ce2645c9c9f has been pushed to the review server.
It is available...
Mr. Hudson
15:18 Bug #25853 (Under Review): Functional tests for persistence are broken
Karsten Dambekalns
15:04 Bug #25853: Functional tests for persistence are broken
Patch set 1 of change Ic714fe64af3fa25872a05b9f8e609ce2645c9c9f has been pushed to the review server.
It is available...
Mr. Hudson
12:42 Bug #25853 (Resolved): Functional tests for persistence are broken
When a database is configured globally it is used instead of the database configured in the FLOW3 package for Testing... Karsten Dambekalns
17:28 Bug #25858 (Under Review): General global settings override local context settings
Karsten Dambekalns
17:27 Bug #25858: General global settings override local context settings
Patch set 1 of change Ic24a63b530e1e2babeb31ec7a9403d3062522f19 has been pushed to the review server.
It is available...
Mr. Hudson
17:23 Bug #25858 (Resolved): General global settings override local context settings
When evaluating the configuration of settings in FLOW3 the settings should be evaluated in the following order, later... Karsten Dambekalns
17:27 Revision f5c57f1d: [BUGFIX] Fix order in which settings are merged
This change makes local context-specific settings take precedence over
generic global settings.
Related: #25853
Fixe...
Karsten Dambekalns
12:39 Bug #3463 (Closed): Short option names for CLI calls do not work anymore
Outdated... Karsten Dambekalns
11:24 Bug #25851: Methods whose name contain "protected" can't be adviced
Patch set 1 of change I11c5cdbeed4caa97682907a0cf39d689e79c3d4a has been pushed to the review server.
It is available...
Mr. Hudson
11:17 Bug #25851 (Resolved): Methods whose name contain "protected" can't be adviced
Due to a bug in the pointcut expression parser, methods which contain the string "public" or "protected" in their nam... Robert Lemke
11:14 Bug #25804 (Rejected): Distribution Base Package is not downloadable
Regine Rosewich wrote:
> The git-repository http://git.typo3.org/FLOW3/Distributions/Base.git is not clonable. The...
Bastian Waidelich

2011-04-07

16:38 Revision d48ddaf8: [TASK] Fix various @var annotations
Change-Id: If4bcdfec251e2acb4353bcd896a30f806e463018 Andreas Förthner
14:20 Revision 323f4341: Merge "[TASK] Adjust @var annotations to current coding guidelines"
Robert Lemke
13:56 Bug #25816: Improve error handling for invalid types
Yes, as I have the same problem here currently: Please go for solution 1! -> I will include that in my serialization ... Andreas Förthner
08:50 Bug #25816 (Resolved): Improve error handling for invalid types
After introducing the Utility\TypeHandling functions, an InvalidArgumentException is thrown if some @var annotation u... Robert Lemke
10:48 Revision a5e4ee52: [TASK] Adjust @var annotations to current coding guidelines
Change-Id: I9bf69170a571345c7ce68818247475b910012471 Andreas Förthner
10:15 Bug #13979: Problem with deleting package
Patch set 4 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available...
Mr. Hudson
08:19 Bug #13979: Problem with deleting package
Patch set 3 of change I445530204cbe7413879b3130610ebc8ba3ab685f has been pushed to the review server.
It is available...
Mr. Hudson
10:15 Revision ee876fda: [BUGFIX] (Package) Clear message when package dir cannot be deleted
When the removal of a package directory fails, throw an exception that
hints at file permissions as a possible cause....
Karsten Dambekalns
10:15 Revision c5d5c5e9: [TASK] (Utility) Exception when unlink fails in emptyDirectoryRecursively
There is a check in place, but it uses the shut-up operator and thus
never get's to check the return value - as the P...
Karsten Dambekalns
10:11 Revision 5d5c9cfa: [BUGFIX] (Utility) Fix isDot() use in Files
CHange Icfdb5027e431140cbf975b8f0002b6f2f53537de added the use of
isDot() in a way that breaks the code fatally. This...
Karsten Dambekalns
09:00 Bug #25472 (Resolved): Files::emptyDirectoryRecursively() cannot remove directories starting with a dot
Applied in changeset commit:9fe27068f684e3953823f1148374fec2577a39c8. Karsten Dambekalns
08:19 Bug #25472: Files::emptyDirectoryRecursively() cannot remove directories starting with a dot
Patch set 3 of change Icfdb5027e431140cbf975b8f0002b6f2f53537de has been pushed to the review server.
It is available...
Mr. Hudson
08:35 Feature #11428: Add performance profiling support
The initial implementation of XHProf support was committed as I3bdb20f763a4130291476b1750e392605e2492f3 but abandoned... Robert Lemke
08:16 Revision 9fe27068: [BUGFIX] (Utility) Make emptyDirectoryRecursively() remove dot-names
If a directory is to be emptied and it contains more directories whose
name starts with a dot, those directories will...
Karsten Dambekalns
08:16 Bug #25776: Doctrine proxy class files can't be overwritten by other SAPI type
For reference, this is what we use, the trick is the umask in combination with our recommended permissions (sticky gr... Karsten Dambekalns
 

Also available in: Atom