Activity

From 2011-09-19 to 2011-10-18

2011-10-18

22:05 Bug #31083 (Resolved): Missing Lazy annotation in migration script
Applied in changeset commit:69f039e5292ba60c2f68f349ebe431683625deba. Julian Kleinhans
21:12 Bug #31083 (Under Review): Missing Lazy annotation in migration script
Patch set 1 of change I76c7744d0c94c7e4d1406972d61400c5ece8dccc has been pushed to the review server.
It is available...
Mr. Hudson
21:10 Bug #31083 (Resolved): Missing Lazy annotation in migration script
The Lazy annotation is missing in the migration-annotation.php script Julian Kleinhans
22:03 Feature #28052: Possibility to enable or disable accounts
Patch set 2 of change I24328e1ff4b2096e7d2de5d602b7bfe5ce45e15b has been pushed to the review server.
It is available...
Mr. Hudson
21:58 Revision 70f9da6c: [TASK] Don't flush caches after package:create
Creating a new package does not really require flushing
all caches because it only adds code (the package class)
but ...
Robert Lemke
21:52 Revision 253ca06e: Merge "[BUGFIX] Missing Lazy annotation in migration script"
Karsten Dambekalns
21:03 Revision 69f039e5: [BUGFIX] Missing Lazy annotation in migration script
The Lazy annotation is missing in the migration-annotation.php script
Change-Id: I76c7744d0c94c7e4d1406972d61400c5ec...
Julian Kleinhans
18:33 Revision 00f1cfeb: [BUGFIX] Minor fix in LinkTest
This fixes a test for \TYPO3\FLOW3\Utility\Files::is_link()
that failed to properly delete a previously generated sym...
Bastian Waidelich
17:21 Revision f1eca95a: [TASK] Remove scope annotations for prototypes
Change-Id: Ifae33dbe4136e0462d21730205b7a7ffea6dd899 Karsten Dambekalns
16:45 Revision 629d5e38: [BUGFIX] Fix doc comment parsing of single line descriptions
A simple bugfix and test for single line description in doc comment
blocks.
Change-Id: I32eadd106397d0b2777f7e32834f...
Christopher Hlubek
16:14 Revision 1da6a9ea: [TASK] Drop @author tags from source code
Change-Id: Ia8a67435a9b43b46ab43ede50966136c90c0e76d Karsten Dambekalns
15:40 Bug #31061 (Resolved): defective and maybe obsolete is_link() mirror function
Applied in changeset commit:b306b18ac9efcba83ae9525bf470cc020d6d4b34. Bastian Waidelich
15:03 Bug #31061 (Under Review): defective and maybe obsolete is_link() mirror function
Patch set 1 of change I94c53b5fe8dda82c05690cf02286091672d0650e has been pushed to the review server.
It is available...
Mr. Hudson
12:48 Bug #31061: defective and maybe obsolete is_link() mirror function
Bastian Waidelich wrote:
> Unfortunately on PHP 5.3.5 (on Windows 7 @ 64bit) neither is_link() nor SplFileInfo::is...
Bastian Waidelich
12:45 Bug #31061: defective and maybe obsolete is_link() mirror function
Unfortunately on PHP 5.3.5 (on Windows 7 @ 64bit) neither is_link() nor SplFileInfo::isLink() work correctly..
*Step...
Bastian Waidelich
12:19 Bug #31061 (Needs Feedback): defective and maybe obsolete is_link() mirror function
Bastian, can you confirm this? Karsten Dambekalns
12:14 Bug #31061 (Resolved): defective and maybe obsolete is_link() mirror function
in \TYPO3\FLOW3\Utility\Files the function is_link is defective. The function returns... Adrian Föder
15:40 Bug #31042 (Resolved): Throwing an exception throws an exception....
Applied in changeset commit:9c48618359df5e4a2d3d5e026a43adcb67944c18. Karsten Dambekalns
15:36 Bug #31042: Throwing an exception throws an exception....
Patch set 2 of change I936356d0c19fafbf3051cd10a9f92d97e64c4974 has been pushed to the review server.
It is available...
Mr. Hudson
11:17 Bug #31042 (Under Review): Throwing an exception throws an exception....
Patch set 1 of change I936356d0c19fafbf3051cd10a9f92d97e64c4974 has been pushed to the review server.
It is available...
Mr. Hudson
09:37 Bug #31042 (Accepted): Throwing an exception throws an exception....
Karsten Dambekalns
09:28 Bug #31042: Throwing an exception throws an exception....
..maybe the current() invocation should be replaced with @$scopeAnnotation->value@, so that the whole block should re... Adrian Föder
09:22 Bug #31042 (Resolved): Throwing an exception throws an exception....
after running the master branch intended to become RC1, I have @Uncaught Exception in FLOW3 #1: Warning: current() ex... Adrian Föder
15:36 Revision 9c486183: [BUGFIX] Exception when entities/valueobjects are not prototype
Change-Id: I936356d0c19fafbf3051cd10a9f92d97e64c4974
Fixes: #31042
Karsten Dambekalns
15:35 Revision b10befd7: Merge "[BUGFIX] Fix error when doctrine:validate finds errors"
Robert Lemke
15:31 Revision 2915d772: [TASK] Beautify exception messages in command line interface
This wraps a try-catch block around the request handling part for
command line commands and renders a more friendly e...
Robert Lemke
15:23 Revision 208c4752: Merge "[TASK] Fix edge case in annotation migration script"
Robert Lemke
15:07 Bug #31070: Symlink related Unit Tests fail on some Windows systems
Patch set 2 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available...
Mr. Hudson
14:43 Bug #31070 (Under Review): Symlink related Unit Tests fail on some Windows systems
Patch set 1 of change I6e59ec224d6c3a3c6f62180be334d3b76d1d067d has been pushed to the review server.
It is available...
Mr. Hudson
14:40 Bug #31070 (Resolved): Symlink related Unit Tests fail on some Windows systems
Depending on the system configuration and the current Windows Username, the PHP function @sys_get_temp_dir()@ returns... Bastian Waidelich
15:03 Revision b306b18a: [BUGFIX] make is_link() work around work for paths with trailing slash
On Windows \TYPO3\FLOW3\Utility\Files::is_link() compares the
given path with the resolved absolute path due to a bug...
Bastian Waidelich
14:11 Revision 994f209e: [TASK] Clean up unit tests using the real ReflectionService
Change-Id: If119aff01c4dbf8038ae11033155f938e9a2eedc Karsten Dambekalns
14:10 Revision 3cc446e5: [TASK] Cache annotation parsing results
Now class and property annotations are collected during regular
class reflection and reused later. This avoids buildi...
Karsten Dambekalns
12:27 Revision b22b157a: [TASK] Fix edge case in annotation migration script
The script failed to replace (some?) nested ORM annotations with
prefixed ones.
Change-Id: I410c39b542262abfc8fe58c5...
Karsten Dambekalns
11:36 Bug #31052 (Resolved): PackageManager::createPackage() creates invalid annotation
Applied in changeset commit:139a4dac9fecd25c694657ef269ff43761be5eb5. Bastian Waidelich
11:09 Bug #31052 (Under Review): PackageManager::createPackage() creates invalid annotation
Patch set 1 of change I7a9e1a7c075fbf48cb3c20593fcb6e43c9c71b01 has been pushed to the review server.
It is available...
Mr. Hudson
11:08 Bug #31052 (Resolved): PackageManager::createPackage() creates invalid annotation
The @PackageManager::createPackage()@ that is called by the @flow3 package:create@ command still creates a Package.ph... Bastian Waidelich
11:16 Revision 207a6c97: [BUGFIX] Fix error when doctrine:validate finds errors
Change-Id: If0c0e0c3a3ae5ce91d3d59ce3842b52d41921b84 Karsten Dambekalns
11:09 Revision 139a4dac: [BUGFIX] PackageManager::createPackage() creates invalid annotation
The PackageManager::createPackage() that is called by the
package:create command still creates a Package.php file wit...
Bastian Waidelich
09:37 Bug #31015 (Resolved): Second classloader in ReflectionService doesn't know about packages
Applied in changeset commit:59b758615957dea8a2efc0defbac2a190b15b31e. Karsten Dambekalns

2011-10-17

23:50 Bug #31015: Second classloader in ReflectionService doesn't know about packages
Patch set 2 of change I50646c4757ea66413ff97406e829b050af7fb29f has been pushed to the review server.
It is available...
Mr. Hudson
18:50 Bug #31015 (Under Review): Second classloader in ReflectionService doesn't know about packages
Patch set 1 of change I50646c4757ea66413ff97406e829b050af7fb29f has been pushed to the review server.
It is available...
Mr. Hudson
18:47 Bug #31015 (Resolved): Second classloader in ReflectionService doesn't know about packages
There should be reuse of the classloader already created in Bootstrap. Karsten Dambekalns
23:50 Revision 59b75861: [BUGFIX] Reuse FLOW3 classloader in ReflectionService
There was a second class loader being created for the annotation
parser. It was lacking the available packages and th...
Karsten Dambekalns
23:31 Feature #27115 (Closed): AOP should provide a way to change method parameters
Closing as duplicate Karsten Dambekalns
22:15 Feature #31021 (Under Review): PropertyMappingConfiguration should support not mapping of properties
Patch set 1 of change Ieb43e8cd244b82c4b6cd388bdf582f9214fe711b has been pushed to the review server.
It is available...
Mr. Hudson
21:55 Feature #31021 (Resolved): PropertyMappingConfiguration should support not mapping of properties
Currently the shouldMap method of the PropertyMappingConfiguration always returns TRUE, it should be possible to conf... Christian Jul Jensen
22:05 Bug #30778 (Resolved): Exceeding Request arguments should only be appended to URI if configured
Applied in changeset commit:d74ce5d9cf5081ebe019c594b80c4d17b96d4fa8. Bastian Waidelich
21:45 Bug #30778: Exceeding Request arguments should only be appended to URI if configured
Patch set 3 of change I5fcb3b583cc237957337e1d94731695e51afcc45 has been pushed to the review server.
It is available...
Mr. Hudson
21:59 Revision b483234c: [TASK] Add appendExceedingArguments setting to all default routes
This adds the setting appendExceedingArguments to the default
fallback routes of FLOW3 in order to make more custom r...
Bastian Waidelich
21:42 Revision d74ce5d9: [!!!][TASK] Only append exceeding request arguments to URI if configured
This changes the default behavior of the routing framework in
order to be more consequent and easier to extend in the...
Bastian Waidelich
19:49 Revision 3ffa7ad0: Merge "[TASK] Convenience Method for adding FlashMessages"
Bastian Waidelich
17:35 Bug #30929 (Resolved): Routing does not always work if splitString is optional
Applied in changeset commit:ce14c0003eb87316e760985c7fa59cbee5af1a72. Bastian Waidelich
17:08 Bug #30929: Routing does not always work if splitString is optional
Patch set 3 of change Iae4ba2652c08e8a0ba468076ae5dec6008f0ea47 has been pushed to the review server.
It is available...
Mr. Hudson
16:57 Revision ce14c000: [BUGFIX] Routing does not always work if splitString is optional
If the route part following an identity route part optional
like "{post}(.html)", the identityRoutePart creates a cor...
Bastian Waidelich
16:20 Revision 10fc76e9: [TASK] Safeguard APC use (in CLI requests)
When activating APC as cache for Doctrine one would get fatal
errors in CLI, because by default APC is disabled for C...
Karsten Dambekalns
15:56 Revision 1f9a0e65: [TASK] Convenience Method for adding FlashMessages
This adds a method addFlashMessage() to the AbstractController
This should be used for adding FlashMessages instead o...
Bastian Waidelich
15:48 Revision 42e8a5eb: [TASK] Adjust to new annotation syntax
The syntax for annotations changed with #27627, this adjusts the
code as needed.
Change-Id: I4ae04dfbeda759332185480...
Karsten Dambekalns
15:48 Revision 4e01754c: [TASK] Useless cleanup of @return annotations...
just because I touched those files anyway.
Change-Id: Ieca9c85b5da389f727f5ccd87d8136faa2098905
Karsten Dambekalns
15:48 Revision db6c8259: [TASK] Teach AOP classAnnotatedWith & methodAnnotatedWith
Two new point cut designators added, includes tests. The pattern
given is used as is, only backslashes are escaped fo...
Karsten Dambekalns
15:48 Revision f00f63fa: [TASK] Support new annotation syntax
This adds support for the new annotation syntax in a way that aims
to change as little code as needed. It does this b...
Karsten Dambekalns
13:51 Bug #31002 (New): Generated __sleep method handles static properties as members.
The __sleep method generated by \TYPO3\FLOW3\Object\DependencyInjection\ProxyClassBuilder::buildSerializeRelatedEntit... Stephan Schuler

2011-10-15

01:58 Revision 32bb751e: [TASK] Add our annotations as classes
This adds classes for all annotations used in FLOW3 to the
TYPO3\FLOW3\Annotations namespace.
Change-Id: I1585399201...
Karsten Dambekalns
01:40 Bug #29976 (Resolved): CSRF token is always the same
Applied in changeset commit:1dd7ba68d3f0b6d6b2c0f9ef9f480e80aab08f2d. Christian Müller
01:14 Revision e8d85ba3: Merge "[BUGFIX] Security_Randomizer fallback does not work"
Karsten Dambekalns
01:05 Revision b7573cb0: [TASK] Remove leftover encoding declarations
Change-Id: Iebda413a9d9560ec51c9a1bea027258f117a7118
Resolves: #30861
Karsten Dambekalns
00:58 Bug #29982 (Resolved): Wrong table structure for multiple ManyToOne relations
Resolved with #30223. Karsten Dambekalns

2011-10-14

19:38 Revision 795c7d00: [!!!][BUGFIX] invalid YAML parser result should be empty array
A non array result of the symfony YAML parser will now be
converted to an empty array to not break things.
Breaking ...
Christian Müller
15:40 Bug #30934 (Accepted): persistAll() should only be called if EntityManager is still alive
Karsten Dambekalns
15:12 Bug #30934 (Resolved): persistAll() should only be called if EntityManager is still alive
In some cases it can happen, that the EntityManager is closed at the end of an controller. This *can* be a valid situ... Thomas Hempel
15:10 Feature #30933 (Needs Feedback): Check for unique constraints on add()
If you define a uniqueConstraints in a Model you want to have that checked as soon as the add() method of your reposi... Thomas Hempel
14:48 Bug #30929 (Under Review): Routing does not always work if splitString is optional
Patch set 2 of change Iae4ba2652c08e8a0ba468076ae5dec6008f0ea47 has been pushed to the review server.
It is available...
Mr. Hudson
14:21 Bug #30929 (Resolved): Routing does not always work if splitString is optional
If the route part following an identity route part optional like... Bastian Waidelich
14:17 Task #27627 (Under Review): Overhaul annotation support/syntax
Karsten Dambekalns
14:06 Feature #26358 (Resolved): Initialize sessions only when necessary
Applied in changeset commit:6d7d3b9ae15b120acb647526f92ed443fdab312a. Robert Lemke
13:50 Feature #26358: Initialize sessions only when necessary
Patch set 12 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is availabl...
Mr. Hudson
14:06 Bug #30436 (Resolved): Access denied exception after session timeout with CSRF
Applied in changeset commit:0edbd68a074a248a8ddd4b023002a7a51e98ca48. Christopher Hlubek
13:52 Bug #30436: Access denied exception after session timeout with CSRF
Patch set 4 of change If2c9c6386a2ee26195073a359dcf87db515d1dc0 has been pushed to the review server.
It is available...
Mr. Hudson
13:51 Revision 0edbd68a: [BUGFIX] Fix access denied exception after session timeout with CSRF
This change nests the firewall inspection in the try catch block that
also catches AuthenticationRequired exceptions ...
Christopher Hlubek
13:50 Revision 6d7d3b9a: [FEATURE] Initialize session and session objects on demand
The default behavior of FLOW3 was that a session was initialized – and
thus a cookie sent – on every request, no matt...
Robert Lemke
13:19 Bug #30778: Exceeding Request arguments should only be appended to URI if configured
Patch set 2 of change I5fcb3b583cc237957337e1d94731695e51afcc45 has been pushed to the review server.
It is available...
Mr. Hudson
11:08 Revision c03a6ab1: [TASK] Get rid of some duplicate code
Moves one duplicate method up and removes one that was
completely unused by now.
The tests for the latter have been ...
Karsten Dambekalns
09:39 Bug #30914 (Resolved): Proxy methods for methods with "by reference" return type are broken
The proxy class builder ignores the by-reference & in the proxy method, and therefore you get an PHP fatal error. Andreas Förthner
08:53 Bug #28036 (Resolved): Database password in Settings.yaml is not recognized when it starts with an ampersand
New YAML parser is merged so this can be closed. I can confirm that a string starting with ampersand works as expecte... Christian Müller
01:05 Task #30826 (Resolved): Use Symphony YAML parser for settings instead of Horde/YAML
Applied in changeset commit:23468adc78877afc51af7a4c39fe3e649afb226e. Christian Müller
00:38 Revision 7f2686df: Merge "[TASK] Use Symphony YAML parser for settings instead Horde/YAML"
Robert Lemke
00:07 Bug #30858 (Resolved): Proxy Class Builder ignores optional arguments with NULL default
Applied in changeset commit:8175869916ad95c8bdd06498c8caaad5d6c1ceac. Christian Müller
00:06 Bug #29488 (Resolved): AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Applied in changeset commit:d77d259613775337751115098200e6175adfcb28. Bastian Waidelich

2011-10-13

23:53 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Patch set 2 of change Ia3d15f8e5e900ccc3b5be1b22b668d5ddadad7c8 has been pushed to the review server.
It is available...
Mr. Hudson
23:52 Revision d77d2596: [!!!][TASK] Change default authentication strategy
This changes the default authentication strategy from "anyToken"
to "atLeastOneToken" in order to provoke an exceptio...
Bastian Waidelich
23:46 Revision 22b094b1: Merge "[BUGFIX] Proxy Class Builder should work with NULL default"
Robert Lemke
23:35 Revision a8bb5b03: Merge "[TASK] Remove scope annotations from interfaces"
Robert Lemke
23:31 Feature #26358: Initialize sessions only when necessary
Patch set 11 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is availabl...
Mr. Hudson
23:09 Feature #26358: Initialize sessions only when necessary
Patch set 10 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is availabl...
Mr. Hudson
22:37 Feature #26358: Initialize sessions only when necessary
Patch set 9 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is available...
Mr. Hudson
23:07 Task #30825 (Resolved): Cleanup of (Flash)Messages API
Applied in changeset commit:2dc4ac4cbd6e370edb3aab21fcf5ec8e15ef4077. Robert Lemke
22:37 Task #30825: Cleanup of (Flash)Messages API
Patch set 9 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
00:17 Task #30825: Cleanup of (Flash)Messages API
Patch set 8 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
20:16 Bug #30778 (Under Review): Exceeding Request arguments should only be appended to URI if configured
Patch set 1 of change I5fcb3b583cc237957337e1d94731695e51afcc45 has been pushed to the review server.
It is available...
Mr. Hudson
18:41 Revision b7326a86: [TASK] Remove scope annotations from interfaces
They have no effect and in userland code even trigger an error.
Change-Id: I49c72a2b9b843173bb9972b106fad114bd9e8a3b
Karsten Dambekalns
17:06 Bug #30633 (Resolved): endless recursion when using the wrong php binary
Applied in changeset commit:a7da3409cb3173d17fcabae5c5cc0c10911f0672. Robert Lemke
16:55 Revision 2dc4ac4c: [!!!][TASK] Clean up Flash Messages API
- FlashMessageContainer is moved to \TYPO3\FLOW3\MVC
- FlashMessage is removed
- FlashMessageContainer now uses \TYPO...
Robert Lemke
16:55 Revision 0800ec1b: [TASK] Make PHPSessions configurable
Change-Id: If2cbda3531e3fec394d6ad35e72f5fc75277f18f
Resolve: #30848
Martin Brüggemann
15:47 Bug #29295: Uncaught Exception in FLOW3 SQLSTATE[HY000]: General error: 1005 Can't create table 'phoenix.#sql-3dc_28' (errno: 150)
Indeed there was a fix recently, could you try if you can reproduce the error with current master? Because I guess no... Christian Müller
15:24 Feature #9534 (Rejected): RAND as order posibility
As stated, with doctrine no longer an issue. Christian Müller
15:21 Feature #3580: Create an administration panel for the FLOW3 Development context
didn't see this ticket so created:
http://forge.typo3.org/issues/30890
with the ideas.
I would use Phoenix styles ...
Christian Müller
15:17 Feature #30890 (Accepted): Developer Toolbar
Create a toolbar that can be enabled to provide easy debugging features and help to the FLOW3 developer.
Some idea...
Christian Müller
15:07 Bug #28036: Database password in Settings.yaml is not recognized when it starts with an ampersand
this works with: https://review.typo3.org/#change,5740 Christian Müller
14:51 Bug #30858: Proxy Class Builder ignores optional arguments with NULL default
Patch set 5 of change I268e5f90ac815edadfe5b49cbc779697ea51a5f5 has been pushed to the review server.
It is available...
Mr. Hudson
11:40 Bug #30858: Proxy Class Builder ignores optional arguments with NULL default
Patch set 4 of change I268e5f90ac815edadfe5b49cbc779697ea51a5f5 has been pushed to the review server.
It is available...
Mr. Hudson
08:54 Bug #30858: Proxy Class Builder ignores optional arguments with NULL default
Patch set 3 of change I268e5f90ac815edadfe5b49cbc779697ea51a5f5 has been pushed to the review server.
It is available...
Mr. Hudson
14:49 Revision 81758699: [BUGFIX] Proxy Class Builder should work with NULL default
Optional arguments with NULL default value will now be correctly
autowired in the proxy class. Therefor optional argu...
Christian Müller

2011-10-12

23:44 Bug #29976: CSRF token is always the same
Patch set 2 of change I93c432e45071a3c5628e98b3fbefa7407c715c15 has been pushed to the review server.
It is available...
Mr. Hudson
12:46 Bug #29976: CSRF token is always the same
FYI: We have added two bug reports to the "Improved Security" project at "SourceSorge":http://sourceforge.net/tracker... Bastian Waidelich
23:43 Revision 1dd7ba68: [BUGFIX] Security_Randomizer fallback does not work
This fix should allow Security_Randomizer to work on Win x64
by making sure that the mt_rand fallback actually return...
Christian Müller
23:21 Bug #29488 (Under Review): AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Patch set 1 of change Ia3d15f8e5e900ccc3b5be1b22b668d5ddadad7c8 has been pushed to the review server.
It is available...
Mr. Hudson
23:04 Bug #29488 (Accepted): AuthenticationManager::authenticate() does not throw Exception for invalid credentials
As discussed at T3CON11 we should change the default strategy from "anyToken" to "atLeastOneToken" as that will fit t... Bastian Waidelich
23:04 Bug #30858: Proxy Class Builder ignores optional arguments with NULL default
Patch set 2 of change I268e5f90ac815edadfe5b49cbc779697ea51a5f5 has been pushed to the review server.
It is available...
Mr. Hudson
20:39 Bug #30858 (Under Review): Proxy Class Builder ignores optional arguments with NULL default
Patch set 1 of change I268e5f90ac815edadfe5b49cbc779697ea51a5f5 has been pushed to the review server.
It is available...
Mr. Hudson
20:35 Bug #30858 (Resolved): Proxy Class Builder ignores optional arguments with NULL default
Christian Müller
22:33 Task #30825: Cleanup of (Flash)Messages API
Patch set 7 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
16:45 Task #30825: Cleanup of (Flash)Messages API
Patch set 6 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
15:27 Task #30825: Cleanup of (Flash)Messages API
Patch set 5 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
14:07 Task #30825: Cleanup of (Flash)Messages API
Patch set 3 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
14:04 Task #30825 (Under Review): Cleanup of (Flash)Messages API
Patch set 2 of change I37370d824511fe3ad6cd993a22ca43a9ffbb13c9 has been pushed to the review server.
It is available...
Mr. Hudson
11:17 Task #30825 (Resolved): Cleanup of (Flash)Messages API
To have a nice API for 1.0 cleanup of FlashMessage, FlashMessageContainer and Message objects is needed. Additionally... Christian Müller
21:35 Feature #26358: Initialize sessions only when necessary
Patch set 8 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is available...
Mr. Hudson
21:29 Feature #26358: Initialize sessions only when necessary
Patch set 7 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is available...
Mr. Hudson
19:44 Feature #26358: Initialize sessions only when necessary
Patch set 6 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is available...
Mr. Hudson
15:27 Feature #26358 (Under Review): Initialize sessions only when necessary
Patch set 5 of change Id7ca5086353a77cabab27086949e326aa0e3d7a6 has been pushed to the review server.
It is available...
Mr. Hudson
18:04 Bug #30436: Access denied exception after session timeout with CSRF
Patch set 3 of change If2c9c6386a2ee26195073a359dcf87db515d1dc0 has been pushed to the review server.
It is available...
Mr. Hudson
16:48 Task #30826: Use Symphony YAML parser for settings instead of Horde/YAML
Patch set 2 of change I3dff3073045b7be75dfd2c54080a347f5616344d has been pushed to the review server.
It is available...
Mr. Hudson
16:00 Task #30826 (Under Review): Use Symphony YAML parser for settings instead of Horde/YAML
Patch set 1 of change I3dff3073045b7be75dfd2c54080a347f5616344d has been pushed to the review server.
It is available...
Mr. Hudson
11:38 Task #30826 (Accepted): Use Symphony YAML parser for settings instead of Horde/YAML
Christian Müller
11:37 Task #30826 (Resolved): Use Symphony YAML parser for settings instead of Horde/YAML
Ideally make a separate Symphony YAML package out of it. Christian Müller
16:48 Revision 23468adc: [TASK] Use Symphony YAML parser for settings instead Horde/YAML
Drop Horde YAML parser and use Symfony YAML parser instead.
It is now included in the new package
Symfony.Component.Y...
Christian Müller
15:22 Task #30848 (Resolved): Make PHP session configurable
I'm using FLOW3 in a subdomain environment and need a way to have valid session cookies for all subdomains of a php s... Martin Brüggemann
11:38 Bug #28036: Database password in Settings.yaml is not recognized when it starts with an ampersand
Hopefully fixed after having: http://forge.typo3.org/issues/30826 Christian Müller
10:48 Feature #26783 (Under Review): Support settings via OS Environment
Patch set 1 of change I89877637d440e060c45dc73011e65a01b36302c4 has been pushed to the review server.
It is available...
Mr. Hudson
00:00 Bug #30223: Column names for association properties are generated wrong
Hint for developers that come across this and need to upgrade their packages:
It is not possible for Doctrine to det...
Bastian Waidelich

2011-10-11

19:52 Bug #29976 (Under Review): CSRF token is always the same
Patch set 1 of change I93c432e45071a3c5628e98b3fbefa7407c715c15 has been pushed to the review server.
It is available...
Mr. Hudson
19:31 Bug #29976: CSRF token is always the same
Yep I see,
I guess it goes wrong around line 219 for you, maybe you check that out. It fills an array with zeros t...
Christian Müller
17:01 Bug #29976: CSRF token is always the same
Christian Mueller wrote:
> Maybe we should add a fallback to generate "not so strongly randomized data" to have
>...
Bastian Waidelich
16:38 Bug #29976: CSRF token is always the same
Maybe we should add a fallback to generate "not so strongly randomized data" to have it running on Win 64-bit but log... Christian Müller
16:37 Bug #29976: CSRF token is always the same
That is a shortcoming of /Packages/Framework/TYPO3.FLOW3/Resources/PHP/iSecurity/Security_Randomizer.php, it also men... Christian Müller
16:24 Bug #30493: CLI argument handling chokes on = use
Patch set 2 of change I15c7ca0ba50fc612b7328573ebce9f748c46fb2f has been pushed to the review server.
It is available...
Mr. Hudson
16:23 Bug #30493 (Under Review): CLI argument handling chokes on = use
Patch set 1 of change I15c7ca0ba50fc612b7328573ebce9f748c46fb2f has been pushed to the review server.
It is available...
Mr. Hudson
11:14 Bug #30778 (Resolved): Exceeding Request arguments should only be appended to URI if configured
Currently when creating URIs/Links via the UriBuilder arguments that are not part of the configured route values are ... Bastian Waidelich
10:52 Bug #28035 (Closed): FLOW3_REWRITEURLS is not taken into credit
Bastian Waidelich
10:09 Bug #28035: FLOW3_REWRITEURLS is not taken into credit
ehm, please close, no right to do so :-) Markus Bucher
10:08 Bug #28035: FLOW3_REWRITEURLS is not taken into credit
True, works like a charm. My bad, there was a .htaccess some folders before trying to use mod_rewrite. This led to th... Markus Bucher
08:47 Bug #28035 (Needs Feedback): FLOW3_REWRITEURLS is not taken into credit
Using FLOW3 without mod_rewrite is perfectly okay – you just won't have the nice URLs. Which errors did you experience? Robert Lemke
09:15 Bug #30633 (Under Review): endless recursion when using the wrong php binary
Robert Lemke
09:15 Bug #30633 (Accepted): endless recursion when using the wrong php binary
Robert Lemke
09:14 Bug #30633: endless recursion when using the wrong php binary
Patch set 1 of change I1b0bb6e451acb60512cd1820fda1e26a5c261e04 has been pushed to the review server.
It is available...
Mr. Hudson
09:11 Revision a7da3409: [BUGFIX] No endless recursion on a missing CLI PHP binary
If a wrong path has been specified or a PHP binary is used which
does not support CLI, FLOW3 could end up in an endle...
Robert Lemke
08:48 Bug #28036 (Accepted): Database password in Settings.yaml is not recognized when it starts with an ampersand
Robert Lemke
08:46 Bug #27695 (Closed): Production configuration cache not flushed on cache:flush
Can't reproduce with current master Robert Lemke
08:42 Revision a15d379c: Merge "[TASK] ClassLoader returns TRUE now if class was found"
Robert Lemke
08:30 Feature #30256: Package help in CLI
I think that, for the sake of simplicity, it should output a list of commands similar to what the current help index ... Robert Lemke

2011-10-10

17:59 Revision bd7ea42b: [TASK] ClassLoader returns TRUE now if class was found
Change-Id: I6970f8f7d22f82af9e19c8c799b281c0ad70d18d Karsten Dambekalns
17:58 Revision 7e901348: [TASK] Fix type annotation for ReflectionService in ObjectSerializer
The var annotation for the ReflectionService property was wrong.
Change-Id: Ie187d4cfdfe09a4456a71d582138081c0429189c
Karsten Dambekalns
12:04 Bug #30714 (Closed): \TYPO3\FLOW3\var_dump() memory use causes fatal error debugging objects.
During some FLOW3 CRUD testing, I got an error several times I wanted to debug objects that have related objects.
...
Alexander Schnitzler
10:18 Revision d8bed4b6: [TASK] Fixed consistent typo in variable name
In the bootstrap one variable was called
$possibleComanndControllerIdentifier instead of
$possibleCommandControllerId...
Robert Lemke

2011-10-07

16:53 Bug #30633 (Resolved): endless recursion when using the wrong php binary
If I uses non cli-php to call flow3, it will get an endless recursion.
It will be better to stop after 100 call, o...
Yves Poersch
13:38 Feature #30378: Cookie authentication
Sorry, I completely missed the thing; what is described above is a kind of session login handling which FLOW3 supplie... Adrian Föder

2011-10-06

23:25 Bug #30614 (Resolved): Use of undefined policies throws exception
Notice: Undefined index: Test in /srv/c/cdas/src/shared/Data/Temporary/Development/Cache/Code/FLOW3_Object_Classes/TY... Peter Russ

2011-10-05

14:47 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Andreas Förthner wrote:
> On the other hand, anyToken [...] doesn't break something if you do nothing...
Except for...
Bastian Waidelich
14:22 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
As already discussed, the behaviour is correct. But maybe we really should change the default strategy. On the other ... Andreas Förthner
12:03 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Bastian Waidelich wrote:
> But if I get it right, the behavior of the default strategy (anyToken) is not correct.
....
Bastian Waidelich
11:57 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
This would be "expected" behavior for the @anyToken@ authentication strategy - authenticated doesn't mean authorized.... Karsten Dambekalns
11:55 Bug #29488: AuthenticationManager::authenticate() does not throw Exception for invalid credentials
I can reproduce this with the default setup.
To fix this you can change the authentication strategy. for instance li...
Bastian Waidelich
11:50 Bug #29488 (Needs Feedback): AuthenticationManager::authenticate() does not throw Exception for invalid credentials
Andi, can you shed some light on this? Karsten Dambekalns
09:54 Revision 659195f9: Merge "[TASK] Use IndexedReader instead of our own "fix""
Karsten Dambekalns
09:52 Revision e2544f5f: Merge "[TASK] Clarify persistence behavior for inheritance in aggregate roots"
Karsten Dambekalns

2011-10-04

19:05 Bug #30542 (Resolved): Static Route Parts are not reset
Applied in changeset commit:9d03bb5259c34403d95f7048da9c80e8a7fb7543. Bastian Waidelich
13:10 Bug #30542 (Under Review): Static Route Parts are not reset
Patch set 1 of change Ide104658cb1c822e58768200092c30dd0b356e33 has been pushed to the review server.
It is available...
Mr. Hudson
13:07 Bug #30542 (Resolved): Static Route Parts are not reset
@StaticRoutePart::resolve()@ sets the value to the route parts name (= the corresponding URI part).
@RoutePart::matc...
Bastian Waidelich
13:09 Revision 9d03bb52: [BUGFIX] Static Route Parts are not reset
StaticRoutePart::resolve() sets the value to the route parts
name (= the corresponding URI part).
RoutePart::match() ...
Bastian Waidelich
09:52 Bug #30536 (Resolved): URI builder does not work correctly with arguments of subrequests
see https://review.typo3.org/#change,2001 Andreas Förthner

2011-10-03

18:11 Revision 6216c3d7: [TASK] Use IndexedReader instead of our own "fix"
There was a mapAnnotationsToKeys() method in our annotation
driver. Using the IndexedReader from Doctrine is the bett...
Karsten Dambekalns
17:01 Revision b46db7bf: [TASK] Another cosmetic fix.
Change-Id: Ifc7af4005f37374c4247a670ca05e5b2aee4003a Robert Lemke
16:58 Revision cb9d87ad: [TASK] Trivial cosmetic fixes.
Change-Id: I7e2156d41211e8094e997a10f0e6a040b2cadf69 Robert Lemke

2011-10-01

00:02 Bug #30493 (Resolved): CLI argument handling chokes on = use
When a value for an argument is given like @--name=value@ the result is an uncaught exception #1297759968. Karsten Dambekalns

2011-09-30

23:35 Bug #29978 (Resolved): Wrong default value 'Text' for $dataType in TYPO3\FLOW3\MVC\Controller\Arguments::addNewArgument()
Applied in changeset commit:2b29376b3ea683ccf15ae925a6cd0373d3749491. Johannes K
23:19 Bug #29978: Wrong default value 'Text' for $dataType in TYPO3\FLOW3\MVC\Controller\Arguments::addNewArgument()
Patch set 3 of change I82f77161e4b7ec277599feb8e07834ed9d39692a has been pushed to the review server.
It is available...
Mr. Hudson
23:19 Revision 2b29376b: [BUGFIX] Wrong default value 'Text' for $dataType
The default value 'Text' for $dataType in the signature of the method
addNewArgument should be 'string' because there...
Johannes K
15:15 Revision bdb224d8: [BUGFIX] Fix regression: flush caches blocked by aggregate analysis
On trying to flush the caches after a package has been removed or
deactivated, the Reflection Service can fail due to...
Robert Lemke
13:44 Feature #27329 (Rejected): Wrap Doctrine ArrayCollection in some FLOW3 collection
I gave this more thought yesterday and today. My conclusion: if we do this, we'll break things or gain nothing.
*o...
Karsten Dambekalns
12:16 Feature #27329: Wrap Doctrine ArrayCollection in some FLOW3 collection
+1 for introducing a FLOW3 interface / wrapper for collections Robert Lemke
12:25 Task #29543 (Resolved): Clarifiy persistence behavior for inheritance in entities / aggregate roots
Karsten Dambekalns
12:20 Task #29543: Clarifiy persistence behavior for inheritance in entities / aggregate roots
Patch set 2 of change Ic64e8cc7b72fc1f570ab4ed9d09a435707e0cc12 has been pushed to the review server.
It is available...
Mr. Hudson
12:00 Task #29543 (Under Review): Clarifiy persistence behavior for inheritance in entities / aggregate roots
Patch set 1 of change Ic64e8cc7b72fc1f570ab4ed9d09a435707e0cc12 has been pushed to the review server.
It is available...
Mr. Hudson
11:52 Task #29543: Clarifiy persistence behavior for inheritance in entities / aggregate roots
A small update to the scope of this:
Karsten Dambekalns wrote:
> * it will return both types
> * it will accept ...
Karsten Dambekalns
12:24 Bug #29416 (Resolved): Aggregate root detection for Person vs AbstractParty is broken
Karsten Dambekalns
12:20 Bug #29416: Aggregate root detection for Person vs AbstractParty is broken
Patch set 2 of change I5538230b42624629a6746ebff5e9e5dae6e93859 has been pushed to the review server.
It is available...
Mr. Hudson
12:24 Feature #6607 (Closed): Enable security for REST services
Okay, I close this for now – once we start working on REST again, we'll naturally stumble over a topic like this. Robert Lemke
12:22 Bug #25694 (Closed): Multiple annotations with the same name are not supported by the reflection service
Can't reproduce. Robert Lemke
12:21 Task #26129 (Closed): Establish simple conventions for qualified and unqualified class names
Robert Lemke
12:20 Revision 095a742b: [TASK] Clarify persistence behavior for inheritance in aggregate roots
This adds a number of functional tests to make sure the repository
behaves as expected. For Person and User, the latt...
Karsten Dambekalns
12:20 Revision c2cf3aa0: [TASK] Clean up class schema building code
Extract some code into methods to make coming changed
easier.
Also add another test to the unit test for ClassSchema...
Karsten Dambekalns
12:20 Revision 23961c89: [!!!][BUGFIX] Make sure only complete hierarchies are aggregate root
Reported as "Aggregate root detection for Person vs AbstractParty is
broken" the issue at hand was that one could not...
Karsten Dambekalns
12:18 Bug #27232: Create unit test for "Original Request must only be set if there is a validation error"
Will you manage to write this test for 1.0? Robert Lemke
12:08 Feature #27116 (Closed): Routing: Declared variables only available in POST but not in GET regexpr signature
Fernando Arconada wrote:
> May be the problem could be fixed with #27117 at this moment not i'm not sure
I gues...
Bastian Waidelich
10:33 Bug #30467 (Under Review): Doctrine fails to initialize AOP and DI in some cases
Patch set 1 of change I83ba6484e9daecf5344242815ec52ad1770907f9 has been pushed to the review server.
It is available...
Mr. Hudson
10:23 Bug #30467 (Resolved): Doctrine fails to initialize AOP and DI in some cases
When a Doctrine lazy loading proxy for an object is created for some specific purpose (e.g. when initializing session... Andreas Förthner
10:22 Task #27627 (Accepted): Overhaul annotation support/syntax
Karsten Dambekalns

2011-09-29

23:21 Bug #29416 (Under Review): Aggregate root detection for Person vs AbstractParty is broken
Patch set 1 of change I5538230b42624629a6746ebff5e9e5dae6e93859 has been pushed to the review server.
It is available...
Mr. Hudson
18:02 Bug #30436: Access denied exception after session timeout with CSRF
Patch set 2 of change If2c9c6386a2ee26195073a359dcf87db515d1dc0 has been pushed to the review server.
It is available...
Mr. Hudson
17:46 Bug #30436 (Under Review): Access denied exception after session timeout with CSRF
Patch set 1 of change If2c9c6386a2ee26195073a359dcf87db515d1dc0 has been pushed to the review server.
It is available...
Mr. Hudson
17:37 Bug #30436 (Resolved): Access denied exception after session timeout with CSRF
An access of a CSRF protected action with an invalidated session throws an Exception (e.g. @\TYPO3\FLOW3\Security\Exc... Christopher Hlubek
14:32 Revision 57045778: [TASK] Some tiny spelling fixes
Change-Id: I51e289b083e771d633444ca94250750ec572e2a2 Karsten Dambekalns
13:36 Feature #3580: Create an administration panel for the FLOW3 Development context
We should also add security debugging information, since this is all very hidden right now.
The question is, if we...
Christopher Hlubek
13:26 Feature #30428 (New): Cloning of request arguments
It should be possible to have two instances of the same entity in a controller action by specifying a "@clone" annota... Christopher Hlubek
13:06 Bug #30425 (New): New methods are not updated in Policies during Development
Adding a new method (e.g. inside a Controller) that is guarded by a Policy (such that a PolicyEnforcementAspect is ap... Christopher Hlubek
13:03 Bug #30424 (New): Forward object arguments with changes
Updated or cloned objects cannot be used as an argument in @forward@ right now, because they are always converted to ... Christopher Hlubek
12:59 Feature #30423 (New): Rendering template of other action without forward
Rendering a template of another action without doing a forward is currently too complicated. It should be possible by... Christopher Hlubek
12:38 Task #29543 (Accepted): Clarifiy persistence behavior for inheritance in entities / aggregate roots
Karsten Dambekalns
12:36 Bug #28638: Signals can't be defined in abstract classes
The regression has been fixed with Icf6bdf3f789162afbca61d7cf915dbb7ecd583d5 (https://review.typo3.org/#change,5409) Karsten Dambekalns
12:35 Bug #28638 (Resolved): Signals can't be defined in abstract classes
Karsten Dambekalns
12:31 Bug #30223 (Resolved): Column names for association properties are generated wrong
Karsten Dambekalns
12:14 Bug #30223: Column names for association properties are generated wrong
Patch set 3 of change Ia32cfcc6cd49385a61845243e67cb0ddd62f5268 has been pushed to the review server.
It is available...
Mr. Hudson
12:15 Revision 0ef0e45d: [BUGFIX] Allow file exists check through ResourceStreamWrapper
For file exists checks, we need to make sure that the
ResourceStreamWrapper returns FALSE when checking the path for...
Karsten Dambekalns
12:14 Feature #30418: Package bootstrapping following dependencies
this is the code I use... Benjamin Heek
12:09 Feature #30418 (New): Package bootstrapping following dependencies
It would be nice if packages are bootstrapped in correct order, following the dependency constraints that are describ... Benjamin Heek
12:14 Revision 395997de: [!!!][BUGFIX] Fix column names for association properties
For associations without a join table the column names in the
model tables followed the target type, not the property...
Karsten Dambekalns
12:12 Revision 1a7fd598: [TASK] Simplify license header in PHP files
Change-Id: Ia0d929babe774b06547738451222e9f61b8b0c65
Resolves: #29415
Karsten Dambekalns
11:42 Revision 38317289: [TASK] Fix foreign key handling in migration
Migrating down would not work because FK constraints where not named.
Change-Id: I2c789467bdb90ee080b69a8e6eebe4c006...
Karsten Dambekalns
11:03 Feature #30300: Support mapping to subclass by argument
Patch set 3 of change I6d0a9d62789bd8557a848311e1f13f0c094dc51f has been pushed to the review server.
It is available...
Mr. Hudson
10:54 Revision eb569a6e: Merge "[TASK] Fix failing unit test after SecurityContext change"
Karsten Dambekalns

2011-09-28

19:05 Bug #30261 (Resolved): CLI Help throws exception if related comments are not available
Applied in changeset commit:75a8b899390e115cbf5028abcb485029547aeb7d. Bastian Waidelich
18:51 Revision 2c1a6599: Merge "[BUGFIX] CLI Help throws exception if related comments are not available"
Bastian Waidelich
15:36 Feature #30317 (Resolved): Support mapping from integer to string
Applied in changeset commit:892d67dcb85b93ba1f2a121672bf9243cceb26ec. Christopher Hlubek
15:35 Revision 35bda30a: [TASK] Fix failing unit test after SecurityContext change
Fix a failing unit test after change 5358.
Change-Id: I2b72768d693cf184d6d0fc64fd33f88549bc5f26
Christopher Hlubek
15:31 Revision 864d0c81: Merge "[FEATURE] Support mapping of integer to string"
Christopher Hlubek
15:07 Bug #30351 (Resolved): Can't use AOP with Repository
Applied in changeset commit:3e36de833c1308ebf4aa3081f0d8e741e6085542. Robert Lemke
14:43 Bug #30351: Can't use AOP with Repository
Patch set 3 of change Icf6bdf3f789162afbca61d7cf915dbb7ecd583d5 has been pushed to the review server.
It is available...
Mr. Hudson
14:34 Bug #30351: Can't use AOP with Repository
Patch set 2 of change Icf6bdf3f789162afbca61d7cf915dbb7ecd583d5 has been pushed to the review server.
It is available...
Mr. Hudson
14:15 Bug #30351 (Under Review): Can't use AOP with Repository
Patch set 1 of change Icf6bdf3f789162afbca61d7cf915dbb7ecd583d5 has been pushed to the review server.
It is available...
Mr. Hudson
14:13 Bug #30351 (Accepted): Can't use AOP with Repository
Robert Lemke
14:47 Revision f493d5fe: Merge "[BUGFIX] AOP proxies are no longer broken if __call() exists"
Robert Lemke
14:43 Revision 3e36de83: [BUGFIX] AOP proxies are no longer broken if __call() exists
If a class contains a magic __call() method, AOP proxy classes are
broken due to a is_callable() use – method_exists(...
Robert Lemke
14:38 Revision 561bd6d6: Merge "[TASK] Guard the account for NULL when getting a party"
Christopher Hlubek
14:36 Bug #30260 (Resolved): CLI CommandManager throws exception for ambiguous commands
Applied in changeset commit:5e5daa1b69c58ba531b270ed685e9528ba01a413. Bastian Waidelich
14:36 Bug #30379 (Resolved): Object persistence has side effects in functional tests
Applied in changeset commit:10af83a3299ea8b0719bc470f28d5d1c8ca481e8. Robert Lemke
11:27 Bug #30379 (Under Review): Object persistence has side effects in functional tests
Patch set 1 of change I484c358f467cf3a13601486f31a92d1c15c403e1 has been pushed to the review server.
It is available...
Mr. Hudson
11:25 Bug #30379 (Resolved): Object persistence has side effects in functional tests
Unpersisted objects which have been added, but not persisted (no Entity Manager flush() called) will still be present... Robert Lemke
14:36 Bug #30380 (Resolved): Optimistic Locking / @version annotation is not functional
Applied in changeset commit:9c8570559b39140255d8aa0b59e8926b2f9c73a0. Robert Lemke
11:30 Bug #30380 (Under Review): Optimistic Locking / @version annotation is not functional
Patch set 1 of change Ia67ce34be122651c4ad741a44c53f7278ca31317 has been pushed to the review server.
It is available...
Mr. Hudson
11:28 Bug #30380 (Resolved): Optimistic Locking / @version annotation is not functional
FLOW3 seems to ignore the @version annotation which is needed for Doctrine's Optimistic Locking feature. Robert Lemke
14:28 Revision 063c0a57: Merge "[BUGFIX] No persistence side effects anymore in functional tests"
Karsten Dambekalns
14:17 Revision 516123c1: Merge "[BUGFIX] CLI CommandManager throws exception for ambiguous commands"
Karsten Dambekalns
13:56 Bug #30223: Column names for association properties are generated wrong
Patch set 2 of change Ia32cfcc6cd49385a61845243e67cb0ddd62f5268 has been pushed to the review server.
It is available...
Mr. Hudson
11:30 Revision 9c857055: [BUGFIX] @version annotations are not ignored anymore
For optimization reasons FLOW3's Reflection Service ignored @version
annotations. Due to this, Doctrine's Optimistic ...
Robert Lemke
11:27 Revision 10af83a3: [BUGFIX] No persistence side effects anymore in functional tests
Doctrine's Unit of Work still contained objects from previous tests.
In order to prevent side effects, the Entity Man...
Robert Lemke
11:13 Feature #30378 (Closed): Cookie authentication
It would be nice having a proof cookie authentication possibility on board. I did a bit of research and found the fol... Adrian Föder

2011-09-27

14:32 Bug #30351 (Resolved): Can't use AOP with Repository
If you write an aspect of a Repository and this Repository is injected via DI in your controller then FLOW3 fires an ... Fernando Arconada
11:18 Feature #30317 (Under Review): Support mapping from integer to string
Patch set 1 of change I662695b9621ead6fb936b3717e91a38979db9ca4 has been pushed to the review server.
It is available...
Mr. Hudson
11:16 Feature #30317 (Resolved): Support mapping from integer to string
The StringConverter should be extended to support mapping from integer to string. Christopher Hlubek
11:18 Revision 892d67dc: [FEATURE] Support mapping of integer to string
Just a small additional source type in the StringConverter.
Change-Id: I662695b9621ead6fb936b3717e91a38979db9ca4
Res...
Christopher Hlubek
09:54 Bug #30312 (Resolved): Entity class name is not properly detected in Repository::__construct()
If a package key contains the string "Repository", model class names are not correctly resolved in the Repository con... Bastian Waidelich

2011-09-26

19:11 Revision 2ae3f0ce: [TASK] Guard the account for NULL when getting a party
This could happen, if the account in the persistence was deleted during
a session.
Change-Id: I50627f00ba237a92b35da...
Christopher Hlubek
18:07 Feature #30300 (Under Review): Support mapping to subclass by argument
Patch set 2 of change I6d0a9d62789bd8557a848311e1f13f0c094dc51f has been pushed to the review server.
It is available...
Mr. Hudson
17:09 Feature #30300 (Resolved): Support mapping to subclass by argument
When type hierarchies are used for modeling, it's necessary to map to a special subclass when creating new entities. ... Christopher Hlubek
09:35 Bug #30261: CLI Help throws exception if related comments are not available
Patch set 2 of change I961cdeaf2a0928017bdfaec16bfcb014ee428076 has been pushed to the review server.
It is available...
Mr. Hudson
09:33 Bug #30261 (Under Review): CLI Help throws exception if related comments are not available
Patch set 1 of change I961cdeaf2a0928017bdfaec16bfcb014ee428076 has been pushed to the review server.
It is available...
Mr. Hudson
09:34 Revision 75a8b899: [BUGFIX] CLI Help throws exception if related comments are not available
The flow3:help:help command parses @see annotations of the
commands and retrieves the method description of related
c...
Bastian Waidelich
09:29 Bug #30260 (Under Review): CLI CommandManager throws exception for ambiguous commands
Patch set 1 of change I54dc784782eadd25f32fcd2e87a1011873070d35 has been pushed to the review server.
It is available...
Mr. Hudson
09:29 Revision 5e5daa1b: [BUGFIX] CLI CommandManager throws exception for ambiguous commands
This change ensures that the CommandManager returns the complete
CommandIdentifier for commands with the same control...
Bastian Waidelich

2011-09-25

12:36 Bug #30262 (Resolved): ObjectConverter expects to be configured as ArrayToObjectConverter
Applied in changeset commit:a9d8cc9e25281b876204e333c99d833993120046. Karsten Dambekalns
11:24 Bug #30234: Compiled proxies override parent instance
Closed as duplicate of itself ;). Really? Johannes K
10:51 Bug #29978 (Under Review): Wrong default value 'Text' for $dataType in TYPO3\FLOW3\MVC\Controller\Arguments::addNewArgument()
Patch set 2 of change I82f77161e4b7ec277599feb8e07834ed9d39692a has been pushed to the review server.
It is available...
Mr. Hudson

2011-09-24

20:35 Bug #30255 (Resolved): ObjectConverter needs to deal with constructor injection properties
Applied in changeset commit:d366973e7ac31b49939d6a17ff642193620800dd. Sebastian Kurfuerst
19:37 Bug #30255: ObjectConverter needs to deal with constructor injection properties
Patch set 2 of change Ic667b86c9231a11ae167f4d2836ebc1c9a12a9a2 has been pushed to the review server.
It is available...
Mr. Hudson
01:48 Bug #30255 (Under Review): ObjectConverter needs to deal with constructor injection properties
Patch set 1 of change Ic667b86c9231a11ae167f4d2836ebc1c9a12a9a2 has been pushed to the review server.
It is available...
Mr. Hudson
01:43 Bug #30255 (Resolved): ObjectConverter needs to deal with constructor injection properties
When a normal object is converted, the generic ObjectConverter is called (not the PersistentObjectConverter).
When...
Sebastian Kurfuerst
19:37 Bug #30262 (Under Review): ObjectConverter expects to be configured as ArrayToObjectConverter
Patch set 1 of change I55f8b51e70d6af1164b291856047aaa1707d642c has been pushed to the review server.
It is available...
Mr. Hudson
19:32 Bug #30262 (Resolved): ObjectConverter expects to be configured as ArrayToObjectConverter
When checking for property mapping configuration the ObjectConverter asks for the "ArrayToObjectConverter" configurat... Karsten Dambekalns
19:36 Revision 87863f3d: [TASK] Clean up PersistentObjectConverter unit test
Change-Id: I4746e33a23e2be019bab3f1c38e758bbf9cd50b0 Karsten Dambekalns
19:36 Revision a9d8cc9e: [BUGFIX] Read ObjectConverter configuration correctly
When checking for property mapping configuration the ObjectConverter
asks for the "ArrayToObjectConverter" configurat...
Karsten Dambekalns
19:36 Revision d366973e: [BUGFIX] Allow ObjectConverter to use constructor parameters
We need this for image upload in Phoenix.
Change-Id: Ic667b86c9231a11ae167f4d2836ebc1c9a12a9a2
Resolves: #30255
Sebastian Kurfuerst
19:24 Bug #30261 (Resolved): CLI Help throws exception if related comments are not available
The @flow3:help:help@ command parses "see" annotations of the commands and retrieves their method description.
This ...
Bastian Waidelich
19:21 Bug #30260 (Resolved): CLI CommandManager throws exception for ambiguous commands
@CommandIdentifier::getShortestIdentifierForCommand()@ currently fails to return the complete CommandIdentifier when ... Bastian Waidelich
19:07 Feature #30256: Package help in CLI
Nice idea, I would even go one further and allow to specify the controller too (e.g. "typo.flow:package" or just "pac... Bastian Waidelich
14:17 Feature #30256 (Resolved): Package help in CLI
Would be nice to get help for one specific package fx. './flow3 help kickstarter' would display only the kickstart pa... Christian Jul Jensen
18:34 Feature #30258: Support optional package dependencies
Nice idea, but I'd prefer if those dependencies would be stored in the Package.xml -as discussed before- (for perform... Bastian Waidelich
17:41 Feature #30258 (New): Support optional package dependencies
FLOW3 should support optional package dependencies to enable the usage of classes inside a package that belong to a s... Christopher Hlubek
18:31 Revision a29a7f77: Merge "[BUGFIX] Do not override parent instance in compiled proxies"
Sebastian Kurfuerst
18:17 Bug #27810 (Closed): ObjectManager returns Subclass sometimes
Closed as duplicate of #30234. Karsten Dambekalns
18:17 Bug #30234 (Closed): Compiled proxies override parent instance
Closed as duplicate of #30234. Karsten Dambekalns
18:05 Bug #30254 (Resolved): The ResourceStreamWrapper should also return the resource path for non-existing persistent resources
Applied in changeset commit:c0319226fb990162c30d216e51ffcf349af20ca4. Sebastian Kurfuerst
17:58 Bug #30254: The ResourceStreamWrapper should also return the resource path for non-existing persistent resources
Patch set 2 of change I6b98a9da29ee155bed80177fff3a17a8b35a8be9 has been pushed to the review server.
It is available...
Mr. Hudson
01:38 Bug #30254 (Under Review): The ResourceStreamWrapper should also return the resource path for non-existing persistent resources
Patch set 1 of change I6b98a9da29ee155bed80177fff3a17a8b35a8be9 has been pushed to the review server.
It is available...
Mr. Hudson
01:36 Bug #30254 (Accepted): The ResourceStreamWrapper should also return the resource path for non-existing persistent resources
Sebastian Kurfuerst
01:36 Bug #30254 (Resolved): The ResourceStreamWrapper should also return the resource path for non-existing persistent resources
For file upload, we need to make sure that the ResourceStreamWrapper also returns the path for a non-existing persist... Sebastian Kurfuerst
17:58 Revision c0319226: [BUGFIX] Allow file creation through ResourceStreamWrapper
For file creation, we need to make sure that the ResourceStreamWrapper
also returns the path for a non-existing persi...
Sebastian Kurfuerst
17:14 Bug #30223 (Under Review): Column names for association properties are generated wrong
Patch set 1 of change Ia32cfcc6cd49385a61845243e67cb0ddd62f5268 has been pushed to the review server.
It is available...
Mr. Hudson

2011-09-23

21:47 Bug #30223: Column names for association properties are generated wrong
The issue is fixed, the fix will be pushed for review as soon as I have the needed migrations ready. Karsten Dambekalns
10:01 Bug #30223 (Resolved): Column names for association properties are generated wrong
As discovered by Bastian, column names for associations are created in model tables not with the property name but th... Karsten Dambekalns
17:16 Bug #30234: Compiled proxies override parent instance
Looks like http://forge.typo3.org/issues/27810 is a duplicate of this bug Johannes K
11:36 Bug #30234 (Under Review): Compiled proxies override parent instance
Patch set 1 of change I00f25162b18f0b3a5e32a6241b6ef2ab6d066415 has been pushed to the review server.
It is available...
Mr. Hudson
11:27 Bug #30234 (Closed): Compiled proxies override parent instance
A subclass of a singleton does override the parent instance in the object manager inside the constructor. See the fun... Christopher Hlubek
11:36 Revision 0275a5ff: [BUGFIX] Do not override parent instance in compiled proxies
Change-Id: I00f25162b18f0b3a5e32a6241b6ef2ab6d066415
Resolves: #30234
Christopher Hlubek

2011-09-22

19:05 Task #29977 (Resolved): URIs should be lower case by default
Applied in changeset commit:755a73526244e29df6b1c106b6e16e9309508e8a. Bastian Waidelich
18:50 Revision c3314712: Merge "[TASK] Reanimate some ActionController unit tests"
Karsten Dambekalns
18:50 Revision 34583c62: Merge "[!!!][TASK] Create lower cased URIs by default"
Karsten Dambekalns
11:02 Bug #30192 (Closed): TYPO3\FLOW3\MVC\Exception\InfiniteLoopException thrown in file TYPO3_FLOW3_MVC_Dispatcher_Original.php
Exception occures when trying to update a blog post (TYPO3.Blog) with invalid data (spaces in link title).
Co...
Fabian Erni

2011-09-21

16:09 Revision 31338bf7: Merge "[BUGFIX] Don't remove referenced entities"
Christopher Hlubek
15:52 Task #29977: URIs should be lower case by default
Patch set 2 of change I572b51af2992e2599b37db3d0e5b31cbb395ece1 has been pushed to the review server.
It is available...
Mr. Hudson
12:03 Task #29977 (Under Review): URIs should be lower case by default
Patch set 1 of change I572b51af2992e2599b37db3d0e5b31cbb395ece1 has been pushed to the review server.
It is available...
Mr. Hudson
15:51 Revision 755a7352: [!!!][TASK] Create lower cased URIs by default
The routing framework is capable of creating case sensitive
URIs so it is possible to resolve different actions depen...
Bastian Waidelich
15:36 Revision 690550e1: Merge "[BUGFIX] Fix recursion error in \TYPO3\FLOW3\var_dump()"
Karsten Dambekalns
15:36 Bug #29761 (Resolved): @ignorevalidation annotation expects parameter name without $ (dollar sign)
Applied in changeset commit:87418d9b0b8c9454993da1e4b6711c8e363f5469. Karsten Dambekalns
15:32 Revision c0d60e79: Merge "[BUGFIX] Fix case of sub package key arguments in Router::getControllerObjectName()"
Sebastian Kurfuerst
15:30 Revision a72146e0: Merge "[BUGFIX] Fix check against @ignorevalidation annotations"
Sebastian Kurfuerst
12:14 Revision 01ffa9ce: [BUGFIX] Fix recursion error in \TYPO3\FLOW3\var_dump()
A var_dump of for example the PersistenceManager results in a memory
error. This happens because the dumped object is...
Rens Admiraal
11:30 Revision b301de55: [TASK] Fix unit test side effects
The CacheFactoryTest created directories in the distribution
root when run from there. Now it used a mocked filesyste...
Karsten Dambekalns

2011-09-20

20:05 Revision d8cab871: Merge "[!!!][FEATURE] Improve default routing for entities"
Karsten Dambekalns
20:03 Feature #8736 (Resolved): Implement generic Identity RoutePartHandler
Karsten Dambekalns
19:12 Feature #8736: Implement generic Identity RoutePartHandler
Patch set 4 of change I8fb5d4f4be3649e2f6307f83af2f3bbaa2191b5b has been pushed to the review server.
It is available...
Mr. Hudson
15:23 Feature #8736: Implement generic Identity RoutePartHandler
Patch set 3 of change I8fb5d4f4be3649e2f6307f83af2f3bbaa2191b5b has been pushed to the review server.
It is available...
Mr. Hudson
13:10 Feature #8736: Implement generic Identity RoutePartHandler
Patch set 2 of change I8fb5d4f4be3649e2f6307f83af2f3bbaa2191b5b has been pushed to the review server.
It is available...
Mr. Hudson
19:12 Revision 38232efb: [FEATURE] Add generic Identity RoutePartHandler
This implements improved routing for persisted objects.
When an object type is specified in the routing configuratio...
Bastian Waidelich
18:42 Revision 2c949e36: [BUGFIX] Don't remove referenced entities
This change adds a check to the removal of dereferenced
entities in the AbstractBackend. If the entity was visited
du...
Christopher Hlubek
17:49 Revision 0863e524: [!!!][FEATURE] Improve default routing for entities
This improves the default dynamic route part handler so that it
can resolve objects that are known to the persistence...
Bastian Waidelich
14:01 Feature #29972: Configurable Redirects
*Additional idea:*
ObjectPathMappings can be marked *obsolet* (triggered when an affected object is changed for inst...
Bastian Waidelich
12:05 Revision cc2caa52: [TASK] Reanimate some ActionController unit tests
Change-Id: I0d4c24015d7de04fdee87d8237dc8b29a136f3b0 Karsten Dambekalns
11:54 Bug #28638 (Needs Feedback): Signals can't be defined in abstract classes
Christopher Hlubek
11:54 Bug #28638: Signals can't be defined in abstract classes
I have some kind of a regression with this after further testing (didn't notice this at first):
If a class uses a ...
Christopher Hlubek
10:36 Bug #28638 (Resolved): Signals can't be defined in abstract classes
Applied in changeset commit:43f08cbd553613dea9c927c297ab677440806f04. Bastian Waidelich
11:28 Bug #29761: @ignorevalidation annotation expects parameter name without $ (dollar sign)
Patch set 2 of change I001bbb639e03fb7db6aaf88eca558155f1b879f6 has been pushed to the review server.
It is available...
Mr. Hudson
11:27 Revision 87418d9b: [BUGFIX] Fix check against @ignorevalidation annotations
The check for argument names against @ignorevalidation annotations
was done with the raw argument name, but the annot...
Karsten Dambekalns
11:05 Bug #29908 (Resolved): @HasLifecycleCallbacks and Doctrine2-Events like @PrePersist don't work.
Applied in changeset commit:31a934570e6fc2cff811a8ec35bfd423c14d50da. Karsten Dambekalns
11:01 Revision e37e8d36: Merge "[BUGFIX] Lifecycle annotations were not detected"
Karsten Dambekalns
11:01 Revision 9eb3ce31: Merge "[BUGFIX] (Resource): Resource manager can also handle files without extension"
Karsten Dambekalns
10:21 Revision b3887ec9: Merge "[BUGFIX] Proxy code of advised abstract classes don't produce errors"
Christopher Hlubek

2011-09-19

22:33 Feature #8736: Implement generic Identity RoutePartHandler
FYI: The current implementation supports following syntax:... Bastian Waidelich
22:27 Feature #8736 (Under Review): Implement generic Identity RoutePartHandler
Patch set 1 of change I8fb5d4f4be3649e2f6307f83af2f3bbaa2191b5b has been pushed to the review server.
It is available...
Mr. Hudson
22:06 Revision 72269db1: [BUGFIX] Fix case of sub package key arguments in Router::getControllerObjectName()
This just changes the method argument name to be in sync with the annotation
Change-Id: Idd0837b3e132167782ebf8cd86a...
Bastian Waidelich
19:10 Revision 13fd2dd6: Merge "[FEATURE] Provide signal for after objects have been persisted"
Karsten Dambekalns
17:32 Revision b28cd358: [FEATURE] Provide signal for after objects have been persisted
This provides two signals – one for the generic and one for the
Doctrine persistence manager - which is emitted right...
Robert Lemke
17:05 Bug #28638: Signals can't be defined in abstract classes
Patch set 2 of change I6480321c117dc0eb264fda45a952d27505156f82 has been pushed to the review server.
It is available...
Mr. Hudson
17:05 Revision 43f08cbd: [BUGFIX] Proxy code of advised abstract classes don't produce errors
The AOP ProxyClassBuilder produced invalid code when signals were
defined in an abstract class. This was due to inval...
Bastian Waidelich
16:35 Bug #30040 (Resolved): Missing quotes in system() command in initializeForRuntime()
As a hardcore Windows user I again experienced a problem regarding the quotes for a system() command, in my case reso... Adrian Föder
15:53 Bug #29908 (Under Review): @HasLifecycleCallbacks and Doctrine2-Events like @PrePersist don't work.
Patch set 1 of change I6f2920069ae8c0470cc4626e0d7e9ff4ae33761a has been pushed to the review server.
It is available...
Mr. Hudson
15:53 Revision 31a93457: [BUGFIX] Lifecycle annotations were not detected
The detection of Doctrine lifecycle event annotations was broken
since the last Doctrine update (because of the chan...
Karsten Dambekalns
15:33 Revision c6546f42: [BUGFIX] (Resource): Resource manager can also handle files without extension
Furthermore, we use move_uploaded_file instead of rename to move the target
file to the final destination, as this al...
Sebastian Kurfuerst
13:12 Revision 1c27b883: [TASK] Use correct respone mock in FunctionalTestCase
The sendWebRequest() method used mocked ResponseInterface, but lacks
the setStatus() method present in the Web\Respon...
Karsten Dambekalns
13:07 Bug #30017 (Resolved): Functional tests see data from previous tests
Applied in changeset commit:eca27e400e89769d6a7a77379e1692c0d8d0ec8d. Robert Lemke
11:50 Bug #30017 (Under Review): Functional tests see data from previous tests
Patch set 1 of change Ibd15fe01d9dea9d0be986e4ab3bd78998d26aa2e has been pushed to the review server.
It is available...
Mr. Hudson
11:49 Bug #30017 (Resolved): Functional tests see data from previous tests
Data stored by functional tests are only flushed after a whole test case ran through, not after each individual test.... Robert Lemke
13:07 Feature #30018 (Resolved): For functional tests: provide function for forgetting instances
Applied in changeset commit:d22fa5ee33802ccafc7b64ce278e40a2286d55bb. Robert Lemke
11:56 Feature #30018 (Under Review): For functional tests: provide function for forgetting instances
Patch set 1 of change I789d346d280e93e765340ab9c9bb71ddc328f24e has been pushed to the review server.
It is available...
Mr. Hudson
11:53 Feature #30018 (Resolved): For functional tests: provide function for forgetting instances
In some situations during functional testing, it is necessary to drop a registered singleton instance before / after ... Robert Lemke
13:05 Feature #29572: The resource manager should be able to create a resource directly from binary content
Alternatively, you could also use http://review.typo3.org/5055 and use php://memory -- seems more clean to me :-)
...
Sebastian Kurfuerst
13:01 Bug #29508 (Closed): multipart/form-data cannot be saved!
Bastian Waidelich
12:15 Bug #29508: multipart/form-data cannot be saved!
Thx for the Link to the Conference package. Uploading works now.
The problem were the wrong annotations in the model...
Andreas Keßler
12:56 Revision e80716a8: Merge "[FEATURE] Support dropping instances in the Object Manager"
Karsten Dambekalns
11:56 Revision d22fa5ee: [FEATURE] Support dropping instances in the Object Manager
This adds a non-API function to the Object Manager which allows for
unregistering instances of arbitrary objects. The...
Robert Lemke
11:49 Revision eca27e40: [BUGFIX] Less persistence side effects in functional tests
Previously, the persistence manager was only teared down after a whole
test case ran through. This change makes sure ...
Robert Lemke
 

Also available in: Atom