Activity

From 2012-02-13 to 2012-03-13

2012-03-13

22:01 Bug #34811 (Under Review): Ghost command "getflow3" introduced with recent change
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9629
Gerrit Code Review
21:57 Bug #34811 (Resolved): Ghost command "getflow3" introduced with recent change
The fix for the "./flow3" invocation hint on Windows introduced a "ghost command" because methods in command controll... Karsten Dambekalns
22:01 Revision d8ee4702: [BUGFIX] Removes "ghost command" getflow3
The fix for #33048 in Ia8561a7878b7dd9ba8a6f3bb926c9da10b46bd0c caused a
ghost command to appear in all command contr...
Karsten Dambekalns
21:43 Bug #33621 (Needs Feedback): Filebackend reports error when trying to rename file due to concurrent proccesses
Karsten Dambekalns
18:20 Bug #25961 (Under Review): HTML should be escaped in the pre output of DebugExceptionHandler
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9624
Gerrit Code Review
18:17 Revision fa8fd72a: [BUGFIX] HTML should be escaped in Debug Exception
HTML in the code that is output as part of the stack trace is
escaped now.
Change-Id: I0b2a1bcf5ee72a3212dec8b6541f5...
Christian Müller
16:43 Feature #34185 (Under Review): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9622
Gerrit Code Review
16:39 Feature #34185 (Accepted): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Karsten Dambekalns
13:13 Bug #3977 (Rejected): TextValidator is insecure
The test improvements are in review now, I will close this, we could decide to deprecate the TextValidator at some po... Christian Müller
12:03 Bug #34134 (Needs Feedback): PropertyMapper throws unnecessary exception
Hi,
could you please try https://review.typo3.org/#/c/9606/ with your environment? I am not sure if that works ou...
Christian Müller
10:55 Feature #34783 (Closed): Provide utility method to get unproxied class name
In some cases, @get_class($object)@ returns the Doctrine proxy class; and not the actual, intended class name.
In ...
Adrian Föder
02:38 Bug #33417 (Resolved): kickstart:package does not update .Shortcuts
Applied in changeset commit:fec2ff945c3b1a73e0811637fe4bb2ecbce8e6df. Christian Müller
02:38 Bug #33789 (Resolved): PersistentObjectConverter may break with < PHP 5.3.4
Applied in changeset commit:a29012b669e90a7e39a4727514538ace5a77eb80. Karsten Dambekalns
02:38 Bug #33048 (Resolved): flow3.bat gives wrong feedback
Applied in changeset commit:7e567e8d38e5a24f052a7da4fa7ae0fd657540e3. Karsten Dambekalns
02:38 Bug #34608 (Resolved): ResourceStreamWrapper::seek gives exactly the wrong bool value
Applied in changeset commit:461bb056be2d6855aa3def46b4dcbe18fca28cd7. Ferdinand Kuhl
02:38 Bug #34620 (Resolved): Wrong return value for getAccessDecisionVoters()
Applied in changeset commit:7e055f0b2c7e2d0f92992afd0c97007b50ef4aac. Bernhard Fischer

2012-03-12

19:02 Feature #27118 (Rejected): Routing: json format should use MIME application/json by default
This has been removed. The JsonView in the FLOW3 package sets the header correctly, you should do the same if you dec... Christian Müller
18:55 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 20 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
09:14 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 19 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
09:13 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 18 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
18:55 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
18:41 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9589
Gerrit Code Review
18:41 Revision 7e055f0b: [BUGFIX] typo in return statement for getAccessDecisionVoters()
Fix return value to array.
Fix type hinting for var $securityContext and $authenticationManager
Change-Id: I05223d15...
Bernhard Fischer
18:41 Revision e796d217: Merge "[BUGFIX] typo in return statement for getAccessDecisionVoters()"
Karsten Dambekalns
18:37 Bug #34608: ResourceStreamWrapper::seek gives exactly the wrong bool value
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9587
Gerrit Code Review
18:37 Revision 461bb056: [BUGFIX] ResourceStreamWrapper returns wrong value for fseek
Calling fseek will always return the wrong value, as fseek
return 0 on success otherwise -1.
The stream_wrapper expec...
Ferdinand Kuhl
18:37 Revision cb6469f8: Merge "[BUGFIX] ResourceStreamWrapper returns wrong value for fseek"
Karsten Dambekalns
18:35 Feature #10524 (Needs Feedback): Support multiple package directories
What speaks against symlinking the Framework directory to your projects? Christian Müller
18:34 Feature #10427 (Resolved): Support inter-type properties for entites
Take a look at Packages/Framework/TYPO3.FLOW3/Classes/Persistence/Aspect/PersistenceMagicAspect.php there we introduc... Christian Müller
18:33 Bug #33932: AOP Proxy Compiler does not handle numeric annotation parameters
Patch set 2 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9584
Gerrit Code Review
18:20 Bug #33932: AOP Proxy Compiler does not handle numeric annotation parameters
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9584
Gerrit Code Review
18:31 Revision 1fb98a95: [BUGFIX] Fixes handling of numeric annotation parameters
Annotations like @FooBar(amount=2) lost their parameter value
in renderAnnotation(). This change fixes that.
Change-...
Karsten Dambekalns
18:28 Feature #10312 (Rejected): Autogenerate setters and getters
Yep, just use your IDE to generate the getters and setters, then you benefit from code completion. If you don't like... Christian Müller
18:14 Revision da1b295e: Merge "[BUGFIX] Fixes handling of numeric annotation parameters"
Karsten Dambekalns
17:57 Bug #33048: flow3.bat gives wrong feedback
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9582
Gerrit Code Review
16:33 Bug #33048: flow3.bat gives wrong feedback
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
15:49 Bug #33048: flow3.bat gives wrong feedback
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
17:56 Revision b33afd7b: [BUGFIX] Make flow3.bat output usage texts matching Windows
When using flow3.bat on Windows the usage information would tell the
user to call "./flow3", which doesn't fit the Wi...
Karsten Dambekalns
17:52 Revision 86efcd57: Merge "[BUGFIX] Make flow3.bat output usage texts matching Windows"
Karsten Dambekalns
17:48 Feature #6609 (Closed): Implement joins for queries
With Doctrine we have JOINS, so this is closed. Christian Müller
17:47 Feature #6456 (Closed): Customization/localization of validator errors
Christian Müller
17:35 Revision b49a75eb: Merge "[BUGFIX] PackageManager should update .Shortcuts when needed"
Karsten Dambekalns
17:27 Revision d1516ea2: Merge "[TASK] Add utility function to retrieve class names for objects"
Christian Müller
16:33 Revision 7e567e8d: [BUGFIX] Make flow3.bat output usage texts matching Windows
When using flow3.bat on Windows the usage information would tell the
user to call "./flow3", which doesn't fit the Wi...
Karsten Dambekalns
15:26 Bug #33789: PersistentObjectConverter may break with < PHP 5.3.4
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/5992
Gerrit Code Review
15:19 Revision a29012b6: [TASK] Remove deprecated methods and unused code
Things which have been deprecated prior to the 1.0.0 release are
removed with this change:
* Cache\AbstractFrontend-...
Karsten Dambekalns
13:51 Feature #6121 (Rejected): Add validator and filter for HTML
Christian Müller
13:51 Feature #6121 (Closed): Add validator and filter for HTML
As Bastian said should be checked on output. Christian Müller
13:29 Task #34749: Provide some examples how to nest inline VH's
Adrian Föder wrote:
> I'll take care, fine?
More than fine ;)
Bastian Waidelich
12:27 Task #34749: Provide some examples how to nest inline VH's
that's fine, thanks Bastian; I think the examples from the FAQ could almost be transferred 1:1.
I'll take care, fine?
Adrian Föder
12:07 Task #34749: Provide some examples how to nest inline VH's
Adrian Föder wrote:
> It would be useful to have some more examples how to nest different variables,
> array and Vie...
Bastian Waidelich
11:39 Task #34749 (Resolved): Provide some examples how to nest inline VH's
It would be useful to have some more examples how to nest different variables, array and ViewHelpers; for example, ho... Adrian Föder

2012-03-10

11:32 Bug #33297 (Closed): flow3 package:list throws an error
That matches my expectations to a large degree - sounded like something not really related to our code.
Have fun w...
Karsten Dambekalns
10:18 Bug #33297: flow3 package:list throws an error
Well, i updated apache2, PHP and FLOW3 Versions last weeks and now the error doesnt occur anymore :/
I will try to...
Christopher Seidel

2012-03-09

23:54 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:54 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:34 Bug #33968 (Under Review): Missing privileges to create symlinks in Windows cause exception
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:34 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 17 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
22:28 Bug #33417: kickstart:package does not update .Shortcuts
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
16:08 Bug #33417: kickstart:package does not update .Shortcuts
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
16:01 Bug #33417 (Under Review): kickstart:package does not update .Shortcuts
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
22:28 Revision fec2ff94: [BUGFIX] PackageManager should update .Shortcuts when needed
The PackageManager needs to update the shortcuts when saving
package states. Besides that the PackageManager should i...
Christian Müller
18:57 Bug #33297: flow3 package:list throws an error
Could you tell us the used PHP version and the amount of files and directories in this folder? And additionally try a... Christian Müller
18:55 Bug #33297: flow3 package:list throws an error
Maybe a bug in a specific PHP version causing some overflow (Too many open files) when there is a file with #?
Kar...
Christian Müller
16:42 Bug #33158: Problems setting PHP binary path on Windows
thanks for noticing ;-) and fixed the example... :) Rens Admiraal
16:04 Bug #33158: Problems setting PHP binary path on Windows
Rens Admiraal wrote:
> Giovanni: are you sure you've no indent errors in your Settings.yaml? I've a 2008 IIS environ...
Adrian Föder
16:03 Bug #33158: Problems setting PHP binary path on Windows
just as a feedback; in my case also the even worse varation with spaces and backward slashes *works*:... Adrian Föder
15:48 Bug #33158: Problems setting PHP binary path on Windows
Giovanni: are you sure you've no indent errors in your Settings.yaml? I've a 2008 IIS environment using:... Rens Admiraal
16:02 Revision b6191e90: [BUGFIX] Package.php template should have correct use statements
The Package.php template will generate clean use statements with
same usage of backslashes.
Change-Id: I30e711549119...
Christian Müller
09:17 Feature #32106 (Accepted): Support for Object source in PropertyMapper
(I felt free to set to "Accepted" because I think there's enough agree for the need for it)
Sebastian, I read a bi...
Adrian Föder

2012-03-08

19:06 Bug #34675 (Rejected): NotFoundView is not used for missing actions
When an action is missing instead of an exception the NotFoundView should be used. Kira Backes
18:47 Feature #34674 (Accepted): NotFoundView is not injected in ActionController
Should be injected in the ActionController so a user can overwrite it and show its custom NotFoundView when an action... Kira Backes
16:48 Bug #34672 (Needs Feedback): Production context is not working
Makes sense - could the problem be distilled into a functional test? Karsten Dambekalns
15:48 Bug #34672 (Resolved): Production context is not working
When running an application (that uses Collections) in Production context the following exception is thrown:... Kira Backes
10:35 Bug #34466: Roles are not cleared after every test in functional tests
Yes, have the fix already here. Will be pushed together with some content security functional tests... Andreas Förthner

2012-03-07

23:23 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Sure, will have a look at it.
@Richard: could you be so kind to add a note with the exact windows version you use?
Rens Admiraal
23:20 Bug #33158: Problems setting PHP binary path on Windows
Sure, will have a look this week Rens Admiraal
18:41 Bug #33158 (Needs Feedback): Problems setting PHP binary path on Windows
Rens, could you check this? Karsten Dambekalns
22:08 Bug #33024 (Accepted): Exception when validating a float in a Model with the Number validator
Karsten Dambekalns
21:45 Task #29266 (Accepted): Transfer "Introduction" chapter to ReST
The old text can serve as a basis for the "Architectural Overview" section of part 3 of the guide. Karsten Dambekalns
21:39 Bug #33297 (Needs Feedback): flow3 package:list throws an error
I created a file named @#test.html@ in the public resources folder and called @package:list@ - worked fine. I suspect... Karsten Dambekalns
20:55 Bug #33297 (Accepted): flow3 package:list throws an error
Karsten Dambekalns
18:14 Bug #33297: flow3 package:list throws an error
Yes just like:
#test.html
or something similar
Christopher Seidel
17:42 Bug #33297 (Needs Feedback): flow3 package:list throws an error
Could you give me some more details to reproduce this? Like an offending filename? Thanks! Karsten Dambekalns
21:12 Bug #33048 (Under Review): flow3.bat gives wrong feedback
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
18:44 Bug #33139 (Accepted): Confusing error message if a CommandController is outside /Controller/ directory
Karsten Dambekalns
18:43 Bug #34545 (Accepted): Hint at wrong usage of @ORM\MappedSuperclass not displayed
Karsten Dambekalns
17:47 Bug #34466 (Accepted): Roles are not cleared after every test in functional tests
Andi, I set this to accepted - right? Karsten Dambekalns
17:46 Bug #34448 (Accepted): Integrity constraint violation on FLOW3 resource tables
Karsten Dambekalns
17:34 Feature #34648: Implement a way to authenticate with a file based encrypted key
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
17:27 Feature #34648 (Under Review): Implement a way to authenticate with a file based encrypted key
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
17:23 Feature #34648 (Resolved): Implement a way to authenticate with a file based encrypted key
For the setup wizard we need a file based encryped key provider. For this we need a password token which only has a p... Aske Ertmann
17:21 Bug #32574 (Accepted): FLOW3 enters fork bombs when using cgi-fcgi vs cli
Karsten Dambekalns
17:13 Bug #27232 (Needs Feedback): Create unit test for "Original Request must only be set if there is a validation error"
Robert, is this still a valid issue considering your MVC refactoring? Feel free to close, if not :) Karsten Dambekalns
17:10 Bug #32827 (Closed): TYPO3\FLOW3\Exception thrown in file Bootstrap.php
Considered as fixed. Karsten Dambekalns
17:08 Feature #34177: Make Resource use with file operations easier
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9145
Gerrit Code Review
17:08 Bug #29694 (Under Review): \TYPO3\FLOW3\Resource\Resource is missing the __toString Method
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9145
Gerrit Code Review
16:45 Bug #34050 (Accepted): DatetimeParser code documentation is wrong
Karsten Dambekalns
16:39 Bug #34527 (Accepted): Add method in repositories does also update
Right, Doctrine doesn't differentiate between add and update in it's API. So we'd need to do this "on our side". Karsten Dambekalns
16:36 Bug #33145 (Accepted): Annotation parser for interfaces gets confused
Karsten Dambekalns
16:35 Bug #27378 (Accepted): JsonView not testable view \F3\FLOW3\Tests\FunctionalTestCase->sendWebRequest
Assigning to Robert as the MVC refactoring should solve this "along the way". Karsten Dambekalns
16:33 Task #33268 (Resolved): Document new YAML behaviour for Upgrade to 1.1
Karsten Dambekalns
16:22 Feature #33937 (Accepted): Convenience method to resolve public "resource://" paths
Karsten Dambekalns
16:15 Feature #33937: Convenience method to resolve public "resource://" paths
Ok, here's the ViewHelper which needed this:... Bastian Waidelich
16:20 Task #33040 (Rejected): rename the default controller as DefaultController
This change would affect *all* users and require adjustment of *all* standard controllers. The advantage is unclear, ... Karsten Dambekalns
16:10 Feature #30256 (On Hold): Package help in CLI
Karsten Dambekalns
16:07 Feature #31788 (Rejected): [PERFORMANCE] cache implementation for AnnotationReader in Flow3AnnotationDriver
Recent improvements have shown the caching we have in place does the job. Karsten Dambekalns
16:06 Feature #33058 (Rejected): Choice for XML Configuration
Our approach to keeping things simple means: one configuration format is enough. Especially if not knowing YAML is th... Karsten Dambekalns
16:05 Feature #32607: Export localized strings for JS consumption
Maybe this could be achieved with a ViewHelper:... Bastian Waidelich
15:59 Feature #32607 (Needs Feedback): Export localized strings for JS consumption
It would be nice to have this in 1.1 - but I need input from the JS folks on this! Karsten Dambekalns
16:00 Task #32606 (Accepted): Provide conventions for ids in XLIFF files
Karsten Dambekalns
15:35 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 16 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
14:39 Bug #34407 (Resolved): NotFoundView should "throw" 404
Applied in changeset commit:ca5b3b9a535ff29a4e34c70bbeb68612d135b0f1. Adrian Föder
14:30 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
14:01 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
00:34 Bug #34620 (Under Review): Wrong return value for getAccessDecisionVoters()
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
00:19 Bug #34620 (Resolved): Wrong return value for getAccessDecisionVoters()
The return value of the function getAccessDecisionVoters() in the AccessDecisionVoterManager should return a array. I... Bernhard Fischer
14:30 Revision 94a07994: [BUGFIX] typo in return statement for getAccessDecisionVoters()
Fix return value to array.
Fix type hinting for var $securityContext and $authenticationManager
Change-Id: I75f82560...
Bernhard Fischer
13:16 Revision 93423ade: Merge "[BUGFIX] NotFoundView sets 404 status"
Karsten Dambekalns
11:33 Revision 62d0629d: [TASK] Fix variable annotations (missing prepending backslashes)
Releases: 1.1
Change-Id: I06d0344ad389e978dd92b8d110b6ae60406184fc
Aske Ertmann

2012-03-06

20:02 Bug #34608 (Under Review): ResourceStreamWrapper::seek gives exactly the wrong bool value
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9427
Gerrit Code Review
19:54 Bug #34608 (Resolved): ResourceStreamWrapper::seek gives exactly the wrong bool value
The ResourceStreamWrapper does:
@return fseek($this->handle, $offset, $whence);@
The documentation to fseek say...
Ferdinand Kuhl
19:56 Revision dd761bb0: [BUGFIX] ResourceStreamWrapper returns wrong value for fseek
Calling fseek will always return the wrong value, as fseek
return 0 on success otherwise -1.
The stream_wrapper expec...
Ferdinand Kuhl
16:28 Bug #34555: StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Karsten Dambekalns wrote:
> > If I get it right, this means that the streamWrapper is only instantiated the *first...
Bastian Waidelich
15:25 Bug #34555: StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Bastian Waidelich wrote:
> If I get it right, this means that the streamWrapper is only instantiated the *first* tim...
Karsten Dambekalns
12:30 Bug #34555 (Resolved): StreamWrapperAdapter::stream_lock does not return StreamWrapper result
While writing unit tests for the StreamWrapperAdapter, I came upon this issue: @StreamWrapperAdapter::stream_lock()@ ... Bastian Waidelich
15:12 Bug #34134: PropertyMapper throws unnecessary exception
That solution still has a flaw, I can’t see all validation errors no more, because the object validation is missing n... Kira Backes
15:10 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
Karsten Dambekalns
15:01 Bug #34547 (Under Review): wrong variable name inside rename() of StreamWrapperAdapter
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9420
Gerrit Code Review
14:38 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
Applied in changeset commit:fe76887f75aa80b82be3104ef1f51e065dd774f0. Bernhard Fischer
08:59 Bug #34547 (Under Review): wrong variable name inside rename() of StreamWrapperAdapter
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9405
Gerrit Code Review
08:35 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
The rename function uses the variable $path which should be $path_from. No error occurred so far because the rename f... Bernhard Fischer
15:00 Revision 93c28d81: [BUGFIX] Wrong variable name inside rename function
Use the proper variable name to create the stream wrapper.
Change-Id: Ia6527b6c95fbe1fcd6cb546a67b7d4b6ac621f66
Fixe...
Bernhard Fischer
13:45 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 15 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
08:57 Revision fe76887f: [BUGFIX] wrong variable name inside rename function
Use the propper variable name to create the stream wrapper.
Change-Id: Icc0ced55caf92d8cd23507b55e1413b9783358e2
Fix...
Bernhard Fischer
08:49 Feature #34185 (Under Review): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Gerrit Code Review
02:38 Bug #33973 (Resolved): Duplicate error id used in StringValidator
Applied in changeset commit:e1f1478eba905740584e9990a68cbf6b7d4c0b4c. Karsten Dambekalns
02:38 Bug #33645 (Resolved): Wrong return value getPasswordHashingStrategyAndIdentifier()
Applied in changeset commit:999b95082c1b5695f698a7f640e9eeaec51d9231. Karsten Dambekalns

2012-03-05

21:28 Bug #33645: Wrong return value getPasswordHashingStrategyAndIdentifier()
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8826
Gerrit Code Review
21:28 Revision 999b9508: [BUGFIX] Fixes getPasswordHashingStrategyAndIdentifier() return value
getPasswordHashingStrategyAndIdentifier() is supposed to return an
array, but in case a strategy identifier has been ...
Karsten Dambekalns
19:37 Bug #34545 (Resolved): Hint at wrong usage of @ORM\MappedSuperclass not displayed
Doctrine 2 allows usage of @MappedSuperclass without @Entity, but in FLOW3 @Entity annotation is necessary. That's wh... Ondrej Hatala
19:20 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
18:18 Bug #34407: NotFoundView should "throw" 404
Karsten, the NotFoundController way isn't involved in every NotFoundView invokation; the NotFoundView is used every t... Adrian Föder
16:57 Bug #34407: NotFoundView should "throw" 404
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
16:52 Bug #34407: NotFoundView should "throw" 404
Under what circumstances is this needed - the NotFoundController sets the status to 404, so out of the box it works a... Karsten Dambekalns
17:27 Bug #33973: Duplicate error id used in StringValidator
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9387
Gerrit Code Review
17:26 Revision e1f1478e: [BUGFIX] Fixes duplicate error id in StringValidator
StringValidator uses the error id 1238108068, but that is
used in StringLengthValidator. This change makes the former...
Karsten Dambekalns
17:25 Revision 5a118ae8: Merge "[BUGFIX] Fixes duplicate error id in StringValidator"
Karsten Dambekalns
16:57 Revision ca5b3b9a: [BUGFIX] NotFoundView sets 404 status
The default NotFoundView, which renders a 404 template,
sets now also the HTTP status to 404.
Change-Id: I01e77d0b3b...
Adrian Föder
11:26 Bug #34527 (Resolved): Add method in repositories does also update
The add method in repositores does also update existing entities, this is a dangerous security flaw, as it allows an ... Kira Backes
08:53 Major Feature #33258: Implement support for Assetic
Hi Sebastian,
indeed I thought about it in "idle time" ;-), I'll write down a few things.
Basically, the design...
Adrian Föder

2012-03-02

16:00 Bug #34466 (Resolved): Roles are not cleared after every test in functional tests
If you do not call authenticateRoles() in one test this will not end in no roles being authenticated as expected. Ins... Andreas Förthner
15:57 Feature #34464 (Resolved): Content security acls should follow the same concept as method security acls
Currently method security acls follow a whitelist approach and content security acls follow a blacklist approach. Thi... Andreas Förthner

2012-03-01

17:09 Revision 7cd7480a: Merge "[TASK] Remove collection validation from Lazy collections"
Karsten Dambekalns
17:01 Bug #34448 (Resolved): Integrity constraint violation on FLOW3 resource tables
I have an own model/class/controller, called "award" with a property mapped to the standard FLOW3 resource table.
...
Jonas
14:35 Feature #34414: JsonView's _exposeObjectIdentifier configurable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9297
Gerrit Code Review
02:38 Bug #33698 (Resolved): ObjectAccess::setProperty must work with numeric indexes
Applied in changeset commit:d473ee2f0e9409959b594d1198bd4d225d8b367c. Sebastian Kurfuerst
02:38 Bug #33460 (Resolved): Missing function visiblity declarations
Applied in changeset commit:95e0ca4941f447f898f84298e529a78c44976dc3. Karsten Dambekalns
02:38 Task #34304 (Resolved): Add abstract classes for entrypoint, provider & token in security authentication
Applied in changeset commit:2a7a67fca12db09aa970549f36b34a50446d4a26. Anonymous
02:38 Bug #34399 (Resolved): Remove Default Authentication Provider configuration
Applied in changeset commit:3f288553a845c904596dd51454cbc90a3e89e06d. Sebastian Kurfuerst
02:38 Bug #33311 (Resolved): AuthenticationProviderManager::isAuthenticated does not work in authentication request
Applied in changeset commit:27f00f62768c2b322e87d815e5bef9f5bd2bb2ea. Christian Müller
02:38 Bug #34423 (Resolved): Missing $context member declaration in ObjectManager
Applied in changeset commit:74838ac1f5e96f097aac0addaad89940c10b766f. Bastian Waidelich

2012-02-29

23:49 Bug #31677: Using current.securityContext Policies.yaml entities section triggers Parser Error
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6596
Gerrit Code Review
23:48 Task #34426 (Under Review): How to receive the correct class name for an object?
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9312
Gerrit Code Review
23:09 Task #34426 (Resolved): How to receive the correct class name for an object?
Currently there is no helper method to find the correct class name of a given object. The reflection service should p... Andreas Förthner
23:48 Revision 5938c224: [TASK] Add utility function to retrieve class names for objects
Resolves: #34426
Releases: 1.1
Change-Id: I768171f2f1d402be0846c7f794669ffb7d1125e2
Andreas Förthner
21:28 Revision 91a9590f: [TASK] Remove collection validation from Lazy collections
The change to validate collections introduced unwanted behavior
by validating lazy annotated and not yet initialized ...
Rens Admiraal
18:24 Bug #34423 (Under Review): Missing $context member declaration in ObjectManager
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9174
Gerrit Code Review
18:22 Bug #34423 (Resolved): Missing $context member declaration in ObjectManager
The ObjectManager refers to $this->context which doesn't exist. Karsten Dambekalns
18:24 Revision 74838ac1: [BUGFIX] Add missing $context field to ObjectManager
The ObjectManager refers to $this->context which didn't exist.
Change-Id: I9754acce672472642c71afa23f0bc0041e882279
...
Bastian Waidelich
18:11 Revision 024f8fc5: [TASK] Add early returns to Security\Context::hasRole
Change the behavior of hasRole so it has an early return
when the authenticationManager is not yet authenticated
(and...
Rens Admiraal
18:07 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9302
Gerrit Code Review
17:55 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9260
Gerrit Code Review
18:07 Revision 27f00f62: [BUGFIX] isAuthenticated should work in authentication request
AuthenticationManager::isAuthenticated now checks for resumable
and new sessions before returning FALSE, so it works ...
Christian Müller
18:05 Revision bb2ca484: Merge "[BUGFIX] isAuthenticated should work in authentication request"
Karsten Dambekalns
17:55 Revision 08b70b82: [BUGFIX] isAuthenticated should work in authentication request
AuthenticationManager::isAuthenticated now checks for resumable
and new sessions before returning FALSE, so it works ...
Christian Müller
17:27 Revision 77fe5922: Merge "[!!!][BUGFIX] (Security): Remove default authentication provider"
Andreas Förthner
17:27 Bug #34399: Remove Default Authentication Provider configuration
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
17:17 Bug #34399: Remove Default Authentication Provider configuration
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
17:26 Revision 3f288553: [!!!][BUGFIX] (Security): Remove default authentication provider
Fixes: #34399
Related to: #34398
Releases: 1.1
Change-Id: Ia370abe31f6c08d1f9a4cf2993ef8fb2b1ffb6b7
Sebastian Kurfuerst
17:10 Revision 0d43a661: Merge "[BUGFIX] (Reflection): ObjectAccess::setProperty must work with numeric indexes"
Sebastian Kurfuerst
17:08 Revision 8a4640e1: Merge "[BUGFIX] Fixes missing function visibility declarations"
Sebastian Kurfuerst
16:56 Task #8923: Provide a Nginx Server Configuration for FLOW3
I had to modify the resource url regexp like this to get it working:... Martin Brüggemann
16:12 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
15:06 Revision 2a7a67fc: [TASK] Add abstract classes for entrypoint, provider & token in security authentication
Change-Id: Ie3a0a8c3fe43689a70c14e5882c3f5e0d4233250
Resolves: #34304
Releases: 1.1
Aske Ertmann
13:43 Feature #34414 (Under Review): JsonView's _exposeObjectIdentifier configurable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9297
Gerrit Code Review
13:11 Feature #34414 (Resolved): JsonView's _exposeObjectIdentifier configurable
The configuration setting for the MVC JsonView allows exposing an object's persistence identifier.
Currently, that c...
Adrian Föder
11:23 Bug #34408 (Closed): CollectionValidator goes in endless recursion
Duplicate of #34154 with fix under review at http://review.typo3.org/9180 Karsten Dambekalns
10:24 Bug #34408 (Closed): CollectionValidator goes in endless recursion
This is a case when 2 domain objects are associated with ManyToMany relation. If the owning side object is created/up... Pankaj Lele
11:20 Bug #32959: Exception thrown on missing role definition
Andi, I think some better error checking would be helpful here, to detect missing/wrong role names. Karsten Dambekalns
11:08 Bug #34018 (Closed): Annotation with a numeric value is not correctly generated
This is a duplicate of #33932 and a fix is under review at https://review.typo3.org/9125 Karsten Dambekalns
10:35 Bug #34407: NotFoundView should "throw" 404
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
10:09 Bug #34407 (Under Review): NotFoundView should "throw" 404
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
10:05 Bug #34407 (Resolved): NotFoundView should "throw" 404
The NotFoundView currently sends itself out with HTTP status 200, saying it was a 404 error. It should instead say 40... Adrian Föder
01:12 Bug #34404 (New): JsonView transformObject does not respect _descendAll configuration
When configuring a jsonView for a domain object, the '_descendAll' configuration is currently not taken into account,... Alexander Berl

2012-02-28

23:12 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
23:08 Revision 95e0ca49: [BUGFIX] Fixes missing function visibility declarations
Some methods were missing their visibility declarations, this
change adds them.
Change-Id: I88ee085111b38366fc0af5ca...
Karsten Dambekalns
23:08 Bug #33460 (Under Review): Missing function visiblity declarations
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9293
Gerrit Code Review
22:19 Bug #33460 (Accepted): Missing function visiblity declarations
FrontendInterface should be public, Route protected (as noted above), the Name fixture public. The others are anonymo... Karsten Dambekalns
22:52 Bug #34399 (Under Review): Remove Default Authentication Provider configuration
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
22:49 Bug #34399 (Resolved): Remove Default Authentication Provider configuration
The default authentication provider was always configured at the first position and could not be removed; which lead ... Sebastian Kurfuerst
15:52 Revision 9c9decda: [TASK] Fix doc comments
Fixes doc comments issues, like missing or wrong @param
annotations. Removes @author annotations.
Change-Id: I785e73...
Karsten Dambekalns
02:43 Bug #34110 (Resolved): Proxy Class strips off Class Doc Comments
Applied in changeset commit:899eb3f37229244f2938f84d52c655b80c91d759. Bastian Waidelich

2012-02-27

22:48 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
19:29 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9262
Gerrit Code Review
19:24 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9261
Gerrit Code Review
19:23 Bug #33311 (Under Review): AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9260
Gerrit Code Review
17:35 Bug #32629 (Closed): globalObjects are not available in the security (current.securityContext.party)
Duplicate of issue #31677 Karsten Dambekalns
17:17 Bug #34110: Proxy Class strips off Class Doc Comments
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9256
Gerrit Code Review
17:14 Revision 465c4cbe: [BUGFIX] Keep class doc comments when building proxies
Currently the doc comment of a class is replaced with
"Autogenerated Proxy Class" when the proxy class is generated.
...
Bastian Waidelich
17:12 Revision 7e483099: Merge "[BUGFIX] Keep class doc comments when building proxies"
Karsten Dambekalns
02:55 Bug #34293 (Resolved): Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
Applied in changeset commit:55150fe526b60d0200b6afd40731b8c36cef1bc4. Johannes K

2012-02-26

22:23 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
22:08 Task #34304 (Under Review): Add abstract classes for entrypoint, provider & token in security authentication
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
22:05 Task #34304 (Resolved): Add abstract classes for entrypoint, provider & token in security authentication
There's a lot of duplicated code in the security authentication, we should create some abstract classes to prevent this. Aske Ertmann
21:14 Bug #34293: Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9222
Gerrit Code Review
21:07 Bug #34293: Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9220
Gerrit Code Review
18:11 Bug #34293 (Under Review): Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9220
Gerrit Code Review
17:54 Bug #34293 (Resolved): Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
l.74: __desctruct should read __destruct
<code class="php">
if (preg_match('/^__wakeup|__construct|__desctruct|__...
Johannes K
21:11 Revision 55150fe5: [BUGFIX] Now filters correctly for '__destruct' in pointcut filter
The filter for proxyable methods in SessionObjectMethodsPointcutFilter skips
the method '__desctruct' instead of '__d...
Johannes K
21:06 Revision 5c5934c3: [BUGFIX] Now filters correctly for '__destruct' in pointcut filter
The filter for proxyable methods in SessionObjectMethodsPointcutFilter skips
the method '__desctruct' instead of '__d...
Johannes K

2012-02-25

23:52 Bug #31677: Using current.securityContext Policies.yaml entities section triggers Parser Error
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6596
Gerrit Code Review

2012-02-24

21:52 Bug #34154: ObjectValidator has exponential growth factor
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9180
Gerrit Code Review
15:23 Bug #34154 (Under Review): ObjectValidator has exponential growth factor
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9180
Gerrit Code Review
17:25 Revision 8979c375: [TASK] Update Package.xml with new version number
Change-Id: I2589eb210140265a829933baeb7d22c0c6f89412
Releases: 1.0
Karsten Dambekalns
17:06 Revision b7269225: [TASK] Update Package.xml with new version number
Change-Id: I942d9356d6c7b05418a1fd1c6f005ba108e765de
Releases: 1.0
Karsten Dambekalns
16:12 Revision 7417bfad: Merge "[BUGFIX] Fix default lifetime use in cache backend" into FLOW3-1.0
Karsten Dambekalns
11:56 Bug #34110: Proxy Class strips off Class Doc Comments
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9121
Gerrit Code Review
11:56 Revision 899eb3f3: [BUGFIX] Keep class doc comments when building proxies
Currently the doc comment of a class is replaced with
"Autogenerated Proxy Class" when the proxy class is generated.
...
Bastian Waidelich
02:43 Feature #33970 (Resolved): Add translation files for bundled validator error messages
Applied in changeset commit:b484e6a4f3725091765cdf9c898b81c03245d3d9. Karsten Dambekalns
02:43 Feature #33959 (Resolved): Make quantity optional when using single numeric arguments in translations
Applied in changeset commit:e7141cb693168c2785c0b7e075ead8c73b96194a. Karsten Dambekalns
02:43 Feature #34169 (Resolved): Encapsulate i18n configuration so it can be passed around and modified easily
Applied in changeset commit:7323b900fb1c96e14f36e2cc7b67b064dc01d912. Karsten Dambekalns
02:43 Feature #34172 (Resolved): Implement fallback rules for i18n
Applied in changeset commit:9ccbdb00a87a21796f28212c480a35112d014196. Karsten Dambekalns
02:43 Bug #34170 (Resolved): XLIFF models are created with wrong locale
Applied in changeset commit:b24339c953375fc738fca7ad364af78c558186b2. Karsten Dambekalns
02:43 Bug #34171 (Resolved): translateById() returns NULL if no arguments need to be replaced
Applied in changeset commit:2b0b5b96657f731bcdef8ecd7ccbcf3edd4cc5de. Karsten Dambekalns

2012-02-23

20:30 Bug #34110: Proxy Class strips off Class Doc Comments
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9121
Gerrit Code Review
17:08 Bug #34171: translateById() returns NULL if no arguments need to be replaced
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9149
Gerrit Code Review
17:02 Bug #34171: translateById() returns NULL if no arguments need to be replaced
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9149
Gerrit Code Review
12:56 Bug #34171: translateById() returns NULL if no arguments need to be replaced
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9149
Gerrit Code Review
17:08 Bug #34170: XLIFF models are created with wrong locale
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9148
Gerrit Code Review
17:02 Bug #34170: XLIFF models are created with wrong locale
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9148
Gerrit Code Review
12:56 Bug #34170: XLIFF models are created with wrong locale
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9148
Gerrit Code Review
17:08 Revision b24339c9: [BUGFIX] Fixes wrong locale in XLIFF models
If a translation is requested but no (exact) match is found,
a different locale may take effect (e.g. en instead of e...
Karsten Dambekalns
17:08 Revision 2b0b5b96: [BUGFIX] Makes translateById() work if no arguments need to be replaced
If translateById() is able to find a translation but is not given
any arguments to embed in the output, NULL is retur...
Karsten Dambekalns
17:02 Feature #34172: Implement fallback rules for i18n
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9147
Gerrit Code Review
17:02 Feature #34169: Encapsulate i18n configuration so it can be passed around and modified easily
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9146
Gerrit Code Review
17:02 Feature #33959: Make quantity optional when using single numeric arguments in translations
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9040
Gerrit Code Review
17:01 Revision e7141cb6: [FEATURE] Makes quantity optional in translation methods
When using plural forms, the quantity to be used for finding
the correct plural form had to be given explicitly. This...
Karsten Dambekalns
17:01 Revision 7323b900: [!!!][FEATURE] Adds i18n configuration holder
To control the behavior of the i18n component a way to
configure the "current" locale, fallback rules for resolving
o...
Karsten Dambekalns
17:01 Revision 9ccbdb00: [FEATURE] Adds fallback rules for locale resolution
Allows to set a fallback order for locale resolving. If not set,
the implicit inheritance of locales will be used. Th...
Karsten Dambekalns
16:56 Revision 4abc9dd3: Merge "[FEATURE] Add translations for validation error messages"
Robert Lemke

2012-02-22

15:05 Feature #34185 (Resolved): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Currently if you connect a $classname + $methodname as slot it will instantiate the class to call $methodname on the ... Christian Müller
14:47 Bug #33707 (Resolved): It is possible to authenticate with an expired account
Applied in changeset commit:873bdd5376defbd863929258b2e52f63b8b73dbe. Karsten Dambekalns
14:34 Feature #33862: a shorthand for custom validators
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8986
Gerrit Code Review
14:34 Revision 8fca8ee3: [FEATURE] Shorthand syntax for custom validators
This change allows the Validate annotation for properties to
be given a value like "Mypkg:My". This is equivalent to ...
Stefan Neufeind
14:25 Feature #33531: DateTimeConverter should support DateTime subclasses
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8770
Gerrit Code Review
14:03 Bug #33698: ObjectAccess::setProperty must work with numeric indexes
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8857
Gerrit Code Review
14:02 Revision d473ee2f: [BUGFIX] (Reflection): ObjectAccess::setProperty must work with numeric indexes
When trying to set a value to an ArrayAccess object with a numeric index, the
ObjectAccess::setProperty() method thro...
Sebastian Kurfuerst
13:43 Revision 912e4305: Merge "[BUGFIX] ArrayMergeRecursiveOverrule does not override arrays with simple types" into FLOW3-1.0
Karsten Dambekalns
13:09 Revision 20ac73a3: Merge "[TASK] Adjust to Doctrine 2.2 libraries" into FLOW3-1.0
Karsten Dambekalns
13:07 Feature #33959: Make quantity optional when using single numeric arguments in translations
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9040
Gerrit Code Review
13:07 Bug #34171 (Under Review): translateById() returns NULL if no arguments need to be replaced
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9149
Gerrit Code Review
11:13 Bug #34171 (Resolved): translateById() returns NULL if no arguments need to be replaced
If @translateById()@ is able to find a translation but is not given any arguments to embed in the output, NULL is ret... Karsten Dambekalns
13:07 Bug #34170 (Under Review): XLIFF models are created with wrong locale
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9148
Gerrit Code Review
11:11 Bug #34170 (Resolved): XLIFF models are created with wrong locale
If a translation is requested but no (exact) match is found, a different locale may take effect (e.g. en instead of e... Karsten Dambekalns
13:07 Feature #34172 (Under Review): Implement fallback rules for i18n
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9147
Gerrit Code Review
11:15 Feature #34172 (Resolved): Implement fallback rules for i18n
Currently the only fallback applied when resolving translations is the implicit chain in locale, e.g. en_UK > en
I...
Karsten Dambekalns
13:07 Feature #34169 (Under Review): Encapsulate i18n configuration so it can be passed around and modified easily
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9146
Gerrit Code Review
11:05 Feature #34169 (Resolved): Encapsulate i18n configuration so it can be passed around and modified easily
The behavior of the i18n component needs to be configurable, down to per request in some cases. Thus a configuration ... Karsten Dambekalns
12:56 Feature #34177 (Under Review): Make Resource use with file operations easier
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9145
Gerrit Code Review
12:54 Feature #34177 (Resolved): Make Resource use with file operations easier
To use a @Resource@ with file operations, one can use the @resource://…@ scheme and the @__toString()@ method of any ... Karsten Dambekalns
11:40 Bug #34154: ObjectValidator has exponential growth factor
This also happens when loading a single entity with lots of connected entities (even when those entities are connecte... Kira Backes

2012-02-21

17:42 Bug #34154 (Resolved): ObjectValidator has exponential growth factor
In the onFlush method of the PersistenceManager all objects are validates, this is a problem especially for many conn... Kira Backes
15:37 Bug #33158: Problems setting PHP binary path on Windows
The flow3.bat also has a path to php.exe. So you should also change this to your local php path to make this work. Mattias Nilsson
15:17 Feature #34133: RFC: Handle Semicolons in Path part of URIs as Scoped Path Parameters
Hi.
Jacob Floyd wrote:
> Do we really want to support using session.use_trans_sid?
I don't give a dime about t...
Karsten Dambekalns
12:06 Feature #34133: RFC: Handle Semicolons in Path part of URIs as Scoped Path Parameters
Karsten Dambekalns wrote:
> Without having read everything yet, I'd like to point to the arg_separator.* directives ...
Jacob Floyd
11:52 Feature #34133: RFC: Handle Semicolons in Path part of URIs as Scoped Path Parameters
…moved to original description. Jacob Floyd
11:36 Feature #34133: RFC: Handle Semicolons in Path part of URIs as Scoped Path Parameters
Without having read everything yet, I'd like to point to the arg_separator.* directives of PHP (see http://www.sitepo... Karsten Dambekalns
11:27 Feature #34133 (New): RFC: Handle Semicolons in Path part of URIs as Scoped Path Parameters
h1. Scoped Path Parameters
The URI RFCs hint at what I think will make an awesome, unique, feature for Flow3, and ...
Jacob Floyd
13:56 Bug #34134: PropertyMapper throws unnecessary exception
Here is a better solution so you can still get all errors for all properties and you still won’t get an exception eve... Kira Backes
12:07 Bug #34134 (Needs Feedback): PropertyMapper throws unnecessary exception
In the case of models with non-optional constructor arguments, you get an exception when one of those subproperties h... Kira Backes
11:01 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 13 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
10:30 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 12 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
00:50 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 11 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
00:39 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
00:36 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review

2012-02-20

21:36 Bug #33707: It is possible to authenticate with an expired account
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9129
Gerrit Code Review
21:36 Revision 873bdd53: [BUGFIX] Makes account expiry work as expected
The expiry if an account was checked in a way that left an account
enabled until after it's last day. Now it will exp...
Karsten Dambekalns
21:33 Revision 9c5f208e: Merge "[BUGFIX] Makes account expiry work as expected"
Karsten Dambekalns
16:32 Bug #33932 (Under Review): AOP Proxy Compiler does not handle numeric annotation parameters
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9125
Gerrit Code Review
16:32 Revision 895d48b9: [BUGFIX] Fixes handling of numeric annotation parameters
Annotations like @FooBar(amount=2) lost their parameter value
in renderAnnotation(). This change fixes that.
Change-...
Karsten Dambekalns
12:20 Bug #34110 (Under Review): Proxy Class strips off Class Doc Comments
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9121
Gerrit Code Review
12:17 Bug #34110 (Resolved): Proxy Class strips off Class Doc Comments
The Proxy Class replaces the class doc comment of the original class with ... Bastian Waidelich
10:35 Bug #34050: DatetimeParser code documentation is wrong
This also causes the DateTimeValidator to not work Kira Backes

2012-02-19

21:18 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
21:15 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
00:10 Feature #33371: HTTP 1.1 Support
@robert - I've seen/heard your comments in the scrum protocols/meeetings about this HTTP work you're doing.
I've b...
Jacob Floyd

2012-02-17

18:56 Bug #34050 (Resolved): DatetimeParser code documentation is wrong
The public methods expect a DateTime object, which they then forward as a string to the internal methods, which then ... Kira Backes
18:42 Bug #34048 (Closed): ResolveValidator breaks on DateTime method arguments
When a dateTime argument is set in a method the ResolveValidator breaks, he tries to create a DateTime (instead of a ... Kira Backes

2012-02-16

20:49 Bug #34018: Annotation with a numeric value is not correctly generated
Patch for the above - suggested - solution.
Tried to add a test in CompilerTest.php, but they are all using the Va...
Georg Großberger
20:40 Bug #34018 (Closed): Annotation with a numeric value is not correctly generated
I have a domain model declared abstract with the following annotation:... Georg Großberger
15:46 Bug #33971: Missing id attributes in XLIFF files are not reported to the user
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9050
Gerrit Code Review
15:41 Bug #33971 (Under Review): Missing id attributes in XLIFF files are not reported to the user
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9050
Gerrit Code Review
11:10 Bug #33971 (Resolved): Missing id attributes in XLIFF files are not reported to the user
XLIFF requires id attributes, but if they are missing, FLOW3 does not complain. Instead, _something_ happens in the X... Karsten Dambekalns
14:27 Bug #33621 (Under Review): Filebackend reports error when trying to rename file due to concurrent proccesses
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8931
Gerrit Code Review
14:27 Bug #27989: Wrong check in our atomic writes code
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8931
Gerrit Code Review
09:20 Bug #27989: Wrong check in our atomic writes code
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8787
Gerrit Code Review
12:19 Revision ca35b1a8: [TASK] Implement best practices in XLIFF files
Adds some "required" attributes to the XLIFF files.
Change-Id: Ib30f5653197229c5d2062eba2c0020ca6e191216
Resolves: #...
Karsten Dambekalns
12:08 Feature #28399: Validation message and code should be configurable for bundled validators
Thinking about it - with the ability to use L18N for outputting the validation message, I don't think we need that fe... Bastian Waidelich
12:01 Feature #33970: Add translation files for bundled validator error messages
FYI this is (kind of) how you can use those to output localized validation messages:... Bastian Waidelich
10:51 Feature #33970 (Under Review): Add translation files for bundled validator error messages
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9045
Gerrit Code Review
10:50 Feature #33970 (Resolved): Add translation files for bundled validator error messages
Karsten Dambekalns
11:58 Bug #33973 (Under Review): Duplicate error id used in StringValidator
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9047
Gerrit Code Review
11:56 Bug #33973 (Resolved): Duplicate error id used in StringValidator
StringValidator uses the error id 1238108068, but that is used in StringLengthValidator as well. Karsten Dambekalns
11:57 Revision 30d2c4cc: [BUGFIX] Fixes duplicate error id in StringValidator
StringValidator uses the error id 1238108068, but that is
used in StringLengthValidator. This change makes the former...
Karsten Dambekalns
11:53 Feature #6456: Customization/localization of validator errors
With the current version and #33970 applied this works quite nice. The respective Fluid code looks something like:
<p...
Bastian Waidelich
11:32 Bug #33932 (Accepted): AOP Proxy Compiler does not handle numeric annotation parameters
Karsten Dambekalns
11:27 Bug #33883 (Accepted): Repositories must be singleton, but no checks are done on this
Well, repositories must be singleton, otherwise I don't even want to imagine what happens…
I changed the bug title...
Karsten Dambekalns
11:22 Bug #33968 (Needs Feedback): Missing privileges to create symlinks in Windows cause exception
Rens, could you take care of this? Yo are working on symlinks and Windows anyway, right?
The error is caused by th...
Karsten Dambekalns
09:52 Bug #33968 (Closed): Missing privileges to create symlinks in Windows cause exception
Warning: symlink() [<a href='function.symlink'>function.symlink</a>]: Cannot create symlink, error code(1314) in C:\x... Richard Lederer
11:19 Feature #33937 (Needs Feedback): Convenience method to resolve public "resource://" paths
What is this needed for? Any file functions can use the resource:// URL directly. To fetch the web URL, a method exis... Karsten Dambekalns
11:10 Bug #33882: XliffParser does not allow id-less translation
Kira Backes wrote:
> Okay, but then you should throw an exception in case of a missing id attribute?
Good point, ...
Karsten Dambekalns
10:57 Bug #33882: XliffParser does not allow id-less translation
Okay, but then you should throw an exception in case of a missing id attribute? Kira Backes
10:48 Bug #33882 (Rejected): XliffParser does not allow id-less translation
This will never change, as XLIFF requires id attributes to be present. Plus, id-based translation is recommended as i... Karsten Dambekalns
10:50 Revision b484e6a4: [FEATURE] Add translations for validation error messages
Change-Id: I8c8c4d19b673d02339369d2a16961441ad65bdc5
Resolves: #33970
Releases: 1.1
Karsten Dambekalns
07:56 Major Feature #33258: Implement support for Assetic
Hey Adrian,
Thanks for starting with a concept! Some comments from my side:
* I'd suggest to use "Assets.yaml" ...
Sebastian Kurfuerst
02:46 Bug #33562 (Resolved): FileBackend didnt use defaultLifetime if lifetime is null
Applied in changeset commit:a0ee47d189f0a2141b6c8de2813d984c69a44eba. Karsten Dambekalns
02:46 Task #33836 (Resolved): Add better error handling to XML file parsing
Applied in changeset commit:987a264f0322b1125ed41fcc26dd41b494b6b2ce. Karsten Dambekalns

2012-02-15

23:24 Feature #33959: Make quantity optional when using single numeric arguments in translations
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9040
Gerrit Code Review
23:18 Feature #33959 (Under Review): Make quantity optional when using single numeric arguments in translations
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9040
Gerrit Code Review
23:15 Feature #33959 (Resolved): Make quantity optional when using single numeric arguments in translations
When using plural forms, the quantity to be used for finding the correct plural form has to be given explicitly. This... Karsten Dambekalns
22:47 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
21:38 Bug #33562: FileBackend didnt use defaultLifetime if lifetime is null
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9037
Gerrit Code Review
21:37 Revision f22d865d: [BUGFIX] Fix default lifetime use in cache backend
This fixes the FileBackend so it actually uses the default lifetime
in cases it should do that.
ArrayAccess detectio...
Karsten Dambekalns
21:32 Revision 7807b255: Merge "[BUGFIX] Fix default lifetime use in cache backend"
Karsten Dambekalns
16:01 Task #33836: Add better error handling to XML file parsing
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8968
Gerrit Code Review
16:00 Revision 987a264f: [TASK] Add better handling of XML parse errors to I18n
When parsing XML files the exception thrown in case of errors did not
differentiate between filesystem and parsing er...
Karsten Dambekalns
12:40 Revision 8259dca1: Merge "[TASK] Remove CGL DocBook XML files from package"
Karsten Dambekalns
12:27 Revision fbc69cc6: Merge "[TASK] Adjust test fixture to Doctrine.ORM 2.2.0"
Karsten Dambekalns
11:25 Feature #33937 (Accepted): Convenience method to resolve public "resource://" paths
It would be helpful to have an easy way to resolve the 'resource://...' path
to static resources.
Currently we end...
Bastian Waidelich
09:51 Major Feature #33258 (Accepted): Implement support for Assetic
Sebastian Kurfuerst
09:48 Major Feature #33258: Implement support for Assetic
Johannes,
we "plan" anything you like :) We're currently in the absolut early stage of collecting some ideas and imp...
Adrian Föder
00:37 Bug #33932 (Resolved): AOP Proxy Compiler does not handle numeric annotation parameters
In the TYPO3\FLOW3\Object\Proxy\Compiler::renderAnnotation function, there is currently no case for numeric annotatio... Alexander Berl

2012-02-14

22:55 Major Feature #33258: Implement support for Assetic
Great!
Do you plan to integrate filters and nested assets, too?

It would be nice to be able to set the debug mode (...
Johannes K
16:00 Major Feature #33258: Implement support for Assetic
So far, I've created two repositories at Github in order to get a clue and to get a possibility to work with and to p... Adrian Föder
10:57 Feature #32106: Support for Object source in PropertyMapper
Hey Sebastian,
sorry for my late Reply.
Sadly i'm still drowning in an ocean of work and can't see an end at th...
Marc Neuhaus
10:17 Bug #33883: Repositories must be singleton, but no checks are done on this
It is "fixable" by setting the scope of the repositories to Singleton Kira Backes
02:43 Task #33142 (Resolved): Ignore Tags / Annotations in external libraries, find some good solution
Applied in changeset commit:cebbf8e2851b28ffaf32abafbb675e47af6ae783. Christian Müller

2012-02-13

15:12 Task #33142: Ignore Tags / Annotations in external libraries, find some good solution
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/7747
Gerrit Code Review
15:10 Revision cebbf8e2: [FEATURE] Make tag ignores configurable
Makes the list of ignored tags configurable. This can be used to add
tags to the list if needed by your package by si...
Christian Müller
14:47 Bug #33300 (Resolved): Validators should allow empty values
Applied in changeset commit:9b627954f289d793b808db2ac19edc6a04c25426. Bastian Waidelich
14:17 Bug #33883 (Resolved): Repositories must be singleton, but no checks are done on this
I have models with injected repositories and due to some change in the last 2 weeks in master I can no longer use FLO... Kira Backes
14:10 Bug #33882 (Rejected): XliffParser does not allow id-less translation
If I want to translate completely without IDs I’m still forced to add IDs in the translation .xlf, because the id-les... Kira Backes
 

Also available in: Atom