Activity

From 2012-02-27 to 2012-03-27

2012-03-27

18:43 Bug #33495: No alternative entry point type can be configured
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9881
Gerrit Code Review
18:43 Feature #35243: HTTP 1.1 Support – Foundations
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9880
Gerrit Code Review
18:43 Task #33705: Inconsistent spelling of sub package and class names
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9780
Gerrit Code Review
11:13 Feature #28399: Validation message and code should be configurable for bundled validators
Yes, that's the idea. Right now it's not possible to treat one validator type differently regarding translations. Whi... Christopher Hlubek

2012-03-26

21:44 Feature #35030 (Accepted): Dynamic locale detection
We'd love to nail this for I18n, so keep your ideas coming. Also make sure to check the locale chain configuration in... Karsten Dambekalns
18:20 Task #33705: Inconsistent spelling of sub package and class names
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9780
Gerrit Code Review
18:20 Bug #33495 (Under Review): No alternative entry point type can be configured
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9881
Gerrit Code Review
18:20 Feature #35243 (Under Review): HTTP 1.1 Support – Foundations
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9880
Gerrit Code Review
18:18 Feature #35243 (Resolved): HTTP 1.1 Support – Foundations
In order to cleanly separate between the domain of HTTP and that of the MVC framework, it is necessary to split up th... Robert Lemke
17:32 Feature #28399: Validation message and code should be configurable for bundled validators
like the idea. Am I right that would mean you can do... Adrian Föder
17:14 Bug #35136: Problem with validating simple types
you are not allowed to throw an exception inside the type converter in case of a user error.
Instead, you should r...
Sebastian Kurfuerst
14:40 Feature #35135 (Resolved): Provide an inject() convenience method in Base Test Case
Applied in changeset commit:8152b8c97a292e79e24b514b161850ccdba85b03. Robert Lemke
11:30 Feature #35135 (Under Review): Provide an inject() convenience method in Base Test Case
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9870
Gerrit Code Review

2012-03-25

12:45 Bug #35136: Problem with validating simple types
I'm totally fine with the conversion, that's not something to discuss I think. But validation always has to be done i... Rens Admiraal
11:33 Bug #35136: Problem with validating simple types
I see what you mean but I think the Converter should just do it's job and don't validate anything, so throwing an exc... Christian Müller

2012-03-24

18:35 Bug #35200: TYPO3\FLOW3\AOP\Exception\InvalidArgumentException thrown in file JoinPoint.php
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9857
Gerrit Code Review
16:00 Bug #35200 (Under Review): TYPO3\FLOW3\AOP\Exception\InvalidArgumentException thrown in file JoinPoint.php
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9857
Gerrit Code Review

2012-03-23

21:11 Bug #35200 (Resolved): TYPO3\FLOW3\AOP\Exception\InvalidArgumentException thrown in file JoinPoint.php
In TYPO3\FLOW3\Session\Aspect\LoggingAspect , l. 68
$reason = $joinPoint->getMethodArgument('reason') ?: 'no reas...
Johannes K
17:57 Feature #35195 (Under Review): Additional possible keys in source array for DateTimeConverter
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9848
Gerrit Code Review
17:21 Feature #35195 (Resolved): Additional possible keys in source array for DateTimeConverter
At the moment, the following is allowed:... Adrian Föder
14:39 Bug #34555 (Resolved): StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Applied in changeset commit:2fd21b11f5b72a668d3d408328a3f7bbd72dc646. Bastian Waidelich
13:23 Feature #34866 (Under Review): Allow fluently working with PropertyMappingConfiguration
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9843
Gerrit Code Review
12:52 Feature #34866 (Accepted): Allow fluently working with PropertyMappingConfiguration
Adrian Föder
12:49 Bug #35016 (Resolved): YamlSource creates invalid YAML files
Sebastian Kurfuerst
12:31 Feature #34867 (Resolved): Allow setting target type in MVC Argument
Sebastian Kurfuerst
12:14 Bug #34837 (Resolved): flow3:cache:flush should care about the .Shortcuts state
Sebastian Kurfuerst
12:10 Bug #34837: flow3:cache:flush should care about the .Shortcuts state
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9648
Gerrit Code Review
10:18 Bug #35173 (Closed): PropertyMapping: FloatConverter - map from float to float is not working
PropertyMapping:
The FloatConverter does not allow to map from float to float.
In contrast to this behaviour the I...
Nils Seinschedt
00:12 Feature #28052: Possibility to enable or disable accounts
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/3245
Gerrit Code Review

2012-03-22

23:23 Feature #32607: Export localized strings for JS consumption
I like the viewhelper idea. Options that such a viewhelper should have:
- select locale (obviously), default should...
Alexander Berl
12:19 Bug #35136 (Resolved): Problem with validating simple types
When an argument of a controller action is annotated with @param integer $var, the validation never fails if a string... Rens Admiraal
11:33 Feature #35135 (Resolved): Provide an inject() convenience method in Base Test Case
Testing code which uses dependency injection requires some additional lines of code for manually injecting the depend... Robert Lemke

2012-03-21

23:05 Bug #31500: Argument validation for CLI requests is not done
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6014
Gerrit Code Review
19:43 Bug #34555: StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9788
Gerrit Code Review
19:42 Bug #34555 (Under Review): StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9788
Gerrit Code Review
19:24 Bug #34555 (Accepted): StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Bastian Waidelich
19:30 Feature #34648: Implement a way to authenticate with a file based encrypted key
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
18:23 Bug #35096 (Closed): Subroutes can't use empty uriPattern as fallback
I have several packages, for each package I like to create a routing shortcut.
So that instead of using these urls
...
Sebastian
17:08 Task #33705: Inconsistent spelling of sub package and class names
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9780
Gerrit Code Review
17:05 Task #33705: Inconsistent spelling of sub package and class names
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9780
Gerrit Code Review
16:48 Task #33705 (Under Review): Inconsistent spelling of sub package and class names
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9780
Gerrit Code Review
13:06 Bug #35083 (New): involving SecurityContext in Widget's __wakeup situation leads to an exception
I experience the situation that the attached exception occurs.
I have an object with an injected @\TYPO3\FLOW3\Secur...
Adrian Föder
11:36 Feature #35030: Dynamic locale detection
@Adrian: The correct way would then be to not have subdomains, but full TLDs for each locale/language used (hierarchy... Alexander Berl
02:39 Bug #31192 (Resolved): Update session cookie lifetime on activity
Applied in changeset commit:cfe4af2e7423da6adbe881d1c97e14abc62ce189. Robert Lemke
02:39 Feature #35052 (Resolved): Make message origin hint configurable
Applied in changeset commit:becbc65f77c30547c0a56a5a1e93b6b68be1365a. Robert Lemke

2012-03-20

22:44 Bug #35011: Column type detection broken when Column annotation is used
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9742
Gerrit Code Review
22:44 Bug #35059 (Under Review): Default for nullable is TRUE but should be FALSE
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9774
Gerrit Code Review
22:30 Bug #35059 (Resolved): Default for nullable is TRUE but should be FALSE
The nullable option for columns is FALSE in Doctrine 2 unless otherwise indicated. Our annotation driver uses a defau... Karsten Dambekalns
20:54 Feature #35052: Make message origin hint configurable
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9766
Gerrit Code Review
17:55 Feature #35052: Make message origin hint configurable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9766
Gerrit Code Review
17:39 Feature #35052 (Under Review): Make message origin hint configurable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9766
Gerrit Code Review
17:36 Feature #35052 (Resolved): Make message origin hint configurable
The logging FileBackend currently adds a hint about where the message was created for every log entry. While this fea... Robert Lemke
18:02 Bug #32829: Mapping to a subclass by __type property fails if subclass adds fields
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/7507
Gerrit Code Review
17:46 Feature #35034 (Resolved): Automatic session expiration on user inactivity
Robert Lemke
17:41 Feature #35034: Automatic session expiration on user inactivity
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
15:59 Feature #35034: Automatic session expiration on user inactivity
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
12:47 Feature #35034 (Under Review): Automatic session expiration on user inactivity
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
12:39 Feature #35034 (Resolved): Automatic session expiration on user inactivity
Sessions should expire automatically after a configured amount of time of inactivity. Robert Lemke
17:41 Bug #31192: Update session cookie lifetime on activity
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
15:59 Bug #31192: Update session cookie lifetime on activity
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
12:47 Bug #31192 (Under Review): Update session cookie lifetime on activity
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9765
Gerrit Code Review
12:38 Bug #31192 (Accepted): Update session cookie lifetime on activity
Robert Lemke
17:35 Feature #35030: Dynamic locale detection
well, that's a question that must be discussed really well. My very humble opinion is, that the language should not b... Adrian Föder
17:07 Feature #35030: Dynamic locale detection
Not to forget, we need to have a way of inserting the locale into URLs if it has been set via the URL. Otherwise we w... Andreas Wolf
12:37 Feature #35030: Dynamic locale detection
Adrian, that's more or less what I was thinking of ;)
For me, the chain would be (highest priority first): URL -> co...
Andreas Wolf
12:26 Feature #35030: Dynamic locale detection
my two cents to this; there may be even a locale determiner mechanism that goes through a chain of LocaleDeterminers ... Adrian Föder
12:17 Feature #35030 (Under Review): Dynamic locale detection
Currently, the locale is automatically set to "en". It is however possible to manually set the locale to something el... Andreas Wolf
14:39 Bug #31997 (Resolved): Security Context::hasRole should also work recursively; this makes <f:security.ifHasRole> work recursively as well
Applied in changeset commit:861231e1eff72b53d3dd415c496bed2b29752358. Sebastian Kurfuerst
10:32 Bug #31997: Security Context::hasRole should also work recursively; this makes <f:security.ifHasRole> work recursively as well
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6859
Gerrit Code Review
10:31 Bug #31997: Security Context::hasRole should also work recursively; this makes <f:security.ifHasRole> work recursively as well
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6859
Gerrit Code Review
09:58 Bug #31997: Security Context::hasRole should also work recursively; this makes <f:security.ifHasRole> work recursively as well
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6859
Gerrit Code Review
13:39 Bug #35035 (Accepted): Doctrine repository findAll is inconsistent
Karsten Dambekalns
13:00 Bug #35035 (Resolved): Doctrine repository findAll is inconsistent
The findAll method of the special doctrine repository (needed for custom DQL afaik) returns an array of objects (thro... Christopher Hlubek

2012-03-19

18:33 Bug #35016 (Under Review): YamlSource creates invalid YAML files
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9748
Gerrit Code Review
18:31 Bug #35016 (Resolved): YamlSource creates invalid YAML files
@\TYPO3\FLOW3\Tests\Unit\Configuration\Source\YamlSource::save()@ currently separates the header from the configurati... Bastian Waidelich
18:17 Bug #35007 (Needs Feedback): Functional tests do not work with MySQL database
Works for me using a Phoenix setup. Are you sure in your test setup/teardown are called? Karsten Dambekalns
15:51 Bug #35007 (Accepted): Functional tests do not work with MySQL database
I'll check this. Karsten Dambekalns
15:15 Bug #35007 (Resolved): Functional tests do not work with MySQL database
If persistence is enabled in functional tests and a MySQL database is configured, I get the following error when exec... Christopher Hlubek
15:48 Bug #35011 (Under Review): Column type detection broken when Column annotation is used
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9742
Gerrit Code Review
15:45 Bug #35011 (Resolved): Column type detection broken when Column annotation is used
If a Column annotation is used but no type argument is given, the default "string" type will be used and override the... Karsten Dambekalns
14:38 Feature #34827 (Resolved): Precompiled reflection data for rather static packages
Applied in changeset commit:e1810549a590de455a609443a1f35e2e3d9baee3. Robert Lemke
11:35 Bug #34864 (Rejected): inproper escape of attribute names
See #33639 for some information. Karsten Dambekalns
11:19 Task #34817: Have a way to clear all sessions
Since #25923 is set to target 1.0, this must go into that as well. Karsten Dambekalns
11:19 Task #34817 (Under Review): Have a way to clear all sessions
Karsten Dambekalns
10:51 Feature #31277 (Accepted): Schema based validation for arrays
Karsten Dambekalns

2012-03-16

14:00 Feature #34783 (Closed): Provide utility method to get unproxied class name
Closed due to duplicity to #34426... Adrian Föder
12:57 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8656
Gerrit Code Review
12:50 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Just was affected by this one by myself; I have... Adrian Föder
11:13 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 22 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
11:10 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 21 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
08:41 Feature #34674 (Accepted): NotFoundView is not injected in ActionController
Robert Lemke
08:41 Bug #34675 (Accepted): NotFoundView is not used for missing actions
Robert Lemke
02:41 Task #9568 (Resolved): Improve speed of AOP proxy building / reflection
Applied in changeset commit:38c3c8e7edbb730699dbd993e180e8aee39b3e3d. Andreas Förthner

2012-03-15

20:47 Feature #34900 (Under Review): New role: ANONYMOUS
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9680
Gerrit Code Review
20:45 Feature #34900 (Resolved): New role: ANONYMOUS
Introduce a magic role which matches only if no account is currently authenticated. Robert Lemke
20:07 Bug #31677: Using current.securityContext Policies.yaml entities section triggers Parser Error
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6596
Gerrit Code Review
20:07 Bug #34466 (Under Review): Roles are not cleared after every test in functional tests
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9676
Gerrit Code Review
20:07 Feature #34464 (Under Review): Content security acls should follow the same concept as method security acls
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9675
Gerrit Code Review
17:04 Feature #34827: Precompiled reflection data for rather static packages
Some rough performance measurements for the record. Tested with current T3CON12 distribution (15.03.2012, 15:30) on W... Bastian Waidelich
16:06 Feature #34827: Precompiled reflection data for rather static packages
Patch set 15 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
15:12 Feature #34827: Precompiled reflection data for rather static packages
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
14:54 Feature #34827: Precompiled reflection data for rather static packages
Patch set 13 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
14:21 Feature #34827: Precompiled reflection data for rather static packages
Patch set 12 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
14:16 Feature #34827: Precompiled reflection data for rather static packages
Patch set 11 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
13:51 Feature #34827: Precompiled reflection data for rather static packages
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
13:25 Feature #34827: Precompiled reflection data for rather static packages
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
13:19 Feature #34827: Precompiled reflection data for rather static packages
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
12:36 Feature #34827: Precompiled reflection data for rather static packages
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
12:08 Feature #34827: Precompiled reflection data for rather static packages
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
12:05 Feature #34827: Precompiled reflection data for rather static packages
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
15:12 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 20 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
15:09 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 19 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
15:04 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 18 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
12:08 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 17 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
11:44 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 16 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
10:42 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 15 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
12:18 Bug #34879 (Accepted): Proxied object is not update()able
in my use case, I have objects as children of a parent object.
I access these children via the <for each=""> ViewHel...
Adrian Föder
11:05 Bug #34872 (Resolved): Singleton validators never have their options passed
The @ValidatorResolver@ does not pass options to validators that are singletons:... Karsten Dambekalns
10:53 Feature #9861: Leave logging up and running as long as possible
Christian Mueller wrote:
> Actually the logging is not shutdown at all atm. Maybe we could shut it down after the Bo...
Karsten Dambekalns
10:45 Feature #34867: Allow setting target type in MVC Argument
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9655
Gerrit Code Review
10:30 Feature #34867 (Under Review): Allow setting target type in MVC Argument
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9655
Gerrit Code Review
10:03 Feature #34867 (Resolved): Allow setting target type in MVC Argument
Consider the following use case:... Adrian Föder
10:37 Bug #27721: Permissions of uploaded resources not correct
Christian Mueller wrote:
> Isn't the current state enough with calling fixFilePermissions after move_uploaded_file()...
Karsten Dambekalns
09:54 Feature #34866 (Resolved): Allow fluently working with PropertyMappingConfiguration
Consider the following use case:... Adrian Föder
07:35 Bug #29582 (Closed): you should be able to pass any kind of objects to action methods
Christian Müller

2012-03-14

23:14 Bug #34864 (Rejected): inproper escape of attribute names
hi all,
I named an attribute "order" in my model and thus ran into problems running "./flow3 doctrine:update", sin...
Nicholas Gray
22:21 Bug #26903: Flush Doctrine metadata cache with FLOW3 caches
Metadata is a problem that is probably solved, but proxy classes stay around for too long. I deleted a package and th... Karsten Dambekalns
21:40 Feature #34827: Precompiled reflection data for rather static packages
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
15:51 Feature #34827: Precompiled reflection data for rather static packages
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
15:46 Feature #34827: Precompiled reflection data for rather static packages
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
12:13 Feature #34827 (Under Review): Precompiled reflection data for rather static packages
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9644
Gerrit Code Review
11:46 Feature #34827 (Resolved): Precompiled reflection data for rather static packages
Packages which are usually not touched during development (such as FLOW3, Fluid etc.) don't need to be monitored for ... Robert Lemke
21:40 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
19:15 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 13 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
18:26 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 12 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
15:42 Task #9568: Improve speed of AOP proxy building / reflection
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
13:50 Task #9568 (Under Review): Improve speed of AOP proxy building / reflection
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9623
Gerrit Code Review
19:33 Feature #30256 (Under Review): Package help in CLI
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9653
Gerrit Code Review
19:28 Feature #30256 (Accepted): Package help in CLI
Showing some mercy to Julle ;) Bastian Waidelich
16:38 Feature #30256: Package help in CLI
Nooooo! I still want this :)
The use-case is this: I know I want to use some command in the kickstarter package, but...
Christian Jul Jensen
16:14 Feature #30256: Package help in CLI
Shouldn't we even close this, with the per command help screen we support already? Christian Müller
19:33 Bug #29582: you should be able to pass any kind of objects to action methods
seems easier in java, in php may be with apc then if it is attached to apc is not a good idea to have inside the fram... Fernando Arconada
15:39 Bug #29582: you should be able to pass any kind of objects to action methods
The interesting question is, how is this being called? Christian Müller
19:29 Feature #29258: Provide a way to override classes by environment
not only debugging, maybe you need to introduce a new feature in a live system (you could change the environment in a... Fernando Arconada
15:07 Feature #29258 (Needs Feedback): Provide a way to override classes by environment
I don't really see the need for this. Debugging on a live machine is bad all the time. Maybe we could introduce a con... Christian Müller
18:40 Bug #33191 (Rejected): TypeConverter from string to array
There are other ways to work with your use case. If we create a string to array converter it should actually try to c... Christian Müller
18:36 Feature #34185: SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9622
Gerrit Code Review
18:11 Feature #34185: SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9622
Gerrit Code Review
08:37 Feature #34185: SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9622
Gerrit Code Review
18:29 Task #25923: Clean up session files in compile run
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9633
Gerrit Code Review
18:11 Task #25923: Clean up session files in compile run
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9633
Gerrit Code Review
08:47 Task #25923 (Under Review): Clean up session files in compile run
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9633
Gerrit Code Review
08:43 Task #25923 (Accepted): Clean up session files in compile run
See also #34817 Christian Müller
18:22 Task #32928 (Rejected): Cleanup ControllerContext
I close it due to the Http change from Robert, if it still needs love after we have that chnage we can reopnen a ticket. Christian Müller
18:13 Bug #31683 (Closed): $joinPoint->getMethodArguments() looses the reference of the argument
We have two more tickets for this, see https://review.typo3.org/#/c/9651/ so I close this, please refer to one of the... Christian Müller
18:10 Feature #31484 (Needs Feedback): possibility to modify inner workings of proxy class builder
You could use the ProxyClassBuilder directly to build your models from metadata, maybe that is already enough? Christian Müller
17:46 Feature #31373 (Rejected): Annotation to enforce validation on setter
Christian Müller
17:42 Bug #34837: flow3:cache:flush should care about the .Shortcuts state
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9648
Gerrit Code Review
15:36 Bug #34837 (Under Review): flow3:cache:flush should care about the .Shortcuts state
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9648
Gerrit Code Review
15:05 Bug #34837 (Resolved): flow3:cache:flush should care about the .Shortcuts state
Currently, after renaming a package path (name; from @Foo@ to @Acme.Foo@) manually, @flow3:cache:flush@ resulted in a... Adrian Föder
17:32 Bug #13333 (Under Review): AOP for methods with references do not work.
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9651
Gerrit Code Review
17:32 Bug #30914 (Under Review): Proxy methods for methods with "by reference" return type are broken
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9651
Gerrit Code Review
16:24 Feature #30423: Rendering template of other action without forward
Well, everytime you want to render a template that is not named by the action or you don't want to forward to another... Christopher Hlubek
16:17 Feature #30423: Rendering template of other action without forward
What would be a use-case for this again? Christian Müller
16:05 Feature #9861 (Needs Feedback): Leave logging up and running as long as possible
Actually the logging is not shutdown at all atm. Maybe we could shut it down after the BootstrapShuttingDown Signal? Christian Müller
16:02 Feature #29547: @identity should make property unique in Database
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9647
Gerrit Code Review
16:01 Feature #29547: @identity should make property unique in Database
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9647
Gerrit Code Review
15:21 Feature #29547 (Under Review): @identity should make property unique in Database
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9647
Gerrit Code Review
15:20 Feature #29547 (Accepted): @identity should make property unique in Database
Christian Müller
15:58 Bug #29979 (Under Review): PersistenceManager::getIdentifierByObject() only returns first Id property
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9650
Gerrit Code Review
15:19 Bug #9557 (Rejected): It's possible to persist multiple entities with the same identity properties
I will drop this ticket in favor of #29547 which is more concise in its title. The issue is the same. Christian Müller
15:07 Bug #29271 (Closed): Query setOrdering doesn't work on relations
Christian Müller
14:57 Feature #28399 (Needs Feedback): Validation message and code should be configurable for bundled validators
Well, actually it's not about the output. A validator is a prototype that is configured with options. To differentiat... Christopher Hlubek
14:53 Feature #28399 (Rejected): Validation message and code should be configurable for bundled validators
With the current state of (validation) errors you can pretty much do all that in your output by using the code and ar... Christian Müller
14:52 Bug #28319 (Needs Feedback): Access denied will be logged at the wrong location in nested calls
Should we still keep this then? Christian Müller
14:49 Feature #28074 (Needs Feedback): Provide a shell script that installs Phoenix or FLOW3 from git
As I see on the mailing list you provide such a script already, so I would like to close this ticket as the script it... Christian Müller
14:47 Bug #28016 (Needs Feedback): Cascade remove of cleared ArrayCollection
Is this still the case? From what I see the behavior of remove and clear should be the same. Christian Müller
14:46 Feature #26560: Use reverse index for AOP matching
Okay, the issue would be resolved for me with the new AOP optimizations.
Christian Mueller wrote:
> I will close ...
Christopher Hlubek
14:23 Feature #26560 (Resolved): Use reverse index for AOP matching
I will close this one, the results of the code sprint are tagged with #9568, and should include this optimization too. Christian Müller
14:44 Bug #27721: Permissions of uploaded resources not correct
Isn't the current state enough with calling fixFilePermissions after move_uploaded_file() Christian Müller
14:41 Bug #27379 (Needs Feedback): add check to clear the database at tearDown in testing
For me the current behaviour makes sense, as you want a cleanly defined state for the DB in testing. What would be a ... Christian Müller
14:31 Feature #26950 (Rejected): Add AccessDeniedException Handler
This is handled in the RequestDispatchingAspect and should work. Christian Müller
14:19 Feature #26132 (Closed): FloatToFloatConverter missing in F3\Property\TypeConverter
Indeed it is obsolete. Christian Müller
13:45 Bug #13559 (Needs Feedback): ObjectSerializer failes with persistent objects within arrays
Persistable Objects should best be stored in a Doctrine Collection like the ArrayCollection. Then persistence will pe... Christian Müller
13:41 Bug #11039 (Needs Feedback): Static object container injects properties to result of factory object
Christopher, do you think this is still valid, I did not do an in-deep debugging but looking at current master code, ... Christian Müller
13:31 Feature #34648: Implement a way to authenticate with a file based encrypted key
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
12:32 Bug #9587 (Rejected): ArrayObject cannot be persisted as part of an array
This works with Doctrine Persistence so I will Reject it for now, as we probably won't work on the Generic Persistenc... Christian Müller
11:30 Task #9457 (Rejected): Refactor type-conversion into ...Utility\TypeHandling
It seems to me this is obsolete with the PropertyMapper. Christian Müller
11:20 Bug #7182 (Resolved): Throw an exception if class for annotated dataType is missing
The "new" PropertyMapper catches this error already and gives a resonable message. Christian Müller
10:53 Task #6591 (Rejected): Refactor F3\FLOW3\Log\Backend\FileBackend : getFormattedVarDump
In the meantime the method has changed quite a lot and the limit IMHO makes sense otherwise the output will totally b... Christian Müller
08:49 Task #34817: Have a way to clear all sessions
As the currently proposed change introduces a new method to the SessionInterface I would regard this as breaking chan... Christian Müller
08:42 Task #34817 (Resolved): Have a way to clear all sessions
Christian Müller
08:33 Feature #34816 (New): Long text encryption
It should be possible to encrypt / decrypt a long plain text using the TYPO3\FLOW3\Security\Cryptography\RsaWalletSer... Pankaj Lele
02:41 Bug #34811 (Resolved): Ghost command "getflow3" introduced with recent change
Applied in changeset commit:d8ee47023607e65be59f30ea6c43bc37042f96dd. Karsten Dambekalns

2012-03-13

22:01 Bug #34811 (Under Review): Ghost command "getflow3" introduced with recent change
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9629
Gerrit Code Review
21:57 Bug #34811 (Resolved): Ghost command "getflow3" introduced with recent change
The fix for the "./flow3" invocation hint on Windows introduced a "ghost command" because methods in command controll... Karsten Dambekalns
21:43 Bug #33621 (Needs Feedback): Filebackend reports error when trying to rename file due to concurrent proccesses
Karsten Dambekalns
18:20 Bug #25961 (Under Review): HTML should be escaped in the pre output of DebugExceptionHandler
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9624
Gerrit Code Review
16:43 Feature #34185 (Under Review): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9622
Gerrit Code Review
16:39 Feature #34185 (Accepted): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Karsten Dambekalns
13:13 Bug #3977 (Rejected): TextValidator is insecure
The test improvements are in review now, I will close this, we could decide to deprecate the TextValidator at some po... Christian Müller
12:03 Bug #34134 (Needs Feedback): PropertyMapper throws unnecessary exception
Hi,
could you please try https://review.typo3.org/#/c/9606/ with your environment? I am not sure if that works ou...
Christian Müller
10:55 Feature #34783 (Closed): Provide utility method to get unproxied class name
In some cases, @get_class($object)@ returns the Doctrine proxy class; and not the actual, intended class name.
In ...
Adrian Föder
02:38 Bug #33417 (Resolved): kickstart:package does not update .Shortcuts
Applied in changeset commit:fec2ff945c3b1a73e0811637fe4bb2ecbce8e6df. Christian Müller
02:38 Bug #33789 (Resolved): PersistentObjectConverter may break with < PHP 5.3.4
Applied in changeset commit:a29012b669e90a7e39a4727514538ace5a77eb80. Karsten Dambekalns
02:38 Bug #33048 (Resolved): flow3.bat gives wrong feedback
Applied in changeset commit:7e567e8d38e5a24f052a7da4fa7ae0fd657540e3. Karsten Dambekalns
02:38 Bug #34608 (Resolved): ResourceStreamWrapper::seek gives exactly the wrong bool value
Applied in changeset commit:461bb056be2d6855aa3def46b4dcbe18fca28cd7. Ferdinand Kuhl
02:38 Bug #34620 (Resolved): Wrong return value for getAccessDecisionVoters()
Applied in changeset commit:7e055f0b2c7e2d0f92992afd0c97007b50ef4aac. Bernhard Fischer

2012-03-12

19:02 Feature #27118 (Rejected): Routing: json format should use MIME application/json by default
This has been removed. The JsonView in the FLOW3 package sets the header correctly, you should do the same if you dec... Christian Müller
18:55 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 20 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
09:14 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 19 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
09:13 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 18 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
18:55 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
18:41 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9589
Gerrit Code Review
18:37 Bug #34608: ResourceStreamWrapper::seek gives exactly the wrong bool value
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9587
Gerrit Code Review
18:35 Feature #10524 (Needs Feedback): Support multiple package directories
What speaks against symlinking the Framework directory to your projects? Christian Müller
18:34 Feature #10427 (Resolved): Support inter-type properties for entites
Take a look at Packages/Framework/TYPO3.FLOW3/Classes/Persistence/Aspect/PersistenceMagicAspect.php there we introduc... Christian Müller
18:33 Bug #33932: AOP Proxy Compiler does not handle numeric annotation parameters
Patch set 2 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9584
Gerrit Code Review
18:20 Bug #33932: AOP Proxy Compiler does not handle numeric annotation parameters
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9584
Gerrit Code Review
18:28 Feature #10312 (Rejected): Autogenerate setters and getters
Yep, just use your IDE to generate the getters and setters, then you benefit from code completion. If you don't like... Christian Müller
17:57 Bug #33048: flow3.bat gives wrong feedback
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9582
Gerrit Code Review
16:33 Bug #33048: flow3.bat gives wrong feedback
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
15:49 Bug #33048: flow3.bat gives wrong feedback
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
17:48 Feature #6609 (Closed): Implement joins for queries
With Doctrine we have JOINS, so this is closed. Christian Müller
17:47 Feature #6456 (Closed): Customization/localization of validator errors
Christian Müller
15:26 Bug #33789: PersistentObjectConverter may break with < PHP 5.3.4
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/5992
Gerrit Code Review
13:51 Feature #6121 (Rejected): Add validator and filter for HTML
Christian Müller
13:51 Feature #6121 (Closed): Add validator and filter for HTML
As Bastian said should be checked on output. Christian Müller
13:29 Task #34749: Provide some examples how to nest inline VH's
Adrian Föder wrote:
> I'll take care, fine?
More than fine ;)
Bastian Waidelich
12:27 Task #34749: Provide some examples how to nest inline VH's
that's fine, thanks Bastian; I think the examples from the FAQ could almost be transferred 1:1.
I'll take care, fine?
Adrian Föder
12:07 Task #34749: Provide some examples how to nest inline VH's
Adrian Föder wrote:
> It would be useful to have some more examples how to nest different variables,
> array and Vie...
Bastian Waidelich
11:39 Task #34749 (Resolved): Provide some examples how to nest inline VH's
It would be useful to have some more examples how to nest different variables, array and ViewHelpers; for example, ho... Adrian Föder

2012-03-10

11:32 Bug #33297 (Closed): flow3 package:list throws an error
That matches my expectations to a large degree - sounded like something not really related to our code.
Have fun w...
Karsten Dambekalns
10:18 Bug #33297: flow3 package:list throws an error
Well, i updated apache2, PHP and FLOW3 Versions last weeks and now the error doesnt occur anymore :/
I will try to...
Christopher Seidel

2012-03-09

23:54 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:54 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:34 Bug #33968 (Under Review): Missing privileges to create symlinks in Windows cause exception
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9528
Gerrit Code Review
23:34 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 17 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
22:28 Bug #33417: kickstart:package does not update .Shortcuts
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
16:08 Bug #33417: kickstart:package does not update .Shortcuts
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
16:01 Bug #33417 (Under Review): kickstart:package does not update .Shortcuts
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9518
Gerrit Code Review
18:57 Bug #33297: flow3 package:list throws an error
Could you tell us the used PHP version and the amount of files and directories in this folder? And additionally try a... Christian Müller
18:55 Bug #33297: flow3 package:list throws an error
Maybe a bug in a specific PHP version causing some overflow (Too many open files) when there is a file with #?
Kar...
Christian Müller
16:42 Bug #33158: Problems setting PHP binary path on Windows
thanks for noticing ;-) and fixed the example... :) Rens Admiraal
16:04 Bug #33158: Problems setting PHP binary path on Windows
Rens Admiraal wrote:
> Giovanni: are you sure you've no indent errors in your Settings.yaml? I've a 2008 IIS environ...
Adrian Föder
16:03 Bug #33158: Problems setting PHP binary path on Windows
just as a feedback; in my case also the even worse varation with spaces and backward slashes *works*:... Adrian Föder
15:48 Bug #33158: Problems setting PHP binary path on Windows
Giovanni: are you sure you've no indent errors in your Settings.yaml? I've a 2008 IIS environment using:... Rens Admiraal
09:17 Feature #32106 (Accepted): Support for Object source in PropertyMapper
(I felt free to set to "Accepted" because I think there's enough agree for the need for it)
Sebastian, I read a bi...
Adrian Föder

2012-03-08

19:06 Bug #34675 (Rejected): NotFoundView is not used for missing actions
When an action is missing instead of an exception the NotFoundView should be used. Kira Backes
18:47 Feature #34674 (Accepted): NotFoundView is not injected in ActionController
Should be injected in the ActionController so a user can overwrite it and show its custom NotFoundView when an action... Kira Backes
16:48 Bug #34672 (Needs Feedback): Production context is not working
Makes sense - could the problem be distilled into a functional test? Karsten Dambekalns
15:48 Bug #34672 (Resolved): Production context is not working
When running an application (that uses Collections) in Production context the following exception is thrown:... Kira Backes
10:35 Bug #34466: Roles are not cleared after every test in functional tests
Yes, have the fix already here. Will be pushed together with some content security functional tests... Andreas Förthner

2012-03-07

23:23 Bug #33968: Missing privileges to create symlinks in Windows cause exception
Sure, will have a look at it.
@Richard: could you be so kind to add a note with the exact windows version you use?
Rens Admiraal
23:20 Bug #33158: Problems setting PHP binary path on Windows
Sure, will have a look this week Rens Admiraal
18:41 Bug #33158 (Needs Feedback): Problems setting PHP binary path on Windows
Rens, could you check this? Karsten Dambekalns
22:08 Bug #33024 (Accepted): Exception when validating a float in a Model with the Number validator
Karsten Dambekalns
21:45 Task #29266 (Accepted): Transfer "Introduction" chapter to ReST
The old text can serve as a basis for the "Architectural Overview" section of part 3 of the guide. Karsten Dambekalns
21:39 Bug #33297 (Needs Feedback): flow3 package:list throws an error
I created a file named @#test.html@ in the public resources folder and called @package:list@ - worked fine. I suspect... Karsten Dambekalns
20:55 Bug #33297 (Accepted): flow3 package:list throws an error
Karsten Dambekalns
18:14 Bug #33297: flow3 package:list throws an error
Yes just like:
#test.html
or something similar
Christopher Seidel
17:42 Bug #33297 (Needs Feedback): flow3 package:list throws an error
Could you give me some more details to reproduce this? Like an offending filename? Thanks! Karsten Dambekalns
21:12 Bug #33048 (Under Review): flow3.bat gives wrong feedback
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9476
Gerrit Code Review
18:44 Bug #33139 (Accepted): Confusing error message if a CommandController is outside /Controller/ directory
Karsten Dambekalns
18:43 Bug #34545 (Accepted): Hint at wrong usage of @ORM\MappedSuperclass not displayed
Karsten Dambekalns
17:47 Bug #34466 (Accepted): Roles are not cleared after every test in functional tests
Andi, I set this to accepted - right? Karsten Dambekalns
17:46 Bug #34448 (Accepted): Integrity constraint violation on FLOW3 resource tables
Karsten Dambekalns
17:34 Feature #34648: Implement a way to authenticate with a file based encrypted key
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
17:27 Feature #34648 (Under Review): Implement a way to authenticate with a file based encrypted key
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9461
Gerrit Code Review
17:23 Feature #34648 (Resolved): Implement a way to authenticate with a file based encrypted key
For the setup wizard we need a file based encryped key provider. For this we need a password token which only has a p... Aske Ertmann
17:21 Bug #32574 (Accepted): FLOW3 enters fork bombs when using cgi-fcgi vs cli
Karsten Dambekalns
17:13 Bug #27232 (Needs Feedback): Create unit test for "Original Request must only be set if there is a validation error"
Robert, is this still a valid issue considering your MVC refactoring? Feel free to close, if not :) Karsten Dambekalns
17:10 Bug #32827 (Closed): TYPO3\FLOW3\Exception thrown in file Bootstrap.php
Considered as fixed. Karsten Dambekalns
17:08 Feature #34177: Make Resource use with file operations easier
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9145
Gerrit Code Review
17:08 Bug #29694 (Under Review): \TYPO3\FLOW3\Resource\Resource is missing the __toString Method
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9145
Gerrit Code Review
16:45 Bug #34050 (Accepted): DatetimeParser code documentation is wrong
Karsten Dambekalns
16:39 Bug #34527 (Accepted): Add method in repositories does also update
Right, Doctrine doesn't differentiate between add and update in it's API. So we'd need to do this "on our side". Karsten Dambekalns
16:36 Bug #33145 (Accepted): Annotation parser for interfaces gets confused
Karsten Dambekalns
16:35 Bug #27378 (Accepted): JsonView not testable view \F3\FLOW3\Tests\FunctionalTestCase->sendWebRequest
Assigning to Robert as the MVC refactoring should solve this "along the way". Karsten Dambekalns
16:33 Task #33268 (Resolved): Document new YAML behaviour for Upgrade to 1.1
Karsten Dambekalns
16:22 Feature #33937 (Accepted): Convenience method to resolve public "resource://" paths
Karsten Dambekalns
16:15 Feature #33937: Convenience method to resolve public "resource://" paths
Ok, here's the ViewHelper which needed this:... Bastian Waidelich
16:20 Task #33040 (Rejected): rename the default controller as DefaultController
This change would affect *all* users and require adjustment of *all* standard controllers. The advantage is unclear, ... Karsten Dambekalns
16:10 Feature #30256 (On Hold): Package help in CLI
Karsten Dambekalns
16:07 Feature #31788 (Rejected): [PERFORMANCE] cache implementation for AnnotationReader in Flow3AnnotationDriver
Recent improvements have shown the caching we have in place does the job. Karsten Dambekalns
16:06 Feature #33058 (Rejected): Choice for XML Configuration
Our approach to keeping things simple means: one configuration format is enough. Especially if not knowing YAML is th... Karsten Dambekalns
16:05 Feature #32607: Export localized strings for JS consumption
Maybe this could be achieved with a ViewHelper:... Bastian Waidelich
15:59 Feature #32607 (Needs Feedback): Export localized strings for JS consumption
It would be nice to have this in 1.1 - but I need input from the JS folks on this! Karsten Dambekalns
16:00 Task #32606 (Accepted): Provide conventions for ids in XLIFF files
Karsten Dambekalns
15:35 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 16 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
14:39 Bug #34407 (Resolved): NotFoundView should "throw" 404
Applied in changeset commit:ca5b3b9a535ff29a4e34c70bbeb68612d135b0f1. Adrian Föder
14:30 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
14:01 Bug #34620: Wrong return value for getAccessDecisionVoters()
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
00:34 Bug #34620 (Under Review): Wrong return value for getAccessDecisionVoters()
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9430
Gerrit Code Review
00:19 Bug #34620 (Resolved): Wrong return value for getAccessDecisionVoters()
The return value of the function getAccessDecisionVoters() in the AccessDecisionVoterManager should return a array. I... Bernhard Fischer

2012-03-06

20:02 Bug #34608 (Under Review): ResourceStreamWrapper::seek gives exactly the wrong bool value
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9427
Gerrit Code Review
19:54 Bug #34608 (Resolved): ResourceStreamWrapper::seek gives exactly the wrong bool value
The ResourceStreamWrapper does:
@return fseek($this->handle, $offset, $whence);@
The documentation to fseek say...
Ferdinand Kuhl
16:28 Bug #34555: StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Karsten Dambekalns wrote:
> > If I get it right, this means that the streamWrapper is only instantiated the *first...
Bastian Waidelich
15:25 Bug #34555: StreamWrapperAdapter::stream_lock does not return StreamWrapper result
Bastian Waidelich wrote:
> If I get it right, this means that the streamWrapper is only instantiated the *first* tim...
Karsten Dambekalns
12:30 Bug #34555 (Resolved): StreamWrapperAdapter::stream_lock does not return StreamWrapper result
While writing unit tests for the StreamWrapperAdapter, I came upon this issue: @StreamWrapperAdapter::stream_lock()@ ... Bastian Waidelich
15:12 Bug #34134: PropertyMapper throws unnecessary exception
That solution still has a flaw, I can’t see all validation errors no more, because the object validation is missing n... Kira Backes
15:10 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
Karsten Dambekalns
15:01 Bug #34547 (Under Review): wrong variable name inside rename() of StreamWrapperAdapter
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9420
Gerrit Code Review
14:38 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
Applied in changeset commit:fe76887f75aa80b82be3104ef1f51e065dd774f0. Bernhard Fischer
08:59 Bug #34547 (Under Review): wrong variable name inside rename() of StreamWrapperAdapter
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9405
Gerrit Code Review
08:35 Bug #34547 (Resolved): wrong variable name inside rename() of StreamWrapperAdapter
The rename function uses the variable $path which should be $path_from. No error occurred so far because the rename f... Bernhard Fischer
13:45 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 15 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
08:49 Feature #34185 (Under Review): SignalSlot Dispatcher should check if Slot method is declared static and act accordingly
Gerrit Code Review
02:38 Bug #33973 (Resolved): Duplicate error id used in StringValidator
Applied in changeset commit:e1f1478eba905740584e9990a68cbf6b7d4c0b4c. Karsten Dambekalns
02:38 Bug #33645 (Resolved): Wrong return value getPasswordHashingStrategyAndIdentifier()
Applied in changeset commit:999b95082c1b5695f698a7f640e9eeaec51d9231. Karsten Dambekalns

2012-03-05

21:28 Bug #33645: Wrong return value getPasswordHashingStrategyAndIdentifier()
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8826
Gerrit Code Review
19:37 Bug #34545 (Resolved): Hint at wrong usage of @ORM\MappedSuperclass not displayed
Doctrine 2 allows usage of @MappedSuperclass without @Entity, but in FLOW3 @Entity annotation is necessary. That's wh... Ondrej Hatala
19:20 Bug #33719: .Shortcuts symlinks use absolute path
Patch set 14 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/8868
Gerrit Code Review
18:18 Bug #34407: NotFoundView should "throw" 404
Karsten, the NotFoundController way isn't involved in every NotFoundView invokation; the NotFoundView is used every t... Adrian Föder
16:57 Bug #34407: NotFoundView should "throw" 404
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
16:52 Bug #34407: NotFoundView should "throw" 404
Under what circumstances is this needed - the NotFoundController sets the status to 404, so out of the box it works a... Karsten Dambekalns
17:27 Bug #33973: Duplicate error id used in StringValidator
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9387
Gerrit Code Review
11:26 Bug #34527 (Resolved): Add method in repositories does also update
The add method in repositores does also update existing entities, this is a dangerous security flaw, as it allows an ... Kira Backes
08:53 Major Feature #33258: Implement support for Assetic
Hi Sebastian,
indeed I thought about it in "idle time" ;-), I'll write down a few things.
Basically, the design...
Adrian Föder

2012-03-02

16:00 Bug #34466 (Resolved): Roles are not cleared after every test in functional tests
If you do not call authenticateRoles() in one test this will not end in no roles being authenticated as expected. Ins... Andreas Förthner
15:57 Feature #34464 (Resolved): Content security acls should follow the same concept as method security acls
Currently method security acls follow a whitelist approach and content security acls follow a blacklist approach. Thi... Andreas Förthner

2012-03-01

17:01 Bug #34448 (Resolved): Integrity constraint violation on FLOW3 resource tables
I have an own model/class/controller, called "award" with a property mapped to the standard FLOW3 resource table.
...
Jonas
14:35 Feature #34414: JsonView's _exposeObjectIdentifier configurable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9297
Gerrit Code Review
02:38 Bug #33698 (Resolved): ObjectAccess::setProperty must work with numeric indexes
Applied in changeset commit:d473ee2f0e9409959b594d1198bd4d225d8b367c. Sebastian Kurfuerst
02:38 Bug #33460 (Resolved): Missing function visiblity declarations
Applied in changeset commit:95e0ca4941f447f898f84298e529a78c44976dc3. Karsten Dambekalns
02:38 Task #34304 (Resolved): Add abstract classes for entrypoint, provider & token in security authentication
Applied in changeset commit:2a7a67fca12db09aa970549f36b34a50446d4a26. Anonymous
02:38 Bug #34399 (Resolved): Remove Default Authentication Provider configuration
Applied in changeset commit:3f288553a845c904596dd51454cbc90a3e89e06d. Sebastian Kurfuerst
02:38 Bug #33311 (Resolved): AuthenticationProviderManager::isAuthenticated does not work in authentication request
Applied in changeset commit:27f00f62768c2b322e87d815e5bef9f5bd2bb2ea. Christian Müller
02:38 Bug #34423 (Resolved): Missing $context member declaration in ObjectManager
Applied in changeset commit:74838ac1f5e96f097aac0addaad89940c10b766f. Bastian Waidelich

2012-02-29

23:49 Bug #31677: Using current.securityContext Policies.yaml entities section triggers Parser Error
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/6596
Gerrit Code Review
23:48 Task #34426 (Under Review): How to receive the correct class name for an object?
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9312
Gerrit Code Review
23:09 Task #34426 (Resolved): How to receive the correct class name for an object?
Currently there is no helper method to find the correct class name of a given object. The reflection service should p... Andreas Förthner
18:24 Bug #34423 (Under Review): Missing $context member declaration in ObjectManager
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9174
Gerrit Code Review
18:22 Bug #34423 (Resolved): Missing $context member declaration in ObjectManager
The ObjectManager refers to $this->context which doesn't exist. Karsten Dambekalns
18:07 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9302
Gerrit Code Review
17:55 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9260
Gerrit Code Review
17:27 Bug #34399: Remove Default Authentication Provider configuration
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
17:17 Bug #34399: Remove Default Authentication Provider configuration
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
16:56 Task #8923: Provide a Nginx Server Configuration for FLOW3
I had to modify the resource url regexp like this to get it working:... Martin Brüggemann
16:12 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
13:43 Feature #34414 (Under Review): JsonView's _exposeObjectIdentifier configurable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9297
Gerrit Code Review
13:11 Feature #34414 (Resolved): JsonView's _exposeObjectIdentifier configurable
The configuration setting for the MVC JsonView allows exposing an object's persistence identifier.
Currently, that c...
Adrian Föder
11:23 Bug #34408 (Closed): CollectionValidator goes in endless recursion
Duplicate of #34154 with fix under review at http://review.typo3.org/9180 Karsten Dambekalns
10:24 Bug #34408 (Closed): CollectionValidator goes in endless recursion
This is a case when 2 domain objects are associated with ManyToMany relation. If the owning side object is created/up... Pankaj Lele
11:20 Bug #32959: Exception thrown on missing role definition
Andi, I think some better error checking would be helpful here, to detect missing/wrong role names. Karsten Dambekalns
11:08 Bug #34018 (Closed): Annotation with a numeric value is not correctly generated
This is a duplicate of #33932 and a fix is under review at https://review.typo3.org/9125 Karsten Dambekalns
10:35 Bug #34407: NotFoundView should "throw" 404
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
10:09 Bug #34407 (Under Review): NotFoundView should "throw" 404
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9296
Gerrit Code Review
10:05 Bug #34407 (Resolved): NotFoundView should "throw" 404
The NotFoundView currently sends itself out with HTTP status 200, saying it was a 404 error. It should instead say 40... Adrian Föder
01:12 Bug #34404 (New): JsonView transformObject does not respect _descendAll configuration
When configuring a jsonView for a domain object, the '_descendAll' configuration is currently not taken into account,... Alexander Berl

2012-02-28

23:12 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
23:08 Bug #33460 (Under Review): Missing function visiblity declarations
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9293
Gerrit Code Review
22:19 Bug #33460 (Accepted): Missing function visiblity declarations
FrontendInterface should be public, Route protected (as noted above), the Name fixture public. The others are anonymo... Karsten Dambekalns
22:52 Bug #34399 (Under Review): Remove Default Authentication Provider configuration
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9290
Gerrit Code Review
22:49 Bug #34399 (Resolved): Remove Default Authentication Provider configuration
The default authentication provider was always configured at the first position and could not be removed; which lead ... Sebastian Kurfuerst
02:43 Bug #34110 (Resolved): Proxy Class strips off Class Doc Comments
Applied in changeset commit:899eb3f37229244f2938f84d52c655b80c91d759. Bastian Waidelich

2012-02-27

22:48 Task #34304: Add abstract classes for entrypoint, provider & token in security authentication
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9242
Gerrit Code Review
19:29 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9262
Gerrit Code Review
19:24 Bug #33311: AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9261
Gerrit Code Review
19:23 Bug #33311 (Under Review): AuthenticationProviderManager::isAuthenticated does not work in authentication request
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/9260
Gerrit Code Review
17:35 Bug #32629 (Closed): globalObjects are not available in the security (current.securityContext.party)
Duplicate of issue #31677 Karsten Dambekalns
17:17 Bug #34110: Proxy Class strips off Class Doc Comments
Patch set 1 for branch *FLOW3-1.0* has been pushed to the review server.
It is available at http://review.typo3.org/9256
Gerrit Code Review
02:55 Bug #34293 (Resolved): Typo in TYPO3\FLOW3\Session\Aspect\SessionObjectMethodsPointcutFilter::matches()
Applied in changeset commit:55150fe526b60d0200b6afd40731b8c36cef1bc4. Johannes K
 

Also available in: Atom