Activity

From 2012-08-27 to 2012-09-25

2012-09-25

23:35 Bug #41369 (Resolved): Web/.htaccess is not installed
Applied in changeset commit:987b91a89a4c1792ed5c7b88887147758f189a2c. Karsten Dambekalns
22:37 Bug #41369 (Under Review): Web/.htaccess is not installed
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15065
Gerrit Code Review
22:35 Bug #41369 (Resolved): Web/.htaccess is not installed
With composer the @Web/.htaccess@ file is not installed. Karsten Dambekalns
22:37 Revision 987b91a8: [BUGFIX] Add .htaccess file to installed files
Change-Id: I480abc8d12a2406ffecea66357462bf28eb2dd1c
Fixes: #41369
Releases: 1.2
Karsten Dambekalns
22:33 Revision d3039191: [TASK] Update settings to new name of installer package
Change-Id: I1dcab45f5644a535fb8eedafaa48e3efb711e2b8
Related: #41031
Releases: 1.2
Christian Jul Jensen
22:22 Revision 0ea33a38: [TASK] Update class exclusion to changed composer installer name
The installer change it's package key from christianjul.installers to
flow3.composerinstallers so the exclusion needs...
Karsten Dambekalns
18:52 Revision 125ff016: [TASK] Change dependency to require flow3/composer-installers
Change-Id: I09a8d1a7808004eeabe50176bf04359659c2a980 Christian Jul Jensen
15:17 Feature #41358 (Resolved): Allow class/interface constants in configuration directives
currently, only "raw" plain PHP constants can be used in YAML files, like @%FLOW3_PATH_FLOW3%@.
IMHO nothing speaks ...
Adrian Föder
14:32 Revision 947608e4: [TASK] Use composer version of installer
Change-Id: Ib9f41406fd4672f2ced3fdf7174a6aca1c529b7c Christian Jul Jensen
13:48 Revision 9a68c0eb: [TASK] Require christianjul/installers directly
Change-Id: I9bed033db14d0f1005c65ffe99d135c5e56e81fc
Related: #41031
Releases: 1.2
Karsten Dambekalns
11:20 Bug #41091 (Resolved): PackageManagerTest::createPackageThrowsExceptionForExistingPackageKey fails with composer changes
Karsten Dambekalns
11:19 Feature #37727 (Resolved): Make Package.php optional
Karsten Dambekalns
11:19 Task #41310 (Resolved): Web/index.php is not installed
Karsten Dambekalns
11:19 Bug #41157 (Resolved): TYPO3.FLOW3.object.excludeClasses gives fatal error if a configuration exists for a non-installed package
Karsten Dambekalns
11:19 Bug #41181 (Resolved): Package->getClassesPath returns path without trailing slash
Karsten Dambekalns
11:19 Bug #41334 (Resolved): Handle missing type in composer manifest gracefully
Karsten Dambekalns
11:17 Revision eb9b140d: Merge "[BUGFIX] Handle missing composer type gracefully"
Karsten Dambekalns
10:39 Revision c516af3e: Merge "[!!!][TASK] Add utility to get classes namespace entry-point"
Karsten Dambekalns
10:39 Revision b71202ea: Merge "[BUGFIX] Allow excludeClasses setting for non-installed package"
Karsten Dambekalns
10:39 Revision a8bfe8e4: Merge "[BUGFIX] getClassesPath() returns path without trailing slash"
Karsten Dambekalns
10:38 Revision 508fa374: Merge "[TASK] Install "Web/index.php" on Composer install"
Karsten Dambekalns
10:25 Revision 37492ff2: [TASK] Test commit for composer install
Change-Id: Ife0cd551a4aa853c88a3bc40850a34f93e7354b6 Christian Jul Jensen
10:01 Revision e3f9f13d: [TASK] Change requirement to real composer installer
Also drop require-dev - only valid for root manifests
Change-Id: I45e2fd8bc08e72cf551399a610902c00df4d339f
Christian Jul Jensen
08:30 Bug #27798: CSRF protection not working for forms in a plugin
Sorry stupid question...
I've deleted it.
David Sporer

2012-09-24

22:58 Bug #41334 (Under Review): Handle missing type in composer manifest gracefully
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15013
Gerrit Code Review
22:58 Bug #41334 (Resolved): Handle missing type in composer manifest gracefully
Karsten Dambekalns
22:58 Revision cb870e17: [BUGFIX] Handle missing composer type gracefully
The type in a composer manifest is optional, so we need to check for it's
existence before we use it.
Change-Id: Iea...
Karsten Dambekalns
22:41 Bug #41181: Package->getClassesPath returns path without trailing slash
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15000
Gerrit Code Review
15:18 Bug #41181 (Under Review): Package->getClassesPath returns path without trailing slash
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15000
Gerrit Code Review
22:41 Bug #41157: TYPO3.FLOW3.object.excludeClasses gives fatal error if a configuration exists for a non-installed package
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15001
Gerrit Code Review
15:51 Bug #41157 (Under Review): TYPO3.FLOW3.object.excludeClasses gives fatal error if a configuration exists for a non-installed package
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15001
Gerrit Code Review
22:40 Task #41310: Web/index.php is not installed
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15005
Gerrit Code Review
17:24 Task #41310 (Under Review): Web/index.php is not installed
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15005
Gerrit Code Review
12:05 Task #41310 (Resolved): Web/index.php is not installed
With composer the @Web/index.php@ script is not installed. Karsten Dambekalns
22:40 Revision 0f8b4d2f: [TASK] Install "Web/index.php" on Composer install
Change-Id: Ib8634b8b4f10f73d6e8a57d6f11f0afa077e8155
Fixes: #41310
Releases: 1.2
Christian Jul Jensen
22:37 Revision 1594a523: [!!!][TASK] Add utility to get classes namespace entry-point
With PSR-0 the entry-point of the classes files needs prefixing of the
pathified namespace. Add a getter, getClassesN...
Christian Jul Jensen
22:29 Revision a952d97f: [BUGFIX] Allow excludeClasses setting for non-installed package
Change-Id: Ibdbb843d9e59d575d05ce7088c5dddca843e2be0
Fixes: #41157
Releases: 1.2
Christian Jul Jensen
22:28 Revision 1925ba31: [BUGFIX] getClassesPath() returns path without trailing slash
Change-Id: I354be2ef635cc384aa7244c812e1fd80a07dab35
Fixes: #41181
Releases: 1.2
Christian Jul Jensen
12:35 Bug #41088 (Resolved): PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Applied in changeset commit:94761514bd3fac7bd48884569ed538cc7b8f7139. Christian Jul Jensen
11:41 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
12:35 Bug #41093 (Resolved): PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Applied in changeset commit:91e1881846a9aef69a46cb7713927208b0d0b1ce. Christian Jul Jensen
11:41 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
12:35 Bug #41092 (Resolved): PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Applied in changeset commit:91e1881846a9aef69a46cb7713927208b0d0b1ce. Christian Jul Jensen
11:41 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:28 Revision 5950a764: [FEATURE] Add moveFile() and deleteFile() operations to migrations
Code migrations now can use deleteFile() and moveFile() to work on
files.
Change-Id: I66ecfc324ab32de16d348ab92b0988...
Karsten Dambekalns
11:28 Revision 2e2d98f6: [FEATURE] Isolate migrations and provide package data
With this change migrations have access to the data of the target
package (the package currently being migrated) and ...
Karsten Dambekalns
11:28 Revision 61302517: [TASK] Add code migration to "composerify" a package
The migration moves all class files into a PSR-0 compatible directory
structure and adds a composer manifest; Package...
Karsten Dambekalns
11:28 Revision 6e88cac9: [TASK] Exclude specific classes from object management
In order to exclude classes from object management - either for performance
or compatibility reasons - create a confi...
Christian Jul Jensen
11:28 Revision 6fdd8553: [TASK] Make package management use Composer
Refactor package management to use Composer, also relax constraints in order
to utilize 3rd party composer / PSR-0 co...
Christian Jul Jensen
11:28 Revision 94761514: [BUGFIX] PackageStates.php does not contains relative paths
Change-Id: Ia3c6f6b932909848c4d7d6bd83127115ec67739b
Fixes: #41088
Releases: 1.2
Christian Jul Jensen
11:28 Revision 91e18818: [BUGFIX] Fix failing tests in package management
Change-Id: I3470ec9eabe73596854cd52c7b2a31e6a76a22b9
Fixes: #41092
Fixes: #41093
Releases: 1.2
Christian Jul Jensen
11:28 Revision ef342614: [TASK] Update unit tests to vfsStream > 1.0
This adds "mikey179/vfsStream" to composer.json and adjusts the unit
tests to the new vfsStream API.
Change-Id: Ifad...
Karsten Dambekalns
11:28 Revision 9b9e92b1: [TASK] Fix PSR-0 compatibility for functional tests
Change-Id: Ia621032e73ef77fc8a8529ae13bd1ae5e5a4b0cd
Related: #41031
Releases: 1.2
Christian Jul Jensen
11:28 Revision bdc5a0ef: [FEATURE] Make metadata available to migrations
This makes metadata from Package.xml and composer.json available
to migrations.
Change-Id: Icda4c3590bf9f3d468faee1c...
Karsten Dambekalns
11:28 Revision 6a5d4d75: [!!!][TASK] Move all classes to PSR-0 compatible path
In order to be fully PSR-0 compatible the path below the classes
directory should now be in a path identical to the n...
Christian Jul Jensen
11:28 Revision 5c1bde47: [TASK] Update referenced paths to reflect PSR-0 paths
See Idad621923ffccdb7b2742d9aba0ff22fdab3e192 for the files being moved.
Change-Id: Ie13b438c0c5d3b0e6616ca56bd32bcd...
Christian Jul Jensen
11:28 Revision f227c309: [TASK] Add composer manifest
Change-Id: I84ca5b28dcdc82aa4d74a1cec5f22bab40b51820
Related: #41031
Releases: 1.2
Christian Jul Jensen
11:28 Revision f9b09a91: [TASK] Add Composer installer script and resources
Upon running 'install' or 'update' with composer, required paths
and files outside of TYPO3.FLOW3 package must be cre...
Christian Jul Jensen
11:28 Revision b811e147: [TASK] Handle exceptions thrown in ClassReflection
When a class cannot be loaded for reflection, it will be ignored and a message
is logged.
This makes sure that class...
Christian Jul Jensen
11:03 Feature #37727 (Under Review): Make Package.php optional
Fixed by: https://review.typo3.org/#/c/14686/ Christian Jul Jensen
10:59 Bug #41091 (Under Review): PackageManagerTest::createPackageThrowsExceptionForExistingPackageKey fails with composer changes
Solved by https://review.typo3.org/#/c/14770/ Christian Jul Jensen
09:24 Feature #41301 (Under Review): Allow action-method-dependent errorAction
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14972
Gerrit Code Review
09:21 Feature #41301 (Rejected): Allow action-method-dependent errorAction
currently, there's only one errorAction for all errors, no matter what action actually has been invoked.
This will...
Adrian Föder

2012-09-23

15:58 Feature #41297 (Rejected): Add a way to extends the Account security model
Currently it's not possible to extend the \TYPO3\FLOW3\Security\Account. I try to use the same configuration as in th... Dominique Feyer

2012-09-22

13:48 Bug #41252 (Closed): Object Route Part to Integer ID generates dash in URL
I have a model that has an ID property that is configured like:... Mario Rimann

2012-09-21

22:47 Revision 44f445d6: [TASK] Clarify parent request type in docblocks
Instead of just "object" this uses a more specific type in a few
docblocks ("ActionRequest|HttpRequest").
Change-Id:...
Karsten Dambekalns
22:46 Revision 5c88d9dc: Merge "[TASK] Clarify parent request type in docblocks"
Karsten Dambekalns
17:35 Feature #41136 (Resolved): Convenience function for registering routes in functional tests
Applied in changeset commit:6562a48e802265d404f1d80c6154a2280b122aa9. Robert Lemke
17:35 Feature #41137 (Resolved): Allow rendering of links without csrf protection token
Applied in changeset commit:2058a64d73c74a6a647115af95112fa05039bfeb. Robert Lemke
17:12 Feature #41137: Allow rendering of links without csrf protection token
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14793
Gerrit Code Review
17:03 Feature #41137: Allow rendering of links without csrf protection token
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14793
Gerrit Code Review
17:12 Revision 2058a64d: [FEATURE] Provide flag for disabling link protection in UriBuilder
This introduces a new flag for the UriBuilder which allows to configure
if a link built by the UriBuilder may be modi...
Robert Lemke
16:44 Bug #41181 (Resolved): Package->getClassesPath returns path without trailing slash
This behaviour breaks the API. Also question is if it should append namespaced path.
Christian Jul Jensen
16:11 Bug #41169 (Closed): Routing Cache caches csrf protection tokens
If you look at the saved urls in routing cache files you will see that csrf protection tokens are cached in there, wh... Christian Müller
12:46 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
11:51 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
11:41 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
10:11 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
09:56 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
09:39 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
12:46 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:51 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:41 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
10:11 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
09:56 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
09:39 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
12:46 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:51 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:41 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
10:11 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
09:56 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
09:39 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
11:52 Bug #41157 (Resolved): TYPO3.FLOW3.object.excludeClasses gives fatal error if a configuration exists for a non-installed package
Christian Jul Jensen
10:10 Bug #41148 (New): Converting of ValueObjects
having a Model "Category" as a valueObject and want to display Articles having this Category assigned the mapping fai... Carsten Bleicker
10:03 Bug #41146 (Resolved): Query with setOffset returns count() = 0
f.e. in the paginateController: Line# 72:
.....
$query = $this->objects->getQuery();
$query->setLimit($itemsPe...
Carsten Bleicker

2012-09-20

23:43 Bug #41088: PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
21:48 Bug #41088 (Under Review): PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14769
Gerrit Code Review
10:10 Bug #41088 (Resolved): PackageManagerTest::packageStatesConfigurationContainsRelativePaths fails in Composer branch
Christian Jul Jensen
23:43 Bug #41093: PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
21:48 Bug #41093 (Under Review): PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
10:48 Bug #41093 (Resolved): PackageManagerTest::deletePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Probably related to failing CreatePackage tests Christian Jul Jensen
23:43 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
21:48 Bug #41092: PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
15:56 Bug #41092 (Under Review): PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14770
Gerrit Code Review
10:47 Bug #41092 (Resolved): PackageManagerTest::deactivatePackageThrowsAnExceptionIfPackageIsProtected fails in composer branch
Probably related to the failing CreatePackage tests Christian Jul Jensen
22:52 Feature #41137 (Under Review): Allow rendering of links without csrf protection token
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14793
Gerrit Code Review
22:44 Feature #41137 (Resolved): Allow rendering of links without csrf protection token
Currently there is no way to render a link without a token when authenticated even if the action you link to is avail... Christian Müller
22:52 Feature #41136 (Under Review): Convenience function for registering routes in functional tests
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14792
Gerrit Code Review
22:19 Feature #41136 (Resolved): Convenience function for registering routes in functional tests
The functional testcase should provide a registerRoute() method. Robert Lemke
22:44 Revision 6562a48e: [FEATURE] Convenience function for registering routes in functional tests
This adds a new convenience function registerRoute() to the functional
base testcase.
Change-Id: I5fe2f7b9b75f1d2859...
Robert Lemke
17:39 Bug #40003: FLOW3 not working on PHP 5.3.16
I'm experiencing the same problem on Extbase in TYPO 4.5.19;
will this fix be merged into Extbase as well?
Thomas Deinhamer
10:43 Bug #41091 (Resolved): PackageManagerTest::createPackageThrowsExceptionForExistingPackageKey fails with composer changes
createPackage needs to be adapted to interface changes Christian Jul Jensen

2012-09-19

10:35 Bug #41046 (Resolved): Debugger crashes when coming upon Closure variable
Applied in changeset commit:15d38605eb1e2597357ef0705cf70bf8303f97bb. Adrian Föder
10:14 Bug #41046: Debugger crashes when coming upon Closure variable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14708
Gerrit Code Review
10:14 Revision 15d38605: [BUGFIX] Debugger now respects possible occurence of Closures
A trial isset() call for a property of a Closure resulted in a PHP
error saying "Closure objects cannot have properti...
Adrian Föder
09:52 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review
09:24 Feature #40555: Missing command arguments parameter in Core\Booting\Scripts::executeCommand()
I'm sorry I can't understand the adjustment for the third parameter.
In my solution I added a fourth parameter for t...
Timo Kiefer
09:21 Bug #41048: AbstractAuthenticationController namespace does not match folder structure
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14713
Gerrit Code Review
09:18 Feature #39839 (Resolved): Provide abstract authentication controller
Karsten Dambekalns

2012-09-18

22:30 Bug #28862: Inconsistent handling of roles as objects and strings in Account
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13868
Gerrit Code Review
12:54 Bug #28862: Inconsistent handling of roles as objects and strings in Account
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13868
Gerrit Code Review
21:13 Revision e1f227cb: [TASK] Adjust CsrfProtectionAspect unit test
Change-Id: I779d57aeab8cf01f198cadd85d63062be89235cd
Related: #40984
Releases: 1.2
Karsten Dambekalns
20:35 Bug #40984 (Resolved): CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
Applied in changeset commit:4574114c6c3e56be84b214c7993da87f036b18b4. Christian Müller
20:29 Revision 3996ee78: Merge "[BUGFIX] Cleanup CSRF protection issues"
Christian Müller
19:53 Bug #41048: AbstractAuthenticationController namespace does not match folder structure
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14713
Gerrit Code Review
19:52 Bug #41048 (Under Review): AbstractAuthenticationController namespace does not match folder structure
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14713
Gerrit Code Review
19:51 Bug #41048 (Rejected): AbstractAuthenticationController namespace does not match folder structure
The namespace in AbstractAuthenticationController does not the directory path and thus makes the autoloader fail. Christian Jul Jensen
18:15 Bug #41046 (Under Review): Debugger crashes when coming upon Closure variable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14708
Gerrit Code Review
17:52 Bug #41046 (Resolved): Debugger crashes when coming upon Closure variable
consider just... Adrian Föder
10:35 Task #40989 (Resolved): Autoloader in ClassReflection is not unregistered if reached
Applied in changeset commit:dfc34e543391eab3aad5fd210eefe27050f2393a. Christian Jul Jensen
10:31 Task #40989: Autoloader in ClassReflection is not unregistered if reached
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14654
Gerrit Code Review
10:29 Revision dfc34e54: [BUGFIX] Make sure autoloader is always unregistered
ClassReflection adds an autoloader to catch cases of unresolved
classes. This autoloader needs to be unregistered rel...
Christian Jul Jensen
09:27 Bug #41029 (Accepted): Method security is also evaluating abstract classes
I want to secure all controllers in my vendor namespace except controllers named LoginController, for that I use the ... Rens Admiraal

2012-09-17

23:06 Bug #40984: CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14655
Gerrit Code Review
23:05 Bug #40984: CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14655
Gerrit Code Review
12:56 Bug #40984: CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14655
Gerrit Code Review
12:00 Bug #40984 (Under Review): CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14655
Gerrit Code Review
10:46 Bug #40984 (Resolved): CsrfProtectionAspect fails with paginate view helper and empty f:link action argument
When Paginate ViewHelper is used in any template FLOW3 fails while adding Csrf token to the pagination links. It fail... Pankaj Lele
23:06 Revision 4574114c: [BUGFIX] Cleanup CSRF protection issues
Change-Id: I83536f1edbdc259eec89b9c31b516c2cbc947268
Fixes: #40984
Releases: 1.2
Christian Müller
14:24 Task #40989: Autoloader in ClassReflection is not unregistered if reached
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14654
Gerrit Code Review
12:26 Task #40989: Autoloader in ClassReflection is not unregistered if reached
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14654
Gerrit Code Review
11:58 Task #40989 (Under Review): Autoloader in ClassReflection is not unregistered if reached
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14654
Gerrit Code Review
11:53 Task #40989 (Resolved): Autoloader in ClassReflection is not unregistered if reached
The autoloader in ClassReflection that throws an exception if reached - indicating that a file could not be properly ... Christian Jul Jensen
11:18 Revision a081efa6: [TASK] Clarify parent request type in docblocks
Instead of just "object" this uses a more specific type in a few
docblocks ("ActionRequest|HttpRequest").
Change-Id:...
Karsten Dambekalns
11:11 Revision d9b71a65: [TASK] Whitespace fix in class docblock
Change-Id: Ib47c50259a2066a389ccdc44a22a1534b8d124dd
Releases: 1.2
Karsten Dambekalns

2012-09-14

12:35 Bug #40661 (Resolved): The PropertyMapper can still choke on compositeTypes like collection<entity>
Applied in changeset commit:4168539bb817cf17d0a17bff562c4d2694ada3e6. Marc Neuhaus
12:00 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:00 Revision 4318dbd4: [BUGFIX] Parse target type before comparing the instance with it
The PropertyMapper chokes on already converted Objects if the targetType
is a compositeType like Collection<Entity>.
...
Marc Neuhaus
11:56 Revision 5a2ffa47: Merge "[BUGFIX] Parse target type before comparing the instance with it"
Karsten Dambekalns
10:04 Bug #40824: Modified action controller methods not detected properly
So reflection data and DI proxy are rebuilt, could it be some security cache needs to be flushed as well? Karsten Dambekalns

2012-09-13

17:35 Bug #40890 (Resolved): Display error message if Data is not writeable
Applied in changeset commit:939181e9b8e78d8c8304c5d04cc275fb55d2c226. Robert Lemke
16:07 Bug #40890: Display error message if Data is not writeable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14577
Gerrit Code Review
11:18 Bug #40890 (Under Review): Display error message if Data is not writeable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14577
Gerrit Code Review
11:15 Bug #40890 (Resolved): Display error message if Data is not writeable
Currently the mkdir() command in Bootstrap doesn't check for any warnings if the directory Data or Data/Persistent co... Robert Lemke
16:07 Revision 939181e9: [BUGFIX] Display error message if "Data/" is not writeable
If the directory "Data/" or "Data/Persistent/" does not exist and could
not be created by the bootstrap, an error mes...
Robert Lemke
13:58 Bug #40824: Modified action controller methods not detected properly
Checked some more, this is probably what you are looking for:... Francois Suter
13:56 Bug #40824: Modified action controller methods not detected properly
I don't see any message about detecting the change. Looking for the affected action's name, I found only messages suc... Francois Suter
11:01 Bug #32829: Mapping to a subclass by __type property fails if subclass adds fields
Patch set 15 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/7507
Gerrit Code Review
10:23 Feature #37436: PropertyMapper should allow settings like allowCreationForSubProperty('products.[n].tierprices.[n]')
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
10:22 Revision 444cad6c: [FEATURE] Allow mapping of indexed property names with placeholder
For multi-valued property types (Doctrine\Common\Collections\Collection or
array) the property mapper uses indexes as...
Christopher Hlubek
10:21 Revision 2778a9cd: Merge "[FEATURE] Allow mapping of indexed property names with placeholder"
Karsten Dambekalns
09:56 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
09:53 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
09:56 Revision 4168539b: [BUGFIX] Parse target type before comparing the instance with it
The PropertyMapper chokes on already converted Objects if the targetType
is a compositeType like Collection<Entity>.
...
Marc Neuhaus
08:55 Bug #40888 (Resolved): Add ViewNotFoundException
As noted in a comment on https://review.typo3.org/14439 we should not use @NotFoundView@ ourselves anymore. Thus it s... Karsten Dambekalns
06:47 Revision 498338f9: Merge "[TASK] Add logging to importResource() and createResource()"
Sebastian Kurfuerst

2012-09-12

22:56 Revision 5ea59153: [TASK] Small code cleanup in ReflectionService
Change-Id: I6be337f1eaafa9dab943936d394110164d39ec0c
Releases: 1.2
Karsten Dambekalns
13:06 Task #40863 (Resolved): Update to Doctrine ORM version 2.3.x
Make sure we can use stock 2.3 packages to be able to rely on composer. Karsten Dambekalns
11:21 Bug #40410 (Needs Feedback): Exception when using Apc, Memcached of Redis cache backend for reflection status and object configuration
When using Redis it works for me, no exceptions whatsoever. APC and memcache fail with a variety of errors. Can you g... Karsten Dambekalns
10:53 Feature #40857 (Resolved): When template is automatically retrieved but not found, a hint about the tried location should be present
Currently, Fluid throws a nice exception when a template file couldn't be found at a tried location.
FLOW3, however,...
Adrian Föder
10:10 Bug #40263 (Resolved): Code migration script destroys method name in Resource\Resource
Karsten Dambekalns
10:07 Feature #40555 (Needs Feedback): Missing command arguments parameter in Core\Booting\Scripts::executeCommand()
As a feature this will go into 1.2 only - and for this the patch needs to be adjusted, as since 1.1 @executeCommand()... Karsten Dambekalns
10:01 Bug #40449: DateTimeValidator doesn't work as expected
I think I know what is wrong… This is the code in @resolveValidatorObjectName()@ inside @ValidatorResolver@. The firs... Karsten Dambekalns
09:55 Bug #40802: Documentation mistake (authentication)
Karsten Dambekalns wrote:
> Christian Mueller wrote:
> > the default AuthenticationController is deprecated and you s...
Kay Strobach
09:52 Bug #40802: Documentation mistake (authentication)
Christian Mueller wrote:
> the default AuthenticationController is deprecated and you should implement your own base...
Karsten Dambekalns
09:53 Task #40854 (New): Update security documentation (authentication in 1.2)
The new authentication controller needs to be documented. Karsten Dambekalns
09:50 Bug #40824 (Needs Feedback): Modified action controller methods not detected properly
Could you check the System_Development.log and check if the change is detected? If it is not, file monitoring seems t... Karsten Dambekalns

2012-09-11

23:35 Bug #40840 (Resolved): Wrong escape character in Configuration/Settings.yaml
Applied in changeset commit:604406e9908306b19f0725c257bc212e6188ea6e. Christian Jul Jensen
22:47 Bug #40840 (Under Review): Wrong escape character in Configuration/Settings.yaml
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14529
Gerrit Code Review
22:37 Bug #40840 (Resolved): Wrong escape character in Configuration/Settings.yaml
In yaml backslash is not a valid escape character in single quoted strings, the only allowed escape-sequence is '' (t... Christian Jul Jensen
23:01 Revision 56538e96: Merge "[BUG] Fix wrong escape sequence in yaml"
Christian Jul Jensen
22:46 Revision 604406e9: [BUG] Fix wrong escape sequence in yaml
Backslash is not a valid escape-character in yaml for single-
quoted strings.
see: http://yaml.org/spec/current.html...
Christian Jul Jensen
17:00 Revision 9b28224c: [TASK] Custom error page: higher priority for class matches
All custom error rendering options should be evaluated for
matches of the exception class name before trying to match...
Robert Lemke
15:35 Task #39599 (Resolved): Handle errors in subprocesses properly
Applied in changeset commit:e590a18ea3b12b73e01fe890bb3df72d901325bb. Christian Jul Jensen
15:23 Task #39599: Handle errors in subprocesses properly
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13362
Gerrit Code Review
14:45 Revision e590a18e: [TASK] Handle errors in subprocesses properly
To be able to properly handle missing class dependencies in ClassReflection
a ClassLoader should be added to end of t...
Christian Jul Jensen
14:35 Feature #39423 (Resolved): Custom Error Renderers
Applied in changeset commit:20e41f38b36482eb3cd861463885e1a032111be4. Bastian Waidelich
11:11 Feature #39423: Custom Error Renderers
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14439
Gerrit Code Review
14:16 Bug #40824 (Needs Feedback): Modified action controller methods not detected properly
I had the issue when changing an action method's signature in a controller, the security framework threw an access fo... Francois Suter
13:36 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review
00:35 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review
12:57 Feature #36077: Separate original classes and proxy classes in class cache
This change is older than Sebastians proxy. At that time, I just tried to get a solution to the problem, but if Sebas... Lienhart Woitok
11:50 Feature #36077 (Needs Feedback): Separate original classes and proxy classes in class cache
The questions is, do we want this? It feels "clean" to have proxy and "original" classes separated, but on the other ... Karsten Dambekalns
11:45 Feature #36077: Separate original classes and proxy classes in class cache
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10500
Gerrit Code Review
11:37 Feature #36077: Separate original classes and proxy classes in class cache
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10500
Gerrit Code Review
11:10 Revision 20e41f38: [!!!][FEATURE] Custom Error Renderers
This extends the exception handlers so that they can render arbitrary
templates based on the status code and/or class...
Bastian Waidelich
08:27 Bug #40802: Documentation mistake (authentication)
This part of the documentation needs to be rephrased anyway. Since last week (https://review.typo3.org/#/c/14377/) th... Christian Müller

2012-09-10

21:44 Bug #40802: Documentation mistake (authentication)
even better:... Kay Strobach
21:39 Bug #40802 (Accepted): Documentation mistake (authentication)
Hello guys,
on http://flow3.typo3.org/documentation/guide/partiii/security.html#using-the-authentication-controlle...
Kay Strobach
13:35 Feature #38424 (Resolved): Give Booting\Sequence an identifier (e.g. for logging)
Applied in changeset commit:e69479279c5aa98905cb603df4a907d48759b9a2. Karsten Dambekalns
12:29 Feature #38424: Give Booting\Sequence an identifier (e.g. for logging)
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12567
Gerrit Code Review
12:50 Revision f484ea40: Merge "[FEATURE] Add identifier to Booting\Sequence"
Karsten Dambekalns
12:35 Bug #40580 (Resolved): Exception when using SQL logger in Production Context
Applied in changeset commit:007e41ba3e8906661647579ecba37720be968f3b. Adrian Föder
12:08 Bug #40580: Exception when using SQL logger in Production Context
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:35 Bug #37001 (Resolved): Catch Exception from inactivityTimeout
Applied in changeset commit:a4c094a71e4df00f2128e8b14e80a03fa3e495b0. Robert Lemke
11:49 Bug #37001: Catch Exception from inactivityTimeout
Patch set 3 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:29 Revision e6947927: [FEATURE] Add identifier to Booting\Sequence
The identifier is set in Bootstrap to "runtime" and "compiletime"
respectively.
If you wire a slot to the beforeInvo...
Karsten Dambekalns
12:26 Bug #34675: NotFoundView is not used for missing actions
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12371
Gerrit Code Review
12:18 Revision 228cb548: [TASK] Add logging to importResource() and createResource()
When importing or creating a resource fails, the reason is
logged to the system log.
Change-Id: I46436f4992f81e8d5bd...
Karsten Dambekalns
12:08 Revision 9ca12776: Merge "[BUGFIX] Fix SQL logging in Production context"
Karsten Dambekalns
12:08 Revision de9c66aa: [BUGFIX] Fix SQL logging in Production context
The logger factory in Objects.yaml refers to a Setting directive which
with this change is present in Production cont...
Adrian Föder
11:52 Revision d697619f: Merge "[BUGFIX] Throw exception on CSRF token error" into FLOW3-1.1
Karsten Dambekalns
11:48 Revision a4c094a7: [BUGFIX] Prevent data from destroyed session from being loaded
This fixes a problem with session data which is being unserialized
even though its session is about to be destroyed. ...
Robert Lemke
11:48 Revision 86755da9: [!!!][BUGFIX] Fix request injection in security context
As inject* methods are excluded from the session
lazy loading proxy mechanism, the injectRequest
method of the securi...
Andreas Förthner

2012-09-09

16:58 Feature #39423: Custom Error Renderers
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14439
Gerrit Code Review
16:55 Feature #39423: Custom Error Renderers
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14439
Gerrit Code Review
01:35 Feature #39879 (Resolved): Improve HTML backtrace for boolean and array arguments
Applied in changeset commit:d953765612a7a7f94cee46f77ceb94034be81e4c. Adrian Föder
01:26 Revision 572ca541: Merge "[FEATURE] Improved argument type watch in HTML debug backtrace"
Karsten Dambekalns
01:10 Revision 6e11772e: [TASK] Fix return type documentation of createQuery
Change-Id: I3a04918874e723ee698c87884507a1c325cca0c4
Releases: 1.1, 1.2
Karsten Dambekalns
01:09 Revision 69c42591: Merge "[TASK] Fix return type documentation of createQuery"
Karsten Dambekalns

2012-09-08

23:33 Bug #28862: Inconsistent handling of roles as objects and strings in Account
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13868
Gerrit Code Review
17:35 Bug #40760 (Resolved): Unit Tests should not fail after AuthenticationController rewrite
Applied in changeset commit:6ba2ae145d740bb2d8333072d3fc23040c3f09b7. Christian Müller
17:15 Bug #40760 (Under Review): Unit Tests should not fail after AuthenticationController rewrite
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14455
Gerrit Code Review
17:15 Bug #40760 (Resolved): Unit Tests should not fail after AuthenticationController rewrite
Christian Müller
17:30 Bug #40738 (Accepted): Move System logger className to Settings instead of Objects.yaml
Karsten Dambekalns
17:18 Revision 5bdad52f: Merge "[BUGFIX] Always add CSRF token, if authenticated"
Andreas Förthner
17:15 Revision 6ba2ae14: [BUGFIX] Fix failing UnitTests for new AuthenticationController
Change-Id: Ie9c67799f1b4342733abe5015a8e1cf60e0e85a6
Fixes: #40760
Releases: 1.2
Christian Müller
17:01 Revision 443d6f1a: [BUGFIX] Always add CSRF token, if authenticated
This ensures that the CSRF token is also present
if the main request is not restricted, but if
the subrequests is.
C...
Andreas Förthner
16:31 Revision 3eb7b5c0: [FEATURE] Provide a general abstract authentication controller
This can be used to be inherited from in a custom package,
to enable developers to quickly implement their own
authen...
Andreas Förthner
10:02 Revision f7f46713: [TASK] Fix return type documentation of createQuery
Change-Id: I3a04918874e723ee698c87884507a1c325cca0c4
Releases: 1.1, 1.2
Karsten Dambekalns

2012-09-07

18:05 Bug #40738 (Resolved): Move System logger className to Settings instead of Objects.yaml
TYPO3\FLOW3\Log\Logger is hard coded in Scripts.php line 133. This class could be moved to Settings.yaml instead. Henrik Møller Rasmussen
17:28 Feature #39423 (Under Review): Custom Error Renderers
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14439
Gerrit Code Review
09:44 Feature #39423 (Accepted): Custom Error Renderers
Bastian Waidelich
16:37 Bug #40580: Exception when using SQL logger in Production Context
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14328
Gerrit Code Review
16:36 Revision 007e41ba: [BUGFIX] Fix SQL logging in Production context
The logger factory in Objects.yaml refers to a Setting directive which
with this change is present in Production cont...
Adrian Föder
14:08 Feature #39879: Improve HTML backtrace for boolean and array arguments
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13848
Gerrit Code Review
14:05 Revision d9537656: [FEATURE] Improved argument type watch in HTML debug backtrace
In the debug backtrace of method calls, this gives concrete
information about the actual argument values in case of b...
Adrian Föder

2012-09-06

11:35 Bug #40658 (Resolved): InternalRequestEngine discards exception status codes
Applied in changeset commit:46fd42294f64849be6a4ce3881dc53cac06aa063. Karsten Dambekalns
10:45 Bug #40658: InternalRequestEngine discards exception status codes
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
10:45 Revision 46fd4229: [BUGFIX] InternalRequestEngine observes exception status code
The InternalRequestEngine set the status code in case of an exception
to 500 in any case. With this change it will in...
Karsten Dambekalns
10:40 Revision b2b45ad8: Merge "[BUGFIX] InternalRequestEngine observes exception status code"
Karsten Dambekalns

2012-09-05

20:20 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
20:17 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
20:15 Bug #40661: The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
20:09 Bug #40661 (Under Review): The PropertyMapper can still choke on compositeTypes like collection<entity>
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14389
Gerrit Code Review
20:05 Bug #40661 (Resolved): The PropertyMapper can still choke on compositeTypes like collection<entity>
The PropertyMapper can still choke on already converted objects if the targetType is a composite Type like Collection... Marc Neuhaus
19:35 Bug #40657 (Resolved): Session Timeout default should be 3600 seconds
Applied in changeset commit:3ef0662e1abcd80c530fc9386a629f96404fb983. Christian Müller
18:57 Bug #40657: Session Timeout default should be 3600 seconds
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14385
Gerrit Code Review
18:49 Bug #40657: Session Timeout default should be 3600 seconds
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14385
Gerrit Code Review
18:49 Bug #40657: Session Timeout default should be 3600 seconds
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14385
Gerrit Code Review
18:48 Bug #40657 (Under Review): Session Timeout default should be 3600 seconds
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14385
Gerrit Code Review
18:48 Bug #40657 (Resolved): Session Timeout default should be 3600 seconds
Christian Müller
18:59 Bug #37001 (Under Review): Catch Exception from inactivityTimeout
Patch set 2 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
18:35 Bug #37001 (Resolved): Catch Exception from inactivityTimeout
Applied in changeset commit:1b409cc3eeb853ee6a733e627752839f6050ce62. Robert Lemke
18:22 Bug #37001: Catch Exception from inactivityTimeout
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
16:58 Bug #37001: Catch Exception from inactivityTimeout
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14379
Gerrit Code Review
16:45 Bug #37001 (Under Review): Catch Exception from inactivityTimeout
See https://review.typo3.org/#/c/14348/ Bastian Waidelich
18:56 Revision 3ef0662e: [BUGFIX] Session Timeout shouldn't be changed to 10 seconds
This reverts the changed session timeout setting introduced
in If7d004c7.
Change-Id: I0c5bca773ce8a234ad71ae36aeb416...
Christian Müller
18:53 Bug #40658 (Under Review): InternalRequestEngine discards exception status codes
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14386
Gerrit Code Review
18:52 Bug #40658 (Resolved): InternalRequestEngine discards exception status codes
The InternalRequestEngine set the status code in case of an exception to 500 in any case. With this change it will in... Karsten Dambekalns
18:53 Revision 4b479b2e: [BUGFIX] InternalRequestEngine observes exception status code
The InternalRequestEngine set the status code in case of an exception
to 500 in any case. With this change it will in...
Karsten Dambekalns
18:06 Revision 06777f7d: [BUGFIX] Throw exception on CSRF token error
Currently, if a required CSRF token is missing or invalid,
FLOW3 dies with a hard coded "Access denied!".
This chang...
Bastian Waidelich
17:02 Bug #40563 (Closed): When session times out, Exception occurs instead of WebRedirect
since it's a duplicate, I close this. Adrian Föder
16:57 Revision 1b409cc3: [BUGFIX] Prevent data from destroyed session from being loaded
This fixes a problem with session data which is being unserialized
even though its session is about to be destroyed. ...
Robert Lemke
16:49 Revision c920caaa: Merge "[BUGFIX] Fix request injection in security context"
Robert Lemke
16:11 Revision 9a843415: Merge "[BUGFIX] Throw exception on CSRF token error"
Andreas Förthner
16:09 Revision 1b3a9e25: [BUGFIX] Throw exception on CSRF token error
Currently, if a required CSRF token is missing or invalid,
FLOW3 dies with a hard coded "Access denied!".
This chang...
Bastian Waidelich
15:55 Feature #39839: Provide abstract authentication controller
Adrian Föder wrote:
> like the idea, but we should think carefully about what methods to make final and abstract
...
Bastian Waidelich
11:33 Bug #40626: Cookie - Setting throws exception in Http\Response
Exactly. Together with curlEngine. (Where another bug is, that no host-header is sent - which violates HTTP/1.1 - Pro... Ferdinand Kuhl
11:26 Bug #40626 (Needs Feedback): Cookie - Setting throws exception in Http\Response
Thanks for the report. Can you give some more info about the steps to reproduce this bug? Were you using the Http\Cli... Robert Lemke
11:20 Bug #40625 (Closed): InvalidArgumentException thrown in file Headers.php
Robert Lemke
11:05 Feature #38787: Provide an "instanceof"-like method for string class names
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12718
Gerrit Code Review
10:45 Feature #38787: Provide an "instanceof"-like method for string class names
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12718
Gerrit Code Review
10:22 Feature #39878: Utility function for determining if an array is considered numerically indexed
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13847
Gerrit Code Review

2012-09-04

22:27 Bug #40625: InvalidArgumentException thrown in file Headers.php
Sorry this is an duplicate of #40626.
Pressed the buttons in wrong order. :(
Ferdinand Kuhl
22:24 Bug #40625 (Closed): InvalidArgumentException thrown in file Headers.php
The "Set-Cookie" headers must be set via setCookie().
28 TYPO3\FLOW3\Http\Headers::set("Set-Cookie", "JSESSIONID=000...
Ferdinand Kuhl
22:26 Bug #40626 (Resolved): Cookie - Setting throws exception in Http\Response
The "Set-Cookie" headers must be set via setCookie().
28 TYPO3\FLOW3\Http\Headers::set("Set-Cookie", "JSESSIONID=000...
Ferdinand Kuhl
21:57 Revision 8d1c1372: [BUGFIX] Fix request injection in security context
As inject* methods are excluded from the session
lazy loading proxy mechanism, the injectRequest
method of the securi...
Andreas Förthner
13:35 Feature #40273 (Resolved): Enable FunctionalTestRequestHandler for non cli requests
Applied in changeset commit:8d01cdf42987f9d1104f93ca785a69a69eebbd7e. Marc Neuhaus
13:19 Feature #40273: Enable FunctionalTestRequestHandler for non cli requests
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14140
Gerrit Code Review
13:12 Revision 8d01cdf4: [FEATURE] Enable functional tests to be executed by non CLI SAPI
The FunctionalTestRequestHandler should be executable by non CLI requests to
enable TestRunners like VisualPHPUnit.
...
Marc Neuhaus
10:26 Bug #40580 (Under Review): Exception when using SQL logger in Production Context
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14328
Gerrit Code Review
10:17 Bug #40580 (Resolved): Exception when using SQL logger in Production Context
when having the SQL logger active in Prodution context, an exception occur, saying that
> Uncaught Exception
C...
Adrian Föder

2012-09-03

15:54 Bug #40563 (Closed): When session times out, Exception occurs instead of WebRedirect
Obvisously when the session times out and one hits /typo3 again, an exception occurs, saying "The context contained n... Adrian Föder
15:51 Bug #40449 (Accepted): DateTimeValidator doesn't work as expected
Cedric, thanks for your information. I will check if I can reproduce it with a Functional Test, because I have no clu... Adrian Föder
13:01 Feature #40555 (Accepted): Missing command arguments parameter in Core\Booting\Scripts::executeCommand()
Currently you can not execute a sub command (http://flow3.typo3.org/documentation/guide/partiii/commandline.html#exec... Timo Kiefer
12:32 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review
11:58 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review

2012-09-02

12:22 Bug #40449: DateTimeValidator doesn't work as expected
Well, I verified this one according to your questions:
* Yes, this is the actual snippet, that is being processed....
Cedric Ziel

2012-08-31

17:35 Bug #40372 (Resolved): Headers::has() always returns FALSE for Cache-Control
Applied in changeset commit:9eaeba7bc40276418a74410ce63f6217b6630814. Robert Lemke
11:35 Bug #33397 (Resolved): Difference for ManyToMany with JoinTable annotation and without
Applied in changeset commit:f8b0bb7ac110f0e3c5d9fae6e252fc9e326b4da9. Christian Müller
10:38 Revision 8557a311: Merge "[!!!][BUGFIX] Misused JoinColumns in ManyToMany"
Karsten Dambekalns

2012-08-30

21:30 Bug #40449: DateTimeValidator doesn't work as expected
I tested it with the DateTimeRange Validator; this one works. Cedric Ziel
21:24 Bug #40449 (Needs Feedback): DateTimeValidator doesn't work as expected
Adrian Föder
21:24 Bug #40449: DateTimeValidator doesn't work as expected
This is indeed strange, what you did Looks perfectly correct as far as I can see.
Are you sure your code snippet is ...
Adrian Föder
21:17 Bug #40449: DateTimeValidator doesn't work as expected
I just wanted to add, that I _think_, I am using Validators the right way.. others do their job just as "NotEmpty".
...
Cedric Ziel
21:14 Bug #40449 (Resolved): DateTimeValidator doesn't work as expected
I have a fairly simple Model which has a property $date:... Cedric Ziel
17:22 Bug #40372 (Under Review): Headers::has() always returns FALSE for Cache-Control
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
17:22 Revision 9eaeba7b: [BUGFIX] Fix Headers::has() for Cache-Control
The Http\Headers::get() method now correctly returns
TRUE if a cache control header exists.
Change-Id: I3323d2f4be6d...
Robert Lemke
16:35 Feature #40414 (Resolved): cURL request engine for HTTP browser
Applied in changeset commit:20a8c74c3b5db0ce787c72cfdc44249a806690a1. Robert Lemke
15:38 Feature #40414: cURL request engine for HTTP browser
Patch set 18 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10721
Gerrit Code Review
15:12 Feature #40414: cURL request engine for HTTP browser
Patch set 17 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10721
Gerrit Code Review
12:40 Feature #40414 (Under Review): cURL request engine for HTTP browser
Patch set 16 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10721
Gerrit Code Review
12:39 Feature #40414 (Resolved): cURL request engine for HTTP browser
Provide a new request engine, based on cURL, which can be used with the virtual browser contained in FLOW3's HTTP fou... Robert Lemke
15:35 Revision 20a8c74c: [FEATURE] cURL request engine for HTTP browser
This provides a new request engine, based on cURL,
which can be used with the virtual browser contained
in FLOW3's HT...
Robert Lemke
14:32 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
12:00 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
11:35 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
10:51 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
14:32 Revision f8b0bb7a: [!!!][BUGFIX] Misused JoinColumns in ManyToMany
With this fix the JoinColumns are created and used in the same
way regardless if you have a JoinTable annotation.
Th...
Christian Müller
13:35 Feature #40418 (Needs Feedback): Add an option to flow3:cache:flush thats keeps user sessions active
At the moment all sessions are being flushed with a
@./flow3 flow3:cache:flush@
There should be an option to fl...
Martin Brüggemann
11:35 Bug #40389 (Resolved): Orphan Removal in ManyToMany Associations
Applied in changeset commit:ca60d48ec5f7fc4e39c5a833c429ea83411e1fa5. Christian Müller
11:13 Bug #40389: Orphan Removal in ManyToMany Associations
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14211
Gerrit Code Review
10:46 Bug #40389: Orphan Removal in ManyToMany Associations
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14211
Gerrit Code Review
10:39 Bug #40389 (Under Review): Orphan Removal in ManyToMany Associations
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14211
Gerrit Code Review
11:26 Bug #40410 (Needs Feedback): Exception when using Apc, Memcached of Redis cache backend for reflection status and object configuration
When I configure to FLOW3 to use an other backend than the (Simple)FileBackend it throws an exception during compilet... Kobbe van Daatselaar
11:08 Revision ca60d48e: [!!!][BUGFIX] Don't override orphanRemoval setting from Doctrine
In Doctrine 2 ORM, orphanRemoval is disabled by default. In FLOW3 we want
orphanRemoval to happen, if the target is n...
Christian Müller

2012-08-29

20:27 Bug #40389 (Resolved): Orphan Removal in ManyToMany Associations
The orphanRemoval option in a ManyToMany annotation defaults to FALSE.
In the Flow3AnnotationDriver a check is mad...
Christian Müller
18:35 Feature #39837 (Resolved): Make WebRedirect EntryPoint less Routing dependent
Applied in changeset commit:94c0c7bb26561a09a7df527a76572188ab8e06a9. Bastian Waidelich
17:50 Revision a3c260f2: Merge "[FEATURE] Make WebRedirect EntryPoint less Routing dependent"
Bastian Waidelich
17:42 Feature #39879: Improve HTML backtrace for boolean and array arguments
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13848
Gerrit Code Review
13:35 Bug #40372 (Resolved): Headers::has() always returns FALSE for Cache-Control
Applied in changeset commit:28fc7e7b717218ee69516112373bd5b6a7c9237a. Robert Lemke
12:46 Bug #40372 (Under Review): Headers::has() always returns FALSE for Cache-Control
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14185
Gerrit Code Review
12:40 Bug #40372 (Resolved): Headers::has() always returns FALSE for Cache-Control
Because the Cache-Control header is handled in a special way, has() returns FALSE even though cache control directive... Robert Lemke
12:45 Revision 28fc7e7b: [BUGFIX] Fix Headers::has() for Cache-Control
The Http\Headers::get() method now correctly returns
TRUE if a cache control header exists.
Change-Id: I3323d2f4be6d...
Robert Lemke
12:37 Task #39121 (Rejected): Encapsulate PHP superglobals for Http\Requests
Thank your for the suggestion. However, due to the points Karsten explained and some more internals, we won't encapsu... Robert Lemke
09:55 Revision 97b6a059: [TASK] Add Windows version hint to documentation
Change-Id: I0783f9e75ce0e7e3231ed73ed8deb3915b64ae8d
Related: #38038
Releases: 1.1, 1.2
Karsten Dambekalns
09:50 Revision fe8c0786: [TASK] Add Windows version hint to documentation
Change-Id: I0783f9e75ce0e7e3231ed73ed8deb3915b64ae8d
Related: #38038
Releases: 1.1, 1.2
Karsten Dambekalns

2012-08-28

15:28 Revision 6656833b: [BUGFIX] Loop confuses variable check on migrating
When migrating code and not specifying a package to work on, the code
would get confused after the first available mi...
Karsten Dambekalns
15:27 Revision f781b115: Merge "[BUGFIX] Loop confuses variable check on migrating"
Karsten Dambekalns
13:02 Revision 45f872a5: [TASK] Detect inject methods more strictly
Currently every method starting with "inject" is considered
for property injection by the ConfigurationManager.
That ...
Bastian Waidelich
12:53 Feature #39837: Make WebRedirect EntryPoint less Routing dependent
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13796
Gerrit Code Review
12:52 Revision 94c0c7bb: [FEATURE] Make WebRedirect EntryPoint less Routing dependent
The WebRedirect currently expects an option uri that points
to a relative or absolute URI to redirect when trying to ...
Bastian Waidelich
11:07 Bug #40263: Code migration script destroys method name in Resource\Resource
Adrian Föder wrote:
> but, just asking: the SearchAndReplace, does this really a brute force string replacement? If ...
Karsten Dambekalns

2012-08-27

22:59 Bug #40283 (New): New constructor in grandparent class not called
I have a class hierarchy like this:... Andreas Wolf
21:57 Bug #40241: Encryption key sometimes readable for anybody
Karsten Dambekalns wrote:
> Off the top of my head I'd respond with "then most systems seem be set up in an insecure...
Andreas Wolf
10:32 Bug #40241: Encryption key sometimes readable for anybody
Off the top of my head I'd respond with "then most systems seem be set up in an insecure way". :/ Karsten Dambekalns
18:44 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
17:18 Bug #33397: Difference for ManyToMany with JoinTable annotation and without
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14141
Gerrit Code Review
18:04 Task #8923: Provide a Nginx Server Configuration for FLOW3
Just as addition, I will compile all the info here into something final for docs. This is the rewrite config used in ... Christian Müller
17:10 Feature #40273: Enable FunctionalTestRequestHandler for non cli requests
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14140
Gerrit Code Review
17:09 Feature #40273 (Under Review): Enable FunctionalTestRequestHandler for non cli requests
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14140
Gerrit Code Review
16:51 Feature #40273 (Resolved): Enable FunctionalTestRequestHandler for non cli requests
Currently the FunctionTestRequestHandler can only be used through cli.
I'd like to use a TestRunner based on Visua...
Marc Neuhaus
16:29 Bug #40263: Code migration script destroys method name in Resource\Resource
but, just asking: the SearchAndReplace, does this really a brute force string replacement? If so, looking for actual ... Adrian Föder
15:23 Bug #40263 (Under Review): Code migration script destroys method name in Resource\Resource
Ok, please check https://review.typo3.org/14134 and see if that helps. Classic looping error… :/ Karsten Dambekalns
15:19 Bug #40263: Code migration script destroys method name in Resource\Resource
Yes. Packages/Framework
Here's the output befor the patch (it was not the first try..As you can see in my Package....
Cedric Ziel
15:00 Bug #40263: Code migration script destroys method name in Resource\Resource
Your FLOW3 package is in @Packages/Framework@? Do you still have the output of the migrate command? Karsten Dambekalns
14:54 Bug #40263: Code migration script destroys method name in Resource\Resource
Hmm well what information do You need?
I read the Upgrade.txt, moved copied over the new Source Files and did the ...
Cedric Ziel
14:46 Bug #40263 (Needs Feedback): Code migration script destroys method name in Resource\Resource
Well, anything inside "Framework" is skipped by the migration tool, so I wonder why it even worked on that piece of c... Karsten Dambekalns
14:37 Bug #40263: Code migration script destroys method name in Resource\Resource
Cedric, if you are able to do, may I please to to test whether the provided patch resolves your issue?
If so, feel f...
Adrian Föder
14:36 Bug #40263 (Under Review): Code migration script destroys method name in Resource\Resource
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14133
Gerrit Code Review
14:27 Bug #40263 (Accepted): Code migration script destroys method name in Resource\Resource
well yes of course, that's it pretty surely:
http://git.typo3.org/FLOW3/Packages/TYPO3.FLOW3.git?a=blob;f=Migratio...
Adrian Föder
14:27 Bug #40263: Code migration script destroys method name in Resource\Resource
I double-checked it-the migrate task replaces getMimeType with getMediaType in the method signature. Cedric Ziel
14:24 Bug #40263: Code migration script destroys method name in Resource\Resource
hey that's a good point, thanks for that hint, I will check this. Adrian Föder
14:22 Bug #40263: Code migration script destroys method name in Resource\Resource
Hello,
thanks for your response. Is there any chance, the migrate task is involved?
I double-checked it and can...
Cedric Ziel
14:19 Bug #40263 (Needs Feedback): Code migration script destroys method name in Resource\Resource
Adrian Föder
14:17 Bug #40263: Code migration script destroys method name in Resource\Resource
Cedric, this is strange, the method you've mentioned should be "getMimeType", hence not a duplicate is present.
the ...
Adrian Föder
14:13 Bug #40263: Code migration script destroys method name in Resource\Resource
It's not the old, but the doublette-sorry. Cedric Ziel
14:12 Bug #40263 (Resolved): Code migration script destroys method name in Resource\Resource
Okay, please be kind in case i missed something..
I am new to FLOW3 an just wanted to migrate my small Package to 1....
Cedric Ziel
15:23 Revision d8d6fee4: [BUGFIX] Loop confuses variable check on migrating
When migrating code and not specifying a package to work on, the code
would get confused after the first available mi...
Karsten Dambekalns
 

Also available in: Atom