Activity

From 2012-10-09 to 2012-11-07

2012-11-07

21:48 Revision 9bebc29f: Merge "[TASK] Tweak exception message for not settable property"
Karsten Dambekalns
21:06 Bug #42770 (Resolved): Routing includes parameters from the current request
I believe that after https://review.typo3.org/#/c/15261/ some routing arguments from the current request is passed al... Aske Ertmann
17:56 Revision 2cc6c244: [TASK] Small code cleanup in Http Request Handler
Change-Id: Iba3d89ea36dfd7a92253b7cd22c7580fe568df48
Releases: 1.2
Pankaj Lele
16:00 Feature #42761 (Resolved): Let getByTag() return the identifiers, not only the values
Robert Lemke
15:08 Feature #42761 (Under Review): Let getByTag() return the identifiers, not only the values
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16253
Gerrit Code Review
15:00 Feature #42761 (Resolved): Let getByTag() return the identifiers, not only the values
Currently getByTag() only returns a numeric array of values – an array indexed by entry identifier would be more usef... Robert Lemke
15:45 Revision fadbe573: Merge "[FEATURE] Cache Frontend: getByTag() now returns identifiers"
Karsten Dambekalns
15:35 Bug #42758 (Resolved): Unit test for PersistenceQueryRewritingAspect broken
Applied in changeset commit:3d946860c611b601492acd59a031d654d3503daa. Karsten Dambekalns
14:42 Bug #42758 (Under Review): Unit test for PersistenceQueryRewritingAspect broken
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16251
Gerrit Code Review
14:40 Bug #42758 (Resolved): Unit test for PersistenceQueryRewritingAspect broken
The solution for #42601 broke one test in the PersistenceQueryRewritingAspectTest. Karsten Dambekalns
15:07 Revision 5cc198c9: [FEATURE] Cache Frontend: getByTag() now returns identifiers
This changes the behavior of getByTag() to not only return a
numeric array of entry values but now index them with th...
Robert Lemke
14:58 Feature #28683 (Closed): CachingFramework should accept cacheIdentifiers with special characters
My suggestion: use md5() or an escaping function to sanitize the identifier (if possible). I'd rather not put it into... Robert Lemke
14:40 Revision 3d946860: [BUGFIX] Fix unit test for PersistenceQueryRewritingAspect
The solution for #42601 broke one test in the
PersistenceQueryRewritingAspectTest.
Change-Id: I2e384aa8d1bf355746b9f...
Karsten Dambekalns
14:35 Bug #42601 (Resolved): Content Security: QOM rewriting is omitted if used in certain cases in an Action Controller
Applied in changeset commit:9af3204b3ceb08b488370d6d85802cac87821154. Robert Lemke
14:35 Bug #42756 (Resolved): Functional BrowserTest fails in Neos setup
Applied in changeset commit:9736f94532c3776154e701354559fa3dba67705e. Karsten Dambekalns
14:20 Bug #42756: Functional BrowserTest fails in Neos setup
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16250
Gerrit Code Review
14:02 Bug #42756: Functional BrowserTest fails in Neos setup
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16250
Gerrit Code Review
13:57 Bug #42756: Functional BrowserTest fails in Neos setup
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16250
Gerrit Code Review
13:44 Bug #42756 (Under Review): Functional BrowserTest fails in Neos setup
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16250
Gerrit Code Review
13:36 Bug #42756 (Resolved): Functional BrowserTest fails in Neos setup
The functional @BrowserTest@ in Flow (added as part of the solution to #42049) fails when run in a Neos context. This... Karsten Dambekalns
14:20 Revision 0c0fbf04: Merge "[BUGFIX] Fix functional BrowserTest in Neos context"
Karsten Dambekalns
14:20 Revision 9736f945: [BUGFIX] Fix functional BrowserTest in Neos context
The functional BrowserTest in Flow (added as part of the solution to
issue #42049) fails when run in a Neos context. ...
Karsten Dambekalns
13:54 Revision 0953a023: Merge "[BUGFIX] Enforce Query Rewriting more reliably"
Robert Lemke
11:41 Feature #90 (Closed): Add PHP dependency support
Composer can do this, just put the requirements in composer.json. Karsten Dambekalns
11:40 Task #3374 (Rejected): Support dedicated package versions per context
This would clash with the way composer manages packages. And in the last years, noone really needed it, or it would h... Karsten Dambekalns
11:39 Task #41414 (Needs Feedback): Check packageKey naming / file structure below Packages/Vendor
Karsten Dambekalns
11:38 Bug #28672: Inconsistent configuration overrides for packages
Julle, this is related to the current issue(s)… Karsten Dambekalns
09:35 Task #40863 (Resolved): Update to Doctrine ORM version 2.3.x
Applied in changeset commit:b807ceb06695ae742da2be7e2d9b3d51f21bfd97. Karsten Dambekalns
09:22 Task #40863: Update to Doctrine ORM version 2.3.x
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14568
Gerrit Code Review
09:21 Revision b807ceb0: [TASK] Use Doctrine 2.3 ORM and adjust as needed
This adjusts our annotation driver to the changes in Doctrine 2.3 that
were breaking.
Also it adds the code needed t...
Karsten Dambekalns

2012-11-06

21:14 Feature #37854: Refactor ConfigurationManager to Support Custom Configuration Files
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11982
Gerrit Code Review
17:16 Feature #37854: Refactor ConfigurationManager to Support Custom Configuration Files
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11982
Gerrit Code Review
14:06 Task #42726: Document new package structure and management
Documentation coverage wish:
> I want to install an arbitrary package from "out there", for example TYPO3.SwiftMai...
Adrian Föder
13:59 Task #42726 (Resolved): Document new package structure and management
Topics
- Composer
- Package structure
- Upgrading
- Installing
- Maintaining
help me make the docs better, ...
Christian Jul Jensen
13:13 Bug #42723: Reflection\ObjectAccess consumes to much processing time
btw: this reduces the execution time within ObjectAccess from > 40% to below 10% in the given example Steffen Ritter
13:07 Bug #42723 (Under Review): Reflection\ObjectAccess consumes to much processing time
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16234
Gerrit Code Review
12:48 Bug #42723 (Resolved): Reflection\ObjectAccess consumes to much processing time
JsonView, Validation, Serialisation and many other parts of Flow use ObjectAccess to retrieve information about how t... Steffen Ritter
11:42 Feature #41297 (Under Review): Add a way to extends the Account security model
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16232
Gerrit Code Review
11:25 Feature #41297: Add a way to extends the Account security model
I think this is a bug, not a feature - and the solution is quite simple - it's a onliner annotation.
Anyhow it is ...
Steffen Ritter
11:27 Bug #42715 (Under Review): ObjectSerializer not capable of Collections
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16231
Gerrit Code Review
10:34 Bug #42715 (Resolved): ObjectSerializer not capable of Collections
Using the serializer on Objects containing instances of \Doctrine\Common\Collections\Collection will fail with an exc... Steffen Ritter
10:35 Bug #42511 (Resolved): "Uri" constructor silently accepts unparsable Uri strings
Applied in changeset commit:1b03b89c9a61c5a8066544929a9be590eb3521b3. Adrian Föder
09:36 Revision 20619c38: Merge "[!!!][BUGFIX] Http\Uri constructor throws exception on invalid Uri"
Robert Lemke

2012-11-04

20:06 Bug #33055: AccessDeniedException instead of WebRedirect
I can confirm this problem on latest Flow master. I think that either throwing an "AccessDeniedException" is wrong he... Andreas Wolf

2012-11-02

11:45 Revision 667ff177: [TASK] Tweak exception message for not settable property
This explains the possible reason for a not settable property
a bit more and describes how to solve the mentioned pro...
Adrian Föder

2012-11-01

22:29 Bug #42606: Content Security with nested objects
Wrong issue infos!
It doesnt work also with only 1 nested loop!
Julian Kleinhans
22:15 Bug #42606 (New): Content Security with nested objects
I think there is a strange bug in the content security
Initial situation:
3 Models
- Product
-- Category
--...
Julian Kleinhans
19:59 Bug #42601 (Under Review): Content Security: QOM rewriting is omitted if used in certain cases in an Action Controller
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16106
Gerrit Code Review
19:10 Bug #42601 (Under Review): Content Security: QOM rewriting is omitted if used in certain cases in an Action Controller
The QOM Query Rewriting Aspect checks if the security context is initialized. If it is not yet initialized, it will s... Robert Lemke
19:58 Revision 9af3204b: [BUGFIX] Enforce Query Rewriting more reliably
This initializes the security context if it hasn't been initialized
when the PersistenceQueryRewritingAspect becomes ...
Robert Lemke
19:05 Bug #40241 (Rejected): Encryption key sometimes readable for anybody
We generally don't set umasks or owners / groups while creating files because server setups may vary a lot. If I'm no... Robert Lemke
12:38 Revision 4bc992cc: Merge "[TASK] Rename Phoenix to Neos"
Christopher Hlubek
11:16 Feature #41900 (Accepted): Check for duplicate PSR-0 autoload namespaces
Christian Jul Jensen

2012-10-31

19:30 Bug #42342: Fatal error / no possibility to flush caches after package has been removed
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15931
Gerrit Code Review
19:02 Feature #33539: Append query arguments from RoutePart handlers
I'd a missing feature for creating links inside modules at the moment. But since we've fixed recursive namespaced arg... Aske Ertmann
18:22 Task #42452: Command handling should support global flags
Christopher Hlubek wrote:
> [...] this is much more convenient than going back to the beginning and inserting @hel...
Bastian Waidelich
18:10 Task #42452: Command handling should support global flags
Not exactly, Git also supports @git rebase --help@. For long commands this is much more convenient than going back to... Christopher Hlubek
11:37 Task #42452: Command handling should support global flags
Right now it follow the git model ;) Karsten Dambekalns
17:35 Feature #42169 (Resolved): Use named indexes for placeholders in translation labels
Applied in changeset commit:71318ee5819bc78a04d2c632774ac0abb13b946f. Thomas Hempel
16:55 Revision 92c1262d: Merge "[BUGFIX] Support named indexes in multivalue translation labels"
Karsten Dambekalns
14:21 Task #42550: Add top-level .htaccess to block everything but Web
> Although we ask to use @Web@ as document root, that is often not done and/or possible (think about the practice of ... Robert Lemke
14:13 Task #42550 (Under Review): Add top-level .htaccess to block everything but Web
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16078
Gerrit Code Review
14:07 Task #42550: Add top-level .htaccess to block everything but Web
Agreed. Also, the complex variant doesn't even work - it blocks as soon as @Web@ is used as doc root as intended, bec... Karsten Dambekalns
13:46 Task #42550: Add top-level .htaccess to block everything but Web
yep, agree the simple variant too, and since @Web/@ has an htaccess already, two files are *affected*, but only one n... Adrian Föder
13:42 Task #42550: Add top-level .htaccess to block everything but Web
Karsten Dambekalns wrote:
> Two ways to do this so far.
I'd prefer the simple solution with two files and w/o e...
Bastian Waidelich
12:41 Task #42550: Add top-level .htaccess to block everything but Web
Two ways to do this so far.
_Simple, but affecting two files_
@.htaccess@...
Karsten Dambekalns
11:54 Task #42550 (Under Review): Add top-level .htaccess to block everything but Web
Although we ask to use @Web@ as document root, that is often not done and/or possible (think about the practice of de... Karsten Dambekalns
14:18 Revision b6e3faac: [BUGFIX] Tweak help output, output version
The help output was a bit clumsy regarding the name of Flow
and did not output the version (since it is missing in th...
Karsten Dambekalns
14:17 Revision c45b2343: [TASK] Rename Phoenix to Neos
This change adjusts some technically irrelevant uses of Phoenix to
Neos, just for completeness.
Change-Id: Ia19cc53d...
Karsten Dambekalns
13:52 Bug #34879 (Accepted): Proxied object is not update()able
Karsten Dambekalns
13:37 Bug #34879: Proxied object is not update()able
I managed to experience the error again; not in the exact same situation like initially described, but maybe comparab... Adrian Föder
10:09 Feature #42539 (Under Review): Allow Object.yaml property value to be also an array
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16068
Gerrit Code Review
10:01 Feature #42539 (Resolved): Allow Object.yaml property value to be also an array
It would be nice to be allowed setting also arrays as values for Object properties.
Use case: consider the followi...
Adrian Föder

2012-10-30

15:14 Bug #42520 (New): Cache must be flushed globally for package state changes
Currently after (de)activating a package the cache is only flushed for the *current context*. Instead it must be flus... Bastian Waidelich
15:11 Revision 6975f522: Merge "[FEATURE] Include technical details to exceptions in dev context"
Bastian Waidelich
15:10 Feature #42479 (Under Review): Context dependant Package states
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16047
Gerrit Code Review
12:13 Feature #42025: Uri type converter
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15522
Gerrit Code Review
12:10 Feature #42025: Uri type converter
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15522
Gerrit Code Review
12:04 Feature #42025: Uri type converter
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15522
Gerrit Code Review
11:57 Bug #42511 (Under Review): "Uri" constructor silently accepts unparsable Uri strings
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/16035
Gerrit Code Review
11:37 Bug #42511 (Resolved): "Uri" constructor silently accepts unparsable Uri strings
The Uri::__construct() method basically relies on the parse_url() method. As of PHP documentation, http://de3.php.net... Adrian Föder
11:52 Revision 1b03b89c: [!!!][BUGFIX] Http\Uri constructor throws exception on invalid Uri
The constructor of the Uri object now checks the return value
of the parse_url method and throws an exception if this...
Adrian Föder
10:41 Revision c17a95db: [BUGFIX] Introduce HTTP Response::createFromRaw()
The Response::createFromRaw method halted if a Set-Cookie header
arrives due to lacking handling.
This brings an imp...
Adrian Föder

2012-10-29

20:35 Feature #42355 (Resolved): Use public key fingerprint for UUID in RsaWalletService
Applied in changeset commit:8a706f20a7bd3cd34f08778a52a40acf35f17313. Christopher Hlubek
19:38 Revision 0d43e11c: Merge "[FEATURE] Identify key pair by fingerprint in RsaWalletService"
Robert Lemke
19:34 Task #42452: Command handling should support global flags
Good point. Some more ideas for global flags (extract from irc):... Bastian Waidelich
17:25 Bug #42342: Fatal error / no possibility to flush caches after package has been removed
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15931
Gerrit Code Review
15:02 Feature #42479: Context dependant Package states
As discussed the PackageStates.php syntax should be rather like:... Bastian Waidelich
14:18 Feature #42479 (Closed): Context dependant Package states
It should be possible to (de)activate packages for certain contexts only.
Suggested PackageStates.php syntax:...
Bastian Waidelich
10:36 Bug #42434 (Resolved): Resource handler not available when session is initialized
Applied in changeset commit:84ef743d1530b5344b2599efea211bd311f9e16c. Ferdinand Kuhl
09:40 Bug #42434: Resource handler not available when session is initialized
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15964
Gerrit Code Review
09:59 Feature #42467 (Resolved): NotEmpty Validator does not work with arrays
Forard-port this patch: https://review.typo3.org/#/c/14707/ Alexander Schnitzler
09:42 Task #42465 (New): Document i18n settings
The documentation does not explain the available settings for i18n. Karsten Dambekalns
09:38 Revision 84ef743d: [BUGFIX] Initialize resource wrapper before session
If you try to attach a resource-dependent object to a session, this
will fail, as the _wakeup() method is called befo...
Ferdinand Kuhl

2012-10-28

09:57 Task #42452 (Closed): Command handling should support global flags
The current help handling in Flow is not intuitive. It would be much easier if every command would understand a "--he... Christopher Hlubek
09:38 Bug #36720: Settings from package cannot override default value with empty array
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10896
Gerrit Code Review

2012-10-26

22:37 Bug #42434: Resource handler not available when session is initialized
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15964
Gerrit Code Review
22:30 Bug #42434 (Under Review): Resource handler not available when session is initialized
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15964
Gerrit Code Review
22:20 Bug #42434 (Resolved): Resource handler not available when session is initialized
In current master (and all earlier releases) the bootstrap initializes the session before the resource wrappers. If y... Ferdinand Kuhl
11:23 Feature #42355: Use public key fingerprint for UUID in RsaWalletService
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15925
Gerrit Code Review
11:23 Feature #42355: Use public key fingerprint for UUID in RsaWalletService
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15925
Gerrit Code Review
11:23 Revision 8a706f20: [FEATURE] Identify key pair by fingerprint in RsaWalletService
This change uses SSH compatible fingerprints of the RSA public
key instead of a random UUID to store keys. This allow...
Christopher Hlubek
11:11 Revision 6b38ecd7: Merge "[BUGFIX] Fix sign method in RsaWalletService"
Robert Lemke

2012-10-25

21:14 Feature #42403 (Resolved): Session handler based on HTTP foundation with multi-backend support
I'd like a new session implementation which
* simplifies testing by using the HTTP foundation
* allows for using ...
Robert Lemke
15:56 Bug #40410: Exception when using Apc, Memcached of Redis cache backend for reflection status and object configuration
Kobbe van Daatselaar wrote:
> In general it would be nice if the caching segment of the documentation was updated wi...
Thomas Plessis
15:36 Task #42319 (Resolved): Make PATTERN_MATCH_PACKAGEKEY more strict (again)
Applied in changeset commit:9762f6271c1bedbffe7295dfc9281e30a6d029a1. Karsten Dambekalns
15:07 Revision 27a5123b: Merge "[TASK] Tighten package key check a little"
Christian Jul Jensen
13:56 Feature #33539 (Needs Feedback): Append query arguments from RoutePart handlers
Do we still need this for Neos?
I'm still a bit unsure about this approach..
Bastian Waidelich
13:39 Feature #42169: Use named indexes for placeholders in translation labels
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15809
Gerrit Code Review
13:39 Revision 71318ee5: [BUGFIX] Support named indexes in multivalue translation labels
Change-Id: I0fd49bfe92695d1672f0b284dc26ad66954be429
Resolves: #42169
Releases: 1.2
Thomas Hempel
10:40 Bug #42342: Fatal error / no possibility to flush caches after package has been removed
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15931
Gerrit Code Review
10:33 Bug #42342: Fatal error / no possibility to flush caches after package has been removed
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15931
Gerrit Code Review
10:33 Bug #42342 (Under Review): Fatal error / no possibility to flush caches after package has been removed
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15931
Gerrit Code Review
10:33 Bug #42269: Unittests fail with PHPunit 3.7(.8)
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15905
Gerrit Code Review
10:29 Bug #37473: Subsequent Exceptions related to Doctrine Entity Manager makes it snap shut
Apparently this is the intended behavior of Doctrine:
> In other words, when an exception occurs during flush/comm...
Matthieu Napoli
10:19 Feature #42366 (Under Review): Make session handling compatible to any PHP session handler
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15930
Gerrit Code Review
08:40 Feature #42366: Make session handling compatible to any PHP session handler
Sounds good, do you provide a change, Martin? Christian Müller
07:55 Feature #42366 (Rejected): Make session handling compatible to any PHP session handler
Today there's no possibility to get Flow working with a custom php session save handler like redis or memcached. You ... Martin Brüggemann
09:35 Bug #42368 (Resolved): Typo in setfilepermissions Script
Applied in changeset commit:c3371afade3336c3ded27b99898ba05a5474f6fa. Ingo Pfennigstorf
08:39 Bug #42368: Typo in setfilepermissions Script
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15929
Gerrit Code Review
08:21 Bug #42368 (Under Review): Typo in setfilepermissions Script
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15929
Gerrit Code Review
08:17 Bug #42368 (Resolved): Typo in setfilepermissions Script
The output of the filepermissions script currently is:
"TYPo3 Flow File Permission Script"
Maybe the "o" should...
Ingo Pfennigstorf
08:38 Revision c3371afa: [BUGFIX] Typo in setfilepermissions Script
This fixes the output of the setfilepermissions script to the correct
spelling of TYPO3.
Releases: 1.2
Fixes: #42368...
Ingo Pfennigstorf

2012-10-24

17:12 Feature #42355 (Under Review): Use public key fingerprint for UUID in RsaWalletService
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15925
Gerrit Code Review
17:11 Feature #42355 (Resolved): Use public key fingerprint for UUID in RsaWalletService
Christopher Hlubek
16:12 Bug #41048 (Rejected): AbstractAuthenticationController namespace does not match folder structure
Just bad rebaisng. Christian Jul Jensen
16:11 Bug #42114 (Needs Feedback): PHPUnit functional tests cannot be run when only installed through composer
Christian Jul Jensen
12:55 Bug #42342: Fatal error / no possibility to flush caches after package has been removed
Robert Lemke wrote:
> Steps to reproduce:
>
> - create Acme.Demo package
> - warm up caches
> - remove the pack...
Robert Lemke
12:55 Bug #42342 (Resolved): Fatal error / no possibility to flush caches after package has been removed
Steps to reproduce (*production context!*):
- create Acme.Demo package
- warm up caches
- remove the package man...
Robert Lemke
12:48 Revision e63ab732: [BUGFIX] Fix sign method in RsaWalletService
Fixes the sign method to use the actual key string for
openssl_sign and adds a unit test for that.
Additionally a wr...
Christopher Hlubek

2012-10-23

17:38 Task #42319: Make PATTERN_MATCH_PACKAGEKEY more strict (again)
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15910
Gerrit Code Review
17:15 Task #42319 (Under Review): Make PATTERN_MATCH_PACKAGEKEY more strict (again)
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15910
Gerrit Code Review
17:14 Task #42319 (Resolved): Make PATTERN_MATCH_PACKAGEKEY more strict (again)
The pattern used to check for a valid package key was made less strict during composer integration. Although composer... Karsten Dambekalns
17:38 Revision 9762f627: [TASK] Tighten package key check a little
The pattern used to check for a valid package key was made less strict
during composer integration. Although composer...
Karsten Dambekalns
15:50 Bug #42269 (Under Review): Unittests fail with PHPunit 3.7(.8)
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15905
Gerrit Code Review
15:41 Bug #42269: Unittests fail with PHPunit 3.7(.8)
The issue here is that PHPUnit-Mock-Objects in has added an internal identifier '__phpunit_id' to mock objects, this ... Christian Jul Jensen
12:12 Feature #42011: Display package keys in migration status
Patch set 10 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
11:14 Feature #42011: Display package keys in migration status
Patch set 9 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
11:00 Feature #42025: Uri type converter
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15522
Gerrit Code Review

2012-10-22

13:56 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
I've just pushed a new patch which renders the annotations in the proxies like this:
https://gist.github.com/39311...
Marc Neuhaus
13:56 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Patch set 11 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13549
Gerrit Code Review
11:53 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Hmm, that kind of sounds like what i had before ^^
I think for quite complex things like expose it makes sense to ...
Marc Neuhaus
00:31 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
The main question for me is, if we want to complicate the whole proxy building even more. Also debugging and traceabi... Christopher Hlubek
13:01 Bug #42114: PHPUnit functional tests cannot be run when only installed through composer
Unittest error #42269 Christian Jul Jensen
12:46 Bug #42114: PHPUnit functional tests cannot be run when only installed through composer
I cannot reproduce the issue with the functionaltests.
However, I did get very weird behaviour from running global...
Christian Jul Jensen
13:00 Bug #42269 (Closed): Unittests fail with PHPunit 3.7(.8)
Output:
There was 1 failure:
1) TYPO3\Flow\Tests\Unit\Persistence\Generic\DataMapperTest::mapToObjectReconstitu...
Christian Jul Jensen
12:51 Feature #40418: Add an option to flow3:cache:flush thats keeps user sessions active
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15846
Gerrit Code Review

2012-10-21

23:46 Revision 99f42a0b: Merge "[BUGFIX] Changed f:form.textbox to f:form.textfield in Documentation"
Christopher Hlubek
13:00 Revision 6f2b8882: Merge "[BUGFIX] Apply PSR-0 code migration only to non-PSR-0 packages"
Christopher Hlubek
12:54 Revision af3c216f: Merge "[BUGFIX] Correct path check in HTTP\Cookie constructor"
Christopher Hlubek
12:50 Bug #42241 (Resolved): HTTP Request adds colon to Host header with empty port
Fixed in commit:bad4dde8b6f62f5db3e7fcd7b986d54f52ecab1e Christopher Hlubek
12:48 Bug #42241 (Under Review): HTTP Request adds colon to Host header with empty port
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15743
Gerrit Code Review
12:47 Bug #42241 (Resolved): HTTP Request adds colon to Host header with empty port
Christopher Hlubek
12:49 Revision bad4dde8: Merge "[BUGFIX] Make HTTP_HOST not always followed by port colon"
Christopher Hlubek
12:47 Revision 53a6fde5: [BUGFIX] Make HTTP_HOST not always followed by port colon
If there is no port given, a trailing colon for the HTTP_HOST
is not allowed to follow.
Change-Id: I9ca324fa3e283213...
Adrian Föder
11:35 Task #42164 (Resolved): CGL-Documentation - Add a notice about byte order mark
Applied in changeset commit:96f47786555fb39f43f30f08c99a18c178c4664c. Andy Grunwald
00:14 Feature #40418 (Under Review): Add an option to flow3:cache:flush thats keeps user sessions active
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15846
Gerrit Code Review

2012-10-20

21:08 Task #42164 (Under Review): CGL-Documentation - Add a notice about byte order mark
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15804
Gerrit Code Review
21:08 Revision 96f47786: [TASK] CGL-Documentation - Add a notice about byte order mark
Change-Id: Ie41bb02dbfa70e23b60255bb8bdfd0a645ae59d7
Fixes: #42164
Releases: 1.1, 1.2, 2.0
Andy Grunwald
20:43 Revision 63923b3f: Merge "[TASK] Check for unexpected properties in Policy schema"
Christopher Hlubek
20:07 Feature #42169 (Under Review): Use named indexes for placeholders in translation labels
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15809
Gerrit Code Review

2012-10-19

17:41 Task #8923: Provide a Nginx Server Configuration for FLOW3
If you want to run some PHP-Applications like www.your-domain.dev/roundcubemail/, you must stop rewriting by existing... Rafael Kähm
17:13 Feature #37373: Make annotation overrides / "injection" via Objects.yaml possible
Can we also set the arguments of the annotations? Just adding an annotation might not be enough for most cases (e.g. ... Christopher Hlubek
15:24 Feature #42176 (Resolved): Improve resolving of view
Currently the resolution of a view class and the respective (fluid) template happens really early in the MVC dispatch... Bastian Waidelich
14:35 Bug #42082 (Resolved): uriFor in subrequest does override explicit empty subpackageKey
Applied in changeset commit:8ebb3f6ecb6cbbb2eae971acc240e7091f5b9b5e. Christopher Hlubek
13:59 Revision bd5e35d7: Merge "[BUGFIX] Respect explicit empty subpackage in uriFor with subrequests"
Christopher Hlubek
12:48 Feature #42169: Use named indexes for placeholders in translation labels
There is a review request available at
https://review.typo3.org/#/c/15809/
Thomas Hempel
12:47 Feature #42169 (Resolved): Use named indexes for placeholders in translation labels
Right now you can replace placedholders in translations like this:... Thomas Hempel
11:21 Revision 580b9632: [TASK] Remove oneline exception for throw statements
Removes the exception for throwing exceptions in oneliners, which is
not allowed anymore.
Change-Id: Icac75a02c9ecf8...
Rens Admiraal
09:56 Task #42164 (Resolved): CGL-Documentation - Add a notice about byte order mark
In the PHP and JS CGL there is mentioned that all files must be UTF-8 encoded:... Andy Grunwald
09:04 Revision 77f148cd: [BUGFIX] Workaround issues with multiline commit messages
In core migration functionality, particularily on windows
systems, the commit message is cropped at the first occurre...
Adrian Föder

2012-10-18

23:35 Feature #42049 (Resolved): HTTP Browser: follow Location redirects like a real browser does
Applied in changeset commit:e90a00d669c4ad196462ad12a7fd75a06c36b1a8. Adrian Föder
23:02 Revision 84341d19: Merge "[FEATURE] Let HTTP browser follow Location redirects"
Robert Lemke
23:00 Revision e90a00d6: [FEATURE] Let HTTP browser follow Location redirects
Since Http's Browser object should behave like a real browser, Location
headers are now followed (as soon as they com...
Adrian Föder
17:53 Revision 03d6d6fd: [BUGFIX] Apply PSR-0 code migration only to non-PSR-0 packages
This change adds a condition to prevent the code migration to move
classes inside the Classes directory if it is alre...
Christopher Hlubek
17:36 Revision 9f407900: [BUGFIX] Correct path check in HTTP\Cookie constructor
A variable name has been corrected in the constructor
of the Cookie class.
Change-Id: I138ebbe49f93cf8ea490d32ef5732...
Adrian Föder
17:27 Bug #41848: Core migration tool applies migrations twice
Well, the interesting part: why are there no *Migration: 2012...* footers in the commit messages? If they are indeed ... Karsten Dambekalns
17:14 Revision 8b5adb71: Merge "[BUGFIX] Documentation mentions the NotEmptyValidator"
Bastian Waidelich
16:11 Revision be181ef7: [FEATURE] Include technical details to exceptions in dev context
Since the implementation of custom error renderers (#39423)
404 errors don't show any technical details to the user,
...
Bastian Waidelich
16:09 Feature #42135 (Resolved): Include technical details to exceptions in dev context
Since the implementation of custom error renderers (#39423) 404 errors don't show any technical details to the user, ... Bastian Waidelich
15:56 Bug #40888 (Accepted): Add ViewNotFoundException
Bastian Waidelich
10:35 Bug #42083 (Resolved): CSRF token is not appended for actions with mixed case characters
Applied in changeset commit:9ea304b4531e404112ae9c189554ef73057fa05b. Bastian Waidelich
10:04 Bug #42083: CSRF token is not appended for actions with mixed case characters
You may also relate this bug to earlier reported similar bug #41524 Thanks Pankaj Lele
10:21 Bug #41524 (Closed): csrfToken not added to action links having action method name with more than 1 word
Bastian Waidelich
10:21 Bug #41524: csrfToken not added to action links having action method name with more than 1 word
Sorry, I didn't see this report (it would have saved me a lot of time).
I'm closing this as duplicate of #42083 now,...
Bastian Waidelich
10:00 Revision faf48bec: Merge "[TASK] Documentation: Fix link to CGL on one page document"
Christopher Hlubek
09:51 Revision 8a730146: Merge "[BUGFIX] CSRF token is not appended for actions with mixed case characters"
Bastian Waidelich
09:23 Bug #42114 (Resolved): PHPUnit functional tests cannot be run when only installed through composer
Steps to reproduce:
* clone base distribution
* adjust composer.json to include ...
Sebastian Kurfuerst

2012-10-17

20:57 Bug #42101: Proxyclasses are not rebuild in Development context unless cache is empty
So I tried removing https://review.typo3.org/#/c/15580/, and it did not solve the problem, so apparently it wasn't in... Christian Jul Jensen
20:46 Bug #42101 (New): Proxyclasses are not rebuild in Development context unless cache is empty
Proxy classes that are missing in the cache are not rebuild, unless the cache is completely flush
Experienced with...
Christian Jul Jensen
19:13 Revision cf4f0ee4: [TASK] Documentation: Fix link to CGL on one page document
The link was renamed during the FLOW3 to TYPO3 Flow replacement
but the site package is not yet renamed.
Change-Id: ...
Christopher Hlubek
16:56 Bug #42083 (Under Review): CSRF token is not appended for actions with mixed case characters
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15765
Gerrit Code Review
16:52 Bug #42083 (Resolved): CSRF token is not appended for actions with mixed case characters
Since the update (I don't know what exactly broke this), the @CrsfProtectionAspect@ no longer appends the CSRF token ... Bastian Waidelich
16:56 Revision 9ea304b4: [BUGFIX] CSRF token is not appended for actions with mixed case characters
The CrsfProtectionAspect no longer appends the CSRF token when the
target action contains uppercase characters (e.g. ...
Bastian Waidelich
16:52 Bug #42082: uriFor in subrequest does override explicit empty subpackageKey
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15764
Gerrit Code Review
16:44 Bug #42082: uriFor in subrequest does override explicit empty subpackageKey
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15764
Gerrit Code Review
16:38 Bug #42082 (Under Review): uriFor in subrequest does override explicit empty subpackageKey
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15764
Gerrit Code Review
16:34 Bug #42082 (Resolved): uriFor in subrequest does override explicit empty subpackageKey
This is a bug that was probably introduced or noticed after change Iae8a2a8a39d47d7e99743d78188dccdd4238ccfb.
This...
Christopher Hlubek
16:52 Revision 8ebb3f6e: [BUGFIX] Respect explicit empty subpackage in uriFor with subrequests
This change just checks for the empty string in the routing arguments and
sets a controller argument for building the...
Christopher Hlubek
14:39 Revision 81a50601: Merge "[BUGFIX] Fix composer manifest loading and unit tests"
Christian Jul Jensen
11:19 Revision ec4d4225: [BUGFIX] Fix path to database error template
The Settings.yaml contained an outdated path for the
Fluid template which is supposed to display database
errors.
Th...
Robert Lemke
09:33 Revision 441957b9: [TASK] Check for unexpected properties in Policy schema
This change disables unknown properties for resources and
acl group keys to prevent mistakes. For example, the schema...
Christopher Hlubek

2012-10-16

16:50 Feature #42049: HTTP Browser: follow Location redirects like a real browser does
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15737
Gerrit Code Review
16:22 Feature #42049 (Under Review): HTTP Browser: follow Location redirects like a real browser does
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15737
Gerrit Code Review
15:20 Feature #42049 (Resolved): HTTP Browser: follow Location redirects like a real browser does
currently, unlike the raw "RequestEngine" functionality, a browser is intended to act like a real browser.
This mean...
Adrian Föder
16:38 Feature #33937: Convenience method to resolve public "resource://" paths
Another use-case:
i'm writing a Surf Deployment to push a file from inside a package to the remove node and need a ...
Marc Neuhaus
09:59 Revision c85ccd70: [BUGFIX] Fix composer manifest loading and unit tests
This change fixes 2 tests in PackageTest that failed when run from
a package directory, because the $package->getComp...
Christopher Hlubek
09:45 Feature #42025 (Under Review): Uri type converter
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15522
Gerrit Code Review
09:37 Revision 0fe86547: Merge "[BUGFIX] Tests fail when run from package path."
Christopher Hlubek
09:17 Feature #42011: Display package keys in migration status
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review

2012-10-15

17:59 Feature #42025 (Resolved): Uri type converter
provide a URI type converter that converts strings (representing a URL/URI) into real Http\Uri objects Adrian Föder
17:47 Feature #42011: Display package keys in migration status
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
17:40 Feature #42011: Display package keys in migration status
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
17:37 Feature #42011: Display package keys in migration status
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
16:59 Feature #42011: Display package keys in migration status
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
16:15 Feature #42011: Display package keys in migration status
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
16:08 Feature #42011: Display package keys in migration status
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
12:25 Feature #42011 (Under Review): Display package keys in migration status
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15629
Gerrit Code Review
12:22 Feature #42011 (Resolved): Display package keys in migration status
currently, only a bunch of versions are displayed in @doctrine:migrationstatus@. Display the package names, too.
T...
Adrian Föder
15:36 Bug #41818 (Resolved): Development Performance: Improve performance of Compile Run if no changes appeared
Applied in changeset commit:c9f04ee02f519bf480d1902662f593663d31e059. Christopher Hlubek
14:50 Revision 4fa37811: Merge "[BUGFIX] Remove unnecessary call for code compilation"
Robert Lemke
14:18 Revision 3b43e2a9: [BUGFIX] UriBuilder doesn't properly handle arguments of SubRequests
If you're creating a link inside a SubRequest that link currently
doesn't add/remember the Arguments, Controller, etc...
Marc Neuhaus

2012-10-13

20:29 Bug #41818: Development Performance: Improve performance of Compile Run if no changes appeared
I found another way of speeding up the compilation. We should try if http://review.typo3.org/15580 works correctly an... Christopher Hlubek
20:26 Bug #41818: Development Performance: Improve performance of Compile Run if no changes appeared
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15580
Gerrit Code Review
20:26 Revision c9f04ee0: [BUGFIX] Remove unnecessary call for code compilation
This change removes the forced compile command subrequest
in a non Production context. Proxy classes are only
initial...
Christopher Hlubek

2012-10-12

17:30 Bug #41848 (Under Review): Core migration tool applies migrations twice
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15531
Gerrit Code Review
17:29 Bug #41848 (Accepted): Core migration tool applies migrations twice
I also ran into that an hour ago, so I'll supply a fix for that. Christopher Hlubek
16:21 Revision c913fb65: Merge "[FEATURE] Allow mapping of indexed property names with placeholder" into FLOW3-1.1
Christopher Hlubek
08:53 Feature #41900 (Accepted): Check for duplicate PSR-0 autoload namespaces
Currently, if two packages define the same PSR-0 autoload namespace in their composer.json, it goes unnoticed by the ... Robert Lemke

2012-10-10

18:34 Task #8923: Provide a Nginx Server Configuration for FLOW3
If you are working with master take care that the settings are now called FLOW_XXXXX instead of FLOW3_XXXXX Christian Müller
16:55 Revision f442e2f5: [BUGFIX] Tests fail when run from package path.
Composer manifests missing in some tests, and not read properly by
package in others
Change-Id: I38f356ad539a5ebe206...
Christian Jul Jensen
16:04 Bug #41848 (Resolved): Core migration tool applies migrations twice
With for example my MooTools.Packager repository located here: http://git.typo3.org/FLOW3/Packages/MooTools.Packager.... Adrian Föder
14:51 Task #40863: Update to Doctrine ORM version 2.3.x
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/14568
Gerrit Code Review
13:00 Task #41832 (New): Improve error handling for incompatible packages
Installing packages that are not PSR-0 compatible currently produces some very unexpected errors:
For example when...
Bastian Waidelich
11:04 Feature #26783 (Rejected): Support settings via OS Environment
I abandon the change. Maybe we come up with some totally different way of setting stuff, but OS Environment seems not... Christian Müller
09:41 Bug #41818 (Under Review): Development Performance: Improve performance of Compile Run if no changes appeared
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15472
Gerrit Code Review
09:40 Bug #41818 (Resolved): Development Performance: Improve performance of Compile Run if no changes appeared
I profiled performance of development context; and found the following:
* A lot of time is spent during *typo3.flo...
Sebastian Kurfuerst
09:27 Bug #41533: Ignored object-validation in editAction when redirecting back from updateAction
Hi, Sebastian
I don't know what is the correct way ... just that this is incompatible.
For me, too, it feels mo...
Simon Schick
09:07 Bug #41533 (Needs Feedback): Ignored object-validation in editAction when redirecting back from updateAction
I think the behavior we implement currently is correct; it's just that the guide is incorrect at this point. Sebastian Kurfuerst

2012-10-09

21:06 Task #41807: Initialize the eventmanager in the EntityManagerInterface
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15110
Gerrit Code Review
20:32 Task #41807: Initialize the eventmanager in the EntityManagerInterface
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15110
Gerrit Code Review
20:31 Task #41807 (Under Review): Initialize the eventmanager in the EntityManagerInterface
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15110
Gerrit Code Review
20:28 Task #41807 (Under Review): Initialize the eventmanager in the EntityManagerInterface
Doctrine extensions often need to register themselves to the EventManager. This EventManager is now not passed to the... Rens Admiraal
15:53 Feature #41358: Allow class/interface constants in configuration directives
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15074
Gerrit Code Review
13:42 Revision ee8f8e1d: [TASK] Exclude classes with broken PSR-0 in DomCrawler
See https://github.com/symfony/DomCrawler/pull/7
Change-Id: Id3fbb8ad5154c633b7153b4f8eef742f385b05a3
Related: #4103...
Christian Jul Jensen
10:35 Bug #41657 (Resolved): ActionRequest does not resolve correctly cased package key
Applied in changeset commit:b744c359a9ff0373a5c22926cf3577468bbe952e. Anonymous
09:36 Bug #41657: ActionRequest does not resolve correctly cased package key
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15396
Gerrit Code Review
09:06 Bug #41657: ActionRequest does not resolve correctly cased package key
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15396
Gerrit Code Review
08:24 Bug #41657: ActionRequest does not resolve correctly cased package key
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/15396
Gerrit Code Review
09:36 Revision b744c359: [BUGFIX] ActionRequest does not resolve correctly cased package key
ActionRequest resolves lowercased package key by looking for
Package class instead of asking PackageManager. If no Pa...
Jan-Erik Revsbech
 

Also available in: Atom