Activity
From 2013-09-25 to 2013-10-24
2013-10-24
-
22:58 Revision 5e1a8591: [TASK] Remove unused use statements
- Change-Id: Iae50bec161d8562f9ffb368922ef3f80f73114dd
Releases: master -
- * Removes indent from inline comments
* Fixes several docblock issues
* Fixes inline conditions
Change-Id: I2f08cf58... -
22:26 Revision 843cae1f: [TASK] Mention PHP closing tag omission in CGL
- This updates the Coding Guidelines to omit the PHP closing tag.
Change-Id: Ie222d1465a60b00fe143bd4f8390f4b40e427b28... -
22:26 Revision 17996c9f: Merge "[TASK] Mention PHP closing tag omission in CGL"
-
- This updates the Coding Guidelines to omit the PHP closing tag.
Change-Id: Ie222d1465a60b00fe143bd4f8390f4b40e427b28... -
11:41 Feature #53080: Support for multiple domains
- Christopher Hlubek wrote:
Thanks for your feedback, this really helps pushing this forward!
> Well, I think the dom... -
09:35 Feature #53080: Support for multiple domains
- Well, I think the domain is not as "discrete" as the HTTP method, so users should be able to specify patterns for fle...
2013-10-23
-
- Currently the Flow does not support multi-domain setups out of the box:
* There is no concept of "domains" in Flow... -
17:47 Bug #44521 (Under Review): ObjectPathMappingRepository always checks case-sensitive
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24977 -
- Change-Id: Ie3856f4c8beb8139b2215f01fc1be177bf8faf72
Migration: TYPO3.Flow-201209251426
Releases: master, 2.0 -
- Tim Spiekerkötter wrote:
Hi Tim,
> thank you for your answer. My request has two arguments, both are Extbase mo... -
11:17 Bug #25801: Request arguments should never contain objects
- Hi Bastian,
thank you for your answer. My request has two arguments, both are Extbase models and the FormViewHelpe... -
2013-10-22
- 16:27 Revision 997a1cbe: Merge "[BUGFIX] Request::getRelativePath() must not return FALSE"
-
- yep it's to have a chance to ever find it again ;)
-
- Adrian Föder wrote:
> A suggestion is here: https://review.typo3.org/#/c/23422/
..which you just abandoned. Mys... -
- A suggestion is here: https://review.typo3.org/#/c/23422/
-
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23783 -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23783
2013-10-21
-
- Releases: master
Change-Id: I2c62ac93654826b049523ca6838f077adf04f6de -
- If TYPO3 Flow is not directly in the document root the var_dump
output is unstyled as the path to the external CSS ca... -
19:16 Feature #33838: Add a way to configure Doctrine Mapping Type
- As Adrian said it's possible to use \Doctrine\DBAL\Types\Type::addType('yourtype', 'Your\Whatever\Type'); and so on t...
-
- it looks like you can do the following, at least, @Package.php@:...
-
- If a filename below Classes in a package contains dots, Flow breaks
when it tries to flush caches during startup.
Se... -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24936 -
17:15 Bug #53010 (Resolved): UsernamePasswordHttpBasic disabled since .htaccess strips "Basic"
- Hey there.
The Token\UsernamePasswordHttpBasic requires the "Authentication" header to begin with "Basic". That's ... -
- this could also be done with setting the @->errorMethodName@ in the appropriate @initialize*Action@ wherever needed.
-
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24926 -
- Now the validation regex has start- and end of string
boundaries, hence rejecting strings which only
contain a valid ... -
-
-
-
- Applied in changeset commit:d645b051ad3d8adb849649ff4076c7759c9c006f.
-
-
-
- Tweaks the documentation for proper git commit messages
and adds some examples.
Change-Id: I0765da6ac4ef4a1d7e3b8fcf... -
- Patch set 16 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/20821 -
- Patch set 8 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/21134 -
-
10:32 Revision bffd27f4: Merge "[BUGFIX] Injected properties are not available in initializeObject()"
2013-10-19
-
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24904 -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24904 -
12:52 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
- I'd still say it's a bug that namespace-less classes cannot be autoloaded. The same happens when trying to autoload T...
-
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/19862
2013-10-18
-
13:25 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
- The reason for this issue belongs to the IRC chat.
Because I wanted to use the ChromePHP library but the ChromePHP c... -
- Issue should be updated then to "Class Loader doesn't handle empty namespaces" or similar
-
- Alexander Berl wrote:
> However, I can see that the class loader currently doesn't handle empty namespaces - so if t... -
- I don't think those are related. The class loader only considers packages that are active (see PackageManager::initia...
-
11:44 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
- Needs to be verified yet. Could be related to this one #52944.
Will investigate both later today. -
- Classes that are excluded in the settings.yaml (Flow > object > excludeClasses) should still be able to autoload.
-
-
- Change-Id: Iaaef26f3c0ff8e6f812cb338e677a8a68de72b43
Releases: master, 2.0 -
- The current configuration format is:...
-
- Should be trivial to fix with an if condition. See Object/Proxy/ProxyClass::render() line 195 ff.:...
-
- A real example would be this:
https://gist.github.com/hfrahmann/7037897#file-flow-cache-chromephp-php-L15 -
- When packages (that are loaded with composer to Libraries) containing classes without a namespace, Flow generates a c...
2013-10-17
-
- Tim Spiekerkötter wrote:
> I have a huge hidden [__referrer][arguments] field with several kb in size. That causes... -
- Has this ever been backported to Extbase? I have a huge hidden [__referrer][arguments] field with several kb in size....
-
- This makes sure that ``Request::getRelativePath()`` always returns
a string.
This getter has been introduced with
I4... -
- Applied in changeset commit:7e0c425ceefd06252ef00b9addcd9389f1e7d950.
-
12:27 Bug #52907: #1355480641: Uncaught Exception
- THX
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24862 -
- Ok, thanks to your feedback I could reproduce the issue (it happens only after flushing the cache, after a refresh yo...
-
- this is how i produced the exception.
!2013-10-17_10-41-58.png!... -
- Kay Strobach wrote:
> keep it closed - i agree. I had a misconfigured Entity (created out of the context and then ... -
- keep it closed - i agree. I had a misconfigured Entity (created out of the context and then copied into a FLOW projec...
-
- Hi Kay,
can you give some more context? Where do you get this exception? If I add a property:... -
- I think that would open kind of a "box" if it's started to catch these kind of errors. I even suspect that's rather h...
-
- mhmm ok, but it would be possible to catch and enhance it ;) - for usability reasons a good error message would be gr...
-
- Hello Kay,
this is a Doctrine exception, hence out of the competence of Flow...
Feel free to reopen if you disagr... -
- ...
-
- This adds a try/catch block to the FlowAnnotationDriver adding the
affected class name to the message of the thrown e... -
- Hey there.
This commit is slightly related to #46689. But since #46689 has drifted to focusing doc parsing and ann...
2013-10-15
-
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24579 -
- Although a little bit of a late answer:
In general, validation has no influence on the database schema. By default... -
18:19 Revision 2b702b0f: [FEATURE] Add tagging to router cache
- This adjusts the RouterCachingService to tag every Routing cache entry
with any UUID the routeValues/matchResult cont... -
- This moves code from the RouterCache AOP aspect to the Router itself
making the aspect redundant.
Before the cache h... -
- Some (mostly cosmetic) adjustments to our CGL and some
renamings to increase readability.
This also renames the misl... -
16:21 Revision 2df9c7cf: [TASK] Move isConnected from role repository to persistence manager
- To make isConnected api, we have to move it to some central
place. The persistence manager seems to be a lot better p... -
- The PolicyService now depends on having an active database connection.
This connection is not always available (like ... -
- Applied in changeset commit:9ec9717a5ba73e7dab90f74fc9e167333930ed87.
-
- Applied in changeset commit:3ca238501129a075a4b1dfe67b536e9df2fb2081.
-
-
-
- As security exceptions will be handled by the security
framework, we have to let them bubble up instead of
converting...
2013-10-14
-
- Patch set 6 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23241 -
- Patch set 6 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23241 -
12:00 Bug #50395: Route cache caches routes for non dispatchable requests
- Hi Bastian.
Sounds good to me. Thanks for your infos!
Cheers -
- Hi Marco,
thanks for your feedback.
We're currently working on automatic redirect-support for routes that might part... -
- Mmmm... certainly the decoupled setting is well-choosen by design and so i have to deal with this drawback. Maybe i c...
2013-10-13
-
- The renderStatically() method does not return a value, and thus the
echo can be removed.
Releases: master
Change-Id:... -
- In the test the HTTP_X_HTTP_METHOD header is not set, but the
HTTP_X_HTTP_METHOD_OVERRIDE is set twice. This causes t...
2013-10-12
-
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24579
2013-10-11
-
21:59 Revision 327db445: Merge "[TASK] Allow package installer actions / scripts"
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24579 -
- Caching of the Routing Framework has been extracted to an AOP aspect in order to keep the Router code simple. Since t...
-
-
- Applied in changeset commit:dbd2f265bfed7ae512519d378842be321639f51c.
-
-
-
- Due to #47975 it happens, that packageKey
and name are not correctly set in role objects. This
change is a quick work... -
- Patch set 8 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/6014 -
- The problem still exists, opening the issue again...
-
- Let's see if the fix for #43659 helps
-
- I think that this is a duplicate of #43659
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24550 -
-
- This fixes an issue where properties injected to the parent class A
were not available when the initializeObject() me... -
-
-
-
-
2013-10-10
-
- This role will always be active as soon as some token could be
authenticated.
Change-Id: Ia00bea27e81b2e4a172ad4f998... -
- Also refactors the routing to use this getter.
Change-Id: I48548b6f1465d6b509298d42cff39242040e7782
Releases: master -
-
-
-
-
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24526 -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24526 -
- Configurations from Views.yaml are merged together leading to mixed
up configurations and invalid options.
This adds... -
- This fixes an issue in the getMediaTypeFromFilename() function which
returned application/octet-stream on any filenam...
2013-10-09
-
14:37 Bug #52635 (Resolved): Incorrect merging of Views.yaml files from multiple Packages
- There is an issue with the way the Views.yaml files are merged in the ConfigurationManager because of the unnamed, in...
-
- Any news on this one? The first patch is already ancient ;)
2013-10-08
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24490 -
- I'm fixing this now
-
- As described in the routing section of the documentation, the
`Object Route Parts`` should use the technical identifi... -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/17526 -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/17526 -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/17526 -
- By default dynamic route parts are lower-cased unless the
"toLowerCase" flag is set to TRUE for the route or a single... -
- The routing cache kicks in as soon as a route matches/resolves successfully. As the routing is (kind of) decoupled fr...
-
2013-10-07
-
- Currently it is not possible to paginate object collections that require a join to be reconstructed....
-
12:50 Bug #49624: Domain Model validators are executed twice
- Also an issue in TYPO3 CMS Extbase!!
-
- I would say that could be fixed by ignoring warnings from the rename (which we have to do anyway as Basti stated). An...
-
- Bastian: Can you push a new patchset that fixes the rename warning (and maybe add the usleep to the busy waiting)?
...
2013-10-05
-
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24252 -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24252
2013-10-04
-
16:35 Bug #52425 (Resolved): "Required option" flag in AbstractValidatior does not work correct
- Applied in changeset commit:9e5f2e40226a8e3e4ecf5ebc2072ee3b7e82076d.
-
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24386 -
- Patch set 8 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- Patch set 7 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- As the authenticate action is usually called by a
POST request, this request is considered a non safe
request. Howeve... -
-
- This fix adds a boolean condition to the "Required option" flag
condition. With this fix the flag can also be FALSE.
... -
-
- This fix adds a boolean condition to the "Required option" flag
condition. With this fix the flag can also be FALSE.
... -
- As the authenticate action is usually called by a
POST request, this request is considered a non safe
request. Howeve... -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24252 -
- In this case the effective privileges can not be calculated.
Therefore we have to skip it.
Change-Id: Ifa82fe6b44484... -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/22382 -
- Patch set 6 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/22384 -
- If testable security is not switched on in a functional test, skip any
checks by overriding in the AccessDecisionMana...
2013-10-03
-
19:35 Bug #46036 (Resolved): AuthenticationRequired should not be thrown in PolicyEnforcement if resource is available to Everybody
- Applied in changeset commit:b6768ccfb736ef8b536f420cd2d8068edc44267b.
-
- Applied in changeset commit:a60ef3c8672ff70b62f799ff6ea6ad1323f18a85.
-
- Patch set 7 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Patch set 6 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
-
-
-
- Change-Id: I791d71289a81b81f385ab5d279308c4ebc4a9753
Releases: master -
- This is a convenience method to avoid a try/catch in userland code.
Breaking only for those who implemented AccessDe... -
- This change differentiates between connection errors and missing
tables in the database which were before handled equ... -
- Change-Id: Ie3856f4c8beb8139b2215f01fc1be177bf8faf72
Migration: TYPO3.Flow-201209251426
Releases: master, 2.0 -
- Flow now specifically warns about a package not being available
when the activate or deactivate command for a package... -
-
- Flow now specifically warns about a package not being available
when the activate or deactivate command for a package... -
- Patch set 6 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- This change removes most of the logic from the
RouterCachingAspect and introduces it in the form of a new
RouterCachi... -
11:36 Bug #50585 (Resolved): Validation fails if nested properties of same type are present
- Applied in changeset commit:09756f36380d948ac84916419e71465a54bd7c2f.
-
- Martin Lipp wrote:
> Helmut Hummel wrote:
> > Can you check if the patch in Gerrit works for you? Thanks.
>
> It... -
-
- We are now using reflection classes to resolve the
case sensitive method names, as this more reliably
includes really... -
- Using this command one can list methods that are included in a resource
definition::
./flow security:showmethodsfo...
2013-10-02
-
23:02 Revision d95e1c0c: [FEATURE] Add Package Filtering by Path and Type
- This makes getting a particular kind of package, by path or type, or
first class Flow feature. The docs say that you ... -
- Applied in changeset commit:26ee5d83293a022eb4b1ee7048ba3bd1c6cd4ccc.
-
- Patch set 2 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24253 -
- Applied in changeset commit:791b57041971f80a50bcbc3194be2bbba698a033.
-
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24253 -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24238 -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24238 -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24238 -
- We still check for a "tag" annotation to exclude transient properties from serialization. That is wrong and transient...
-
- To be able to use real role based authorization with the
FileBasedSimpleKeyProvider, we have to authenticate an
accou... -
- To be able to use real role based authorization with the
FileBasedSimpleKeyProvider, we have to authenticate an
accou... -
- Properties annotated with the \TYPO3\Flow\Annotations\Transient
annotation should not be serialized in the autogenera... -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24218 -
17:34 Bug #50585: Validation fails if nested properties of same type are present
- Helmut Hummel wrote:
> Martin Lipp wrote:
>
> > Yes. I checked again it works fine with FLOW3 1.1. I also quickly... -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24218 -
- Breaking change was in #46340
-
- Martin Lipp wrote:
> Yes. I checked again it works fine with FLOW3 1.1. I also quickly migrated the package to Flo... -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24218 -
- The performance optimization in #46340
changed the isValid() method of the
GenericObjectValidator to use the result
p... -
-
- The migration checking for the use of globally defined roles identifier
was a bit too eager in working on packages wi... -
-
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24242 -
- Currently the logic for fetching the routing cache and creating it resides solely in the RouterCachingAspect. This ma...
-
- With the new commands it is possible to check for unprotected commands
and see the effective policy rules for a given... -
- Change-Id: I1de7069e392163a836ff5b58385d9accc6ea2bec
Releases: master -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24223 -
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24252 -
-
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24240 -
- PolicyEnforcement does no longer throw an AccessDenied exception
if not logged in before checking the actual ACLs for... -
-
- Properties annoated with the \TYPO3\Flow\Annotations\Transient
annotation should not be serialized in the autogenerat...
2013-10-01
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24223 -
- Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24174 -
- Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24174 -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24218 -
- Helmut Hummel wrote:
> Martin Lipp wrote:
>
> > This does not happen in one of my older projects (with FLOW3 1.1)... -
15:48 Bug #52430 (New): Cannot convert from UUID to auto-increment ID
- Hi all
I think I found a bug - when I tried to convert a model to use an auto-increment ID instead of the UUID, th... -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24211 -
- The "required" flag for the options in source:/Classes/TYPO3/Flow/Validation/Validator/AbstractValidator.php does not...
-
12:19 Revision 0dd80fb8: [TASK] Allow package installer actions / scripts
- Allow packages to register scripts and resources to be executed or
installed upon composer install and update.
Chang... -
- Applied in changeset commit:bdebde07f3fc0a78db022900c4446c3fac6d9dbd.
-
- Patch set 8 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/22597 -
- With this change the PhpFrontend has the added method
getWrappend(), which returns the code including the
automatical...
2013-09-30
-
- Martin Lipp wrote:
> This does not happen in one of my older projects (with FLOW3 1.1), because there the GenericO... -
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24174 -
- Bastian Waidelich wrote:
> This might be related to #50585
I think that is something different.
The issue in t... -
- There is still an issue with the current implementation (even with the patches applied): rename() issues a warning so...
-
14:46 Bug #33621: Filebackend reports error when trying to rename file due to concurrent proccesses
- The SimpleFileBackend "set" method also does not handle concurrency. "rename" should only be called if the file still...
2013-09-26
-
- Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24076 -
- \TYPO3\Flow\Validation\Validator\UuidValidator::$PATTERN_MATCH_UUID is '/([a-f0-9]){8}-([a-f0-9]){4}-([a-f0-9]){4}-([...
-
- Now the validation regex has start- and end of string
boundaries, hence rejecting strings which only
contain a valid ... -
- This is fixed with https://review.typo3.org/#/c/20737/
-
- The DB columns for those properties are VARCHAR(255), so the validation
limit of 100 makes no sense.
Change-Id: Ia26... -
- This Option should be the default for MySQL ... overriding is ok, but this is definitly a problem on many hosts!
Atl... -
- It would be nice if TYPO3 Flow throws an Exception if there is an array in PSR-0 autoload in composer.json.
Exampl...
2013-09-25
-
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23241 -
- Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23241 -
- This might be related to #50585
-
- When calling ``unpublishPersistentResource``, now only the actually
intended Resource gets deleted, rather than the w... -
- Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24033 -
- As soon as a class which is *not* an entity was present as an
ancestor of an Entity (with at least one Entity descend...
Also available in: Atom