Activity

From 2013-10-15 to 2013-11-13

2013-11-13

18:32 Bug #53620: Move Classes/TYPO3/Flow/Composer to own Package
I can not find review or issue for adding postPackageUpdateAndInstall() and runPackageScripts() methods in Classes/TY... Rafael Kähm
18:26 Bug #53620 (New): Move Classes/TYPO3/Flow/Composer to own Package
By installing TYPO3 Flow or neos you get warnings on each dependency package "Class TYPO3\Flow\Composer\InstallerScri... Rafael Kähm
15:18 Revision 6dad43ef: [TASK] Remove persistAll() from IdentityRoutePart
Having IdentityRoutePart call persistAll() could have very weird and
unexpected side effects, not even mentioning “sa...
Karsten Dambekalns

2013-11-12

21:09 Revision 52e2d76c: [BUGFIX] Fix broken unit test for ConfigurationManager
Fixes a unit test that broke with a previous commit
Change-Id: I0705897bef5da66027dc87aab5b00b201f94b155
Releases: m...
Bastian Waidelich
19:57 Revision b8cec90f: [TASK] Add additional safeguard for corrupt user sessions
This adds an additional check into Context->getPartyByType() to avoid
"called member function on a non-object" errors...
Robert Lemke
16:55 Revision 2e1edd65: [TASK] Remove left over PHP closing tags
Releases: master
Change-Id: Iacab55cca28eb5b9c463aacd87f9054816533c2a
Bastian Waidelich
16:07 Bug #49847: PSR-0 compatible namespace with underscores is not loaded
I think so too Sören Rohweder

2013-11-11

21:05 Bug #53533 (New): Class reflection assumes reverse PSR-0, can lead to fail in autoloader
When gathering info about a package Flow currently assumes PSR-0 as bijective which is not the case.
Ie.
The fi...
Christian Jul Jensen
20:44 Bug #49847: PSR-0 compatible namespace with underscores is not loaded
This patch has been merged in master, I guess we can close the ticekt? Christian Jul Jensen

2013-11-10

01:05 Feature #51570: Unpersisted changes in Safe Requests should throw an Exception
Patch set 9 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availabl...
Gerrit Code Review
00:34 Feature #51570: Unpersisted changes in Safe Requests should throw an Exception
Patch set 8 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availabl...
Gerrit Code Review
00:17 Feature #51570: Unpersisted changes in Safe Requests should throw an Exception
Patch set 7 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availabl...
Gerrit Code Review

2013-11-08

15:43 Revision 8d5f7bf2: Merge "[TASK] Move isConnected from role repository to persistence manager"
Bastian Waidelich

2013-11-07

10:53 Feature #51570: Unpersisted changes in Safe Requests should throw an Exception
Patch set 6 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availabl...
Gerrit Code Review

2013-11-06

21:56 Feature #51570: Unpersisted changes in Safe Requests should throw an Exception
Patch set 5 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availabl...
Gerrit Code Review

2013-11-05

20:05 Feature #52064: HTTP components for handling requests
Patch set 18 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availab...
Gerrit Code Review
20:05 Feature #52064: HTTP components for handling requests
Patch set 17 for branch *master* of project *Packages/TYPO3.Flow* has been pushed to the review server.
It is availab...
Gerrit Code Review
17:48 Bug #47236: Error at offset 6279 of 6338
I could isolate it a bit more: The problem occurs with the native php serialization, not with igbinary.
The mentio...
Irene Höppner
16:39 Bug #47236: Error at offset 6279 of 6338
Seems to be a server settings topic. I have the same problem reproducable on my local machine, but not on the remote ... Irene Höppner
15:00 Bug #53350 (Accepted): Trying to create a Link in an Template in CLI Context should provide a helpful exception
Bastian Waidelich
15:00 Bug #53350 (Accepted): Trying to create a Link in an Template in CLI Context should provide a helpful exception
If you try to render a FluidTemplate with a link in it through a
CommandController it fails currently with this erro...
Marc Neuhaus

2013-11-04

09:21 Feature #33838: Add a way to configure Doctrine Mapping Type
Alexander Schnitzler wrote:
> As Adrian said it's possible to use \Doctrine\DBAL\Types\Type::addType('yourtype', 'Yo...
Karsten Dambekalns

2013-11-03

10:16 Revision 3fd5ad97: [BUGFIX] Fix wrong exception class name
In change I048360fc8883942d6561be92c2d0ad915e9f164e an exception was moved
around and not adjusted in all places.
Ch...
Karsten Dambekalns

2013-11-01

19:32 Bug #53238: Throw exception if PackageStates.php is not writeable
Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/25120
Gerrit Code Review
19:32 Bug #53238 (Under Review): Throw exception if PackageStates.php is not writeable
Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/25120
Gerrit Code Review
14:20 Bug #48290: Browser must not directly handle cookie
Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/20830
Gerrit Code Review
10:48 Bug #53262 (New): FileBakend have some race condition
One of the problem is that get() can be called before the file is available, so we need multiple try of file_get_cont... Dominique Feyer

2013-10-31

13:38 Feature #2817 (Needs Feedback): Provide safeguard for preventing multiple submits of a form
IMO this is not the responsibility of the framework as we can't know for sure whether a request is idempotent or not.... Bastian Waidelich

2013-10-30

23:45 Bug #53238 (Resolved): Throw exception if PackageStates.php is not writeable
The Package Manager writes package states to PackageStates.php file using
"file_put_contents()":http://forge.typo3.o...
Steffen Müller
12:04 Bug #53224 (New): Constructor in subclass breaks call chain leading to missing identifier / uuid
If a subclass in a class hierachy has constrcutor, the call chain of proxies constructors will be broken which will l... Christian Jul Jensen

2013-10-29

15:49 Revision e2e3ec46: Merge "[BUGFIX] var_dump() is unstyled if Flow is not in docroot"
Sebastian Kurfuerst
09:50 Bug #53189: Blog tutorial no longer works
This page contains the error: http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinitiveGuide/PartII/Controller.... Philipp Maier
09:46 Bug #53189 (New): Blog tutorial no longer works
People seem to have problems with the blog example here: http://docs.typo3.org/flow/TYPO3FlowDocumentation/TheDefinit... Philipp Maier

2013-10-28

18:33 Bug #49737: TYPO3.session.inactivityTimeout not working
ok, it really works. you can close that issue. Simon Schaufelberger
00:20 Bug #49737: TYPO3.session.inactivityTimeout not working
here is my message:... Simon Schaufelberger
14:39 Feature #53177 (New): entity resource policy value support for `this`
It would be great if a resource policy for an entity could be defined like:
resources:
entities:
\Some\Dom...
Benjamin Heek

2013-10-26

13:44 Feature #53080: Support for multiple domains
I basically see two options:
- configure the domain seperately from the uriPattern, which allows to handle paths in...
Alexander Berl

2013-10-25

14:25 Bug #53134 (Under Review): Regex Character class "alnum" not working correct in AlphanumericValidator
Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/25006
Gerrit Code Review
14:19 Bug #53134 (Closed): Regex Character class "alnum" not working correct in AlphanumericValidator
The Regex Character class "alnum" not working correct in AlphanumericValidator.
A better regular expression would be...
Michael Gerdemann
14:04 Feature #53080: Support for multiple domains
Hello folks,
i have currently no examples for that but is it maybe convinient to split up all domains by contexts(...
Rafael Kähm
12:30 Task #44566 (Closed): RFC: Change CGL to remove closing PHP tag
True, I'll close it. Christopher Hlubek
09:09 Task #44566: RFC: Change CGL to remove closing PHP tag
This seems to have been fixed with commit:d9d6ff9. Mathias Brodala

2013-10-24

22:58 Revision 5e1a8591: [TASK] Remove unused use statements
Change-Id: Iae50bec161d8562f9ffb368922ef3f80f73114dd
Releases: master
Rens Admiraal
22:56 Revision e53648c8: [TASK] CGL Fixes
* Removes indent from inline comments
* Fixes several docblock issues
* Fixes inline conditions
Change-Id: I2f08cf58...
Rens Admiraal
22:26 Revision 843cae1f: [TASK] Mention PHP closing tag omission in CGL
This updates the Coding Guidelines to omit the PHP closing tag.
Change-Id: Ie222d1465a60b00fe143bd4f8390f4b40e427b28...
Adrian Föder
22:26 Revision 17996c9f: Merge "[TASK] Mention PHP closing tag omission in CGL"
Karsten Dambekalns
22:26 Revision d9d6ff98: [TASK] Mention PHP closing tag omission in CGL
This updates the Coding Guidelines to omit the PHP closing tag.
Change-Id: Ie222d1465a60b00fe143bd4f8390f4b40e427b28...
Adrian Föder
11:41 Feature #53080: Support for multiple domains
Christopher Hlubek wrote:
Thanks for your feedback, this really helps pushing this forward!
> Well, I think the dom...
Bastian Waidelich
09:35 Feature #53080: Support for multiple domains
Well, I think the domain is not as "discrete" as the HTTP method, so users should be able to specify patterns for fle... Christopher Hlubek

2013-10-23

17:50 Feature #53080 (Closed): Support for multiple domains
Currently the Flow does not support multi-domain setups out of the box:
* There is no concept of "domains" in Flow...
Bastian Waidelich
17:47 Bug #44521 (Under Review): ObjectPathMappingRepository always checks case-sensitive
Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24977
Gerrit Code Review
17:46 Revision eac16e7f: [TASK] Replace some leftover FLOW3 in tests
Change-Id: Ie3856f4c8beb8139b2215f01fc1be177bf8faf72
Migration: TYPO3.Flow-201209251426
Releases: master, 2.0
Karsten Dambekalns
11:37 Bug #25801: Request arguments should never contain objects
Tim Spiekerkötter wrote:
Hi Tim,
> thank you for your answer. My request has two arguments, both are Extbase mo...
Bastian Waidelich
11:17 Bug #25801: Request arguments should never contain objects
Hi Bastian,
thank you for your answer. My request has two arguments, both are Extbase models and the FormViewHelpe...
Tim Spiekerkötter
09:36 Revision 27571d28: Merge "[BUGFIX] Safeguard against illegal filenames below Classes"
Karsten Dambekalns

2013-10-22

16:27 Revision 997a1cbe: Merge "[BUGFIX] Request::getRelativePath() must not return FALSE"
Tim Kandel
13:44 Feature #51459: Allow catching of particular exceptions on property mapping
yep it's to have a chance to ever find it again ;) Adrian Föder
12:53 Feature #51459: Allow catching of particular exceptions on property mapping
Adrian Föder wrote:
> A suggestion is here: https://review.typo3.org/#/c/23422/
..which you just abandoned. Mys...
Bastian Waidelich
12:44 Feature #51459: Allow catching of particular exceptions on property mapping
A suggestion is here: https://review.typo3.org/#/c/23422/ Adrian Föder
13:37 Bug #51809: Commit "[BUGFIX] Published resources don't support symlinks" produces an fatal error on Windows
Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23783
Gerrit Code Review
13:37 Feature #51676: Support of symlinks for Resources
Patch set 4 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/23783
Gerrit Code Review

2013-10-21

21:29 Revision 181a01b0: [TASK] Remove PHP closing tag
Releases: master
Change-Id: I2c62ac93654826b049523ca6838f077adf04f6de
Rens Admiraal
20:51 Revision e7499ac2: [BUGFIX] var_dump() is unstyled if Flow is not in docroot
If TYPO3 Flow is not directly in the document root the var_dump
output is unstyled as the path to the external CSS ca...
Rens Admiraal
19:16 Feature #33838: Add a way to configure Doctrine Mapping Type
As Adrian said it's possible to use \Doctrine\DBAL\Types\Type::addType('yourtype', 'Your\Whatever\Type'); and so on t... Alexander Schnitzler
17:16 Feature #33838: Add a way to configure Doctrine Mapping Type
it looks like you can do the following, at least, @Package.php@:... Adrian Föder
17:55 Revision cebda033: [BUGFIX] Safeguard against illegal filenames below Classes
If a filename below Classes in a package contains dots, Flow breaks
when it tries to flush caches during startup.
Se...
Karsten Dambekalns
17:22 Bug #53010 (Under Review): UsernamePasswordHttpBasic disabled since .htaccess strips "Basic"
Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24936
Gerrit Code Review
17:15 Bug #53010 (Resolved): UsernamePasswordHttpBasic disabled since .htaccess strips "Basic"
Hey there.
The Token\UsernamePasswordHttpBasic requires the "Authentication" header to begin with "Basic". That's ...
Stephan Schuler
16:33 Feature #41301 (Rejected): Allow action-method-dependent errorAction
this could also be done with setting the @->errorMethodName@ in the appropriate @initialize*Action@ wherever needed. Adrian Föder
15:49 Bug #52311: Uuid validator doesn't have string boundaries
Patch set 1 for branch *2.0* has been pushed to the review server.
It is available at https://review.typo3.org/24926
Gerrit Code Review
15:49 Revision 0b91dd2c: [BUGFIX] UUID Validator rejects too long UUIDs
Now the validation regex has start- and end of string
boundaries, hence rejecting strings which only
contain a valid ...
Adrian Föder
15:49 Revision 6128102a: Merge "[BUGFIX] UUID Validator rejects too long UUIDs"
Karsten Dambekalns
15:11 Revision fef70081: Merge "[FEATURE] A boolean value Validator"
Bastian Waidelich
14:44 Revision 78a0d2a5: Merge "[FEATURE] Add tagging to router cache"
Bastian Waidelich
14:36 Task #52704 (Resolved): Get rid of RouterCachingAspect
Applied in changeset commit:d645b051ad3d8adb849649ff4076c7759c9c006f. Bastian Waidelich
13:39 Revision b220c235: Merge "[TASK] Get rid of RouterCachingAspect"
Bastian Waidelich
13:39 Revision cf135ad5: Merge "[TASK] Cleanup RouterCachingService"
Bastian Waidelich
13:22 Revision 7534a582: [TASK] Update commit message documentation
Tweaks the documentation for proper git commit messages
and adds some examples.
Change-Id: I0765da6ac4ef4a1d7e3b8fcf...
Bastian Waidelich
12:00 Feature #52064: HTTP components for handling requests
Patch set 16 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/20821
Gerrit Code Review
12:00 Feature #45293: More flexible parsing of body arguments
Patch set 8 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/21134
Gerrit Code Review
11:26 Revision f5781451: Merge "[FEATURE] Command to list registered type converters"
Bastian Waidelich
10:32 Revision bffd27f4: Merge "[BUGFIX] Injected properties are not available in initializeObject()"
Robert Lemke

2013-10-19

19:10 Bug #52944: Generating correct proxy classes for classes without a namespace
Patch set 2 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24904
Gerrit Code Review
19:02 Bug #52944 (Under Review): Generating correct proxy classes for classes without a namespace
Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24904
Gerrit Code Review
12:52 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
I'd still say it's a bug that namespace-less classes cannot be autoloaded. The same happens when trying to autoload T... Alexander Berl
12:47 Bug #36734: Transient properties cannot be property mapped
Patch set 5 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/19862
Gerrit Code Review

2013-10-18

13:25 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
The reason for this issue belongs to the IRC chat.
Because I wanted to use the ChromePHP library but the ChromePHP c...
Hendrik Frahmann
13:08 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
Issue should be updated then to "Class Loader doesn't handle empty namespaces" or similar Alexander Berl
12:38 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
Alexander Berl wrote:
> However, I can see that the class loader currently doesn't handle empty namespaces - so if t...
Hendrik Frahmann
12:26 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
I don't think those are related. The class loader only considers packages that are active (see PackageManager::initia... Alexander Berl
11:44 Bug #52945: Excluded classes should only be excluded from reflection but still autoloaded
Needs to be verified yet. Could be related to this one #52944.
Will investigate both later today.
Philipp Maier
11:42 Bug #52945 (New): Excluded classes should only be excluded from reflection but still autoloaded
Classes that are excluded in the settings.yaml (Flow > object > excludeClasses) should still be able to autoload.
Hendrik Frahmann
13:21 Revision aff1fd46: Merge "[TASK] Cleanup usage of return value on @return void method"
Karsten Dambekalns
12:44 Revision be54ffb5: [TASK] Improve documentation for excludeClasses setting
Change-Id: Iaaef26f3c0ff8e6f812cb338e677a8a68de72b43
Releases: master, 2.0
Karsten Dambekalns
12:11 Feature #52064: HTTP components for handling requests
The current configuration format is:... Bastian Waidelich
11:53 Bug #52944: Generating correct proxy classes for classes without a namespace
Should be trivial to fix with an if condition. See Object/Proxy/ProxyClass::render() line 195 ff.:... Alexander Berl
11:33 Bug #52944: Generating correct proxy classes for classes without a namespace
A real example would be this:
https://gist.github.com/hfrahmann/7037897#file-flow-cache-chromephp-php-L15
Philipp Maier
11:29 Bug #52944 (Resolved): Generating correct proxy classes for classes without a namespace
When packages (that are loaded with composer to Libraries) containing classes without a namespace, Flow generates a c... Hendrik Frahmann

2013-10-17

17:43 Bug #25801: Request arguments should never contain objects
Tim Spiekerkötter wrote:
> I have a huge hidden [__referrer][arguments] field with several kb in size. That causes...
Bastian Waidelich
17:35 Bug #25801: Request arguments should never contain objects
Has this ever been backported to Extbase? I have a huge hidden [__referrer][arguments] field with several kb in size.... Tim Spiekerkötter
16:22 Revision 2955be47: [BUGFIX] Request::getRelativePath() must not return FALSE
This makes sure that ``Request::getRelativePath()`` always returns
a string.
This getter has been introduced with
I4...
Bastian Waidelich
14:36 Bug #52907 (Resolved): #1355480641: Uncaught Exception
Applied in changeset commit:7e0c425ceefd06252ef00b9addcd9389f1e7d950. Bastian Waidelich
12:27 Bug #52907: #1355480641: Uncaught Exception
THX Kay Strobach
12:03 Bug #52907 (Under Review): #1355480641: Uncaught Exception
Patch set 1 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24862
Gerrit Code Review
11:57 Bug #52907 (Accepted): #1355480641: Uncaught Exception
Ok, thanks to your feedback I could reproduce the issue (it happens only after flushing the cache, after a refresh yo... Bastian Waidelich
10:46 Bug #52907: #1355480641: Uncaught Exception
this is how i produced the exception.
!2013-10-17_10-41-58.png!...
Kay Strobach
10:31 Bug #52907: #1355480641: Uncaught Exception
Kay Strobach wrote:
> keep it closed - i agree. I had a misconfigured Entity (created out of the context and then ...
Bastian Waidelich
10:27 Bug #52907: #1355480641: Uncaught Exception
keep it closed - i agree. I had a misconfigured Entity (created out of the context and then copied into a FLOW projec... Kay Strobach
10:21 Bug #52907 (Needs Feedback): #1355480641: Uncaught Exception
Hi Kay,
can you give some more context? Where do you get this exception? If I add a property:...
Bastian Waidelich
10:15 Bug #52907: #1355480641: Uncaught Exception
I think that would open kind of a "box" if it's started to catch these kind of errors. I even suspect that's rather h... Adrian Föder
10:10 Bug #52907: #1355480641: Uncaught Exception
mhmm ok, but it would be possible to catch and enhance it ;) - for usability reasons a good error message would be gr... Kay Strobach
09:54 Bug #52907 (Rejected): #1355480641: Uncaught Exception
Hello Kay,
this is a Doctrine exception, hence out of the competence of Flow...
Feel free to reopen if you disagr...
Adrian Föder
09:44 Bug #52907 (Resolved): #1355480641: Uncaught Exception
... Kay Strobach
12:02 Revision 7e0c425c: [BUGFIX] Expose more details in MappingExceptions
This adds a try/catch block to the FlowAnnotationDriver adding the
affected class name to the message of the thrown e...
Bastian Waidelich
11:24 Bug #52909 (New): Class Loader fallback to non-proxy hides fatal errors
Hey there.
This commit is slightly related to #46689. But since #46689 has drifted to focusing doc parsing and ann...
Stephan Schuler

2013-10-15

20:26 Task #52704: Get rid of RouterCachingAspect
Patch set 3 for branch *master* has been pushed to the review server.
It is available at https://review.typo3.org/24579
Gerrit Code Review
18:27 Bug #52014: Migration makes fields NOT NULL even though not true
Although a little bit of a late answer:
In general, validation has no influence on the database schema. By default...
Philipp Maier
18:19 Revision 2b702b0f: [FEATURE] Add tagging to router cache
This adjusts the RouterCachingService to tag every Routing cache entry
with any UUID the routeValues/matchResult cont...
Tim Kandel
18:19 Revision d645b051: [TASK] Get rid of RouterCachingAspect
This moves code from the RouterCache AOP aspect to the Router itself
making the aspect redundant.
Before the cache h...
Bastian Waidelich
18:18 Revision 2a4a7f46: [TASK] Cleanup RouterCachingService
Some (mostly cosmetic) adjustments to our CGL and some
renamings to increase readability.
This also renames the misl...
Bastian Waidelich
16:21 Revision 2df9c7cf: [TASK] Move isConnected from role repository to persistence manager
To make isConnected api, we have to move it to some central
place. The persistence manager seems to be a lot better p...
Andreas Förthner
14:49 Revision 3ba15f01: [BUGFIX] Role handling depends on an active database connection
The PolicyService now depends on having an active database connection.
This connection is not always available (like ...
Rens Admiraal
13:36 Bug #44521 (Resolved): ObjectPathMappingRepository always checks case-sensitive
Applied in changeset commit:9ec9717a5ba73e7dab90f74fc9e167333930ed87. Karsten Dambekalns
13:36 Bug #51082 (Resolved): Object Route Parts should take persistence_object_identifier into account
Applied in changeset commit:3ca238501129a075a4b1dfe67b536e9df2fb2081. Bastian Waidelich
12:43 Revision c93bb32a: Merge "[BUGFIX] Object Route Parts fall back to technical identifier"
Bastian Waidelich
12:42 Revision da6b2c2f: Merge "[BUGFIX] Respect case-sensitivity in object routing"
Bastian Waidelich
10:30 Revision 5438318b: [BUGFIX] Don't catch security exceptions during property mapping
As security exceptions will be handled by the security
framework, we have to let them bubble up instead of
converting...
Andreas Förthner
 

Also available in: Atom