Activity

From 2012-05-25 to 2012-06-23

2012-06-21

11:23 Revision edd10b4d: [TASK] Code cleanup
Does code cleanup, mostly to documentation, but also tweaks
unused variables, missing return statements and similar t...
Karsten Dambekalns
10:43 Revision 630992b7: [BUGFIX] Only render hidden upload fields if a resource is available
The UploadViewHelper always creates hidden fields for filename and
resource pointer so that previously uploaded files...
Bastian Waidelich
10:41 Revision ecc4f01e: [BUGFIX] Only render hidden upload fields if a resource is available
The UploadViewHelper always creates hidden fields for filename and
resource pointer so that previously uploaded files...
Bastian Waidelich
10:37 Revision 39f691af: Merge "[TASK] Code cleanup" into FLOW3-1.1
Karsten Dambekalns

2012-06-20

20:51 Revision 40a283fb: [TASK] Update Package.xml with new version number
Change-Id: I4da20c6b28ab6afabc91dd221303bd771362b3d3
Releases: 1.1
Karsten Dambekalns
19:26 Revision a8b58323: [TASK] Update Package.xml with new version number
Change-Id: I8a259401b2a10c97f9f6d23d4f185f7b1172f557
Releases: 1.1
Karsten Dambekalns
11:37 Task #11636 (Resolved): Form viewhelper not functional with method GET
Applied in changeset commit:488b238d9436d73df7e06679a6e76e83515f0fb7. Christopher Hlubek
11:12 Task #11636: Form viewhelper not functional with method GET
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
10:35 Task #11636: Form viewhelper not functional with method GET
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11571
Gerrit Code Review
10:32 Revision 488b238d: [TASK] Add query parameters for form action as hidden fields
This change makes the form viewhelper usable with method GET by adding
query parameters of the action as hidden field...
Christopher Hlubek

2012-06-19

19:59 Task #11636: Form viewhelper not functional with method GET
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11571
Gerrit Code Review
12:15 Feature #31765 (Closed): Forward to Action of widgetController
There has been no feedback for a while here. If this is still an issue, feel free to reopen. Thanks for your understa... Karsten Dambekalns

2012-06-18

23:20 Revision ad4ed841: [TASK] Code cleanup
Does code cleanup, mostly to documentation, but also tweaks
unused variables, missing return statements and similar t...
Karsten Dambekalns
21:00 Feature #3725: CSS Engine
Or, instead of using: ... Jacob Floyd
20:13 Feature #3725: CSS Engine
If you're going to make a "CSS Engine", make an interface type thing that makes it easy to implement other css pre-pr... Jacob Floyd
20:21 Feature #33394: Logical expression parser for BooleanNode
How will Eel be integrated in Fluid? A view helper? I couldn't find a ticket about that - is there one? Do we need on... Jacob Floyd
17:59 Revision 0a43a537: Merge "[FEATURE] Add a ViewHelper for entity identifier retrieval" into FLOW3-1.1
Karsten Dambekalns
17:38 Task #13342 (Resolved): f:form.checkbox does only render hidden input for first item of same name
Applied in changeset commit:9f01a42dc97a85f22a08c4d7ca75405fe1e75557. Bastian Waidelich
11:36 Task #13342 (Under Review): f:form.checkbox does only render hidden input for first item of same name
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
17:38 Bug #26481 (Resolved): hidden fields should be rendered in extra section
Applied in changeset commit:9f01a42dc97a85f22a08c4d7ca75405fe1e75557. Bastian Waidelich
11:36 Bug #26481 (Under Review): hidden fields should be rendered in extra section
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
17:38 Bug #35894 (Resolved): CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Applied in changeset commit:dec3b187b6db773a5a84dec70918c22f428cb994. Rens Admiraal
17:36 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 3 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
17:20 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 2 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
15:41 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
15:22 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 8 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
15:19 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
10:53 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
17:36 Revision dec3b187: [BUGFIX] Fix unusable checkbox/radio if formObject is NULL
When using a form object inside of a form view helper inside an index
action template and a checkbox is referring to ...
Rens Admiraal
15:22 Revision cbe93048: [BUGFIX] Fix unusable checkbox/radio if formObject is NULL
When using a form object inside of a form view helper inside an index
action template and a checkbox is referring to ...
Rens Admiraal
11:45 Feature #38147: Suggested addition to SelectViewHelper - allowing prepend/append of child content to rendered option tag list
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/2113
Gerrit Code Review
11:42 Feature #38147 (Closed): Suggested addition to SelectViewHelper - allowing prepend/append of child content to rendered option tag list
This is a simple but functional and useful addition to the SelectViewHelper. It adds two new boolean attributes: prep... Claus Due
11:36 Revision 9f01a42d: [BUGFIX] hidden fields should be rendered in extra section
Currently form.select and form.checkbox ViewHelpers render
hidden fields before the actual input field in order to
fo...
Bastian Waidelich
11:33 Bug #36662: Checked state isn't always correct when property is collection
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10829
Gerrit Code Review
11:19 Task #11636: Form viewhelper not functional with method GET
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11571
Gerrit Code Review
10:37 Feature #33494 (Resolved): Verify state and future intentions of a persistence identity VH
Applied in changeset commit:c8d53e983c5a387b80560fd2bd62556a4c91833a. Adrian Föder
10:24 Feature #33494: Verify state and future intentions of a persistence identity VH
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
10:22 Feature #33494: Verify state and future intentions of a persistence identity VH
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11484
Gerrit Code Review
10:24 Revision 85bca322: [FEATURE] Add a ViewHelper for entity identifier retrieval
This adds a ViewHelper "format.identifier" that returns
the plain identifier for a given entity.
Change-Id: I1348648...
Adrian Föder
10:22 Revision c8d53e98: [FEATURE] Add a ViewHelper for entity identifier retrieval
This adds a ViewHelper "format.identifier" that returns
the plain identifier for a given entity.
Change-Id: I1348648...
Adrian Föder

2012-06-17

09:54 Feature #38130 (New): Checkboxes and multiple select fields should have an assignable default value
Currently, when a checkbox is left unchecked, an empty string is submitted for its value. But sometimes I'd like to d... Jost Baron

2012-06-12

16:37 Bug #37671 (Resolved): ViewHelper exceptions should not be caught in testing context
Applied in changeset commit:5a75ed885661b11d73715acc82922936b438f0b1. Sebastian Kurfuerst
16:25 Bug #37671 (Under Review): ViewHelper exceptions should not be caught in testing context
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
16:25 Revision 5a75ed88: [BUGFIX] ViewHelper exceptions should not be caught in testing context
While it is correct that ViewHelper exceptions are silently logged in
production context, they should be displayed in...
Sebastian Kurfuerst

2012-06-07

18:37 Bug #37671 (Resolved): ViewHelper exceptions should not be caught in testing context
Applied in changeset commit:166e7e54a8ff03e44cd5e692e273894280594b32. Sebastian Kurfuerst
11:43 Bug #37671: ViewHelper exceptions should not be caught in testing context
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11787
Gerrit Code Review
11:43 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
09:19 Revision 166e7e54: [BUGFIX] ViewHelper exceptions should not be caught in testing context
While it is correct that ViewHelper exceptions are silently logged in
production context, they should be displayed in...
Sebastian Kurfuerst

2012-06-05

21:32 Revision ba2f8851: [TASK] Update Package.xml with new version number
Change-Id: Ibaaa944f638b6a56f3557ea3dd229e976f4499ae
Releases: 1.0
Karsten Dambekalns
21:30 Revision 152ae289: [TASK] Update Package.xml with new version number
Change-Id: Ibe36949d2d54b00e68956002cfe0db6b01d1d1d2
Releases: 1.0
Karsten Dambekalns

2012-06-03

02:54 Feature #35748: Add generic data-* attribute
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10184
Gerrit Code Review
02:54 Feature #35748: Add generic data-* attribute
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11803
Gerrit Code Review

2012-06-01

10:59 Bug #37671 (Under Review): ViewHelper exceptions should not be caught in testing context
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11787
Gerrit Code Review
10:57 Bug #37671 (Resolved): ViewHelper exceptions should not be caught in testing context
Sebastian Kurfuerst
10:54 Bug #29603 (Closed): __toString() usage for rendering the compiled Fluid template breaks the concept of security exceptions
After looking at it and discussing it once again with my colleague, this was probably fixed somewhen along the way. W... Andreas Förthner

2012-05-31

14:25 Bug #29603: __toString() usage for rendering the compiled Fluid template breaks the concept of security exceptions
Hi Sebastian,
I'm currently checking this, probably you are right, that this was only a problem with the old TS re...
Andreas Förthner
14:04 Bug #29603 (Needs Feedback): __toString() usage for rendering the compiled Fluid template breaks the concept of security exceptions
I fear that I need more feedback in here.
Inside fluid, __toString is definitely never used.
Could it have some...
Sebastian Kurfuerst
11:29 Revision 575adc24: [TASK] Update Package.xml with new version number
Change-Id: Iea7c65241130b94ad680ead9f2b9447b9f830949
Releases: 1.2
Karsten Dambekalns
10:16 Revision 9ea875e8: [TASK] Update Package.xml with new version number
Change-Id: I785aaed74c64e97147c62b43a831ea18b381b0f8
Releases: 1.1
Karsten Dambekalns

2012-05-30

23:17 Bug #37619 (New): Fatal Error when using variable in name attribute of Section ViewHelper
I'm experiencing this error with TYPO3 4.6, but from looking at the code I'm pretty sure this is reproducible with FL... Sebastian Michaelsen
22:37 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
21:56 Bug #31380 (Resolved): DocComment of Form.ValidationResultsViewHelper is incorrect
Karsten Dambekalns
17:27 Revision 6f1b39d8: [TASK] Standalone View: enable escaping for "html"
Since the introduction of Content Negotiation to FLOW3
(I7d753155aa72f41e3df85b076e8067bcbfe7ac04), the default
Forma...
Robert Lemke
10:53 Revision db77eca6: [TASK] Standalone View: set default format "html"
Since the introduction of Content Negotiation to FLOW3
(I7d753155aa72f41e3df85b076e8067bcbfe7ac04), the default
Forma...
Robert Lemke

2012-05-29

18:41 Bug #33628: Multicheckboxes (multiselect) for Collections don’t work
Kira Backes wrote:
Hi Kira,
> > Could someone verify that https://review.typo3.org/#/c/11648/ solves this issue...
Bastian Waidelich
10:10 Bug #33628: Multicheckboxes (multiselect) for Collections don’t work
Bastian Waidelich wrote:
>
> Could someone verify that https://review.typo3.org/#/c/11648/ solves this issue?
I...
Kira Backes
11:17 Revision 3d750231: Merge "[FEATURE] Allow access to attributes in TagBuilder" into FLOW3-1.1
Karsten Dambekalns
09:44 Task #37558 (Resolved): Form.Textfield ViewHelper's placeholder attribute should be (re)moved
currently, the @placeholder@ attribute in the Textfield ViewHelper is explicitly enabled: ... Adrian Föder
09:07 Feature #37496: placeholder attribute in textarea-viewhelper
thanks for this hint!
i saw the placeholder-argument for the textfield-viewhelper and thought that this is missing f...
Martin Hummer
08:58 Feature #37496 (Closed): placeholder attribute in textarea-viewhelper
you can easily add arbitrary attributes with the @additionalAttributes@ attribute; this goes for every tag based View... Adrian Föder
08:52 Bug #26481 (Resolved): hidden fields should be rendered in extra section
Sebastian Kurfuerst
08:52 Task #13342 (Resolved): f:form.checkbox does only render hidden input for first item of same name
Sebastian Kurfuerst
06:04 Bug #37543 (Accepted): Additional __identity field when using TYPO3.Media
I'll take care of that; the solution you proposed is just a workaround unfortunately. Sebastian Kurfuerst

2012-05-28

14:30 Bug #37543 (Closed): Additional __identity field when using TYPO3.Media
When using a <f:form.upload /> field for uploading a TYPO3.Media Image, FLUID adds a hidden __identity field for the ... Michel Albers
12:28 Bug #33628 (Needs Feedback): Multicheckboxes (multiselect) for Collections don’t work
Bastian Waidelich wrote:
> As commented on the review request already: I'm not happy with the implementation as it...
Bastian Waidelich

2012-05-26

21:27 Task #13342 (Under Review): f:form.checkbox does only render hidden input for first item of same name
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11648
Gerrit Code Review
19:19 Task #13342 (Accepted): f:form.checkbox does only render hidden input for first item of same name
Bastian Waidelich wrote:
> [...] the hidden field is *not* generated in a *second* form, when you
> use the same ...
Bastian Waidelich
09:40 Task #13342 (Needs Feedback): f:form.checkbox does only render hidden input for first item of same name
Hi Martin ;)
I just checked this one again and I think, I missunderstood you.
Are you saying, that the hidden field...
Bastian Waidelich
21:27 Bug #26481 (Under Review): hidden fields should be rendered in extra section
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11648
Gerrit Code Review
09:35 Bug #26481: hidden fields should be rendered in extra section
Sorry for the delay on this one. I take care of implementing this for 1.1! Bastian Waidelich
21:27 Revision f25fa5fb: [BUGFIX] hidden fields should be rendered in extra section
Currently form.select and form.checkbox ViewHelpers render
hidden fields before the actual input field in order to
fo...
Bastian Waidelich
17:31 Feature #37506: Building up Nested Forms with this ViewHelper
Damn :)
Touché!
i will try this.
sometimes life could be so easy :P
but maybe the viewhelper is still usefull if ...
Carsten Bleicker
17:27 Feature #37506 (New): Building up Nested Forms with this ViewHelper
Carsten Bleicker wrote:
> so i can build up just only one partial wich holds any fields.
> namespacing is set by ...
Bastian Waidelich
17:08 Feature #37506: Building up Nested Forms with this ViewHelper
For example i have an address model and want to
use this in an order model.
deliveryAddress
billingAddress
so i can ...
Carsten Bleicker
16:59 Feature #37506 (Needs Feedback): Building up Nested Forms with this ViewHelper
Bastian Waidelich
16:59 Feature #37506: Building up Nested Forms with this ViewHelper
Hi Carsten,
why isn't that working for you:...
Bastian Waidelich
16:11 Feature #37506: Building up Nested Forms with this ViewHelper
Sorry for these stupid inline comments.
Usage now in the comments of attached php file.
Carsten Bleicker
15:58 Feature #37506 (Closed): Building up Nested Forms with this ViewHelper
Just want to know what you think about this viewhelper
f.e. you sould be able to pass one object to <f:form object="...
Carsten Bleicker
15:35 Feature #37460 (Resolved): TagBuilder should allow access to attribue collection
Applied in changeset commit:afaacebed16d6b9ab2cb320fecc32be6a9d7d69a. Christopher Hlubek
15:35 Bug #35041 (Resolved): TranslateViewHelper returns empty string if id is missing and view helper tag is empty
Applied in changeset commit:68e3bad56dfc67911d8c968f792b90bc8d55579f. Karsten Dambekalns
03:31 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
03:30 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
03:26 Bug #35894 (Under Review): CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11637
Gerrit Code Review
02:59 Bug #35894: CheckboxViewHelper and RadioViewHelper missing an existence check for formObject, and thus an exception is being thrown
The problem is that we get formObject = NULL
1. ... if we visit the index action
2. ... if the form submit fails
...
Sebastian Wojtowicz

2012-05-25

22:30 Feature #37496 (Closed): placeholder attribute in textarea-viewhelper
hello,
i just discovered that the placeholder attribute in the textarea viewhelper is missing.
the following code...
Martin Hummer
21:56 Bug #35041: TranslateViewHelper returns empty string if id is missing and view helper tag is empty
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11627
Gerrit Code Review
15:06 Bug #35041: TranslateViewHelper returns empty string if id is missing and view helper tag is empty
Patch set 2 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
15:03 Bug #35041 (Under Review): TranslateViewHelper returns empty string if id is missing and view helper tag is empty
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
21:56 Revision 68e3bad5: [BUGFIX] Avoid empty output of TranslateViewHelper
If translation by ID is used but no translation is found, the ID will now be
returned if the view helper tag has no c...
Karsten Dambekalns
16:21 Feature #33494: Verify state and future intentions of a persistence identity VH
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11484
Gerrit Code Review
16:09 Feature #33494: Verify state and future intentions of a persistence identity VH
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/11484
Gerrit Code Review
15:30 Feature #37460: TagBuilder should allow access to attribue collection
Patch set 2 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
15:29 Feature #37460: TagBuilder should allow access to attribue collection
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
15:30 Revision f5337883: [FEATURE] Allow access to attributes in TagBuilder
Change-Id: Ib3f9aead9a4e10176816aab4fd0e0627f7180305
Resolves: #37460
Releases: 1.1, 1.2
Christopher Hlubek
15:06 Revision cd86a2dd: [BUGFIX] Avoid empty output of TranslateViewHelper
If translation by ID is used but no translation is found, the ID will now be
returned if the view helper tag has no c...
Karsten Dambekalns
14:57 Bug #37387 (Needs Feedback): Translate Helper: Arguments replacement is not working for default value
Right, but the fact that there is output is rather due to the fact that the VH itself does:... Karsten Dambekalns
 

Also available in: Atom