Activity

From 2012-07-12 to 2012-08-10

2012-08-10

23:12 Feature #33215: RFC: Dynamic values in ObjectAccess paths
Would be nice to have that feature, I like the syntax suggestion with ... Christian Müller
19:23 Feature #33215: RFC: Dynamic values in ObjectAccess paths
Yeah, me too and I did it with a simple ViewHelper, too. But I really would not go for another nested curly braces sy... Christopher Hlubek
18:11 Feature #33215: RFC: Dynamic values in ObjectAccess paths
I had this requirement already (solved it by implementing an object-accessor viewhelper that gets an object path stri... Alexander Berl
19:10 Feature #39682: Disregegard { as Fluid variable when followed by a white space
I find the idea of only allowing array syntax in viewhelper arguments interesting. It's at least worth a second thoug... Alexander Berl
15:27 Feature #39682: Disregegard { as Fluid variable when followed by a white space
Adrian Föder wrote:
> I would really like to see an additional option, because especially when attempting
> to ma...
Bastian Waidelich
13:23 Feature #39682: Disregegard { as Fluid variable when followed by a white space
great that actually a discussion comes up; Sebastian, no need to sorry, that's why I opened this issue ;)
Sebastian, ...
Adrian Föder
13:01 Feature #39682: Disregegard { as Fluid variable when followed by a white space
Hi all,
first I thought "great!" but after thinking about it again, I agree to Sebastians opinion:
Instead of
<p...
Bastian Waidelich
12:23 Feature #39682 (Rejected): Disregegard { as Fluid variable when followed by a white space
sorry, I'm strongly against this change going in. Fluid should be whitespace-agnostic.
Instead of introducing thes...
Sebastian Kurfuerst
12:21 Feature #39682: Disregegard { as Fluid variable when followed by a white space
yes alex, definitely your example would also be invalid syntax. You then would have to write... Adrian Föder
12:15 Feature #39682: Disregegard { as Fluid variable when followed by a white space
What about Fluid array notation? Would you also unconsider "{ foo: 'bar' }" as invalid array syntax?
IMO that's too ...
Alexander Berl
11:26 Feature #39682 (Rejected): Disregegard { as Fluid variable when followed by a white space
This is a reopen of an issue I had long time ago, so, long story short:
There's still the need for some CDATA wrap...
Adrian Föder
10:35 Task #6757: support literal strings in boolean arguments
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review
01:55 Task #6757: support literal strings in boolean arguments
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13555
Gerrit Code Review
01:49 Task #6757: support literal strings in boolean arguments
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13554
Gerrit Code Review
01:33 Task #6757: support literal strings in boolean arguments
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review
01:24 Task #6757: support literal strings in boolean arguments
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review
01:24 Task #6757: support literal strings in boolean arguments
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review
00:27 Task #6757: support literal strings in boolean arguments
Ok, so after quite some fiddling with this and the Viewhelpertest package, I come to the following conclusions:
1)...
Alexander Berl
10:33 Revision 125413ca: [TASK] Support literal strings in boolean arguments
This change adds support for string literals in boolean comparisons.
String literals have to be surrounded by single ...
Alexander Berl
09:35 Bug #39604 (Resolved): TemplateParser unquoteString does not trim escaped quotes correctly
Applied in changeset commit:c852f275cf73da7fece821976e771dea823bea24. Alexander Berl
09:18 Bug #39604: TemplateParser unquoteString does not trim escaped quotes correctly
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
09:18 Revision c852f275: [BUGFIX] TemplateParser unquoteString does not trim escaped quotes correctly
This change fixes wrong trimming of trailing quotes in escaped sequences
by replacing trim() calls with a preg_replac...
Alexander Berl
09:18 Revision 1fad7bff: Merge "[BUGFIX] TemplateParser unquoteString does not trim escaped quotes correctly"
Karsten Dambekalns

2012-08-09

21:30 Bug #39604: TemplateParser unquoteString does not trim escaped quotes correctly
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13511
Gerrit Code Review
21:17 Revision 009b1fc6: [BUGFIX] TemplateParser unquoteString does not trim escaped quotes correctly
This change fixes wrong trimming of trailing quotes in escaped sequences
by replacing trim() calls with a preg_replac...
Alexander Berl
16:35 Feature #39410 (Resolved): Implement reserved variables returning their intended representation
Applied in changeset commit:3000719576da649017a4cbed51da2c2c058737f6. Adrian Föder
13:23 Feature #39410: Implement reserved variables returning their intended representation
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13358
Gerrit Code Review
13:22 Revision 30007195: [FEATURE] Reserved variables represent their meaning when accessing
All reserved variables, ie true, false, on, off etc. now represent
their intended value when accessing them.
Change-...
Adrian Föder

2012-08-08

02:06 Bug #39604 (Under Review): TemplateParser unquoteString does not trim escaped quotes correctly
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13511
Gerrit Code Review
01:50 Bug #39604 (Resolved): TemplateParser unquoteString does not trim escaped quotes correctly
Assume the following case:... Alexander Berl

2012-08-07

17:35 Task #39255 (Resolved): reflectionService property in AbstractViewHelper should be protected instead of private
Applied in changeset commit:4b3c0967b73ebe13e044dab061192999c016b60b. Anonymous
17:35 Bug #39456 (Resolved): Action URI of the form ViewHelper is not reset
Applied in changeset commit:694538964346bc39f0dbf90725fd5474c6c5ee08. Bastian Waidelich
17:18 Bug #39428: Layout and partial identifiers should be independent of current controller name
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13391
Gerrit Code Review
16:56 Revision dfa62024: Merge "[TASK] Make reflectionService property in AbstractViewHelper protected"
Karsten Dambekalns
13:44 Feature #33394: Logical expression parser for BooleanNode
I think to re-use the same expression parser is generally a great idea and was also a motivation when writing Eel. Bu... Christopher Hlubek
13:23 Task #5636: Form_RadioViewHelper and CheckBoxViewHelper miss check for existing object before it is accessed.
Is there any news about this issue? Unfortunately in 4.7.2 this problem still exists which might extbase/fluid show u... Michael Bakonyi
01:32 Task #6757: support literal strings in boolean arguments
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review

2012-08-06

12:14 Feature #33394: Logical expression parser for BooleanNode
I'm not sure if it's a good idea to add a new syntax construct for expressions in fluid. It could confuse people on w... Alexander Berl

2012-08-04

18:12 Task #6757: support literal strings in boolean arguments
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review

2012-08-03

16:18 Bug #37543: Additional __identity field when using TYPO3.Media
Two remarks from my point of view (using 1.1 rc2 and TYPO3.Media) to probably make things clearer:
1. The problem on...
Martin Keck

2012-08-02

11:10 Bug #39456: Action URI of the form ViewHelper is not reset
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
11:10 Revision 299ad012: [BUGFIX] Action URI of the form ViewHelper is not reset
Form ViewHelpers store the action URI attribute for performance
reasons.
But because instances of ViewHelpers are reu...
Bastian Waidelich
01:34 Task #6757: support literal strings in boolean arguments
I just took the initial idea further and required string literals to be written in single quotes.
This is necessary ...
Alexander Berl
01:09 Task #6757 (Under Review): support literal strings in boolean arguments
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13421
Gerrit Code Review

2012-08-01

18:44 Bug #39456 (Under Review): Action URI of the form ViewHelper is not reset
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13417
Gerrit Code Review
18:33 Bug #39456 (Resolved): Action URI of the form ViewHelper is not reset
The Form ViewHelper stores the action URI attribute for performance reasons.
BUt because instances of ViewHelpers ar...
Bastian Waidelich
18:44 Revision 69453896: [BUGFIX] Action URI of the form ViewHelper is not reset
Form ViewHelpers store the action URI attribute for performance
reasons.
But because instances of ViewHelpers are reu...
Bastian Waidelich

2012-07-31

23:31 Bug #39428 (Under Review): Layout and partial identifiers should be independent of current controller name
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13391
Gerrit Code Review
19:12 Bug #39428 (Resolved): Layout and partial identifiers should be independent of current controller name
Currently, all templates get an identifier made up of package/subpackage, controller, prefix and unique hash.
This l...
Alexander Berl
11:08 Feature #39410 (Under Review): Implement reserved variables returning their intended representation
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13358
Gerrit Code Review
10:58 Feature #39410 (Accepted): Implement reserved variables returning their intended representation
Adrian Föder
10:58 Feature #39410 (Resolved): Implement reserved variables returning their intended representation
currently, in Fluid there are reserved variables anyway, like true, false, on, off etc.
Enable accessing these value...
Adrian Föder

2012-07-30

09:00 Bug #31189 (Resolved): Make TextareaViewHelper HTML5 aware
Karsten Dambekalns
08:40 Bug #31189: Make TextareaViewHelper HTML5 aware
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13076
Gerrit Code Review
08:28 Revision 2ed20916: [BUGFIX] Make TextareaViewHelper HTML5 aware
This makes the arguments "rows" and "cols" of the form.textarea
ViewHelper optional.
Change-Id: Ia94a66ab4ee33e75aa7...
Bastian Waidelich

2012-07-26

14:46 Bug #36662: Checked state isn't always correct when property is collection
Kevin Ulrich Moschallski wrote:
Hi Kevin,
> my case looks like yours and with the patch applied it works fine f...
Bastian Waidelich
13:24 Bug #36662: Checked state isn't always correct when property is collection
Hi Bastian,
my case looks like yours and with the patch applied it works fine for me. If you want i could upload m...
Kevin Ulrich Moschallski
12:44 Bug #36662 (Needs Feedback): Checked state isn't always correct when property is collection
@Kevin could you please give some feedback on how to reproduce the problem... Bastian Waidelich
12:42 Bug #36662: Checked state isn't always correct when property is collection
Patch set 5 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10829
Gerrit Code Review
14:00 Bug #31189: Make TextareaViewHelper HTML5 aware
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
13:59 Bug #31189: Make TextareaViewHelper HTML5 aware
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13076
Gerrit Code Review
13:58 Bug #31189 (Under Review): Make TextareaViewHelper HTML5 aware
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13076
Gerrit Code Review
14:00 Revision a5752cfd: [BUGFIX] Make TextareaViewHelper HTML5 aware
This makes the arguments "rows" and "cols" of the form.textarea
ViewHelper optional.
Change-Id: Ia94a66ab4ee33e75aa7...
Bastian Waidelich

2012-07-25

18:37 Bug #36662: Checked state isn't always correct when property is collection
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10829
Gerrit Code Review
18:36 Bug #36662: Checked state isn't always correct when property is collection
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/10829
Gerrit Code Review
15:24 Task #39255: reflectionService property in AbstractViewHelper should be protected instead of private
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13042
Gerrit Code Review
15:21 Task #39255: reflectionService property in AbstractViewHelper should be protected instead of private
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13042
Gerrit Code Review
15:21 Task #39255: reflectionService property in AbstractViewHelper should be protected instead of private
Patch set 2 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13042
Gerrit Code Review
15:20 Task #39255 (Under Review): reflectionService property in AbstractViewHelper should be protected instead of private
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/13042
Gerrit Code Review
15:17 Task #39255 (Resolved): reflectionService property in AbstractViewHelper should be protected instead of private
The property "reflectionService" in the AbstractViewHelper should be protected instead of private to allow usage of t... Aske Ertmann
15:24 Revision 4b3c0967: [TASK] Make reflectionService property in AbstractViewHelper protected
The property "reflectionService" in the AbstractViewHelper should be
protected instead of private to allow usage of t...
Aske Ertmann
14:40 Feature #39214 (Closed): The textfield viewhelper should have an attribute 'step' to allow decimal numbers
Cool, thanks for the feedback! Bastian Waidelich
14:11 Feature #39214: The textfield viewhelper should have an attribute 'step' to allow decimal numbers
Hi Bastian - thanks for your reply. Yes, the way you suggested works perfectly. I was not aware of the additionalAttr... Thomas Kirst
13:02 Feature #39214 (Needs Feedback): The textfield viewhelper should have an attribute 'step' to allow decimal numbers
IMO that is very specific and there are more possible attributes (like @min@ & @max@). That's why every tag based Vie... Bastian Waidelich

2012-07-24

13:05 Feature #39214 (Closed): The textfield viewhelper should have an attribute 'step' to allow decimal numbers
When using the textfield viewhelper to render a number field it will only accept integer values and no decimals. It i... Thomas Kirst

2012-07-23

00:19 Task #36207: Speed up performance in format.currency
This micro optimization was now merged to v4 fluid with https://review.typo3.org/#/c/10443/ in ticket #34519 Christian Kuhn

2012-07-19

18:00 Feature #38147: Suggested addition to SelectViewHelper - allowing prepend/append of child content to rendered option tag list
Patch set 4 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/2113
Gerrit Code Review

2012-07-18

21:23 Revision c845ccc8: [TASK] Update Package.xml with new version number
Change-Id: I84b81959ab9827d28661ac8bc56a571ca5a3b741
Releases: 1.1
Karsten Dambekalns
18:12 Revision 6613e1ed: [TASK] Update Package.xml with new version number
Change-Id: Ib8b204b98b1cfb14ccddb4d480e2e91802434ff1
Releases: 1.1
Karsten Dambekalns
15:19 Feature #33143: Allow Format.Currency ViewHelper regard Locale
Patch set 7 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/7783
Gerrit Code Review
14:39 Feature #33143: Allow Format.Currency ViewHelper regard Locale
Patch set 6 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/7783
Gerrit Code Review
12:38 Revision 9a00d1b3: Merge "[TASK] Correct StripTags test because of unintended incompletion result"
Karsten Dambekalns
12:37 Revision 492a8daa: [TASK] Correct StripTags test because of unintended incompletion result
A test's data provider's method name began with the character sequence
'test', was hence regarded as test to be execu...
Adrian Föder
12:35 Bug #37387 (Resolved): Translate Helper: Arguments replacement is not working for default value
Karsten Dambekalns
12:35 Bug #37387 (Under Review): Translate Helper: Arguments replacement is not working for default value
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:35 Bug #37387 (Resolved): Translate Helper: Arguments replacement is not working for default value
Applied in changeset commit:96189df3951e77ed115c33d4a12603e0571c3f7a. Karsten Dambekalns
12:35 Revision a4a939cb: [BUGFIX] Replace placeholders in fallback for id translation
When using id based translation and no translation is defined in XLIFF,
the tag value is used as a fallback in Transl...
Karsten Dambekalns
12:34 Revision c53abbf1: Merge "[BUGFIX] Replace placeholders in fallback for id translation"
Karsten Dambekalns
11:40 Revision 96f77ee3: [TASK] Correct StripTags test because of unintended incompletion result
A test's data provider's method name began with the character sequence
'test', was hence regarded as test to be execu...
Adrian Föder
10:46 Bug #38592 (Resolved): attributes with dashes lead to wrong exception message
Karsten Dambekalns

2012-07-13

15:13 Bug #38592 (Under Review): attributes with dashes lead to wrong exception message
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:36 Bug #38592 (Resolved): attributes with dashes lead to wrong exception message
Applied in changeset commit:88d7486d961daa35af376559675e93bcffe7756c. Karsten Dambekalns
15:13 Revision 049704f0: [BUGFIX] Make use of dashes in attribute names possible
When using e.g. data-foo in VH tags, the parser would choke. This
change fixes this.
Change-Id: I2fee1b0413557814578...
Karsten Dambekalns
12:19 Revision 93c28ece: Merge "[BUGFIX] Make use of dashes in attribute names possible"
Bastian Waidelich

2012-07-12

15:04 Revision 7e68ea46: [BUGFIX] Remove (wrong) use of Internal annotation
The internal annotation is used to declare command methods
as internal, not to mark things as not being public API.
...
Karsten Dambekalns
15:03 Revision 15c7ecd6: Merge "[BUGFIX] Remove (wrong) use of Internal annotation"
Karsten Dambekalns
13:08 Bug #38592 (Under Review): attributes with dashes lead to wrong exception message
Patch set 1 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12762
Gerrit Code Review
13:07 Bug #38592 (Accepted): attributes with dashes lead to wrong exception message
Karsten Dambekalns
13:08 Revision 88d7486d: [BUGFIX] Make use of dashes in attribute names possible
When using e.g. data-foo in VH tags, the parser would choke. This
change fixes this.
Change-Id: I2fee1b0413557814578...
Karsten Dambekalns
12:35 Bug #38873 (Resolved): Remove eval from StandaloneViewTest
Applied in changeset commit:73c686b0ff4710e2a89f30a526f9bdb132723f95. Christian Müller
12:20 Bug #38873: Remove eval from StandaloneViewTest
Patch set 2 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:02 Bug #38873: Remove eval from StandaloneViewTest
Patch set 1 for branch *FLOW3-1.1* has been pushed to the review server.
It is available at http://review.typo3.org/1...
Gerrit Code Review
12:01 Bug #38873: Remove eval from StandaloneViewTest
Patch set 3 for branch *master* has been pushed to the review server.
It is available at http://review.typo3.org/12753
Gerrit Code Review
12:20 Revision 73c686b0: [BUGFIX] Remove eval from StandaloneViewTest
Removes the use of eval from the StandaloneViewTest so that
now a Fixture class is used that extends the StandaloneVi...
Christian Müller
12:17 Revision 50370f1a: [BUGFIX] Move functional test configuration to Testing
This moves the functional test configuration to the
Testing context, to avoid errors in other contexts.
Change-Id: I...
Karsten Dambekalns
12:01 Revision ec1b9049: [BUGFIX] Remove eval from StandaloneViewTest
Removes the use of eval from the StandaloneViewTest so that
now a Fixture class is used that extends the StandaloneVi...
Christian Müller
 

Also available in: Atom