« Previous | Next » 

Revision 79e1d935

ID79e1d93532d8d77920a68085a4188c5eeb3571a5

Added by Stephan Schuler over 10 years ago

[BUGFIX] Reset WidgetViewHelpers when being reused from ViewHelperNode

  • Introduce an AbstractViewHelper::resetState method to handle any kind
    of stateful interaction, empty by default.
  • Make ViewHelperNode call resetState when reusing a ViewHelper, and also
    call it when reusing it in a compiled template.
  • AbstractWidgetViewHelper implements resetState for creating a new
    WidgetContext object.

As ViewHelpers are supposed to be stateless they were create once per
RenderingContext and reused whenever the RenderingContext fits.
Some ViewHelpers are not stateless, e.g. AJAX widgets.

AJAX widgets push their WidgetContext into an AjaxWidgetContextHolder
before they get rendered.

As soon as AJAX-WidgetViewHelpers were used multiple times within the
same RenderingContext (widgets in ForViewHelpers for example) different
widgets share the same ViewHelper containing the same WidgetContext.
Because the WidgetContext contains all stateful information about a
widget, only the last rendered widget gets stored in the ContextHolder.
That makes equal AJAX widgets within a for-loop impossible because
each GUI representation interacts with only the last rendered PHP object.

A test case has been committed to Viewhelpertest with http://review.typo3.org/6594

Change-Id: I7b0b1779079d4e48399d8db4981f2e6a24ebe536
Fixes: #31667
Release: 1.0, 1.1

  • added
  • modified
  • copied
  • renamed
  • deleted