Activity
From 2019-05-20 to 2019-06-18
2019-06-18
-
20:42 Revision 8f7ac7be: [TASK] Install Tool: Move common code into abstract class
- All modules of the Install Tool used in modal windows now share a common
abstract class that contains some boilerplat... - 11:54 Revision 6805f471: [TASK] Upgrade TYPO3 testing framework
- composer require --dev typo3/testing-framework:~5.0.10
Releases: master
Resolves: #88580
Change-Id: I1dcef11cee0caa7... -
11:25 Revision b3a592f2: [TASK] Update doctrine/dbal to ^2.9
- doctrine/dbal 2.8.x ran into unmaintained mode:
https://www.doctrine-project.org/projects/dbal.html
We should upgrad... -
09:49 Revision 02efc2c2: [BUGFIX] Fix comment in ViewHelper page.link
- Resolves: #88578
Releases: master, 9.5
Change-Id: I5fc57a9c61d5f02838f3afd3c305ae0b7b037dfc
Reviewed-on: https://revi... -
- Resolves: #88578
Releases: master, 9.5
Change-Id: I5fc57a9c61d5f02838f3afd3c305ae0b7b037dfc
Reviewed-on: https://revi... -
08:47 Revision c4dd8ff8: [BUGFIX] Fix getSiteFinder() mocking in SiteProcessorTest
- As it produced a warning:
1) TYPO3\CMS\Frontend\Tests\Unit\DataProcessing\SiteProcessorTest::
nullIsProvidedIfSiteC...
2019-06-17
- 23:24 Revision 2b972169: [BUGFIX] Improve wording in Install Tool
- Rephrases button title and success message for user preference
reset.
Resolves: #88520
Releases: master, 9.5
Change-... - 23:03 Revision ba732d9c: [BUGFIX] Improve wording in Install Tool
- Rephrases button title and success message for user preference
reset.
Resolves: #88520
Releases: master, 9.5
Change-... -
- doctrine/dbal 2.8.x ran into unmaintained mode:
https://www.doctrine-project.org/projects/dbal.html
We should upgrad... -
- doctrine/dbal 2.8.x ran into unmaintained mode:
https://www.doctrine-project.org/projects/dbal.html
We should upgrad... -
16:02 Revision 749e4222: [TASK] Switch Locales to regular singleton instance
- Locales resolves the user-defined TYPO3-languages and
its dependencies via TYPO3_CONF_VARS, which are only
finally av... -
- SiteMatcher is a container around SiteFinder now as PseudoSite
handling was removed, so SiteFinder can be used direct... - 14:30 Revision 7f21ba47: [!!!][TASK] Do not magically register validators
- This patch removes the automatical registration of two types
of validators.
- model validators
- type validators
Mo... - 11:48 Revision 72d857f3: [BUGFIX] Fix tests on windows
- Some unit tests still have problems on Windows.
- setlocale will not error even if the locale is not found
- file per... -
- When parsing TypoScript, PageTSconfig and UserTSconfig
is taking into account for evaluting if "TSFE.constants" is
se...
2019-06-14
-
- Resolves: #88262
Resolves: #85346
Releases: master, 9.5
Change-Id: Ia72ef1b670841d90ec0251c99b7f4d3dc1e7770a
Reviewed... -
21:44 Revision d2f7199a: [TASK] Deprecate unused methods of VersionNumberUtility
- The following methods of `\TYPO3\CMS\Core\Utility\VersionNumberUtility`
are unused and can be deprecated:
- `splitVe... -
- There are a lot of places where AbstractUserAuthentication
and the dependents (BE/FE user auth) set various settings,... -
- Resolves: #88262
Resolves: #85346
Releases: master, 9.5
Change-Id: Ia72ef1b670841d90ec0251c99b7f4d3dc1e7770a
Reviewed... -
15:10 Revision b36be531: [BUGFIX] Fix page caching with tree.rootLineIds condition check
- Conditions with `tree.rootLineIds` if matched caused page cache
regeneration on each request.
Resolves: #88374
Relea... -
- Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895
cHash's that are used within the URL but not ne... -
- Introduced with https://review.typo3.org/c/Packages/TYPO3.CMS/+/60895
cHash's that are used within the URL but not ne...
2019-06-13
-
- The two TypoScript options
* config.htmlTag_langKey
* config.htmlTag_dir
have been removed, as they have no effect ... -
- This patch removes a trailing comma in a ternary operation, as this causes
a JavaScript error in Internet Explorer 11... -
- Various documentation in TSFE is updated,
in addition to having $TSFE->setAbsRefPrefix()
to be set within the postPro... -
- Conditions with `tree.rootLineIds` if matched caused page cache
regeneration on each request.
Resolves: #88374
Relea... - 12:19 Revision 4d1c1604: [BUGFIX] Allow same configuration key in multiple extensions
- Fix two issues in the extension configuration tool if more than one
extension is using the same configuration key:
*... -
- For further TSFE-related changes, the frontend request
workflow now stores user-/session-related information
in the m... -
- If a cHash GET parameter is given, but there
are no GET parameters that are relevant, a
hash_calc() call against an e... -
- The only occurrence for 'loginSecurityLevel' checks for empty and falls back
to 'normal' (also defined in #81852 this...
2019-06-12
-
- This patch updates the COMPOSER_ROOT_VERSION environment variable to the
current TYPO3 version. This ensures all comp... -
07:56 Revision 166cbdf0: [TASK] Add title to topbar buttons
- Add title to the two topbar buttons on the left:
- Minimize/maximize module menu
- Collapse page tree
Resolves: #883... -
- Extensions should make use of TYPO3's native functionality for
using FAL-based folders, or the Environment API and TY... -
- With the introduction of CKEditor in TYPO3 v8, the support
for images in RTEs is dropped, however functionality was k... - 06:18 Revision 7fdb0f0b: [BUGFIX] Allow same configuration key in multiple extensions
- Fix two issues in the extension configuration tool if more than one
extension is using the same configuration key:
*...
2019-06-11
-
13:32 Revision 41813a47: [BUGFIX] Tests broken with phpunit 8.2
- Switching from accessibleMock to prophecy resolves
a lot of failures.
Also, using a concrete instance instead accessi...
2019-06-10
- 18:15 Revision db0fa467: [TASK] Update GitHub description in CONTRIBUTING.md
- Releases: master
Resolves: #88535
Change-Id: Ibeb645965840c8c4e78f5e4d13272db32e9fc308
Reviewed-on: https://review.ty...
2019-06-09
-
- If a backend usergroup has no permission to edit page properties, the
wizard for content element creation is not rend... -
- If a backend usergroup has no permission to edit page properties, the
wizard for content element creation is not rend... -
15:28 Revision 1703acca: [BUGFIX] Allow adding content without page edit permissions
- Resolves: #87687
Releases: master, 9.5
Change-Id: I8113f3fa2facf6b21bc19ee1c445265c5ff4f4b4
Reviewed-on: https://revi...
2019-06-08
-
- If a cHash GET parameter is given, but there
are no GET parameters that are relevant, a
hash_calc() call against an e... -
- This patch removes unused variables:
$GLOBALS['TYPO3_MISC']['microtime_BE_USER_start']
$GLOBALS['TYPO3_MISC']['micro...
2019-06-07
-
- With #88459, the closing tag `</property>` was accidentally not
removed, leaving a broken XML structure. This patch r... -
- The fat BE User object needs a haircut, and the obvious
logic for sending out an email is moved out.
Resolves: #8845... -
- Due to incomplete handling of "0" and casting, the fallback
is always "0" which is wrong.
The patch fixes the behavi... -
- Due to incomplete handling of "0" and casting, the fallback
is always "0" which is wrong.
The patch fixes the behavi... -
07:26 Revision edf32576: [TASK] Improve click behavior of the pagetree
- Initialize the d3-drag clickDistance setting to prevent clicks
where the mouse slightly moves from being detected as ...
2019-06-06
-
- Initialize the d3-drag clickDistance setting to prevent clicks
where the mouse slightly moves from being detected as ... -
20:25 Revision d38fee08: Revert "[TASK] Drop t3_origuid fields from functional tests"
- This reverts commit 55f7beae9e8360c56f9f788774177d7572bbd901.
Unfortunately it's not possible to get rid of t3_origu... -
- The usage of no_cache should be avoided. If still required it can be added
by using the setting additionalGetParamete...
2019-06-05
- 22:46 Revision 018fa63c: [BUGFIX] Prevent division by zero when scaling image
- Prevents multiple division by zero errors when scaling
images, by checking that the input image size is valid
(meanin... - 22:28 Revision 8b01570b: [BUGFIX] Prevent division by zero when scaling image
- Prevents multiple division by zero errors when scaling
images, by checking that the input image size is valid
(meanin... - 22:11 Revision a3b2904c: [BUGFIX] Prevent division by zero when scaling image
- Prevents multiple division by zero errors when scaling
images, by checking that the input image size is valid
(meanin... -
22:00 Revision c39bf90e: [FEATURE] Add log message for "Switch User action"
- If an admin user switches to another be_user account via the "Switch User"
action in the "Backend users" module, the ... - 21:12 Revision a6651f3d: [TASK] Better example for FlashMessage finisher
- - Show how to use messageArguments
- messageCode is mandatory (Don't know why, but yes it is)
--> As it is mandatory,... -
- The LinkBrowser used in FormEngine is now opened in a modal window
instead of a popup.
Resolves: #88471
Releases: ma... -
- In order to drop t3_origuid semantics (see issue #88494) according
usages should be purged from functional tests. Thi... -
- When no constant is given (due to old OS),
a PHP warning is now triggered due to PHP 7.2. This is
overcome to use the... -
- When no constant is given (due to old OS),
a PHP warning is now triggered due to PHP 7.2. This is
overcome to use the... -
- The Locales class implies a kind-of singleton approach to fetch
configuration information.
In addition, Locales does... -
- Due to non-site handling, setting the locale was built on top of
TypoScript settings. This was the reason, this was e... -
06:40 Revision 3fddb69a: [TASK] Upgrade Symfony-components
- Command used:
composer update symfony/* --with-dependencies
Following dependencies changed:
- Installing symfony/pol... -
- The check if the pages table is accessible is removed.
In TYPO3 v9 this was right after the TSFE creation due to 100...
2019-06-04
-
- Cache Timeout, configured via config.cache_period can be configured
when TypoScript is available.
The functionality ... -
- This reverts commit 1683f107e72e59737fb389e4623782de0ef472c0.
Reason for revert:
This breaks existing code, as multi... -
- This reverts commit 1683f107e72e59737fb389e4623782de0ef472c0.
Reason for revert:
This breaks existing code, as multi... -
- Error pages in site configurations don't need to point to an absolute URI.
When such error pages get resolved, the sc... -
- Error pages in site configurations don't need to point to an absolute URI.
When such error pages get resolved, the sc... -
- The class typo3/sysext/frontend/Tests/Unit/Middleware/SiteResolverTest
manipulates the locale setting of the environm...
2019-06-03
-
- With #88388, the composer.json file was adjusted to the required
versions of
phpunit/phpunit ^8.1
codeception/codece... -
- Due to site handling, the TypoScript properties config.language
and config.language_alt have no effect anymore and ca... -
- The SiteMatcher object now always returns a Site / NullSite, so there
will never be an exception "SiteNotFoundExcepti...
2019-05-31
-
22:28 Revision f364ea8f: [TASK] Raise typo3 icons to 1.9.0
- Executed tasks:
cd Build
yarn add @typo3/icons@1.9.0 --dev
yarn grunt copy:core_icons
yarn grunt copy:extensi... -
- Executed tasks:
cd Build
yarn add @typo3/icons@1.9.0 --dev
yarn grunt copy:core_icons
yarn grunt copy:extensi... -
- For IRRE relations with a "foreign_selector" relation set to a field of
type "group" and internal_type "db", the back... -
- There is a "Images on this page" feature in the info module of the
adminpanel. This patch adds a simple link icon for... -
- There is a "Images on this page" feature in the info module of the
adminpanel. This patch adds a simple link icon for... -
- For IRRE relations with a "foreign_selector" relation set to a field of
type "group" and internal_type "db", the back... -
14:21 Revision 8d5c45d2: [BUGFIX] Refresh browser cache when ckeditor config or plugins changes
- CKEDITOR.timestamp now contains also a hash of the configuration.
This is appended to uri when CKeditor loads resourc... -
- CKEDITOR.timestamp now contains also a hash of the configuration.
This is appended to uri when CKeditor loads resourc... -
- For IRRE relations with a "foreign_selector" relation set to a field of
type "group" and internal_type "db", the back... -
- In order to avoid RuntimeExceptions, the "simulateDate" TSConfig setting
for the adminpanel has to be at least 60 se... -
- This patch adds the missing copyright header of the original md5
JavaScript library.
To achieve this, the Grunt conf... -
- CKEDITOR.timestamp now contains also a hash of the configuration.
This is appended to uri when CKeditor loads resourc... -
- In order to avoid RuntimeExceptions, the "simulateDate" TSConfig setting
for the adminpanel has to be at least 60 se... -
13:14 Revision a18a72e9: [TASK] Write cleaner FileWriter JSON output
- Since PHP 5.4 it's possible to disable escaping for unicode characters
and slashes, which results in a much cleaner, ... -
- Since PHP 5.4 it's possible to disable escaping for unicode characters
and slashes, which results in a much cleaner, ... -
12:46 Revision f63f6fa2: [BUGFIX] Allow leading zeros in croncommand
- The Scheduler system extension requires a valid cron command or
seconds between scheduler runs.
With this commit, th... -
- Ensure the uid fields in the SeparateSysHistoryFromSysLogUpdate that are
passed to RecordHistoryStore::addRecord() an... -
- There is a "document size" row in the info module of the
adminpanel. Currently the value is outputted as integer, whi... -
- Ensure the uid fields in the SeparateSysHistoryFromSysLogUpdate that are
passed to RecordHistoryStore::addRecord() an... -
- There is a "document size" row in the info module of the
adminpanel. Currently the value is outputted as integer, whi...
2019-05-30
-
- The functionality "ftu" ("Frontend Track User"), which allows
to send the session through GET parameter within the si...
2019-05-29
-
- phpunit/phpunit changed in their latest release the handling of
interface constructor mocking.
Some of the tests reac... -
- phpunit/phpunit changed in their latest release the handling of
interface constructor mocking.
Some of the tests reac...
2019-05-27
-
- Fix a few typos in comments with the word "exits".
Resolves: #88396
Releases: master, 9.5
Change-Id: Ie1bff70e9f451c... -
- Fix a few typos in comments with the word "exits".
Resolves: #88396
Releases: master, 9.5
Change-Id: Ie1bff70e9f451c... - 07:03 Revision 8a1e581c: [BUGFIX] Respect sys_language_uid when fetching records for link browser
- The link browser now respects the sys_language_uid of the active
page record when selecting content elements to link ... - 06:44 Revision 2fd159f5: [BUGFIX] Respect sys_language_uid when fetching records for link browser
- The link browser now respects the sys_language_uid of the active
page record when selecting content elements to link ...
2019-05-24
- 21:13 Revision 4aeec26f: [TASK] Add information on how to create custom workspaces
- The documentation had no information where to create custom workspaces in the backend.
That information has been adde... - 15:23 Revision f5503fab: [BUGFIX] Allow to send multiple HTTP headers with the same name
- HTTP allows to send multiple headers with the same name.
Espacially this is needed for the "Set-Cookie" header to sen... -
- The file `md5.js` used to generate a MD5 hash in JavaScript is deprecated
and replaced by an AMD module `TYPO3/CMS/Ba... - 15:06 Revision 1683f107: [BUGFIX] Allow to send multiple HTTP headers with the same name
- HTTP allows to send multiple headers with the same name.
Espacially this is needed for the "Set-Cookie" header to sen... -
- The Scheduler system extension requires a valid cron command or
seconds between scheduler runs.
With this commit, th... -
- The global JavaScript function `top.openUrlInWindow()` has been marked as
deprecated. This method was used to open li... -
- In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interest... -
14:14 Revision 26ba10c4: [TASK] Delete unused ColorPicker.js file
- The js module „TYPO3/CMS/Backend/Wizard/Colorpicker“ is not used
anymore. The PHP code was removed with #80913.
This ... -
- In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interest... - 13:47 Revision dc42abec: [TASK] Harden \TYPO3\CMS\Extbase\Service\ExtensionService
- - Use strict type mode
- Use type hints whereever possible
- Use strict type comparison for in_array
Releases: maste... -
- The global JavaScript functions `top.rawurlencode()` and
`top.str_replace()` were introduced in 2009 and have been ma... -
- In rare cases it might occur that jquery is not available on ckeditor
initialization, but it's used already. Interest... -
- The TypoScript option config.defaultGetVars is not
evaluated anymore, as this conflicts with TypoScript
logic itself:... -
- The file `jsfunc.evalfield.js` responsible for form value evaluation and
validation has been removed. This job is now... -
- This patch refactors the IRRE handling on client side, the JavaScript
land has been rewritten to have a better struct... - 11:54 Revision 7c8ab513: [TASK] Typo in "validate"
- Releases: master
Resolves: #88409
Change-Id: Iff722b6b6f4206e4912fd2d2f7bc8e55d860133f
Reviewed-on: https://review.ty... -
- This commit also removes superfluous code and streamlines the search
template.
Resolves: #88333
Releases: master
Cha... - 09:57 Revision 65bc70dc: [TASK] Add information on how to create custom workspaces
- The documentation had no information where to create custom workspaces in the backend.
That information has been adde... -
09:51 Revision e9422c8a: [BUGFIX] Ensure correct initialization of selectTree value
- This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is ... -
- Resolves: #88345
Releases: master
Change-Id: I1da8e97558b0a4697db8aae6b1a098e2628fa519
Reviewed-on: https://review.ty... -
- This patch provides the current set database value in a hidden field as
early as the whole select tree JavaScript is ... -
- This patch removes the TBE_EDITOR.typo3form object, which is unused for
a long time now. This "API" was used to eithe...
2019-05-22
-
- Having Site Handling in place, the option "useCacheHash"
rendered useless as it is added by TYPO3 Core automatically
... -
- The argument `showLabel` must be used while creating a button.
Resolves: #88408
Releases: master, 9.5
Change-Id: I5b... -
- The argument `showLabel` must be used while creating a button.
Resolves: #88408
Releases: master, 9.5
Change-Id: I5b...
2019-05-21
- 15:36 Revision 0031cb2c: [BUGFIX] Remove superflous parameter that blocks the test
- assertNotNull takes only one parameter, but due to a left over
from former refactoring, it got two, and the first one... -
- The following methods changed from protected to private:
ConditionMatcher->determinePageId()
ConditionMatcher->getPa... -
- With the introduction of site handling, the old "pageNotFound_handling"
mechanisms can be removed. If a site configur...
2019-05-20
-
- A few places still use t3ver_state instead of the available
constants in VersionState. To increase
the semantics of t... - 15:52 Revision 91d5f80b: [TASK] Update typo3/testing-framework, phpunit and codeception
- commands:
composer update typo3/testing-framework
composer require --dev codeception/codeception:^3
composer updat... -
- A few places still use t3ver_state instead of the available
constants in VersionState. To increase
the semantics of t...
Also available in: Atom