Activity
From 2022-10-02 to 2022-10-31
2022-10-31
-
16:18 Revision a4c7bb4f: [TASK] Replace prophecy in EXT:core StorageRepositoryTest
- Resolves: #98739
Releases: main
Change-Id: I099820f55874eac4dc6df7cd045a87b1a7ca7d3c
Reviewed-on: https://review.typo... -
16:17 Revision 0efa659f: [TASK] Replace prophecy in EXT:backend PasswordResetTest
- Resolves: #98877
Releases: main
Change-Id: If70c0bca6bf710f467fcf8d84d9e96e684f5a64a
Reviewed-on: https://review.typo... -
16:16 Revision 203dc169: [BUGFIX] Check if variable exists before passing it to json_decode
- Avoid passing a null parameter to json_decode() which would cause
a PHP deprecation
Resolves: #98962
Releases: main,... -
- Avoid passing a null parameter to json_decode() which would cause
a PHP deprecation
Resolves: #98962
Releases: main,... -
- Resolves: #98878
Releases: main
Change-Id: I0b4e4dd4380a6a393723eb6f11644a7288c6117d
Reviewed-on: https://review.typo... -
09:08 Revision 1627c2f9: [TASK] Make FormProtectionFactory injectable - part 2
- This change modifies all places in TYPO3 Core
to avoid using FormProtectionFactory::get() and use
proper DI. A new me... -
- Resolves: #98879
Releases: main
Change-Id: Id7be42cb707c29d5c43ed8d299fd43cc8fd1f684
Reviewed-on: https://review.typo... -
- Resolves: #98738
Releases: main
Change-Id: I16dd353cf2910c4b7a7ebf853112d998236e5014
Reviewed-on: https://review.typo...
2022-10-30
-
- Resolves: #98887
Releases: main
Change-Id: I9231fa207503e258e5bd5ee94c83ea243d3fdd28
Reviewed-on: https://review.typo... -
- Resolves: #98880
Releases: main
Change-Id: I86c9862a6c8e4acf083088852fdcf3c745e95979
Reviewed-on: https://review.typo... -
- Resolves: #98881
Releases: main
Change-Id: I189341499e66e53935a7370d511f0dc434afed09
Reviewed-on: https://review.typo... -
- Resolves: #98883
Releases: main
Change-Id: I136ae22e7d35f6e260cc60a76110a756caa45e95
Reviewed-on: https://review.typo... -
- Resolves: #98884
Releases: main
Change-Id: I8c560609b9ce1542fd92cfd675dc2d800737028d
Reviewed-on: https://review.typo... -
- Resolves: #98886
Releases: main
Change-Id: Id7cecd7518a2f8d72fcaae2cd978dfe5609bc03f
Reviewed-on: https://review.typo... -
- Resolves: #98736
Releases: main
Change-Id: Ia3085e54e5c9688789fa4392012d1499215f5c37
Reviewed-on: https://review.typo... -
- Also, a wrong call to flushByTag(s) is corrected.
Resolves: #98735
Releases: main
Change-Id: I3f6ecbf7570d6383fb836e... -
- Resolves: #98733
Releases: main
Change-Id: Iff82295a7d29c35fe8d05679154772ef908652be
Reviewed-on: https://review.typo...
2022-10-29
-
16:36 Revision 9f2fef30: [BUGFIX] Rename event variable in multi-delete handler
- The patch for #98288 accidentally overwrote the variable of the event in
the event handler for deleting multiple file... -
- These comments don't add any value as the class under test can be easily
determined from the filename.
Executed comm... -
- Resolves: #98724
Resolves: #98728
Releases: main
Change-Id: Id046c240ae4e9d3017dc4b8503e23fd8a6a9b4b8
Reviewed-on: ht... -
- Resolves: #98904
Releases: main
Change-Id: I659bad4926656c2d5e3ed3120a13ef8b14a720c9
Reviewed-on: https://review.typo... -
12:58 Revision 12f6d1dd: [TASK] Update phpstan-phpunit to 1.2.2
- composer req --dev phpstan/phpstan-phpunit:^1.2.2
Resolves: #98943
Releases: main, 11.5
Change-Id: Iee2f421546a7be58... -
- composer req --dev phpstan/phpstan-phpunit:^1.2.2
Resolves: #98943
Releases: main, 11.5
Change-Id: Iee2f421546a7be58... -
- Resolves: #98729
Resolves: #98876
Releases: main
Change-Id: I7184afd240dc9d3ebd0dbd92f4b106f2909370b1
Reviewed-on: ht... -
- This change allows to use the LinkResult object
for custom HMENU generation moving HMENU to be
more consistent like t... -
- Resolves: #98907
Releases: main
Change-Id: I475b245a83a29e3993dfd47652dfbdb8c0527e0e
Reviewed-on: https://review.typo... -
- Resolves: #98902
Releases: main
Change-Id: Icf72d1124c6abec85940d8ff511f6bdff62e9e06
Reviewed-on: https://review.typo... -
- Resolves: #98903
Releases: main
Change-Id: I1de1bb7df01d552b82dd13fea0d287cbe654342a
Reviewed-on: https://review.typo... -
- Resolves: #98908
Releases: main
Change-Id: Ibf9f2f47ed9343d8b91052bf0e06601ccb96d60f
Reviewed-on: https://review.typo... -
12:01 Revision 45b856e0: [BUGFIX] Ensure proper functional test setup for FileBackendTest
- With the patch resolving #98931 and #98734 the FileBackendTest
has been migrated from unit to a functional test, and ...
2022-10-28
-
18:51 Revision 0872bab0: [TASK] Remove useCrawlerForExternalFiles setting from Indexed Search
- This removes an obsolete configuration from the Indexed Search.
It was earlier used to use the TYPO3 Crawler for inde... -
- Resolves: #98899
Resolves: #98901
Releases: main
Change-Id: Ifb188334c1445e3e8847bca476b6c5182bce829c
Reviewed-on: ht... -
- Resolves: #98737
Releases: main
Change-Id: I12de96341eae97eafb2fa558e8da2f9cc2e40bb6
Reviewed-on: https://review.typo... -
- A new method `getByPrefix()` is added to the module
`@typo3/backend/storage/abstract-client-storage`, affecting its
i... -
09:13 Revision 78def4c4: [DOCS] Correct changelog about removing TMENU.collapse
- Resolves: #98946
Related: #96517
Releases: main
Change-Id: Ibf44b8dad7a1cc79796a5791f194fc7792e9a355
Reviewed-on: htt...
2022-10-27
-
19:12 Revision 73dc2c04: [BUGFIX] Make toolbar dropdown menu scrollable again
- With #94641 toolbar dropdown menus were made
scrollable, since otherwise bookmarks were cut off
at the bottom of the ... -
- Resolves: #98725
Releases: main
Change-Id: Ia0cac4637e14e7fbe46fa4216022b6e9bcf3406a
Reviewed-on: https://review.typo... -
- Resolves: #98900
Releases: main
Change-Id: Ie6f7d98ee293dcc2153a6af191892a7e12c1ea9e
Reviewed-on: https://review.typo... -
- Resolves: #98893
Releases: main
Change-Id: Idcf53113f2f4acafe11cd953d9d9dd89f3b3dccb
Reviewed-on: https://review.typo... -
- Resolves: #98726
Releases: main
Change-Id: I80f4e40c32193aaffd2c99cdbb307018103e971d
Reviewed-on: https://review.typo... -
- Resolves: #98890
Releases: main
Change-Id: If64893018e062ffb1fe83d3b8f68de3d5f2b2289
Reviewed-on: https://review.typo... -
16:31 Revision 51c73783: [TASK] Remove dependency mikey179/vfsstream
- TYPO3 Core Tests no longer use the vfsStream
dependency, so it is removed.
Resolves: #98939
Related: #97762
Releases... -
16:20 Revision d7d06709: [TASK] Improve FAL tests
- * Make some unit tests functional test
* Remove some state
* Avoid last usages of vfsStream
> Build/Scripts/runTests... -
- Resolves: #98888
Releases: main
Change-Id: I54c4cb0bb406f9d6a0a6b8d56a330f89630c9ca4
Reviewed-on: https://review.typo... -
- Resolves: #98885
Releases: main
Change-Id: Ia51c12a35892c7d9d9f8e332470d5986472f8c67
Reviewed-on: https://review.typo... -
- Resolves: #98898
Releases: main
Change-Id: I62c2915adb19bc8cc124cab51e4f99782053b4d9
Reviewed-on: https://review.typo... -
- Resolves: #98894
Releases: main
Change-Id: I7c1d7cf3622f64666adcabbb3ebf30d7c6189d1b
Reviewed-on: https://review.typo... -
- Resolves: #98896
Releases: main
Change-Id: I3c452a229b8a690d3954cfadfa439c9b3b7be30e
Reviewed-on: https://review.typo... -
- Resolves: #98895
Releases: main
Change-Id: Ib1898a11fcb156d08d0f3fd9cfb738038d3d90ca
Reviewed-on: https://review.typo... -
- > composer req --dev friendsofphp/php-cs-fixer:^3.12.0
> Build/Scripts/runTests.sh -s cgl -p 8.1
Resolves: #98938
Re... -
06:25 Revision 1caa2e5e: [BUGFIX] Correct registration of toolbar link buttons in CKEditor 5
- The CKEditor 5 has very limited support for managing links.
By default, you only get a simple input field for a strin... -
- > composer req --dev friendsofphp/php-cs-fixer:^3.12.0
> Build/Scripts/runTests.sh -s cgl -p 8.1
Resolves: #98938
Re...
2022-10-26
-
20:01 Revision 82d9577f: [TASK] Clean up types in ResourceStorageTest
- Resolves: #98937
Related: #98936
Releases: main
Change-Id: I55ed2c9546312c8bc9b99ffae2b8d3c8a38b5117
Reviewed-on: htt... -
- To finally tame the FAL related unit tests,
the resource related BaseTestCase is dissolved
and merged into consuming ... -
- The vfsStream setup is not used in the tests.
Resolves: #98935
Related: #97762
Releases: main
Change-Id: I87ec61c1e5... -
- We can avoid vfs usages in GeneralUtility
tests by creating fixture files and testing
these directly. A detail test f... -
- Testing 'non-writable' directories is flaky in
real life since it depends on the user that
executes these tests. On g... -
- Moving cache framework related FileBackendTest
unit tests to functional tests needs less mocks
and avoids vfsStream.
... -
- Acceptance test cookie output is less noisy due to
a new feature in codeception/module-webdriver 3.2.0
and styleguide... -
- https://github.com/TYPO3-CMS/styleguide/pull/361
ExtensionManagementUtility::allowTableOnStandardPages()
has been re... -
- https://github.com/TYPO3-CMS/styleguide/pull/360
https://review.typo3.org/c/Packages/TYPO3.CMS/+/74925 -
- This property name is too generic as weak match and
throws too many false positives.
Resolves: #98926
Release: main,... -
- This property name is too generic as weak match and
throws too many false positives.
Resolves: #98926
Release: main,... -
- There is little reason to fake filesystems
details within functional tests that use an
isolated instance.
Resolves: ... -
- CKEditor 5 changed the way it handles links, and
introduced new modules to do so. In the automatic
migration from CKE... -
- This patch updates jasmine to the current version 4.4.0. This mainly
impacts performance and dropped support for outd... -
- The class can be hardended a bit and some unused
methods removed. The tests are turned into
functional tests.
Resolv...
2022-10-25
-
- testing-framework now avoids access to
TSFE->tmpl as well.
> composer u typo3/testing-framework
Resolves: #98919
Re... -
- Resolves: #98918
Releases: main
Change-Id: I1d6b9fcb5ec0f84d2a5a65689aa4f23b0ff3f82f
Reviewed-on: https://review.typo... -
- The patch introduces the new request attribute
TypoScriptRequestAttribute as 'frontend.typoscript'.
It is set up in ... -
- Resolves: #98730
Resolves: #98731
Resolves: #98732
Releases: main
Change-Id: Ie13c6f640b07e3b1fd6742ea4d7f300bb0a3d10... -
- Resolves: #98722
Releases: main
Change-Id: Id79d474b607fd024b992bffe669033bf7a974710
Reviewed-on: https://review.typo... -
- Resolves: #98723
Releases: main
Change-Id: Ia64fed2b7f4f9a0c420e5a836fafb1959c7143d9
Reviewed-on: https://review.typo... - 11:04 Revision be6ba983: [BUGFIX] Avoid undefined array key frequencyOptions
- Resolves: #98915
Releases: 11.5
Change-Id: I6a9236f08d8446f465d6bccb72c6f5bad4c5b473
Reviewed-on: https://review.typo... -
- Also update the PHPUnit PHPStan configuration.
This update gets rid of some false positives.
Run commands:
> compo... -
- Also update the PHPUnit PHPStan configuration.
This update gets rid of some false positives.
Run commands:
> compo... -
- Resolves: #98911
Releases: main
Change-Id: I6228795976338f5c8bdf02e03075140272f2511b
Reviewed-on: https://review.typo...
2022-10-24
-
- The "is backend" check will never kick in since this is
dispatched in ConfigurationManager already.
Resolves: #98721... -
- When a content element gets hidden or visible, the page module is
reloaded with an anchor in the URL to scroll to the... -
- Resolves: #98547
Releases: main, 11.5
Change-Id: I82b2fc75947d451b24ccfd90ebe82b0107aff1e5
Reviewed-on: https://revie... -
- Resolves: #98547
Releases: main, 11.5
Change-Id: I82b2fc75947d451b24ccfd90ebe82b0107aff1e5
Reviewed-on: https://revie... -
- The global charRangeMap option in TypoScript / GIFBUILDER
allows to define the pixelSpace (with a multiplicator for t... -
- doctrine/dbal is working on deprecating and changing code and
behaviour in 3.x as preparation for removal in 4.x. Sta... -
- Replaced all prophecy usages and fixed a typo in
BackendGroupsExplicitAllowDenyMigrationTest
Resolves: #98711
Releas... -
- Resolves: #98705
Releases: main
Change-Id: I4ec9e97cbe9ab42dd70eb9960331f3dab1f06ff4
Reviewed-on: https://review.typo... -
- Resolves: #98712
Releases: main
Change-Id: Idd4107a911c2ec363d4fd7588d5dc07aa2fe8a45
Reviewed-on: https://review.typo...
2022-10-23
-
- Resolves: #98708
Releases: main
Change-Id: Ia0db3b56b54de7835707ff97db255730a81573d7
Reviewed-on: https://review.typo... -
- With doctrine/dbal v3.5.0 some changes has been introduced which
shows invalid test setup. This change use proper tes... -
07:09 Revision 613f487d: [DOCS] Fix PHP doc comments in events
- Releases: main
Resolves: #98706
Change-Id: I7f80d8469483d098b97ffb178090ed11abfe8b9d
Reviewed-on: https://review.typo...
2022-10-22
-
- This is a clean up and optimization.
First, TSFE->lock does not need to be a multi
dimensional array anymore since t... -
- With #98502 code got merged, which does not follow the
cgl rules. This was a overlap since patch was pushed on
gerrit...
2022-10-21
-
22:39 Revision 2b4f8790: [BUGFIX] Handle InsufficientFolderAccessPermissions in FileTree search
- Releases: main, 11.5
Resolves: #87048
Change-Id: Ia44998ec3601226f45b96468b7a37ad4d20dccdf
Reviewed-on: https://revie... - 22:32 Revision 6dd592c6: [TASK] Convert FormRuntimeTest to a functional test
- The FormRuntimeTest is converted from unit test to a functional test.
This avoids heavy mocking and makes the test ca... -
- The Fluid template in the filelist now checks if the clipboard is
available at all to render the "multi item" actions... -
22:18 Revision e3089207: [BUGFIX] Interpolate log messages in InMemoryLogWriter
- Log messages may have placeholders that must be interpolated
based on the context provided to the message.
Resolves:... -
- Log messages may have placeholders that must be interpolated
based on the context provided to the message.
Resolves:... -
- Releases: main, 11.5
Resolves: #87048
Change-Id: Ia44998ec3601226f45b96468b7a37ad4d20dccdf
Reviewed-on: https://revie... -
- The Fluid template in the filelist now checks if the clipboard is
available at all to render the "multi item" actions... -
- Resolves: #98694
Releases: main
Change-Id: I9db591448046d043cb2291612dc8c1625da450f5
Reviewed-on: https://review.typo... -
- Resolves: #98698
Releases: main
Change-Id: I568f8dbfffec1c570b27f0d7ef80084cb8b47d5f
Reviewed-on: https://review.typo... -
- Resolves: #98699
Releases: main
Change-Id: I3ed97c0ad92d73da412cf2e2a907f988aae0c8c7
Reviewed-on: https://review.typo... -
- The functionality to check authentication such
as frontend users only to certain PIDs, is now centralized
in Frontend... -
- Releases: main
Resolves: #98633
Change-Id: Ie1f00996b817d788190bca9ef958e4b24addcb54
Reviewed-on: https://review.typo... -
- File ending .ts tends to confuse IDE's since they
think this is about typ-e-script, not typ-o-script.
Adapt some file... -
- A backend module's docheader is "folded" when scrolling down in the
backend module. Sometimes, the folding process ap... -
- To avoid setting potentially invalid links, the "email address" and
"telephone number" fields both are marked as "req... -
- EXT:dashboard has some custom CSS for its modal contents. Due to how
modals are rendered, the CSS needs to be loaded ... -
- Resolve: #98686
Releases: main
Change-Id: Id48b6e61e87eaaadc1e28cbf0b8439d9af791b57
Reviewed-on: https://review.typo3... -
- A backend module's docheader is "folded" when scrolling down in the
backend module. Sometimes, the folding process ap... -
- With recent FE TS changes, we now have some information
a little earlier, which allows us to simplify the page
genera... -
- Resolves: #98690
Releases: main
Change-Id: I00a069b9ed749be5efa89271eb86fcdee057f2ce
Reviewed-on: https://review.typo... -
- To avoid setting potentially invalid links, the "email address" and
"telephone number" fields both are marked as "req... -
- Resolves: #98695
Releases: main
Change-Id: I7425f675d49970ed61064eb063452b042f7303b2
Reviewed-on: https://review.typo... -
- Resolves: #98674
Releases: main
Change-Id: I019fe150c4061751c3d1a2910dbf007623e2487d
Reviewed-on: https://review.typo... -
- Resolves: #98678
Releases: main
Change-Id: I4df275eadd6b5bdbc2af9e7eb617f37fc95f2ff4
Reviewed-on: https://review.typo... -
- Resolves: #98677
Releases: main
Change-Id: I3c36c8c4748b1cd653cbba96746873d3a40c4424
Reviewed-on: https://review.typo... -
- Resolves: #98671
Releases: main
Change-Id: Ibe74811636aa12f6ddeb8717df86f75011f521be
Reviewed-on: https://review.typo... -
- Resolves: #98675
Releases: main
Change-Id: I65f25d393ef84b825dd18f421891ad1719dcf7be
Reviewed-on: https://review.typo... -
- Due to CSS changes, unnecessary margin was dropped from the `code`
element in #98349, which leads to missing spacing ... -
- The patch changes TSFE getFromCache() to leverage more
effective TypoScript cache layers, possible with the
new TypoS... -
- Resolves: #98685
Releases: main
Change-Id: I7cbb2135639ba9a0d03e9e536802c01c60919f88
Reviewed-on: https://review.typo... -
- Resolves: #98672
Releases: main
Change-Id: Icd7aa0b8f624e07140c40ffea78b8b724147d725
Reviewed-on: https://review.typo... -
- Resolves: #98676
Releases: main
Change-Id: Ia2ed99a4116a5bd84f9ba2cc258e8ccf4d65ed07
Reviewed-on: https://review.typo... -
- In AddRecord Wizard, the property editConf is marked as string, but the
fallback assignment is null, leading to a typ... -
- In AddRecord Wizard, the property editConf is marked as string, but the
fallback assignment is null, leading to a typ... -
- Resolves: #98667
Releases: main
Change-Id: I4721bc4bccdca1231c88997cce55d1d5b2575012
Reviewed-on: https://review.typo... -
08:31 Revision 2c3e224f: [TASK] Use fallback to default error handler
- Use the default erorr handler of status code 0 as stated in the
description of the backend module.
Resolves: #98502
... -
- Resolves: #98680
Releases: main
Change-Id: I2ce193c9388396338a5eab5c6e451780378af6a0
Reviewed-on: https://review.typo... -
- Resolves: #98662
Releases: main
Change-Id: I8d49a71cd4a391a06b7e23f1e38763089228f86f
Reviewed-on: https://review.typo... -
- Resolves: #98673
Releases: main
Change-Id: I0761015ccc54e9c1ef909238774a196df404cb5d
Reviewed-on: https://review.typo... -
07:23 Revision 46a24a0b: [BUGFIX] Always send strings to the method createStream
- PHP8.1 throws an TypeError if we sending null to createStream
Resolves: #98417
Releases: main, 11.5
Change-Id: I3277... -
- Resolves: #98670
Releases: main
Change-Id: I364679b56f65b4a4fa0f93ba795a42462424c4b8
Reviewed-on: https://review.typo... -
- PHP8.1 throws an TypeError if we sending null to createStream
Resolves: #98417
Releases: main, 11.5
Change-Id: I3277... -
- Resolves: #98679
Releases: main
Change-Id: Ic610343c7e9af37924b2df35dd60efd8804d53a6
Reviewed-on: https://review.typo...
2022-10-20
- 19:01 Revision da2fb6d2: [BUGFIX] Use local TypoScriptFrontendController in nested ContentObjects
- RecordsContentObject and ContentContentObject create new instances of
the ContentObjectRenderer. They need to pass do... - 18:43 Revision a7a443ec: [BUGFIX] Use local TypoScriptFrontendController in nested ContentObjects
- RecordsContentObject and ContentContentObject create new instances of
the ContentObjectRenderer. They need to pass do... -
- Resolves: #98669
Releases: main
Change-Id: I60ce42e744baa1782795791a103ee129b3d4491e
Reviewed-on: https://review.typo... -
- This migrates all usages of the FQCN for data
processors in EXT:fluid_styled_content with the
corresponding identifie... -
- The password reset feature for TYPO3 backend users does now consider the
configurable password policy introduced in #... -
14:21 Revision 058c2678: [FEATURE] Allow tagging of data processors
- This adds the possibility to tag data processors
with the "data.processor" tag in the service configuration.
Tagged ... -
- The newly introduced LinkFactory is the main entrypoint
for generating links. It can now be used to generate URLs,
al... -
- FormProtectionFactory is hard to mock, and relies
a lot on global state and global variables. The functionality
was b... -
- Resolves: #98661
Releases: main
Change-Id: Iddd7f6d53d6a708c08099c3cfc39b6ea7fca2066
Reviewed-on: https://review.typo... -
- This has been obsoleted with the paginate
widget removal.
Resolves: #98663
Releases: main
Change-Id: Iee6d57d02b82f9... -
07:06 Revision d3528fcb: [BUGFIX] Backend user table: title of "edit" button
- Resolves: #98637
Releases: main, 11.5
Change-Id: I516eb70b998bd81fdb522085aee42ec94b22908b
Reviewed-on: https://revie... -
- Resolves: #98637
Releases: main, 11.5
Change-Id: I516eb70b998bd81fdb522085aee42ec94b22908b
Reviewed-on: https://revie... -
- Resolves: #98660
Releases: main
Change-Id: Id9318e8e4bc8e813c10e96c74519c51121e03679
Reviewed-on: https://review.typo... -
- The backend module of EXT:form uses an enhanced version of jQuery UI's
sortable implementation that can handle nested... -
- Resolves: #98651
Releases: main, 11.5
Change-Id: I6f2dbd859341e7a57bf9bca7bf815eb2e1d161bc
Reviewed-on: https://revie... -
- Resolves: #98651
Releases: main, 11.5
Change-Id: I6f2dbd859341e7a57bf9bca7bf815eb2e1d161bc
Reviewed-on: https://revie... -
- Resolves: #98658
Releases: main
Change-Id: Iccd4ff6089195c995f0e8d2ce793a209be2334dd
Reviewed-on: https://review.typo...
2022-10-19
-
- PHPStan will (correctly) unify the previous type
`\PDO::PARAM_*|Connection::PARAM_*|int` to `int` (because
`\PDO::PAR... -
- PHPStan will (correctly) unify the previous type
`\PDO::PARAM_*|Connection::PARAM_*|int` to `int` (because
`\PDO::PAR... -
- This change modifies most of the userland code to use
a) Connection::PARAM_* constants instead of \PDO::PARAM_* cons... -
- This change unifies the generation of the LinkResult
object in order to allow the generation of the LinkResult
for JS... - 09:36 Revision e981cfa3: [TASK] Remove outdated deprecation notice
- This patch removes an outdated deprecation notice that was left when
the ViewResolverInterface was changed in #96174.... -
08:20 Revision 7e747470: [BUGFIX] Cover multi-value properties in form editor with HMAC
- With #85044, HMAC validation for form definitions in the backend form
editor was introduced. However, nested multi-va... -
- With #85044, HMAC validation for form definitions in the backend form
editor was introduced. However, nested multi-va... -
- With #85044, HMAC validation for form definitions in the backend form
editor was introduced. However, nested multi-va...
2022-10-18
- 20:50 Revision 2328e14a: [TASK] Add iterable types to methods in `TypoLinkCodecService`
- This patch adds iterable types to parameters and return types in
methods of `TypoLinkCodecService` leading to a bette... - 20:32 Revision 819d2784: [TASK] Add iterable types to methods in `TypoLinkCodecService`
- This patch adds iterable types to parameters and return types in
methods of `TypoLinkCodecService` leading to a bette... -
- Resolves: #98652
Releases: main
Change-Id: I4b5638bd06175ed33d96efa4ecf98ec15544fb60
Reviewed-on: https://review.typo... -
- This change modifies most of the userland code to use
a) Connection::PARAM_* constants instead of \PDO::PARAM_* cons... -
- The event handlers for the backend search are now bound only once, when
the DOM becomes ready to fix event handler st... -
- Replace all prophecy calls in ext:seo tests.
Additionally, the unit tests in HrefLangGeneratorTest
have been adapted... -
- The active state in the workspaces menu is now streamlined and aligned
to the look the "Help" menu by removing the "t... -
- This change widens the testing to have more PHP8.2
testing covered, mainly not only composer locked.
phpspec/prophec... -
- The "table" for translated page records is internally identified as
"pages_translated". However, the real table name ...
2022-10-17
-
- The "table" for translated page records is internally identified as
"pages_translated". However, the real table name ... -
- Resolves: #98639
Releases: main
Change-Id: Id2561c857aa4d7a61ade2f23e6909f1f9cdad665
Reviewed-on: https://review.typo... -
- This change unifies the loading of "pids"
when looking for records within
* List module
* Live search
* Log module
* ... -
13:15 Revision 5aaf0ae5: [TASK] Add service to prepare CSS for SCSS parsing
- Add a dedicated service to parse and prepare CSS for SCSS parsing.
Resolves: #98620
Releases: main
Change-Id: I1592b... -
- Issue #91499 allows to define arbitrary HTML attributes for the
corresponding HTML tag to be generated in PageRendere... -
- The contents of a field of type `flex` may be NULL if the field is
empty. `BackendUtility::getProcessedValue()` handl...
2022-10-16
-
- A superfluous space character in a frontend login template
leads to an exception during the Fluid parsing process.
R...
2022-10-15
-
- Some builds of MariaDB server and/or report server version of
MariaDB with a '5.5.5-' prefix. This change address cha...
2022-10-14
-
22:09 Revision 4a4cfea9: [BUGFIX] Avoid undefined array key in FlexFormTools
- Resolves: #98607
Releases: main, 11.5
Change-Id: Ib57659fb5e343449de877cf5e78f55c8656bf9e9
Reviewed-on: https://revie... -
- Resolves: #98607
Releases: main, 11.5
Change-Id: Ib57659fb5e343449de877cf5e78f55c8656bf9e9
Reviewed-on: https://revie... -
- The removePlugins option needs to be assigned
as an array in CKEditor5. While we recommended
passing the option alrea... - 10:39 Revision d1941f13: [BUGFIX] Assure a string is passed to `octdec` function
- Since strict types were enabled for the GeneralUtility class, the
`GU::createDirectoryPath()` may throw an exception ... -
10:31 Revision 7c82be9b: [BUGFIX] Fix PHP warning when checking for resource collection object
- Used command(s):
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #98603
Releases: main, 11.5
Chang... - 10:30 Revision 5532fb07: [BUGFIX] Assure a string is passed to `octdec` function
- Since strict types were enabled for the GeneralUtility class, the
`GU::createDirectoryPath()` may throw an exception ... -
- Used command(s):
> Build/Scripts/runTests.sh -s phpstanGenerateBaseline
Resolves: #98603
Releases: main, 11.5
Chang... -
- JetBrains created a new product named `Fleet` as
lightweight editor. This tool tends to write it's
config files to `.... -
- JetBrains created a new product named `Fleet` as
lightweight editor. This tool tends to write it's
config files to `.... -
- This update gets rid of some false positives.
Run commands:
> composer req --dev phpstan/phpstan:^1.8.9
> ./Build/S... -
- JetBrains created a new product named `Fleet` as
lightweight editor. This tool tends to write it's
config files to `.... -
08:39 Revision 1c7b55e1: [BUGFIX] Avoid undefined array key for bodyTagCObject
- Fix warning if bodyTagCObject is referenced in TypoScript template.
Set as empty array.
Resolves: #98611
Releases: m... -
- This update gets rid of some false positives.
Run commands:
> composer req --dev phpstan/phpstan:^1.8.9
> ./Build/S... -
- Fix warning if bodyTagCObject is referenced in TypoScript template.
Set as empty array.
Resolves: #98611
Releases: m... -
- Commands executed:
npm install bootstrap@^5.2.2
npm install --save-dev @types/bootstrap@^5.2.5
npm run build
R... -
- The magic happening for cropHTML in the regex is
really hard to understand. It led to compilation
failures due to the...
2022-10-13
-
- This change renames some variables within
GeneralUtility::implodeAttributes and adds some first
tests to this method.... -
- Some CSS minifier remove the semicolon before the curly brace
While this is valid CSS, the ScssPHP Parser is unable t... -
- With the introduction of additional
attributes for asset includes it was not
considered that a asset can not provide
... -
- This change renames some variables within
GeneralUtility::implodeAttributes and adds some first
tests to this method....
2022-10-12
- 19:48 Revision 667083f9: [BUGFIX] Fix short scheduler:run options in documentation
- Releases: main, 11.5
Resolves: #98591
Change-Id: I5474e11cd0653b61a1ac2c8725959bc4f1437da4
Reviewed-on: https://revie... - 19:38 Revision f86ff782: [BUGFIX] Fix short scheduler:run options in documentation
- Releases: main, 11.5
Resolves: #98591
Change-Id: I5474e11cd0653b61a1ac2c8725959bc4f1437da4
Reviewed-on: https://revie... -
- We can avoid ugly setters in TypoScript TreeBuilder
class by handing over arguments to the main function,
effectively... -
- This change adapts our coding guidelines
and rules with PHP-CS-Fixer, allowing for
* PER (a.k.a. PSR-12)
* no_useless... -
- This change adapts our coding guidelines
and rules with PHP-CS-Fixer, allowing for
* PER (a.k.a. PSR-12)
* no_useless... -
06:52 Revision e3bc112b: [TASK] styleguide: Upgrade action/checkout to avoid deprecation message
- https://github.com/TYPO3-CMS/styleguide/pull/357
GitHub has deprecated node v12 support for executing GitHub
actions...
2022-10-11
-
- Resolves: #98404
Releases: main, 11.5
Change-Id: I01f52c45d95f6ff2a56e0a3128f1367dc2a595aa
Reviewed-on: https://revie... -
- Resolves: #98414
Releases: main, 11.5
Change-Id: If29dc5fd03156889ac0d281d5c7b2e5683f708d1
Reviewed-on: https://revie... -
- Resolves: #98414
Releases: main, 11.5
Change-Id: If29dc5fd03156889ac0d281d5c7b2e5683f708d1
Reviewed-on: https://revie... -
- Resolves: #98404
Releases: main, 11.5
Change-Id: I01f52c45d95f6ff2a56e0a3128f1367dc2a595aa
Reviewed-on: https://revie... -
- A first code clean up of this class streamlines
the properties and removes some rather obvious
stuff. The unit tests ... -
- Resolves: #98582
Releases: main, 11.5
Change-Id: I20116640c9adc44df524b58172913a4d8f8a01ed
Reviewed-on: https://revie... -
- Resolves: #98582
Releases: main, 11.5
Change-Id: I20116640c9adc44df524b58172913a4d8f8a01ed
Reviewed-on: https://revie... -
- Resolves: #98573
Releases: main
Change-Id: Id69bd8f970f0d5f780850faf842620cf7ed87de2
Reviewed-on: https://review.typo... -
- Resolves: #98580
Releases: main, 11.5
Change-Id: Ib3ee06cb2849efd8e4cf18fc2497f3c0fed0f752
Reviewed-on: https://revie... -
- Resolves: #98580
Releases: main, 11.5
Change-Id: Ib3ee06cb2849efd8e4cf18fc2497f3c0fed0f752
Reviewed-on: https://revie... -
- Resolves: #98564
Releases: main
Change-Id: I2177342a3f5952ba33edcfa231283826cdc27a7c
Reviewed-on: https://review.typo... -
- The extbase ConfigurationManager is a complex beast full
of anti patterns. We need to refactor here to unblock
other ... -
- Change-Id: I87e5976885d5d1862cb742d0ba8855a7912f5ac1
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/760... -
- Change-Id: I908c2eb905d4601da7a4737cc6211467384a64e9
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/760... -
- Search- and filter functionaly usually uses `LIKE` or `NOT LIKE`
SQL statements to search a provided search term in t... -
- Resolves: #98575
Related: #97747
Releases: main
Change-Id: If0c5dca5574a1bb6842e6c1c45e14cbfac171389
Reviewed-on: htt... -
06:40 Revision 7aec7a4b: [FEATURE] Introduce MailerInterface
- In order to register your own mailer implementation,
a new interface has been introduced that makes registration
of y... -
- Obvious hardening of an array access.
Resolves: #98469
Releases: main, 11.5
Change-Id: Ie4e083b0ff50de4e2fbabf4bdfd4... -
- Harden GeneralUtility::explodeUrl2Array() and
increase test coverage.
Change-Id: I3136a27572414810989c038b78bd0f362c... -
- TSFE->config['rootLine'] and TSFE->rootLine
are not identical: The one in config array
is a restricted set that stops... -
- Search- and filter functionaly usually uses `LIKE` or `NOT LIKE`
SQL statements to search a provided search term in t... -
- TypoScript related TreeFromLineStreamBuilder has state
due to setTokenizer(), it should be "shared: false" in DI.
We... -
- The installer has a step to 'Create empty start page'
which adds a default sys_template to a first page.
This sys_te... -
- Obvious hardening of an array access.
Resolves: #98469
Releases: main, 11.5
Change-Id: Ie4e083b0ff50de4e2fbabf4bdfd4... -
- Harden GeneralUtility::explodeUrl2Array() and
increase test coverage.
Change-Id: I3136a27572414810989c038b78bd0f362c... -
- Resolves: #98559
Releases: main, 11.5
Change-Id: Ifa5c3ac6997545a79c7306ff9a3afc0d97675dec
Reviewed-on: https://revie... - 04:16 Revision 5f898be4: [BUGFIX] Prevent undefined array index "pi_flexform"
- Resolves: #98539
Releases: main, 11.5
Change-Id: I1a9943316a7d8d657b2e64cc704ae52943a89b40
Reviewed-on: https://revie... - 04:16 Revision 5df71177: [BUGFIX] Prevent undefined array index "pi_flexform"
- Resolves: #98539
Releases: main, 11.5
Change-Id: I1a9943316a7d8d657b2e64cc704ae52943a89b40
Reviewed-on: https://revie...
2022-10-10
-
- This change raises typo3/testing-framework to include a
bunch of changes to tighten unit- and function tests.
* setU... -
- Stop a naughty mocking party provided by
TypoScriptFrontendController unit tests by
turning most of them into functio... -
- Invalid HTML must not produce notices in backend or frontend.
Resolves: #98513
Releases: main, 11.5
Change-Id: I6aca... -
- Invalid HTML must not produce notices in backend or frontend.
Resolves: #98513
Releases: main, 11.5
Change-Id: I6aca... -
- PostgresSQL is really picky about types and used operators. Thus using
for example a `like` comparision on non string... -
- PostgresSQL is really picky about types and used operators. Thus using
for example a `like` comparision on non string... -
- Resolves: #98559
Releases: main, 11.5
Change-Id: Ifa5c3ac6997545a79c7306ff9a3afc0d97675dec
Reviewed-on: https://revie... -
- Resolves: #98468
Releases: main, 11.5
Change-Id: Ia3f0ac3c5d4c20eaef5ffdafae060bab4a1c9aad
Reviewed-on: https://revie... -
- PostgresSQL seems to get picky with upper case column names, if
they are not proper quoted in queries, like `pages.SY... -
- Prior to PHP8.0 the long libpq version (`PGSQL_LIBPQ_VERSION_STR`)
contained compiler informations, which is used in ... -
- Resolves: #98468
Releases: main, 11.5
Change-Id: Ia3f0ac3c5d4c20eaef5ffdafae060bab4a1c9aad
Reviewed-on: https://revie... -
- PostgresSQL seems to get picky with upper case column names, if
they are not proper quoted in queries, like `pages.SY... -
- Prior to PHP8.0 the long libpq version (`PGSQL_LIBPQ_VERSION_STR`)
contained compiler informations, which is used in ... -
13:05 Revision 275677e2: [BUGFIX] Uninitialized properties in DebuggerUtility
- DebuggerUtility::var_dump() is commonly used to debug PHP classes.
We recommend hardening PHP classes by using typed... -
- DebuggerUtility::var_dump() is commonly used to debug PHP classes.
We recommend hardening PHP classes by using typed... -
- PostgresSQL is picky if aggregation functions like `order by`,
`group by` and similar are used, but missing the corre... -
- PostgresSQL is picky if aggregation functions like `order by`,
`group by` and similar are used, but missing the corre... -
- The library `imagesloaded` is only used in the image cropper to
initialize the cropper functionality once the image i...
2022-10-09
-
- Resolves: #98558
Releases: main, 11.5
Change-Id: Ic7bfd4812e49481f51603826a729423951275dbb
Reviewed-on: https://revie... -
- Resolves: #98558
Releases: main, 11.5
Change-Id: Ic7bfd4812e49481f51603826a729423951275dbb
Reviewed-on: https://revie... -
- This change properly removes registered exception handlers
in tests to avoid side effects. Thus acting as pre-patch t... -
- This change properly removes registered exception handlers
in tests to avoid side effects. Thus acting as pre-patch t...
2022-10-08
-
- This change ensures that unit tests has a valid `setUp()`
parent call chain down to the testing-framework base
class ... -
- This change ensures that unit tests has a valid `setUp()`
parent call chain down to the testing-framework base
class ... -
- With the introduction of CSRF-like request tokens in #97305 a
3rd party dependency has been added with a PHP8.2 depre... -
- Use guard to avoid undefined array key acces in core viewhelper
`\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper`.... -
- Use guard to avoid undefined array key acces in core viewhelper
`\TYPO3\CMS\Fluid\ViewHelpers\Be\PageInfoViewHelper`....
2022-10-07
-
- This update finds new problems and gets rid of some
false positives.
Run commands:
> composer req --dev phpstan/php... -
- Hook call runThroughTemplatesPostProcessing related to the
old TypoScript parser is now removed in the new TypoScript... -
13:15 Revision 365aa647: [FEATURE] Introduce additional attributes for all page.include** TS configurations
- Introduce tag attributes for the following TypoScript configurations:
* page.includeCSS
* page.includeCSSLibs
* page... -
- TYPO3 core required the package `tagsort` since at least version 8 but
it seems to be unused since then. The library ...
2022-10-06
-
- This update finds new problems and gets rid of some
false positives.
Run commands:
> composer req --dev phpstan/php... -
- Resolves: #98542
Related: #98535
Releases: main
Change-Id: Iacda5665031458eca739aa7d42b364ff66d57631
Reviewed-on: htt... -
- This helps avoid breakage when GeneralUtility will switch to
strict mode.
This change also prevents a bunch of possi...
2022-10-05
-
- With #98443, EXT:recordlist was moved into EXT:backend.
The moved classes were added to the class alias map,
however... -
- Resolves: #98533
Releases: main
Change-Id: Icf0718383c01b675ee9118aab07b61f21bd82cbb
Reviewed-on: https://review.typo... -
- The button to change the orientation in the EXT:viewpage module now
correctly "rotates" the preview again.
Resolves:... -
- This change moves the access of the link target
for files / external URLs and pages into the
actual AbstractTypolinkB... -
- Also, nikic/php-parser is only a dependency of
ext:install, ext:core does not use it, so we can
remove it from ext:co...
2022-10-04
-
- > composer req --dev codeception/codeception:^5.0.3
> composer req --dev codeception/module-webdriver:^3.1.3
> compos... -
- This patch reimplements the drag&drop functionality in the page module
with interactjs and thus removes the need of j... -
- This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
... -
- This change addresses several "undefined array key" issues that have
been identified by PsalmPHP (see issue #98321).
... -
- This introduces a new PSR-14 event, enabling
extension authors to modify the form data, used
by FormEngine to generat... -
- Some minor php-cs-fixer modifications:
* Move main config file to Build/php-cs-fixer
* Adapt runTests.sh setup and he... -
- Using <em:be.trigger triggers="{triggers}" /> in the
template seems to be obsolete since the controller
never sets th... -
- This update finds new problems and gets rid of some
false positives.
Run commands:
> composer req --dev phpstan/php... -
- This update finds new problems and gets rid of some
false positives.
Run commands:
> composer req --dev phpstan/php... -
- Some minor php-cs-fixer modifications:
* Move main config file to Build/php-cs-fixer
* Adapt runTests.sh setup and he... -
- Having manually(!) enabled "enhanced spell checking" in browsers,
can lead to scenarios where password data is sent t... -
- This avoids abandoned php-cs-fixer/diff
> composer req --dev friendsofphp/php-cs-fixer:^3.11.0
> Build/Scripts/runTe... -
- This avoids abandoned php-cs-fixer/diff. The raise
brings a series of CGL changes.
> composer req --dev friendsofphp... -
- > composer req --dev phpunit/phpunit:^9.5.25 -w
> composer u typo3/testing-framework
> composer u typo3/cms-styleguid... -
- Releases: main
Resolves: #98499
Change-Id: I39030ab03f82b34d96f5b39d5966068019c2cf22
Reviewed-on: https://review.typo... -
- Change-Id: I1feb236aeae9b3b7da1c50d5f65daf4fca4727bc
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/759... -
- Change-Id: I90d3ef8740698afac0327dff0591e4597b51e3e6
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/759... -
- Adjust the whitespace of the bookmark
edit form in the backend toolbar, to look
more aligned to the other dropdowns.
...
2022-10-03
-
- A followup to #97452 where a hook was removed but TYPO3 Core still
used it - the hook implementation is now removed.
... -
- PHP8.2 testing is temporarly completly disabled due firebase/php-jwt
depreaction issue (variable interpolation deprec... -
- Several performance analysis showed that `AbstractUserAuthentication`
takes a reasonable amount of processing time, e... -
- TYPY3v12 recently added hard requirement for `typo3/cms-composer-installers:5.x`,
which install core system extension... -
- - Add cross references for changelog files
- Remove additional empty lines
- Rename core -> Core
- Rename composer ->... -
18:50 Revision f410c0d1: [TASK] Deprecate support for RequireJS modules
- The RequireJS project has been discontinued [1] and was therefore
replaced by native ECMAScript v6/v11 modules in TYP... -
- Checking for a not existing value of a flexform sheet must not lead
to a notice.
Resolves: #98483
Releases: main, 11... -
- This switches from TemplateService to new TypoScript
parser logic in TypoScriptFrontendController.
The central metho... -
- Checking for a not existing value of a flexform sheet must not lead
to a notice.
Resolves: #98483
Releases: main, 11... -
- Internal calls to this method have already been adjusted by
previous patches.
Another one has been found in acceptan... -
- Resolves: #98507
Related: #98488
Releases: main
Change-Id: Id947f9b9ca75fa97b4f3fd2d270e0d92ac6a88e3
Reviewed-on: htt... -
- Resolves: #98508
Related: #97305
Releases: main
Change-Id: Id0f77fe51946cffeedf3699bf800169f0972657c
Reviewed-on: htt... -
- Symfony released new versions, which includes a bugfix in
"symfony/mailer", which allows us to reactivate a unit test... -
- Symfony released new versions, which includes a bugfix in
"symfony/mailer", which allows us to reactivate a unit test... -
- Resolves: #98510
Related: #98035
Releases: main
Change-Id: Ic6bd5074838647b9b18c74d5880a4e49f8be41dd
Reviewed-on: htt... -
- Disables spell checking in additional form elements:
* Setup Module `<form>` element
* ext:felogin `<form onsubmit>` ...
2022-10-02
-
- This change tackle a left over @todo regarding method
changes related to strict typing of interface changes
for TYPO3... -
- With Typolink (and the typolink ViewHelpers), a new option is
now available to allow to add ALL current queryParamete... -
- By supporting the `approved` attribute, integrators can decide
whether translations not marked as approved should be ... -
- TYPO3 now includes a PasswordPolicyValidator component which can
be used to validate passwords against configurable p... -
- Since #98377, the request passed to Fluid's rendering context is no
`ExtbaseRequestInterface` anymore by default, whi... -
- The array key `javaScriptModules` accepts a list of
JavaScriptModuleInstructions the same way as `requireJsModules`
d... -
- This change introduces a new registry class to be used
automatically instead of accessing $GLOBALS['PAGES_TYPES']
whi... -
- In the process of using dedicated TCA types,
the new TCA type "file" is introduced and
replaces TCA type "inline" wit... -
- This change introduces a new PSR-14 event
"ModifyDatabaseQueryForRecordListingEvent"
which serves as a successor for ... - 07:13 Revision eea87a05: [TASK] Align UI of the DB check module
- DB Check seems to be the only module in backend
that uses an Overview view for displaying the functions.
Other module...
Also available in: Atom