[BUGFIX] Prevent type error in Extension Scanner

Several extension scanner matchers scan a MethodCall node type, but cannot deal with possible method concatenation. Concatenating method names may involve dynamic variable resolving, which static analysis cannot perform. Thus, it is a setup for failure to try this. Instead this patch gracefully ignores these method calls to not throw a PHP type error on scanning extensions. Teachable moment: Try to not use dynamic method calls like ``` $dynamic = '1'; $this->{'like' . $dynamic}($arg1, $arg2, $arg3); ``` Resolves: #106043 Releases: main, 13.4, 12.4 Change-Id: I20a2953d649ea7377492eed489965f617b1069ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88046 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Garvin Hicking <gh@faktor-e.de>

[BUGFIX] Prevent type error in Extension Scanner
Several extension scanner matchers scan a MethodCall node type, but cannot deal with possible method concatenation. Concatenating method names may involve dynamic variable resolving, which static analysis cannot perform. Thus, it is a setup for failure to try this. Instead this patch gracefully ignores these method calls to not throw a PHP type error on scanning extensions. Teachable moment: Try to not use dynamic method calls like ``` $dynamic = '1'; $this->{'like' . $dynamic}($arg1, $arg2, $arg3); ``` Resolves: #106043 Releases: main, 13.4, 12.4 Change-Id: I20a2953d649ea7377492eed489965f617b1069ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/88046 Tested-by: core-ci <typo3@b13.com> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Stefan Bürk <stefan@buerk.tech> Reviewed-by: Garvin Hicking <gh@faktor-e.de> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Stefan Bürk <stefan@buerk.tech> Tested-by: Garvin Hicking <gh@faktor-e.de>
0eaded70 · Garvin Hicking · 0bdcf915 · 0eaded70 · 0eaded70 · 0eaded70
Commit 0eaded70 authored 1 month ago by Garvin Hicking
--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcher.php
@@ -80,7 +80,7 @@ class InterfaceMethodChangedMatcher extends AbstractCoreMatcher

        // Match method call (not static) with number of arguments
        if ($node instanceof MethodCall
-            && array_key_exists($node->name->name, $this->matcherDefinitions)
+            && isset($node->name->name) && array_key_exists($node->name->name, $this->matcherDefinitions)
        ) {
            $methodName = $node->name->name;
            $numberOfUsedArguments = 0;

--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcher.php
@@ -51,6 +51,7 @@ class MethodArgumentDroppedMatcher extends AbstractCoreMatcher
        if (!$this->isFileIgnored($node)
            && !$this->isLineIgnored($node)
            && $node instanceof MethodCall
+            && isset($node->name->name)
            && array_key_exists($node->name->name, $this->flatMatcherDefinitions)
        ) {
            $match = [

--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcher.php
@@ -50,6 +50,7 @@ class MethodArgumentRequiredMatcher extends AbstractCoreMatcher
        if (!$this->isFileIgnored($node)
            && !$this->isLineIgnored($node)
            && $node instanceof MethodCall
+            && isset($node->name->name)
            && array_key_exists($node->name->name, $this->flatMatcherDefinitions)
        ) {
            $match = [

--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcher.php
@@ -52,6 +52,7 @@ class MethodArgumentUnusedMatcher extends AbstractCoreMatcher
        if (!$this->isFileIgnored($node)
            && !$this->isLineIgnored($node)
            && $node instanceof MethodCall
+            && isset($node->name->name)
            && array_key_exists($node->name->name, $this->flatMatcherDefinitions)
        ) {
            $match = [

--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcher.php
@@ -67,6 +67,7 @@ class MethodCallArgumentValueMatcher extends AbstractCoreMatcher

            $matchCandidate = [$this->matcherDefinitions[$node->class->toString() . '::' . $node->name->name]];
        } elseif ($node instanceof MethodCall
+                && isset($node->name->name)
                && array_key_exists($node->name->name, $this->flatMatcherDefinitions)
        ) {
            $match = [

--- a/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallMatcher.php
+++ b/typo3/sysext/install/Classes/ExtensionScanner/Php/Matcher/MethodCallMatcher.php
@@ -50,6 +50,7 @@ class MethodCallMatcher extends AbstractCoreMatcher
        if (!$this->isFileIgnored($node)
            && !$this->isLineIgnored($node)
            && $node instanceof MethodCall
+            && isset($node->name->name)
            && array_key_exists($node->name->name, $this->flatMatcherDefinitions)
        ) {
            $match = [

--- a/typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/InterfaceMethodChangedMatcherFixture.php
+++ b/typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/Fixtures/InterfaceMethodChangedMatcherFixture.php
@@ -81,4 +81,17 @@ class InterfaceMethodChangedMatcherFixture
     * @param $arg3
     */
    protected function like5($arg1, $arg2, $arg3): void {}
+
+    /**
+     * No match: Protected, no error thrown
+     *
+     * @param $arg1
+     * @param $arg2
+     * @param $arg3
+     */
+    protected function concatenatedCall($arg1, $arg2, $arg3): void
+    {
+        $dynamic = '1';
+        $this->{'like' . $dynamic}($arg1, $arg2, $arg3);
+    }
 }