Skip to content
Snippets Groups Projects
Commit 42e2a93d authored by Joerg Kummer's avatar Joerg Kummer Committed by Christian Kuhn
Browse files

[BUGFIX] Fix failing acceptance test on topbar bookmark 

Adapt viewport changes in the acceptance tests too.

Resolves: #78273
Related: #52877
Releases: master
Change-Id: Ie627372e24af90a235794181841265c5ca7d2ed7
Reviewed-on: https://review.typo3.org/50203


Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarJoerg Kummer <service@enobe.de>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent f20de408
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
typo3/sysext/core/Tests/Acceptance/Backend/Topbar/BookmarkCest.php
+ 8
− 8
View file @ 42e2a93d
......@@ -47,6 +47,7 @@ class BookmarkCest
// Ensure main content frame is fully loaded, otherwise there are load-race-conditions
$I->switchToIFrame('contentIframe');
$I->waitForText('Web>Page module');
$I->switchToIFrame();
}
/**
......@@ -70,7 +71,7 @@ class BookmarkCest
{
$I->switchToIFrame();
// open the scheduler module as we would like to put it into the bookmark liste
$I->click('Scheduler', '#typo3-module-menu');
$I->click('Scheduler', '.scaffold-modulemenu');
$I->switchToIFrame('contentIframe');
......@@ -117,11 +118,11 @@ class BookmarkCest
public function checkIfEditBookmarkItemWorks(Admin $I)
{
$this->clickBookmarkDropdownToggleInTopbar($I);
$firstShortcutSelector = self::$topBarModuleSelector . ' .shortcut';
$I->click('.shortcut-edit', $firstShortcutSelector);
$I->fillField($firstShortcutSelector . ' input[name="shortcut-title"]', 'Scheduled tasks renamed');
$I->click('.shortcut-form-save', $firstShortcutSelector);
$firstShortcutSelector = self::$topBarModuleSelector . ' .t3js-topbar-shortcut';
$I->click('.t3js-shortcut-edit', $firstShortcutSelector);
$secondShortcutSelector = self::$topBarModuleSelector . ' form.shortcut-form';
$I->fillField($secondShortcutSelector . ' input[name="shortcut-title"]', 'Scheduled tasks renamed');
$I->click('.shortcut-form-save', $secondShortcutSelector);
// searching in a specific context fails with an "Stale Element Reference Exception"
// see http://docs.seleniumhq.org/exceptions/stale_element_reference.jsp
......@@ -138,7 +139,7 @@ class BookmarkCest
$this->clickBookmarkDropdownToggleInTopbar($I);
$I->canSee('Scheduled tasks renamed', self::$topBarModuleSelector);
$I->click('.shortcut-delete', self::$topBarModuleSelector . ' .shortcut');
$I->click('.t3js-shortcut-delete', self::$topBarModuleSelector . ' .t3js-topbar-shortcut');
$dialog->clickButtonInDialog('OK');
$I->cantSee('Scheduled tasks renamed', self::$topBarModuleSelector);
......@@ -149,7 +150,6 @@ class BookmarkCest
*/
protected function clickBookmarkDropdownToggleInTopbar(Admin $I)
{
$I->switchToIFrame();
$I->click(Topbar::$dropdownToggleSelector, self::$topBarModuleSelector);
}
}
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment