Skip to content
Snippets Groups Projects
Commit 445c7539 authored by Josef Glatz's avatar Josef Glatz Committed by Frank Nägler
Browse files

[BUGFIX] Module Permissions: wrong un-/lock icon state 

Fix icon state by replacing unlock with locked icon.
Add better explaining tooltip text for locked pages.

Releases: master
Resolves: #71357
Change-Id: If2a0c587b4f3e9b2c4f64486a0b6464ca2e47477
Reviewed-on: https://review.typo3.org/44562


Reviewed-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarMarkus Klein <markus.klein@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarFrank Nägler <frank.naegler@typo3.org>
Tested-by: default avatarFrank Nägler <frank.naegler@typo3.org>
parent 1ac139f2
No related branches found
No related tags found
No related merge requests found
Hide whitespace changes
Inline Side-by-side
typo3/sysext/beuser/Classes/Controller/PermissionAjaxController.php
+ 2
− 2
View file @ 445c7539
......@@ -302,9 +302,9 @@ class PermissionAjaxController
{
$page = (int)$page;
if ($editLockState === 1) {
$ret = '<span id="el_' . $page . '"><a class="editlock btn btn-default" data-page="' . $page . '" data-lockstate="1" title="The page and all content is locked for editing by all non-Admin users.">' . $this->iconFactory->getIcon('actions-unlock', Icon::SIZE_SMALL)->render() . '</a></span>';
$ret = '<span id="el_' . $page . '"><a class="editlock btn btn-default" data-page="' . $page . '" data-lockstate="1" title="The page and all content is locked for editing by all non-Admin users.">' . $this->iconFactory->getIcon('actions-lock', Icon::SIZE_SMALL)->render() . '</a></span>';
} else {
$ret = '<span id="el_' . $page . '"><a class="editlock btn btn-default" data-page="' . $page . '" data-lockstate="0" title="Enable the &raquo;Admin-only&laquo; edit lock for this page">' . $this->iconFactory->getIcon('actions-lock', Icon::SIZE_SMALL)->render() . '</a></span>';
$ret = '<span id="el_' . $page . '"><a class="editlock btn btn-default" data-page="' . $page . '" data-lockstate="0" title="Enable the &raquo;Admin-only&laquo; edit lock for this page">' . $this->iconFactory->getIcon('actions-unlock', Icon::SIZE_SMALL)->render() . '</a></span>';
}
return $ret;
}
......
typo3/sysext/beuser/Resources/Private/Language/locallang_mod_permission.xlf
+ 1
− 1
View file @ 445c7539
......@@ -25,7 +25,7 @@
<source>Lock</source>
</trans-unit>
<trans-unit id="EditLock_descr">
<source>The page and all content is locked for editing by all non-Admin users.</source>
<source>Disable the »Admin-only« edit lock for this page. Currently this page and all content is locked for editing by all non-Admin users.</source>
</trans-unit>
<trans-unit id="EditLock_descr2">
<source>Enable the »Admin-only« edit lock for this page</source>
......
typo3/sysext/beuser/Resources/Private/Templates/Permission/Index.html
+ 2
− 2
View file @ 445c7539
......@@ -114,7 +114,7 @@
data-lockstate="1"
title="{f:translate(key: 'LLL:EXT:beuser/Resources/Private/Language/locallang_mod_permission.xlf:EditLock_descr')}"
>
<core:icon identifier="actions-unlock" />
<core:icon identifier="actions-lock" />
</a>
</f:then>
<f:else>
......@@ -124,7 +124,7 @@
data-lockstate="0"
title="{f:translate(key: 'LLL:EXT:beuser/Resources/Private/Language/locallang_mod_permission.xlf:EditLock_descr2')}"
>
<core:icon identifier="actions-lock" />
<core:icon identifier="actions-unlock" />
</a>
</f:else>
</f:if>
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment