Skip to content
Commit 5b2ad55f authored by Stefan Bürk's avatar Stefan Bürk
Browse files

[BUGFIX] Mitigate change detection loop for enum and set fields

Doctrine DBAL retrieves for MariaDB `ENUM()` and `SET()`
field default values quotes with single quotes, which
leads to an endless field change reporting recursion in
the database analyzer. The default value is now trimmed
to ensure a working field compare within the extending
`TYPO3\CMS\Core\Database\Schema\Comparator` class.

Note that TYPO3 v13 (main) may reveal the same issue but
is shadowed due to the general `ENUM()` and `SET()` type
field issue since Doctrine DBAL 4, reported in #104413.
That needs a change on its own for main only.

Resolves: #97498
Related: #104413
Releases: 12.4, 11.5
Change-Id: I51b79a7f63db43cca2724958b0355a496a49fd33
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/85511


Tested-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarMarkus Klein <markus.klein@typo3.org>
Tested-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarcore-ci <typo3@b13.com>
Reviewed-by: default avatarSimon Schaufelberger <simonschaufi+typo3@gmail.com>
Reviewed-by: default avatarStefan Bürk <stefan@buerk.tech>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent e716082f
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment