[TASK] Decouple TemplateService->getFileName
TemplateService in TYPO3 frontend is responsible for fetching sys_template records and sorting TypoScript related things out, but also contains one method, which is nowadays completely separate from sys_template: "getFileName". This method checks for valid syntax and returns a proper string then (resolves "EXT:... syntax" and valdiates against available paths). The logic is frontend-related, thus moved to EXT:frontend/FilePathSanitizer. The old functionality in TemplateService is deprecated, along with the public property "fileCache". Resolves: #85445 Releases: master Change-Id: Id52ef476d0cd6a67de2560a0e427339b7310427e Reviewed-on: https://review.typo3.org/57403 Reviewed-by:Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/core/Classes/TypoScript/TemplateService.php 25 additions, 39 deletionstypo3/sysext/core/Classes/TypoScript/TemplateService.php
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-85445-TemplateService-getFileName.rst 37 additions, 0 deletions.../master/Deprecation-85445-TemplateService-getFileName.rst
- typo3/sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php 1 addition, 35 deletions...sysext/core/Tests/Unit/TypoScript/TemplateServiceTest.php
- typo3/sysext/core/Tests/UnitDeprecated/TypoScript/TemplateServiceTest.php 75 additions, 0 deletions...e/Tests/UnitDeprecated/TypoScript/TemplateServiceTest.php
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php 11 additions, 5 deletions.../frontend/Classes/ContentObject/ContentObjectRenderer.php
- typo3/sysext/frontend/Classes/ContentObject/FileContentObject.php 19 additions, 14 deletions...sext/frontend/Classes/ContentObject/FileContentObject.php
- typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php 6 additions, 2 deletions...ntend/Classes/Controller/TypoScriptFrontendController.php
- typo3/sysext/frontend/Classes/Imaging/GifBuilder.php 7 additions, 2 deletionstypo3/sysext/frontend/Classes/Imaging/GifBuilder.php
- typo3/sysext/frontend/Classes/Page/PageGenerator.php 71 additions, 16 deletionstypo3/sysext/frontend/Classes/Page/PageGenerator.php
- typo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php 107 additions, 0 deletionstypo3/sysext/frontend/Classes/Resource/FilePathSanitizer.php
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php 12 additions, 18 deletions...nd/Tests/Unit/ContentObject/ContentObjectRendererTest.php
- typo3/sysext/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php 67 additions, 0 deletions...xt/frontend/Tests/Unit/Resource/FilePathSanitizerTest.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php 7 additions, 0 deletions.../Configuration/ExtensionScanner/Php/MethodCallMatcher.php
- typo3/sysext/install/Configuration/ExtensionScanner/Php/PropertyPublicMatcher.php 10 additions, 5 deletions...figuration/ExtensionScanner/Php/PropertyPublicMatcher.php
Loading
Please register or sign in to comment