Skip to content
Snippets Groups Projects
Commit 819380b1 authored by Martin Kutschker's avatar Martin Kutschker Committed by Christian Kuhn
Browse files

[BUGFIX] Remove useless role="img" attributes

Role "img" requires an accessible name. The backend never supplies one,
but uses it only on SVG icons within links that must have a link text.

Resolves: #93826
Releases: master
Change-Id: Ic8793f79a1e783aac51af57aa57712a1972d3252
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68623


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarRichard Haeser <richard@richardhaeser.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarOliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: default avatarRichard Haeser <richard@richardhaeser.com>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
parent d1fd9d28
No related branches found
No related tags found
No related merge requests found
......@@ -4,7 +4,7 @@
title="Create a bookmark to this page">
<span class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new" data-identifier="actions-system-shortcut-new">
<span class="icon-markup">
<svg class="icon-color" role="img"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
<svg class="icon-color"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
</span>
</span>
</a>
......@@ -4,7 +4,7 @@
title="Create a bookmark to this page">
<span class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new" data-identifier="actions-system-shortcut-new">
<span class="icon-markup">
<svg class="icon-color" role="img"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
<svg class="icon-color"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
</span>
</span>
</a>
......@@ -4,7 +4,7 @@
title="Create a bookmark to this page">
<span class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new" data-identifier="actions-system-shortcut-new">
<span class="icon-markup">
<svg class="icon-color" role="img"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
<svg class="icon-color"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
</span>
</span>
</a>
......@@ -4,7 +4,7 @@
title="Create a bookmark to this page">
<span class="t3js-icon icon icon-size-small icon-state-default icon-actions-system-shortcut-new" data-identifier="actions-system-shortcut-new">
<span class="icon-markup">
<svg class="icon-color" role="img"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
<svg class="icon-color"><use xlink:href="typo3/sysext/core/Resources/Public/Icons/T3Icons/sprites/actions.svg#actions-star" /></svg>
</span>
</span>
</a>
......@@ -48,7 +48,7 @@ class SvgSpriteIconProvider extends AbstractSvgIconProvider implements IconProvi
}
$source = PathUtility::getAbsoluteWebPath($source);
return '<svg class="icon-color" role="img"><use xlink:href="' . htmlspecialchars($source) . '" /></svg>';
return '<svg class="icon-color"><use xlink:href="' . htmlspecialchars($source) . '" /></svg>';
}
/**
......
......@@ -58,7 +58,7 @@ class SvgSpriteIconProviderTest extends UnitTestCase
'sprite' => 'fileadmin/sprites/actions.svg#actions-add',
'source' => 'fileadmin/svg/actions-add.svg',
]);
self::assertEquals('<svg class="icon-color" role="img"><use xlink:href="fileadmin/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
self::assertEquals('<svg class="icon-color"><use xlink:href="fileadmin/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
}
/**
......@@ -70,7 +70,7 @@ class SvgSpriteIconProviderTest extends UnitTestCase
'sprite' => '/fileadmin/sprites/actions.svg#actions-add',
'source' => '/fileadmin/svg/actions-add.svg',
]);
self::assertEquals('<svg class="icon-color" role="img"><use xlink:href="/fileadmin/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
self::assertEquals('<svg class="icon-color"><use xlink:href="/fileadmin/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
}
/**
......@@ -82,7 +82,7 @@ class SvgSpriteIconProviderTest extends UnitTestCase
'sprite' => 'EXT:core/Resources/Public/Images/sprites/actions.svg#actions-add',
'source' => 'EXT:core/Resources/Public/Images/svg/actions-add.svg',
]);
self::assertEquals('<svg class="icon-color" role="img"><use xlink:href="typo3/sysext/core/Resources/Public/Images/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
self::assertEquals('<svg class="icon-color"><use xlink:href="typo3/sysext/core/Resources/Public/Images/sprites/actions.svg#actions-add" /></svg>', $this->icon->getMarkup());
}
/**
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment