Skip to content
Snippets Groups Projects
Commit 8415fce0 authored by Daniel Siepmann's avatar Daniel Siepmann Committed by Georg Ringer
Browse files

[BUGFIX] Use single type @var in LogEntry model properties

With https://review.typo3.org/c/Packages/TYPO3.CMS/+/64018
several @var annotations have been adjusted to reflect the
actual used type of properties.

This however led to the issue that several properties of
Extbase models had one type as annotation but used more
than one specific type internally. Adding the additional
type made phpstan happy but broke the property mapper of
Extbase, which expects just one type to be annotated via
@var.

Therefore, the @var annotations in the affected models
have been reverted to their original state and the
reoccurring errors have been put onto phpstans list of
ignored errors.

Resolves: #90969
Releases: master
Change-Id: I91944a631b9e1ff300ada25953577d852a998270
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64094


Tested-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarAlexander Schnitzler <git@alexanderschnitzler.de>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
parent 52959b6d
No related branches found
No related tags found
No related merge requests found
......@@ -101,6 +101,16 @@ parameters:
count: 1
path: typo3/sysext/core/Classes/Resource/Processing/ImageCropScaleMaskTask.php
# Ignored errors for level 3
-
message: "#^Property TYPO3\\\\CMS\\\\Belog\\\\Domain\\\\Model\\\\LogEntry\\:\\:\\$tableName \\(string\\) does not accept default value of type int\\.$#"
count: 1
path: typo3/sysext/belog/Classes/Domain/Model/LogEntry.php
-
message: "#^Property TYPO3\\\\CMS\\\\Belog\\\\Domain\\\\Model\\\\LogEntry\\:\\:\\$newId \\(string\\) does not accept default value of type int\\.$#"
count: 1
path: typo3/sysext/belog/Classes/Domain/Model/LogEntry.php
# Ignored errors for level 4
-
message: "#^Unreachable statement \\- code above always terminates\\.$#"
......
......@@ -58,7 +58,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
/**
* Table name
*
* @var string|int
* @var string
*/
protected $tableName = 0;
......@@ -135,7 +135,7 @@ class LogEntry extends \TYPO3\CMS\Extbase\DomainObject\AbstractEntity
/**
* New ID
*
* @var string|int
* @var string
*/
protected $newId = 0;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment