[TASK] FormEngine result array cleanup for internal data

Some of the data created within the FormDataCompiler stuff by the data providers is used only within the data creation process internally and should not be used by the render engine later. An example is the "inline overrule" array that is merged by one provider to the target TCA and render engine must not access or handle this later on. The patch introduces a list of keys in FormDataCompiler that is unset from the result array before it is returned to the calling controller. Change-Id: Ic6abf7787d18a92753ae1415e91f50411ca149d4 Resolves: #70552 Releases: master Reviewed-on: http://review.typo3.org/43944 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>

[TASK] FormEngine result array cleanup for internal data
Some of the data created within the FormDataCompiler stuff by the data providers is used only within the data creation process internally and should not be used by the render engine later. An example is the "inline overrule" array that is merged by one provider to the target TCA and render engine must not access or handle this later on. The patch introduces a list of keys in FormDataCompiler that is unset from the result array before it is returned to the calling controller. Change-Id: Ic6abf7787d18a92753ae1415e91f50411ca149d4 Resolves: #70552 Releases: master Reviewed-on: http://review.typo3.org/43944 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
8b4352f5 · Anja Leichsenring · Morton Jonuschat · 0ed1f300 · 8b4352f5 · 8b4352f5
Commit 8b4352f5 authored 9 years ago by Anja Leichsenring Committed by Morton Jonuschat 9 years ago
--- a/typo3/sysext/backend/Classes/Form/FormDataCompiler.php
+++ b/typo3/sysext/backend/Classes/Form/FormDataCompiler.php
@@ -27,6 +27,16 @@ class FormDataCompiler
     */
    protected $formDataGroup;

+    /**
+     * List of top level array elements to be unset from
+     * result array before final result is returned.
+     *
+     * @var array
+     */
+    protected $removeKeysFromFinalResultArray = [
+        'inlineOverruleTypesArray',
+    ];
+
    /**
     * Get form data group injected
     *
@@ -96,6 +106,12 @@ class FormDataCompiler
            );
        }

+        // Remove some data elements form result that are data provider internal and should
+        // not be exposed to calling object.
+        foreach ($this->removeKeysFromFinalResultArray as $key) {
+            unset($result[$key]);
+        }
+
        return $result;
    }


--- a/typo3/sysext/backend/Tests/Unit/Form/FormDataComplierTest.php
+++ b/typo3/sysext/backend/Tests/Unit/Form/FormDataComplierTest.php