[TASK] Do not use custom "getInstance()" methods on Singleton interfaces
There was a time when new code for TYPO3 Core was introduced by using "MyClass::getInstance()" to act as a factory for this class, which _would_ be OK if these classes are actually prototypes and not services (or singleton services), as GeneralUtility::makeInstance() or DI via Services.yaml works as well. This change deprecates all getInstance methods around such code with GeneralUtility::makeInstance() calls. At a later point, proper DI can be introduced in these cases. * TYPO3\CMS\Core\Resource\Index\ExtractorRegistry::getInstance() * TYPO3\CMS\Core\Resource\Index\FileIndexRepository::getInstance() * TYPO3\CMS\Core\Resource\Index\MetaDataRepository::getInstance() * TYPO3\CMS\Core\Resource\OnlineMedia\Helpers\OnlineMediaHelperRegistry::getInstance() * TYPO3\CMS\Core\Resource\Rendering\RendererRegistry::getInstance() * TYPO3\CMS\Core\Resource\TextExtraction\TextExtractorRegistry::getInstance() * TYPO3\CMS\Form\Service\TranslationService::getInstance() * TYPO3\CMS\T3editor\Registry\AddonRegistry::getInstance() * TYPO3\CMS\T3editor\Registry\ModeRegistry::getInstance() Resolves: #95326 Releases: master Change-Id: Ie3160c67792e115cf5488dc800bd717c0b913ab9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71178 Tested-by:core-ci <typo3@b13.com> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/backend/Classes/Controller/OnlineMediaController.php 1 addition, 1 deletion...sext/backend/Classes/Controller/OnlineMediaController.php
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php 1 addition, 1 deletion...backend/Classes/Form/Container/InlineControlContainer.php
- typo3/sysext/core/Classes/Resource/Index/ExtractorRegistry.php 2 additions, 0 deletions.../sysext/core/Classes/Resource/Index/ExtractorRegistry.php
- typo3/sysext/core/Classes/Resource/Index/FileIndexRepository.php 2 additions, 0 deletions...ysext/core/Classes/Resource/Index/FileIndexRepository.php
- typo3/sysext/core/Classes/Resource/Index/Indexer.php 2 additions, 2 deletionstypo3/sysext/core/Classes/Resource/Index/Indexer.php
- typo3/sysext/core/Classes/Resource/Index/MetaDataRepository.php 2 additions, 0 deletions...sysext/core/Classes/Resource/Index/MetaDataRepository.php
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php 1 addition, 1 deletion...esource/OnlineMedia/Helpers/AbstractOnlineMediaHelper.php
- typo3/sysext/core/Classes/Resource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php 2 additions, 0 deletions...esource/OnlineMedia/Helpers/OnlineMediaHelperRegistry.php
- typo3/sysext/core/Classes/Resource/OnlineMedia/Metadata/Extractor.php 3 additions, 4 deletions.../core/Classes/Resource/OnlineMedia/Metadata/Extractor.php
- typo3/sysext/core/Classes/Resource/OnlineMedia/Processing/PreviewProcessing.php 2 additions, 2 deletions...ses/Resource/OnlineMedia/Processing/PreviewProcessing.php
- typo3/sysext/core/Classes/Resource/Rendering/RendererRegistry.php 2 additions, 0 deletions...sext/core/Classes/Resource/Rendering/RendererRegistry.php
- typo3/sysext/core/Classes/Resource/Rendering/VimeoRenderer.php 2 additions, 1 deletion.../sysext/core/Classes/Resource/Rendering/VimeoRenderer.php
- typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php 1 addition, 1 deletion...ysext/core/Classes/Resource/Rendering/YouTubeRenderer.php
- typo3/sysext/core/Classes/Resource/ResourceFactory.php 1 addition, 1 deletiontypo3/sysext/core/Classes/Resource/ResourceFactory.php
- typo3/sysext/core/Classes/Resource/ResourceStorage.php 2 additions, 2 deletionstypo3/sysext/core/Classes/Resource/ResourceStorage.php
- typo3/sysext/core/Classes/Resource/Service/ExtractorService.php 2 additions, 1 deletion...sysext/core/Classes/Resource/Service/ExtractorService.php
- typo3/sysext/core/Classes/Resource/TextExtraction/TextExtractorRegistry.php 2 additions, 0 deletions...Classes/Resource/TextExtraction/TextExtractorRegistry.php
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-95326-VariousGetInstanceStaticMethodsOnSingletonInterfaces.rst 49 additions, 0 deletions...-VariousGetInstanceStaticMethodsOnSingletonInterfaces.rst
- typo3/sysext/core/Tests/Unit/Resource/Rendering/RendererRegistryTest.php 1 addition, 1 deletion...re/Tests/Unit/Resource/Rendering/RendererRegistryTest.php
- typo3/sysext/core/ext_localconf.php 3 additions, 3 deletionstypo3/sysext/core/ext_localconf.php
Loading
Please register or sign in to comment