Bug #100428
closed
TYPO3 v12 Database Upgrade is never fulfilled
100%
Description
On TYPO3 12.3.0 running the command 'vendor/bin/typo3 upgrade:run' leads to the error message
"Error running Database Up-to-Date. Please ensure this prerequisite manually and try again."
This is repetitive, as we only "add" database changes here but no indexes. The issue was introduced in https://review.typo3.org/c/Packages/TYPO3.CMS/+/58128 in file https://review.typo3.org/c/Packages/TYPO3.CMS/+/58128/10/typo3/sysext/install/Classes/Updates/DatabaseUpdatedPrerequisite.php and function ensure()
$result = null;
if (count($adds) > 0) {
$this->output->writeln('Performing ' . count($adds) . ' database operations.');
$result = $this->upgradeWizardsService->addMissingTablesAndFields();
}
return $result === null;
The addMissingTablesAndFields() returns an empty array, if no errors exists, so we try to check empty array against null. Uncool.
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review about 1 year ago
Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Oliver Klee about 1 year ago
- Related to Task #100491: Improve some type annotations in DB-upgrade-related classes added
Updated by Gerrit Code Review about 1 year ago
Patch set 5 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review 12 months ago
Patch set 6 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review 12 months ago
Patch set 7 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review 12 months ago
Patch set 8 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review 12 months ago
Patch set 9 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by Gerrit Code Review 11 months ago
Patch set 10 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/78447
Updated by
Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch 11.5 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79301
Updated by Gerrit Code Review 11 months ago
Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/79354
Updated by Alexander Opitz 11 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 22d9db30d7ca70f19f724f97fbac4a41c748534b.