Task #101529: Use relative paths for test fixture files - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #101529

closed

Use relative paths for test fixture files

Added by Anja Leichsenring 9 months ago. Updated 3 months ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Tests

Target version:

Start date:

2023-08-02

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

easy

Sprint Focus:

On Location Sprint

Description

functional tests heavily use a feature to import and compare DB records via CSV files. Those files should be referenced by a syntax consisting of __DIR__ . '...' to enable direct jumping of IDEs and also serve as a clean read.
Some of the CSV fixtures are loaded via 'typo3/sysext/....' paths, which will not offer those benefits.
Find the occurences and replace the relative patch with the __DIR__ syntax.

Functions to look for are
- $this->assertCSVDataSet()
- $this->importCSVDataSet()

Have for example a look into typo3/sysext/extbase/Tests/Functional/Persistence/RelationTest.php for the wanted syntax, here we corrected the pathes already.

Actions

Copy link

Updated by Anja Leichsenring 9 months ago

Description updated (diff)

Actions

Copy link

Updated by Stephan Jorek 9 months ago

What about $this->setUpFrontendRootPage() calls? Looks like they should be replaced too. Will look at it, and give feedback on those calls in the review …

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Status changed from New to Under Review

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 2 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 3 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions

Copy link

Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80325

Actions

Copy link

#10

Updated by Gerrit Code Review 9 months ago

Patch set 4 for branch main of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80321

Actions

Copy link

#11

Updated by Gerrit Code Review 9 months ago

Patch set 1 for branch 12.4 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/80384

Actions

Copy link

#12