Project

General

Profile

Actions

Bug #17338

closed

Sitemap Content Element does not honorate Workspaces

Added by Olivier Dobberkau almost 17 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Workspaces
Target version:
-
Start date:
2007-05-29
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.1
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The Content Element Sitemap does not switch to the new PID once the Version is published.

(issue imported from #M5699)


Files

tslib_menu.diff (232 Bytes) tslib_menu.diff Administrator Admin, 2010-04-02 13:48

Related issues 1 (0 open1 closed)

Has duplicate TYPO3 Core - Bug #17396: HMENU with special=list does not take workspace into account in FE-PreviewClosedSusanne Moog2007-06-18

Actions
Actions #1

Updated by Dmitry Dulepov over 16 years ago

Possibly related to #5817

Actions #2

Updated by Dmitry Dulepov over 16 years ago

Oliver, can you provide more information? Description is too short.

Actions #3

Updated by Olivier Dobberkau over 16 years ago

Hello Dmitry. The Sitemap Content Element does not work in the Workspace Context.

Testcase:
Create a Sitemap Content Element in Live WS
Create a Workspace Version of Page with the Sitemap in it.
Check if the Sitemap is being displayed
Publish the Page
Check if the Sitemap is being displayed

But I am not sure if this is still in 4.1.x it was in 4.0.x

Cheers Olivier

Actions #4

Updated by Sacha Vorbeck about 16 years ago

I can confirm that. I use custom tt_content.menu elements a lot and if a HMENU within one of those custom menus should display fields from the pages table (e. g. media, description, custom fields) the output will always show the content of the fields from the live version.

But it should display the contents of the current workspace version instead. So when you have a site that uses sitemap elements a lot, the workspace system can`t be used for a staging workflow.

Actions #5

Updated by Petro Boychuk about 14 years ago

I can confirm this on TYPO3 version 4.3.2.

I've attached the patch that solved this issue for me, can someone (i think I has to be someone from the core team, right?) test it and confirm that it works?

I'm not sure if this is correct diff file, so I'll post how to modify it manually.

The problem was with file typo3/sysext/cms/tslib/class.tslib_menu.php after line 516, before

// Add external MP params, then the row:
if (is_array($row)) {
if ($MP) $row['_MP_PARAM'] = $MP.($row['_MP_PARAM'] ? ','.$row['_MP_PARAM'] : '');
$temp[] = $this->sys_page->getPageOverlay($row);
}

I've placed 4 lines

//Add versioning overlay for current page (to respect workspaces)
if(is_array($row)){
$this->sys_page->versionOL('pages',$row,true);
}

The problem was that array with page record was not overlaid with versioning information. Looks like just 4 lines of code solved the issue.

Actions #6

Updated by Susanne Moog about 14 years ago

Committed to trunk rev. 7364

Actions #7

Updated by Michael Stucki over 10 years ago

  • Category changed from Miscellaneous to Workspaces
Actions #8

Updated by Michael Stucki over 10 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
  • Target version deleted (0)
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF