Workspaces & Versioning

added a patch to receive emails for users of the assigned backend usergroups and the assigend users entries.

Patrick, there is a problem (because it is confusing) is that $users is used for two distinct data sets: an array of user IDs and a PREF match array.

This can be amened easily:

if (!$noTablePrefix) {
preg_match_all('/be_groups_([0-9]+)/', $listOfEntries, $match_groups);
preg_match_all('/be_users_([0-9]+)/', $listOfEntries, $match_users);
$groups = $match_groups¹;
$users = $match_users¹;
} else {
$groups = array();
$users = t3lib_BEfunc::trimExplode(',',$listOfEntries,1);
}

Test:

php -r 'preg_match_all("/be_users_([0-9]+)/","be_users_1,be_groups_5,be_users_2",$match);print_r($match);'

Now you have always an array (may be empty) for $users and $groups always containing a list of IDs (without the table prefix).

Please change this as this will make the code much more readable.

Hi Martin,

I have applied the your suggestions and refactored the code a little bit. Please have a look and let me know if this is ok with you.

Recent patch is 0006239_v2.patch

see also issue 0011255

If the patch is already applied ?
It's quite strange to see not applied patch 2 years old.

see http://review.typo3.org/2088

Patch set 2 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088

Patch set 3 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088

Patch set 4 of change I099e6132cd4698b886cae3c837c0cae80c318b46 has been pushed to the review server.
It is available at http://review.typo3.org/2088