Bug #19845
Duplicated values in localconf.php (typo3conf) - compat_version
| Status: | Closed | Start date: | 2009-01-17 | |
|---|---|---|---|---|
| Priority: | Should have | Due date: | ||
| Assignee: | Christian Kuhn | % Done: | 0% |
|
| Category: | Install Tool | |||
| Target version: | - | |||
| TYPO3 Version: | 4.2 | Complexity: | ||
| PHP Version: | 5.2 | |||
| Votes: | 0 |
Description
I found an annoying "bug" in Install Tool/localconf.php when doing some upgrades (from 4.1.x to 4.2.x, from 4.2.x to 4.3.dev). It's not something that I find in every upgraded installations, but in some.
The "bug" is a duplicate of ["SYS"]["compat_version"]. How and when the duplicate is made, i don't know. All off these installations has a history back to 4.0.x and older. The annoying part is when using the upgrade wizard in the Install Tool, it looks like only the first occurence of ["SYS"]["compat_version"] is changed, but it's the second one which are read back to the TYPO3 backend/Install Tool. Ant therefore tells you both in backend and Install Tool that you havent't upgraded.
I doesn't look like this "bug" do any harm, or gives problems.
The first occurence is always written ['SYS']['compat_version'] (single quotes). The second i always written ["SYS"]["compat_version"] (double qoutes). No other variables in localconf.php in tested/checked installations has "double quotes"
Solution should prabably be checking for ["SYS"]["compat_version"] (with double quotes) and comment out/delete this line.
I have tagged the bug to TYPO3 4.2 and above. Reason, I can't remenber this problem upgrading from 4.0.x to 4.1.x. I also don't have the duplicate value in installations done after the release of 4.1.0
(issue imported from #M10175)
Related issues
| related to Core - Bug #21203: Install Tool, "Update Wizard", "changeCompatibilityVersio... | Closed | 2009-10-08 | ||
| related to Core - Bug #18947: Compatibility version changed to 3.8 after update on vers... | Resolved | 2008-06-13 | ||
| duplicated by Core - Bug #16721: Update Wizard wont overwrite compat_version mode, in case... | Resolved | 2006-11-17 |
History
Updated by Christian Kuhn over 4 years ago
This is probably related to #19205
Updated by Stefano Kowalke over 4 years ago
This related to #19205 but was not fixed properly.
Installer don´t fetch ["SYS"]["compat_version"] (with double quotes) and insert a new one at bottom of the page with single quotes -> ['SYS']['compat_version']
Need a to be tolerant for double quotes an replace them with single quotes.
Updated by Michiel Roos about 4 years ago
This problem is still present in 4.3 trunk.
I just copied a 4.2 installation and tried to upgrade that.
Install tool keep complaining I need to upgrade . . .
Line 68 reads: $TYPO3_CONF_VARS["SYS"]["compat_version"] = '4.2'; // Modified or inserted by T
Line 56 reads: $TYPO3_CONF_VARS['SYS']['compat_version'] = '4.3'; // Modified or inserted by T
Updated by Tim Lochmüller about 4 years ago
I think this is a problem from older versions (or change manually to ").
if the order is wrong the installer change the line above the right line.
Check: t3lib/class.t3lib_install.php line 00147 - 00161
in this lines the installer finde the ' and ignore a "
this ok because all options set with '
but i dont know if a old version of TYPO3 set the configuration with "
Updated by Christian Kuhn almost 4 years ago
- Committed to trunk (rev. 5640)