Feature #24037: Add "edit end token" to allow custom post configuration in localconf.php - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Feature #24037

closed

Add "edit end token" to allow custom post configuration in localconf.php

Added by Steffen Müller over 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Tobias Liebig

Category:

Install Tool

Target version:

Start date:

2010-11-12

Due date:

% Done:

100%

Estimated time:

PHP Version:

Tags:

Complexity:

Sprint Focus:

Description

Problem:
"INSTALL SCRIPT EDIT POINT TOKEN" limits the range in localconf.php which is handled by class t3lib_install. Configuration ABOVE this token is not touched by the t3lib_install.

In some deployment cases it is useful to have some configuration BELOW this range, which is also not touched by t3lib_install. (e.g. to override config before extensions are loaded).
Details and use cases have already been discussed in TYPO3-dev newsgroup: http://lists.typo3.org/pipermail/typo3-dev/2010-October/041857.html

Solution:
Add handling of an end token, which limits the editable range of class t3lib_install.

I tested this successfully with introduction package.

Since introduction package does not completely use the API of t3lib_install, I added a second patch to preserve compatibility.

We could also think about adding this end token in localconf.php of dummy and introduction package

P.S. Please don't blame me for the smelly code. t3lib_install is a hassle. :)

(issue imported from #M16369)

Files

Download all files

16369.diff (10.1 KB) 16369.diff		Administrator Admin, 2010-11-12 17:54
16369-introduction.diff (906 Bytes) 16369-introduction.diff		Administrator Admin, 2010-11-12 17:54

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Steffen Müller over 13 years ago

Example localconf.php:

// lines untouched by t3lib_install
...

INSTALL SCRIPT EDIT POINT TOKEN - all lines after this points may be changed by the install script!'

// lines touched by t3lib_install
$GLOBALS['TYPO3_CONF_VARS']['GFX']['im_version_5'] = 1;
$GLOBALS['TYPO3_CONF_VARS']['GFX']['gdlib'] = 1;
$GLOBALS['TYPO3_CONF_VARS']['GFX']['TTFdpi'] = 72
// Updated by ...

INSTALL SCRIPT EDIT END POINT TOKEN - all lines before this points may be changed by the install script!
// lines untouched by t3lib_install
...
$GLOBALS['TYPO3_CONF_VARS']['GFX']['TTFdpi'] =96

Actions

Copy link

Updated by Chris topher over 13 years ago

Is there a way to see in the Install Tool, that some settings (in your example $GLOBALS['TYPO3_CONF_VARS']['GFX']['TTFdpi']) will be overwritten with unchangable values?
If there is none, people might think that writing to localconf does not work correctly...

Actions

Copy link

Updated by Xavier Perseguers over 13 years ago

@Steffen: please note that I added a relationship to a change that will committed soon.

@Christopher: this could be the opportunity to add a flash message with the reason why a setting was not updated once you click the update button.

Actions

Copy link

Updated by Tobias Liebig about 12 years ago

Assignee set to Tobias Liebig
Target version deleted (0)

Actions

Copy link

Updated by Tobias Liebig about 12 years ago

accidentally voted -1, should have been +1

Actions

Copy link

Updated by Gerrit Code Review about 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10492

Actions

Copy link

Updated by Tobias Liebig about 12 years ago

Category set to Install Tool
% Done changed from 0 to 100
TYPO3 Version changed from 4.5 to 6.0

We will need that to setup a "best practice" deployment setup with server/envoirment specific localconf configurations. E.g. different database credentials for the staging and live system.

Actions

Copy link