Bug #31404

session.auto_start flag not checked correctly

Added by Jochen Weiland over 1 year ago. Updated over 1 year ago.

Status:Closed Start date:2011-10-29
Priority:Must have Due date:
Assignee:Xavier Perseguers % Done:

100%

Category:Install Tool
Target version:4.6.1
TYPO3 Version:4.6 Complexity:no-brainer
PHP Version:5.3
Votes: 0

Description

When loading, the install tool checks the status of the PHP flag session.auto_start and stops with an error message if auto_start is enabled.

The check is done in sysext/install/mod/class.tx_install_session.php:

if (ini_get('session.auto_start')) {

  (display error message and throw runtime exception)

}

This works as long as ini_get('session.auto_start') returns an empty string.

We found that when running PHP in FCGI/FPM mode, the return value is the string "Off" and thus trowing the exception even if auto_start is not set.

In our PHP CGI configuration it works, since an empty string is returned instead of "Off".

Tested with PHP 5.3.8

Our temporary solution was this patch:

if (ini_get('session.auto_start') == '1' || ini_get('session.auto_start') == 'On') {

  (display error message and throw runtime exception)

}

However as an alternative a function like those for checking safe_mode setting in t3lib/utility/class.t3lib_utility_phpoptions.php could be implemented.

Associated revisions

Revision 4ebc852d
Added by Markus Klein over 1 year ago

[BUGFIX] Install Tool: Improper check of PHP session.auto_start

This fix improves the check for the PHP session.auto_start configuration
to account also for valid Yes/No configuration values.

Change-Id: Icbbe4ed6afdb69642fc5a9ca3a86dc82cc066464
Fixes: #31404
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/6382
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

Revision 55dada22
Added by Markus Klein over 1 year ago

[BUGFIX] Install Tool: Improper check of PHP session.auto_start

This fix improves the check for the PHP session.auto_start configuration
to account also for valid Yes/No configuration values.

Change-Id: I8a4dea14dece1d514681ed8a54f4549c22f6bf5c
Fixes: #31404
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/6383
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers

History

Updated by Markus Klein over 1 year ago

Since the whole Install Tool already uses t3lib_utility_phpoptions, I vote for adding a new function there.

Updated by Mr. Hudson over 1 year ago

  • Status changed from New to Under Review

Patch set 1 of change Icbbe4ed6afdb69642fc5a9ca3a86dc82cc066464 has been pushed to the review server.
It is available at http://review.typo3.org/6382

Updated by Mr. Hudson over 1 year ago

Patch set 1 of change I8a4dea14dece1d514681ed8a54f4549c22f6bf5c has been pushed to the review server.
It is available at http://review.typo3.org/6383

Updated by Mr. Hudson over 1 year ago

Patch set 2 of change Icbbe4ed6afdb69642fc5a9ca3a86dc82cc066464 has been pushed to the review server.
It is available at http://review.typo3.org/6382

Updated by Xavier Perseguers over 1 year ago

  • Status changed from Under Review to Resolved
  • Assignee set to Xavier Perseguers
  • % Done changed from 0 to 100

Updated by Xavier Perseguers over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF