Bug #32480

Form.css cannot be disabled

Added by Lorenz Ulrich over 1 year ago. Updated 8 months ago.

Status:Resolved Start date:2011-12-12
Priority:Should have Due date:
Assignee:- % Done:

100%
Category:Form Wizard
Target version:-
TYPO3 Version:4.6 Complexity:medium
PHP Version:
Votes: 7 (View)

Description

Currently the frontend CSS file of the new form element is hardcoded and thus cannot be disabled.

Form.php:

    protected function setCss() {
        $GLOBALS['TSFE']->additionalHeaderData['tx_form_css'] =
            '<link rel="stylesheet" type="text/css" href="' .
            t3lib_extMgm::siteRelPath('form') .
            'Resources/Public/CSS/Form.css' .
            '" media="all" />';
    }

I would suggest to remove this method and the CSS include to the TypoScript setup in sysext/form/Configuration/TypoScript/setup.txt.

page.includeCSS.tx_form = typo3/sysext/form/Resources/Public/CSS/Form.css

Same for Confirmation.php.

If you agree with me, I would submit a request to Gerrit.

Related issues

related to Core - Bug #40670: Cant modify the output with typoscript New 2012-09-06
duplicated by Core - Bug #28607: CSS path with TS Closed 2011-07-31

Associated revisions

Revision 0eee6027
Added by Lorenz Ulrich 9 months ago

[FEATURE] Make CSS for sysext form configurable

Move the default styles of ext:form to TS in
plugin.tx_form._CSS_DEFAULT_STYLE. This way it can be disabled with
TypoScript either via plugin.tx_form._CSS_DEFAULT_STYLE >, and also
respects the config.removeDefaultCss setting.

Change-Id: Ie2b0c397124f06ec32114983e78dd60b4229ce97
Resolves: #32480
Releases: 6.0
Reviewed-on: http://review.typo3.org/11932
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog

History

#1
Updated by Lorenz Ulrich over 1 year ago

After thinking about it, I think it would be better to read out TypoScript configuration in the setCss method because we want to make sure that the CSS is only on pages that contain a form element.

#2
Updated by Steffen Gebert over 1 year ago

I start puking, when I see that code.. it totally circumvents most API. Yes, including it in the TS template should be cleaner!

#3
Updated by Oliver Hader over 1 year ago

  • Status changed from New to Accepted
  • Complexity changed from easy to medium

Agreed, Lorenz did you consider to fix this? ;-)

#4
Updated by Lorenz Ulrich over 1 year ago

Yes I did :-). And I think I'll fix it.

#5
Updated by Blogger about 1 year ago

This correction is resolved?

#6
Updated by Andreas Sauer about 1 year ago

Is there any way to circumvent the inclusion of the stylesheet this until it is resolved?
I don't want to poop on anybodies party, but i completely disagree with the contents of Form.css and want it gone.

#7
Updated by Lorenz Ulrich about 1 year ago

Since I missed feature freeze (and a TypoScript config is a feature) this can only go into 4.8 (6.0?). I need to setup a new installation for master before I can do it.

#8
Updated by Paul Fleischanderl 12 months ago

made progress?

#9
Updated by Gerrit Code Review 12 months ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

#10
Updated by Lorenz Ulrich 11 months ago

As you can see, this change is pending in Gerrit. Now it's your work to test it and plusone it if it works. Thanks!

#11
Updated by Gerrit Code Review 10 months ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

#12
Updated by Gerrit Code Review 10 months ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

#13
Updated by Gerrit Code Review 10 months ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

#14
Updated by Lorenz Ulrich 10 months ago

Anyone annoyed by this: I think the latest changeset would be fine for merging, but I will not be able to push that since I'll be on a holiday now. Please merge it before feature freeze :-). Thanks.

#15
Updated by Gerrit Code Review 10 months ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/13402

#16
Updated by Gerrit Code Review 10 months ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11932

#17
Updated by Lorenz Ulrich 9 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF