Bug #34634

Inserting Tables is broken in 4.5.12 and 4.6.5

Added by Jan Loderhose about 1 year ago. Updated about 1 year ago.

Status:Resolved Start date:2012-03-07
Priority:Must have Due date:
Assignee:Stanislas Rolland % Done:

100%
Category:rtehtmlarea
Target version:4.5.13
TYPO3 Version:4.5 Complexity:
PHP Version:5.3
Votes: 0

Description

After upgrading TYPO3 to 4.5.12 and 4.6.5 inserting tables via RTE fails.

Latest FF says:

Error: HTMLArea.util.Color.colorToHex(element && element.style.borderColor ? element.style.borderColor : this.properties.borderColor &&
this.properties.borderColor.defaultValue ? this.properties.borderColor.defaultValue : "") is null

Source file: http://xxxxxx/typo3temp/compressor/htmlarea_cumulative_26d8390a9806dabb7c6c_compressed-
6e184a46173deb6d9f67984f1417affe.js.gzip
Line: 657

where as latest Chrome mumbles

Uncaught TypeError: Cannot call method 'substr' of null

The window to define the table parameters does not appear.

Associated revisions

Revision 41271aa0
Added by Stanislas Rolland about 1 year ago

[BUGFIX] RTE: Inserting a table is broken

Problem: The error is related to the color border settings.
Solution: HTMLArea.util.Color.colorToHex should return an empty string
rather than null.

Change-Id: I8dfeaca6fd9b2298c4120bdd4e3d4f76be5d3576
Resolves: #34634
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/9466
Reviewed-by: Stefan Neufeind
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Benny Schimmer
Tested-by: Benny Schimmer
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

Revision 5549a18a
Added by Stanislas Rolland about 1 year ago

[BUGFIX] RTE: Inserting a table is broken

Problem: The error is related to the color border settings.
Solution: HTMLArea.util.Color.colorToHex should return an empty string
rather than null.

Change-Id: I6a0b3095be2ba381ba9f78729fb45c8c0c684719
Resolves: #34634
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/9465
Reviewed-by: Stefan Neufeind
Reviewed-by: Jan Loderhose
Tested-by: Jan Loderhose
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland

History

#1
Updated by Christian Hennecke about 1 year ago

This also affects the properties dialogs of table, row, column, and cell. Same error message.

The error is related to the border settings. It does not occur if

disableBordersFieldsetInTableOperations = 1

#2
Updated by Stanislas Rolland about 1 year ago

  • Status changed from New to Accepted
  • Assignee set to Stanislas Rolland
  • Target version set to 4.5.13

#3
Updated by Gerrit Code Review about 1 year ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9465

#4
Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9466

#5
Updated by Stanislas Rolland about 1 year ago

Please test these changes for 4.5 and 4.6.

#6
Updated by Jan Loderhose about 1 year ago

Reviewed on gerrit. +1 for both patches.

#7
Updated by Stanislas Rolland about 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF