Core

Hi,
now tested with Image Magick 6.6.7.1 Same thing. Rendering Twice. Please could someone proof on his own Server what happend?
Thx in advance

Florian

Same problem here - using GraphicsMagick Version 1.2.10

I could solve problem also with lines below of Florian Zimmermann, before had both issues:
Black Background and twice pictures // Schwarzer Hintergrund und doppelt geladene Grafiken

Typo3 4.7.1
GraphicMagick 1.2.7

Thanks.

It would be great if you insert this function, to generate alpha-transparent PNGs. At the Moment only Alpha-Transparent Layers in GIFBUILDER are possible.

In File: t3lib/class.t3lib_stdgraphic.php at Line 439 replace the function with this function:

function imagecopyresized(&$im, $cpImg, $Xstart, $Ystart, $cpImgCutX, $cpImgCutY, $w, $h, $w, $h) {
        static $counter = 0;
        if ($this->imagecopyresized_fix && !$this->saveAlphaLayer) {
            $im_base = imagecreatetruecolor(imagesx($im), imagesy($im)); // Make true color image
            imagecopyresized($im_base, $im, 0, 0, 0, 0, imagesx($im), imagesy($im), imagesx($im), imagesy($im)); // Copy the source image onto that
            imagecopyresized($im_base, $cpImg, $Xstart, $Ystart, $cpImgCutX, $cpImgCutY, $w, $h, $w, $h); // Then copy the $cpImg onto that (the actual operation!)
            $im = $im_base; // Set pointer
        } else {
            if ($this->saveAlphaLayer) {
                imagealphablending($im, TRUE);
                imagealphablending($cpImg, TRUE);
            }
            imagecopyresized($im, $cpImg, $Xstart, $Ystart, $cpImgCutX, $cpImgCutY, $w, $h, $w, $h);
        }
    }

The provided patch fixes the problem only for the first rendererd item on the page.

I refined lib.headerData.5 (graphical headline) and include a arrow in front of the headline using an offset.

• Without using your patch I get the arrow rendered twice (0,0 and on offset position) and black background
• with using your patch and removing the offset I get both elements on the page rendered with correct background and arrow at 0,0
• with using your patch and including the offset the first element on the page is correct (arrow only one time and correct background) but the second element now again has both arrows and black background

So there must be still something weird going on (global variable?, same image used twice as destination?). If I use a GIFBUILDER-object two times on one page the second one is messed up when using offset...

Florian Schaeffer wrote:

The provided patch fixes the problem only for the first rendererd item on the page.

• with using your patch and including the offset the first element on the page is correct (arrow only one time and correct background) but the second element now again has both arrows and black background

So there must be still something weird going on (global variable?, same image used twice as destination?). If I use a GIFBUILDER-object two times on one page the second one is messed up when using offset...

Hello,

have you truncate your typo3temp/pics and typo3temp/GB folder? When i was testing the whole process i have the same thing.
First image great second image bad because of caching.
Please test it
Thx
Florian

Obviously a mistake that happened during the refactoring of the imagecopyresized method.
I came across a similar problem while using a gifbuilder-generated mask under TYPO3 4.7. Versions 4.5 and 4.6 rendered the image correctly.
Using the above fix from Florian Zimmermann or the implementation from TYPO3 4.6 fixed this Problem.

I already commented on the patchsets that apply this change at
https://review.typo3.org/#/c/9608/ and
https://review.typo3.org/#/c/6829/

For the TYPO3_4-7 branch, this change has been integrated as Revision 98f73d8b. Related issue is #26660.

@ Gernot Ploiner: There is only one bugfix/feature allowed in a change request. Please open an new issue for your feature request (alpha-transparent PNG).

@ Florian Zimmermann: I will take care of pushing the fix to Master (where it's already merged). Then it can be applied to the other versions.

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/12074