Bug #36981
Regression of "better condition in versionOL of t3lib_tstemplate" (#31139)
| Status: | Resolved | Start date: | 2012-05-09 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | Andy Grunwald | % Done: | 100% |
|
| Category: | Frontend | |||
| Target version: | - | |||
| TYPO3 Version: | 4.5 | Complexity: | ||
| PHP Version: | 5.3 | |||
| Votes: | 0 |
Description
In bug #31139: "better condition in versionOL of t3lib_tstemplate", the commit / change produces a regression.
The line
if (is_object($GLOBALS['TSFE'])) { // Frontend:
was changed to
if (TYPO3_MODE === 'FE') { // Frontend:
This change cause an error, because not in every case in TYPO3_MODE FE is a full blown frontend available. One example is an eID.
An eID is TYPO3_MODE === 'FE' but there is no $GLOBALS['TSFE']->sys_page.
The following error occur:
Fatal error: Call to a member function versionOL() on a non-object in /var/www/dasgastroportal.dus.wmdb.de/typo3_src-4.5.15/t3lib/class.t3lib_tstemplate.php on line 753
In our case we create via direct_mail api new mailings via an eid.
Direct mail calls this method to get the correct charset for this page.
I will provide a patch for all four branches 4.5, 4.6, 4.7 and 6.0
Related issues
| related to Core - Bug #31139: better condition in versionOL of t3lib_tstemplate | Resolved | 2011-10-20 |
Associated revisions
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.
The patch replaces the frontend check with a more specific test
for the required methods.
Change-Id: Ib3f9ebf355ee820e5144dd484d9a3a5e7708ebd4
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11096
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.
The patch replaces the frontend check with a more specific test
for the required methods.
Change-Id: I9c9cdfd494044a23def97db90ec3adf528e86f39
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11099
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.
The patch replaces the frontend check with a more specific test
for the required methods.
Change-Id: I9920cf185883d35c2121077b62e34c76ace72a94
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11098
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.
The patch replaces the frontend check with a more specific test
for the required methods.
Change-Id: If7712903b96922ea3da51218d3ed5ff2496168f8
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11097
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.
The patch replaces the frontend check with a more specific test
for the required methods.
Change-Id: Ib3f9ebf355ee820e5144dd484d9a3a5e7708ebd4
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11096
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
History
Updated by Andy Grunwald about 1 year ago
- Assignee set to Andy Grunwald
Updated by Andy Grunwald about 1 year ago
I`m currently working on it.
Updated by Gerrit Code Review about 1 year ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098
Updated by Gerrit Code Review about 1 year ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098
Updated by Andy Grunwald about 1 year ago
So, here we go.
four new patches for all affected branched in Gerrit.
Updated by Gerrit Code Review about 1 year ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096
Updated by Gerrit Code Review about 1 year ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096
Updated by Gerrit Code Review 12 months ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/11096
Updated by Gerrit Code Review 12 months ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11320
Updated by Gerrit Code Review 12 months ago
Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099
Updated by Gerrit Code Review 12 months ago
Patch set 3 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098
Updated by Gerrit Code Review 12 months ago
Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097
Updated by Andy Grunwald 12 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 4163ef3b917915141c716c8800932aa1eb604d75.
Updated by Gerrit Code Review 12 months ago
- Status changed from Resolved to Under Review
Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/11099
Updated by Gerrit Code Review 12 months ago
Patch set 4 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/11098
Updated by Gerrit Code Review 12 months ago
Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/11097
Updated by Andy Grunwald 12 months ago
- Status changed from Under Review to Resolved
Applied in changeset 1125e3dd0de9ac6d626a05ced701904b2b56a97e.
Updated by Gerrit Code Review 10 months ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13142
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13258
Updated by Helmut Hummel 8 months ago
- Status changed from Under Review to Resolved