Bug #38849
IRRE record can not be expaned in IE
| Status: | Resolved | Start date: | 2012-07-10 | |
|---|---|---|---|---|
| Priority: | Must have | Due date: | ||
| Assignee: | - | % Done: | 100% |
|
| Category: | - | |||
| Target version: | - | |||
| TYPO3 Version: | 4.5 | Complexity: | easy | |
| PHP Version: | ||||
| Votes: | 0 |
Description
A really weired error after upgrading to 4.5.17 which has to do with the fixed hide/unhide issue:
IE8 and 9 do not show any error after clicking the title to expand a record, but the details are not shown, only the spinner is active.
I could not reproduce it on a 4.7 setup what makes it even stranger, because the jsfunc.inline.js files seem to be identical in 4.5 and .47.
However, there seems to be a problem with the removal of the elements
// It might be the case that a child record
// cannot be hidden at all (no hidden field)
if (formObj.length && valueObj.length) {
hiddenValue = formObj[0].checked;
formObj[0].remove();
valueObj[0].remove();
}
I needed to wrap formObj0 and valueObj0 in a $() so the prototype method is used here and not the DOM method.
// It might be the case that a child record
// cannot be hidden at all (no hidden field)
if (formObj.length && valueObj.length) {
hiddenValue = formObj[0].checked;
$(formObj[0]).remove();
$(valueObj[0]).remove();
}
Prototype seems to not directly remove the element, but calls removeChild from the parentNode. Maybe this prevents IE in that case from crashing.
remove: function(element) {
element = $(element);
element.parentNode.removeChild(element);
return element;
},
Associated revisions
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/12776
Tested-by: Stefan Geith
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/13412
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/13411
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/13410
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/12776
Tested-by: Stefan Geith
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
[BUGFIX] IRRE childs don't expand in Internet Explorer
document.getElementsByName doesn't always extend the returned DOM
Elements with prototype.js specific methods in Internet Explorer.
This patch uses the $$() selector to retrieve the needed DOM
Elements, as it always extends the returned Elements with
prototype.js specific methods (e.g. remove())
Change-Id: I083ca8b55a3b95757408a159f39f7b22cacf9c8f
Fixes: #38849
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/12776
Tested-by: Stefan Geith
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
History
Updated by Andreas Kiessling 10 months ago
Missed a "d" in the subject...: IRRE record can not be expanded in IE
Updated by Stefan Aebischer 10 months ago
I could not reproduce it on a 4.7 setup what makes it even stranger, because the jsfunc.inline.js files seem to be identical in 4.5 and .47.
I can reproduce this bug in 4.7.2 and 4.5.17 on Internet Explorer 8
Updated by Gerrit Code Review 10 months ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12776
Updated by Gerrit Code Review 10 months ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12776
Updated by Gerrit Code Review 10 months ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12776
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13410
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13411
Updated by Gerrit Code Review 10 months ago
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/13412
Updated by Anonymous 10 months ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 5b8d6c47b7cb5d008791b47f32f1208010dbab91.
Updated by Gerrit Code Review 9 months ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/13678
Updated by Helmut Hummel 9 months ago
- Status changed from Under Review to Resolved